[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73238334 --- Diff: guide/ops/locations/_AWS.md --- @@ -19,21 +19,35 @@ and [AWS IAM instructions](http://docs.aws.amazon.com/IAM/latest/UserGuide/Manag

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73238552 --- Diff: guide/ops/locations/_AWS.md --- @@ -111,3 +125,15 @@ You can then deploy blueprints to the subnet, allowing VPC hardware instance typ

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73239082 --- Diff: guide/ops/locations/_AWS.md --- @@ -111,3 +125,15 @@ You can then deploy blueprints to the subnet, allowing VPC hardware instance typ

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73239440 --- Diff: guide/ops/locations/_cloudstack.md --- @@ -0,0 +1,138 @@ +--- +section: Openstack +title: Openstack +section_type: inline

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73239646 --- Diff: guide/ops/locations/_cloudstack.md --- @@ -0,0 +1,138 @@ +--- +section: Openstack +title: Openstack +section_type: inline

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73239894 --- Diff: guide/ops/locations/_cloudstack.md --- @@ -0,0 +1,138 @@ +--- +section: Openstack +title: Openstack +section_type: inline

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73240077 --- Diff: guide/ops/locations/_cloudstack.md --- @@ -0,0 +1,138 @@ +--- +section: Openstack +title: Openstack +section_type: inline

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73240175 --- Diff: guide/ops/locations/_ibm-softlayer.md --- @@ -7,6 +7,34 @@ section_position: 5 ## IBM SoftLayer +### Credentials

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73240673 --- Diff: guide/ops/locations/_openstack.md --- @@ -1,18 +1,66 @@ --- -section: Openstack -title: Openstack +section: OpenStack

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73240786 --- Diff: guide/ops/locations/_openstack.md --- @@ -1,18 +1,66 @@ --- -section: Openstack -title: Openstack +section: OpenStack

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73240898 --- Diff: guide/ops/locations/_openstack.md --- @@ -1,18 +1,66 @@ --- -section: Openstack -title: Openstack +section: OpenStack

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73241286 --- Diff: guide/ops/locations/_cloudstack.md --- @@ -0,0 +1,138 @@ +--- +section: Openstack +title: Openstack +section_type: inline

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73241436 --- Diff: guide/ops/locations/_openstack.md --- @@ -32,12 +80,16 @@ Do this by setting the desired values id as an option in the

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73241839 --- Diff: guide/ops/locations/_openstack.md --- @@ -91,33 +143,95 @@ This is the same OpenStack location in a format that can be added to your

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73241935 --- Diff: guide/ops/locations/_openstack.md --- @@ -91,33 +143,95 @@ This is the same OpenStack location in a format that can be added to your

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73242134 --- Diff: guide/ops/locations/_openstack.md --- @@ -91,33 +143,95 @@ This is the same OpenStack location in a format that can be added to your

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73242356 --- Diff: guide/ops/locations/_openstack.md --- @@ -91,33 +143,95 @@ This is the same OpenStack location in a format that can be added to your

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73242970 --- Diff: guide/yaml/setting-locations.md --- @@ -24,22 +29,98 @@ Private cloud systems including `openstack-nova` and `cloudstack` are also suppo

[GitHub] brooklyn-docs pull request #98: Improve location docs

2016-08-02 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/98#discussion_r73243661 --- Diff: guide/yaml/setting-locations.md --- @@ -24,22 +29,98 @@ Private cloud systems including `openstack-nova` and `cloudstack` are also suppo

[GitHub] brooklyn-docs pull request #111: Expand round-robin and availability zone do...

2016-09-22 Thread mikezaccardo
GitHub user mikezaccardo opened a pull request: https://github.com/apache/brooklyn-docs/pull/111 Expand round-robin and availability zone docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/mikezaccardo/brooklyn-docs avail-zone

[GitHub] brooklyn-dist pull request #56: [READY FOR REVIEW] docker image, for standal...

2016-11-03 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/56#discussion_r86363116 --- Diff: docker/Dockerfile --- @@ -0,0 +1,59 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] brooklyn-server pull request #403: Adds DynamicFabric.includeInitialChildren...

2016-11-07 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/403#discussion_r86846586 --- Diff: core/src/test/java/org/apache/brooklyn/entity/group/DynamicRegionsFabricTest.java --- @@ -60,16 +64,98 @@ public void setUp() throws

[GitHub] brooklyn-server pull request #403: Adds DynamicFabric.includeInitialChildren...

2016-11-07 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/403#discussion_r86838197 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicFabricImpl.java --- @@ -122,27 +124,50 @@ public void start(Collection

[GitHub] brooklyn-server issue #403: Adds DynamicFabric.includeInitialChildren config

2016-11-07 Thread mikezaccardo
Github user mikezaccardo commented on the issue: https://github.com/apache/brooklyn-server/pull/403 Reviewed, all tests pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server pull request #403: Adds DynamicFabric.includeInitialChildren...

2016-11-07 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/403#discussion_r86839669 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicFabricImpl.java --- @@ -122,27 +124,50 @@ public void start(Collection

[GitHub] brooklyn-server pull request #403: Adds DynamicFabric.includeInitialChildren...

2016-11-07 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/403#discussion_r86839055 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicFabricImpl.java --- @@ -122,27 +124,50 @@ public void start(Collection

[GitHub] brooklyn-docs pull request #136: Default is no credentials required

2016-12-27 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/136#discussion_r93975287 --- Diff: guide/start/running.md --- @@ -134,13 +134,15 @@ Extract this zip file to a directory on your computer such as `c:\Program Files

[GitHub] brooklyn-ui pull request: Location wizard generates correct spec f...

2016-05-19 Thread mikezaccardo
Github user mikezaccardo commented on the pull request: https://github.com/apache/brooklyn-ui/pull/26#issuecomment-220355541 Tested, works as expected. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] brooklyn-docs pull request: Documentation on configuring Openstack...

2016-05-19 Thread mikezaccardo
Github user mikezaccardo commented on the pull request: https://github.com/apache/brooklyn-docs/pull/67#issuecomment-220385229 Thanks @sjcorbett, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] brooklyn-docs pull request: Improve multi-location docs

2016-05-22 Thread mikezaccardo
Github user mikezaccardo commented on the pull request: https://github.com/apache/brooklyn-docs/pull/70#issuecomment-220857111 LGTM -- this is documentation that would have been very helpful when I was developing a clustered blueprint targeted at multiple locations with round-robin

[GitHub] brooklyn-docs pull request #81: Expand OpenStack location docs

2016-06-27 Thread mikezaccardo
GitHub user mikezaccardo opened a pull request: https://github.com/apache/brooklyn-docs/pull/81 Expand OpenStack location docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/mikezaccardo/brooklyn-docs openstack-location-doc

[GitHub] brooklyn-docs pull request #81: Expand OpenStack location docs

2016-06-27 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/81#discussion_r68629195 --- Diff: guide/ops/locations/_more-clouds.md --- @@ -300,7 +306,94 @@ Configuration of floating IPs is as networks; specify the pools to use as

[GitHub] brooklyn-docs pull request #81: Expand OpenStack location docs

2016-06-27 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/81#discussion_r68629206 --- Diff: guide/ops/locations/_more-clouds.md --- @@ -300,7 +306,94 @@ Configuration of floating IPs is as networks; specify the pools to use as

[GitHub] brooklyn-docs pull request #81: Expand OpenStack location docs

2016-06-27 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/81#discussion_r68629570 --- Diff: guide/ops/locations/_more-clouds.md --- @@ -300,7 +306,124 @@ Configuration of floating IPs is as networks; specify the pools to use as

[GitHub] brooklyn-docs pull request #84: Fix broken links to SSH keys docs

2016-06-29 Thread mikezaccardo
GitHub user mikezaccardo opened a pull request: https://github.com/apache/brooklyn-docs/pull/84 Fix broken links to SSH keys docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/mikezaccardo/brooklyn-docs fix/ssh-keys-links

[GitHub] brooklyn-server pull request #555: Add DurationPredicates

2017-02-09 Thread mikezaccardo
GitHub user mikezaccardo opened a pull request: https://github.com/apache/brooklyn-server/pull/555 Add DurationPredicates Adds `DurationPredicates` which contain `Predicate`s for common `Duration` comparison operations. You can merge this pull request into a Git repository by

[GitHub] brooklyn-docs pull request #159: Add docs for enricher.producer values

2017-03-30 Thread mikezaccardo
GitHub user mikezaccardo opened a pull request: https://github.com/apache/brooklyn-docs/pull/159 Add docs for enricher.producer values Adds documentation to address the problem described by https://issues.apache.org/jira/browse/BROOKLYN-458. Questions for reviewers

[GitHub] brooklyn-docs pull request #159: Add docs for enricher.producer values

2017-03-30 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/159#discussion_r108968331 --- Diff: guide/java/policies.md --- @@ -235,6 +235,30 @@ An Enricher which computes latency in accessing a URL. Can be used to combine the

[GitHub] brooklyn-docs pull request #159: Add docs for enricher.producer values

2017-03-30 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/159#discussion_r108968770 --- Diff: guide/java/policies.md --- @@ -235,6 +235,30 @@ An Enricher which computes latency in accessing a URL. Can be used to combine the

[GitHub] brooklyn-docs pull request #159: Add docs for enricher.producer values

2017-03-30 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/159#discussion_r108973986 --- Diff: guide/java/policies.md --- @@ -200,8 +200,8 @@ Converts absolute sensor values into a delta

[GitHub] brooklyn-docs issue #159: Add docs for enricher.producer values

2017-03-30 Thread mikezaccardo
Github user mikezaccardo commented on the issue: https://github.com/apache/brooklyn-docs/pull/159 @geomacy I will create a separate enrichers page in a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] brooklyn-docs pull request #160: Add separate enrichers page and combine pol...

2017-03-30 Thread mikezaccardo
GitHub user mikezaccardo opened a pull request: https://github.com/apache/brooklyn-docs/pull/160 Add separate enrichers page and combine policies pages This implements a structural change that I proposed in a previous PR and was supported[1] by @geomacy. [1] https

[GitHub] brooklyn-server issue #546: Sequencer entity

2017-04-10 Thread mikezaccardo
Github user mikezaccardo commented on the issue: https://github.com/apache/brooklyn-server/pull/546 @grkvlt this would indeed be useful for the Hyperledger Fabric multi-cluster in place of this entity: https://github.com/cloudsoft/brooklyn-hyperledger/blob/master/catalog/hyperledger

[GitHub] brooklyn-docs pull request #160: Add separate enrichers page and combine pol...

2017-04-10 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/160#discussion_r110738621 --- Diff: guide/java/enrichers.md --- @@ -0,0 +1,150 @@ +--- +title: Enrichers +layout: website-normal +toc: ../guide_toc.json

[GitHub] brooklyn-docs pull request #160: Add separate enrichers page and combine pol...

2017-04-10 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/160#discussion_r110738634 --- Diff: guide/java/enrichers.md --- @@ -0,0 +1,150 @@ +--- +title: Enrichers +layout: website-normal +toc: ../guide_toc.json

[GitHub] brooklyn-docs pull request #160: Add separate enrichers page and combine pol...

2017-04-10 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/160#discussion_r110738673 --- Diff: guide/java/enrichers.md --- @@ -0,0 +1,150 @@ +--- +title: Enrichers +layout: website-normal +toc: ../guide_toc.json

[GitHub] brooklyn-docs pull request #160: Add separate enrichers page and combine pol...

2017-04-10 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/160#discussion_r110738650 --- Diff: guide/java/enrichers.md --- @@ -0,0 +1,150 @@ +--- +title: Enrichers +layout: website-normal +toc: ../guide_toc.json

[GitHub] brooklyn-docs pull request #160: Add separate enrichers page and combine pol...

2017-04-10 Thread mikezaccardo
Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/160#discussion_r110738692 --- Diff: guide/java/enrichers.md --- @@ -0,0 +1,150 @@ +--- +title: Enrichers +layout: website-normal +toc: ../guide_toc.json

[GitHub] brooklyn-dist pull request #91: Enable TLS 1.1 and 1.2

2017-05-03 Thread mikezaccardo
GitHub user mikezaccardo opened a pull request: https://github.com/apache/brooklyn-dist/pull/91 Enable TLS 1.1 and 1.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mikezaccardo/brooklyn-dist enable-tls-1.1-and-1.2

[GitHub] incubator-brooklyn pull request: [DISCUSSION] Sequential Entity St...

2015-12-03 Thread mikezaccardo
GitHub user mikezaccardo opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1088 [DISCUSSION] Sequential Entity Stop Order This adds a `stop.sequence.position` config value which enables YAML blueprint authors to explicitly specify a stop order. This can

[GitHub] incubator-brooklyn pull request: [DISCUSSION] Sequential Entity St...

2015-12-05 Thread mikezaccardo
Github user mikezaccardo closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1088 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-brooklyn pull request: Add timeout to attributeWhenReady...

2015-12-05 Thread mikezaccardo
GitHub user mikezaccardo opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1090 Add timeout to attributeWhenReady if entity is in destructive state Previously, `attributeWhenReady` would only abort if the entity was is on fire. Now

[GitHub] incubator-brooklyn pull request: Add all.members.up sensor to Dyna...

2015-12-08 Thread mikezaccardo
Github user mikezaccardo commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1050#issuecomment-162957168 @sjcorbett I still think this addition has value because it simplifies YAML blueprints (vs. having to add an aggregator from #1037), and it also