Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
ok thanks @sjcorbett
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
Thanks @geomacy. Will merge this. Printing usage when someone writes `br
--skipSslChecks` or `br --json` can be a future improvement.
---
If your project is set up for it, you can reply
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
`requiresLogin` should check that the command isn't `help`. It also needs
to handle invocations of the program that set global options but don't give a
command. I think that of the options
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@sjcorbett et al is this ok to merge now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
Thanks @geomacy LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
Alternatively open a separate pull request for the `logout` command. It's
tangential to the rest of the PR, which is ready to merge.
---
If your project is set up for it, you can reply to
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@geomacy I was right on the cusp of merging this when I realised that
logging out means you can't view help text:
```
$ br version
0.12.0-SNAPSHOT
$ br
NAME:
br
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
ping @Graeme-Miller, @robertgmoss, @m4rkmckenna et al, can this be merged
now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
p.s. updated config file format looks like
[this](https://github.com/geomacy/brooklyn-client/blob/b5e51e420aab89ad34cbf5581f3de520220263c7/cli/io/testconfig.json)
---
If your project is set
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@Graeme-Miller I take your point about security, but I am not convinced
that caching 1 context is _really_ that much more secure than caching `n`! The
surprising thing to me is that we
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
Just want to chime in with a different opinion. I think we should merge as
is, and not implement the functionality to allow users to switch between
multiple hosts.
For me, it
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@robertgmoss don't worry, I'm sure I can get round to it some time in the
next while if I put my mind to it.
---
If your project is set up for it, you can reply to this email and have
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@geomacy I'd rather this was not merged as is. It would deprecate a
current format, then introduce a further deprecation further down the line.
I will make a PR into your branch
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@robertgmoss et al; I have meant to implement Robert's change above but I'm
really not getting any time to look at it these days. Can I suggest we accept
this PR as it stands, and I can try
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@m4rkmckenna sorry, I thought I'd implemented that feature, but clearly I
didn't. Yes, @geomacy the format was like that so that you could simply change
the `target` in the `login`
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
P.S. I took it out because I thought it was cleaner to keep it simple.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@robert I think the original format was done like that to allow for
multiple hosts but then we didn't actually provide that ability. What do you
all think, should we support the ability to
Github user m4rkmckenna commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@robertgmoss I was un aware we had that functionality ... How is it
supposed to work?
I tried
```
br login
br apps # Returns host1 apps
br login
br apps #
Github user robertgmoss commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@geomacy I think it is a shame to lose the caching of credentials for
multiple Brooklyn servers and the ability to switch between them without
re-entering credentials.
---
If your
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
hi all,
I have made a bunch of updates to address the above comments and add some
further functionality.
The main change is the simplification of the `.brooklyn_cli` file
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
On the current master:
```
$ ./target/bin/br login http://ldsn3e
Get http://ldsn3e/v1/server/version: dial tcp: lookup ldsn3e on
66.28.0.45:53: no such host
```
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/42
@Graeme-Miller, @johnmccabe, @m4rkmckenna you may be interested to review
this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
22 matches
Mail list logo
