Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/344
Agreed that marking tests as integration is not a good idea right now;
hence closing this. If it bites us a lot before we find the time to change it
to either use port `0` (so it picks a fr
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/344
Closing this. We'll see if the
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/344
They do actually - there are multiple jobs running the tests
(server-master, build-master, server-master-pull-requests).
Still I think fixing the free port checking logic is better than pi
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/344
@neykov running two tests in parallel would understandably generate this
error. but our test machines don't do that do they ... actually if the boxes
do that could explain the problem and
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/344
Marking tests integration is same as deleting them right now so I'd be wary
of such changes (integration tests don't get run, let alone on regular basis).
I was able to reproduce this by r
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/344
Re sneaking the change into #340 - next time can you do it in a separate
PR, even if you merge that PR yourself immediately!
---
Maybe it is just the problem of socket `time_wai
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/344
This is a bad cop out. The tests aren't relying on a specific port. I
think the problem is that the `Networking.isPortAvailable()` check isn't
releasing the port fast enough and probably
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/344
@ahgittin can you take a look at this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
