Re: Looking for help on query optimization statistics

2018-11-05 Thread Ted Xu
Hi Tian, To inject statistics, you need to implement your own RelMetadataProvider and register it into your runtime environment. I'm not able to find a valid example in Calcite, but there is a good example you can find in Drill

Re: Pull requests to review

2018-11-05 Thread Vladimir Sitnikov
Piotr, Have you tried to use SqlToRelConverter to convert argument from SqlNode format to the appropriate one? Vladimir

Pull requests to review

2018-11-05 Thread ptr.bo...@gmail.com
Hello, Anyone willing to review my pull requests? https://github.com/apache/calcite/pull/878 - this is already patched after reviews. It fixes CALCITE-2609. https://github.com/apache/calcite/pull/878 https://github.com/apache/calcite/pull/900 Those pulls are alternative fixes to CALCITE-2641 .

Re: Pull requests to review

2018-11-05 Thread ptr.bo...@gmail.com
Vladimir, I thought that TimestampString IS the appropriate type :D (knowledge based on Rexbuilder code, where TimestampString is being created as RexLiteral). My problem is that I don't see what is the scope of TimestampString, DateString, etc in Calcite. Does it span to Rel/Rex tree? Or it

[DISCUSS] State of the project 2018

2018-11-05 Thread Michael Mior
It's that time of year again where we consider where Calcite has gone over the past year and where it's going in the future. I've been happy to see our first academic publication on Calcite finally get out this year (thanks to Edmon, Dan, Jesús, and Julian!) It's also been really positive to see

Re: [DISCUSS] State of the project 2018

2018-11-05 Thread Francis Chuang
Thanks for starting this discussion, Michael! The Calcite project and it's Avatica sub project has been doing really well in the past year under your stewardship. I have seen a lot of new contributors who are highly motivated and we also added new committers. In terms of what we are doing

Re: [DISCUSS] Towards Calcite 1.18

2018-11-05 Thread Francis Chuang
I think we should consider releasing new versions of Calcite and Avatica soon, especially with the Thanksgiving holiday in North America and Christmas + New Year later in December/January coming up. Am I correct to assume that we need to release Avatica 1.13.0 before Calcite 1.17.0? If so,

Re: [DISCUSS] Towards Calcite 1.18

2018-11-05 Thread Francis Chuang
I think we should consider releasing new versions of Calcite and Avatica soon, especially with the Thanksgiving holiday in North America and Christmas + New Year later in December/January coming up. Am I correct to assume that we need to release Avatica 1.13.0 before Calcite 1.18.0? If so,

Re: [DISCUSS] State of the project 2018

2018-11-05 Thread Francis Chuang
One more thing I forgot. There were proposals for a new Calcite logo a couple of months ago and some really cool ones were proposed. The discussion died down, but I hope it's still something we can move forward on. On 6/11/2018 8:27 AM, Francis Chuang wrote: Thanks for starting this

Re: Pull requests to review

2018-11-05 Thread ptr.bo...@gmail.com
Julian, so.. is it correct to translate TimestampString to java.sql.Timestamp on RexToLixTranslator.convert(...) level as in pull request https://github.com/apache/calcite/pull/900/commits ? I hope so, then I could revoke pull request https://github.com/apache/calcite/pull/878 On Mon, Nov 5,

Re: Pull requests to review

2018-11-05 Thread Julian Hyde
Yeah, TimestampString is for SqlNode and RexNode only. Not JDBC code. Likewise DateString, TimeString, NlsString. Sorry the doc didn’t make that clear. Although frankly it’s impractical to document all of the places something is NOT used. > On Nov 5, 2018, at 5:49 AM, ptr.bo...@gmail.com

Re: Pull requests to review

2018-11-05 Thread Julian Hyde
A TimestampString has no timezone. It does not represent a moment in time. It represents a position of the hands on a clock. A Timestamp does not have a timezone either, but it represents a moment in time. (Internally represented by milliseconds since the UTC epoch.) Therefore, to go from a