While trying to fix Sergey's issue with stale folder (see CALCITE-2442) I
realized that CassandraUnit wasn't shutting down the cluster.
So I've added a manual tearDown() method which explicitly calls close() on
both session and cluster: https://github.com/apache/calcite/pull/775
Can you pls
I was finally able to reproduce this with OpenJDK 9. Strangely, JDK 10
works for me. I'll take a look and see if I can figure out what's going on.
--
Michael Mior
mm...@apache.org
Le dim. 29 juil. 2018 à 14:05, Julian Hyde a écrit :
> I'm seeing the following error when I run the tests on
Or maybe you already have a Cassandra instance binded to port 9142 (virtual
machine for example) ?
On Wed, Aug 1, 2018 at 7:28 PM Andrei Sereda wrote:
> Is it possible that you run several maven processes in parallel ?
>
> Unfortunately currently there can be only one CassandraAdapterTest
>
Is it possible that you run several maven processes in parallel ?
Unfortunately currently there can be only one CassandraAdapterTest (setup()
method really) running on a box in parallel.
On Wed, Aug 1, 2018 at 4:55 PM Andrei Sereda wrote:
> Hi Julian,
>
> Can you please tell if you're getting
Hi Julian,
Can you please tell if you're getting same (or different) error for all
java versions (8,9,10 etc.) ?
Do you get this error consistently or intermittently (flaky behaviour) ?
What is the stack trace ?
It will help me debug the issue.
Regards,
Andrei.
On Wed, Aug 1, 2018 at 4:40 PM
Also works fine for JDK 10.
➜ cassandra git:(master) ✗ java -version
java version "10.0.2" 2018-07-17
Java(TM) SE Runtime Environment 18.3 (build 10.0.2+13)
Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.2+13, mixed mode)
Kind regards
Igor Kryvenko
On Wed, 1 Aug 2018 at 23:03, Julian Hyde
What about on JDK 10? Here’s my java version:
$ java -version
java version "10" 2018-03-20
Java(TM) SE Runtime Environment 18.3 (build 10+46)
Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10+46, mixed mode)
> On Aug 1, 2018, at 12:58 PM, Igor Kryvenko wrote:
>
> "mvn -Pit clean test" works
"mvn -Pit clean test" works fine for me.
Ubuntu 18.04
java version "1.8.0_171"
Kind regards
Igor Kryvenko
On Wed, 1 Aug 2018 at 22:34, Julian Hyde wrote:
> The test is failing every time for me on JDK 10. The command “mvn -Pit
> clean test” will probably reproduce it for most people.
>
> Can
The test is failing every time for me on JDK 10. The command “mvn -Pit clean
test” will probably reproduce it for most people.
Can other folks please try to reproduce this? I’m getting close to saying that
we should back this change out even though apparently only I can reproduce the
failure.
Julian, I have amended the commit message in f0b00f0c
On Mon, Jul 30, 2018 at 4:22 PM Julian Hyde wrote:
> I’m running tests on the PR now.
>
> Since commit comments are a soap-box of mine, I will remark that rather
> than
>
> [CALCITE-2428] Fix cassandra unit test initialization. (Andrei
I’m running tests on the PR now.
Since commit comments are a soap-box of mine, I will remark that rather than
[CALCITE-2428] Fix cassandra unit test initialization. (Andrei Sereda)
the commit comment should be
[CALCITE-2428] Cassandra unit test fails to parse version string (Andrei
Thanks Andrei for digging into this! Since I haven't reproduced this
failure myself, if someone else could check out the PR, that would be
great.
--
Michael Mior
mm...@apache.org
Le lun. 30 juil. 2018 à 13:29, Andrei Sereda a écrit :
> Agree, flaky tests are pretty annoying. I'll try to watch
Agree, flaky tests are pretty annoying. I'll try to watch more carefully
new "embedded data-source" issues (fongo, ES, cassandra). They introduced
more "non-determinism" because they now run as part of regular build which
means executed much more often than IT.
Last commit was for a more
On balance, I don’t think we should back out CassandraAdapterTest. But we do
need to continue working to make it more resilient. Any test that generates too
many false negatives over the long run should be disabled, and this is no
exception.
And as the other test results show, it’s not the
Pls check and confirm that the following PR fixes the issue:
https://github.com/apache/calcite/pull/770
It addresses build failures due to version parsing.
Stale folders / files will be addressed in a different PR.
On Mon, Jul 30, 2018 at 10:10 AM Andrei Sereda wrote:
> This must be something
This must be something specific to Cassandra Unit. Will check
On Mon, Jul 30, 2018, 08:59 Sergey Nuyanzin wrote:
> There is one more strange thing (at least on Windows): while building a
> file with name ".toDelete" is generated under calcite\cassandra and it's
> not removed by the end of tests
There is one more strange thing (at least on Windows): while building a
file with name ".toDelete" is generated under calcite\cassandra and it's
not removed by the end of tests
Is there a way to make cassandra generates these files in target directory
e.g.?
On Mon, Jul 30, 2018 at 3:52 PM,
Most of the problems are during test init Phase. Most likely with version
string (eg. 11-ea for JDK11).
I'll fix that.
On Mon, Jul 30, 2018 at 8:16 AM Michael Mior wrote:
> I tested myself a fair bit under Ubuntu before pushing this and didn't see
> any of these issues myself. That said, I
I tested myself a fair bit under Ubuntu before pushing this and didn't see
any of these issues myself. That said, I agree that it's important the test
suite be stable. I'm fine with reverting for now or (more preferably IMO)
just disabling these tests by default.
--
Michael Mior
mm...@apache.org
I ran on several JDK versions, all on Ubuntu Linux. The machine was
fairly heavily loaded (I was copying one filesystem to another at the
time).
Here's the error from OpenJDK10:
[INFO] Running org.apache.calcite.test.CassandraAdapterTest
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0,
What version of java / OS / maven do you have ? What is your maven command
?
Things pass for me on MacOS X java 8,9 and 10.
On Sun, Jul 29, 2018 at 2:05 PM Julian Hyde wrote:
> I'm seeing the following error when I run the tests on bd0e14002
> origin/master. Anyone else see it?
>
> [INFO]
21 matches
Mail list logo
