回复:Re: JSON support

2018-11-10 Thread 张宏泽
收件人: dev@calcite.apache.org 主题: Re: JSON support(Internet mail) Hongze has also just contributed WITHIN GROUP [1] - basically the ability for aggregate functions to operate on sorted input, the same way that many window functions do. So, thanks for the great contributions. But also, I want

Re: JSON support

2018-11-10 Thread Hongze Zhang
I am very glad to see the patch has been accepted,and many thanks to all of you (Michael, Julian, Vladimir, ...) for continuously paying attention to this thread, and for the great review work. Thank you again! Hongze At 2018-11-10 02:30:31, "Julian Hyde" wrote: >Hongze has also just

Re: JSON support

2018-11-09 Thread Julian Hyde
Hongze has also just contributed WITHIN GROUP [1] - basically the ability for aggregate functions to operate on sorted input, the same way that many window functions do. So, thanks for the great contributions. But also, I want to thank our committers (Michael, Vladimir). Shepherding complex

Re: JSON support

2018-11-09 Thread Stamatis Zampetakis
Great addition! Many thanks to all (Hongze, Michael, Vladimir) of you :) Στις Παρ, 9 Νοε 2018 στις 5:44 μ.μ., ο/η Michael Mior έγραψε: > Just wanted to put out a thanks to Hongze on this thread for the numerous > changes that went into the initial pull request which has now landed! Happy > to

Re: JSON support

2018-11-09 Thread Michael Mior
Just wanted to put out a thanks to Hongze on this thread for the numerous changes that went into the initial pull request which has now landed! Happy to see this completed. -- Michael Mior mm...@apache.org Le mer. 29 août 2018 à 16:11, Julian Hyde a écrit : > Somehow I missed this… we have a

Re: JSON support

2018-08-30 Thread Michael Mior
Thanks for the clarification :) -- Michael Mior mm...@apache.org Le mer. 29 août 2018 à 19:28, Julian Hyde a écrit : > The rules for Parser.jj are a little different. JavaCC needs to parse the > Java fragments inside rules and sometimes it can’t handle modern Java > syntax such as “new

Re: JSON support

2018-08-29 Thread Julian Hyde
The rules for Parser.jj are a little different. JavaCC needs to parse the Java fragments inside rules and sometimes it can’t handle modern Java syntax such as “new ArrayList<>()”. > On Aug 29, 2018, at 1:16 PM, Michael Mior wrote: > > One thing that jumped out to me was the use of an explicit

Re: JSON support

2018-08-29 Thread Michael Mior
One thing that jumped out to me was the use of an explicit type when calling the ArrayList constructor in the parser. I initially thought this was something that Julian had gotten rid of in his big update to support Java 8 syntax. However, I see this still persists in Parser.jj . Is this

Re: JSON support

2018-08-29 Thread Michael Mior
Thanks for surfacing this. I'll take a look now. -- Michael Mior mm...@apache.org Le mer. 29 août 2018 à 16:11, Julian Hyde a écrit : > Somehow I missed this… we have a pull request for JSON support. It’s a big > change (both in terms of importance and the amount of effort). > >