回复：Re: JSON support
I am very glad to see the patch has been accepted，and many thanks to all of you (Michael, Julian, Vladimir, ...) for continuously paying attention to this thread, and for the great review work. Thank you again! Hongze ---原始邮件--- 发件人: Julian Hyde 发送时间: 2018年11月10日 09:36 收件人: dev@calcite.apache.org 主题: Re: JSON support(Internet mail) Hongze has also just contributed WITHIN GROUP [1] - basically the ability for aggregate functions to operate on sorted input, the same way that many window functions do. So, thanks for the great contributions. But also, I want to thank our committers (Michael, Vladimir). Shepherding complex PRs into the code base while maintaining the high standards of the code is difficult and time-consuming. Julian [1] https://issues.apache.org/jira/browse/CALCITE-2224 > On Nov 9, 2018, at 10:03 AM, Stamatis Zampetakis wrote: > > Great addition! Many thanks to all (Hongze, Michael, Vladimir) of you :) > > Στις Παρ, 9 Νοε 2018 στις 5:44 μ.μ., ο/η Michael Mior > έγραψε: > >> Just wanted to put out a thanks to Hongze on this thread for the numerous >> changes that went into the initial pull request which has now landed! Happy >> to see this completed. >> >> -- >> Michael Mior >> mm...@apache.org >> >> >> Le mer. 29 août 2018 à 16:11, Julian Hyde a écrit : >> >>> Somehow I missed this… we have a pull request for JSON support. It’s a >> big >>> change (both in terms of importance and the amount of effort). >>> >>> https://github.com/apache/calcite/pull/785 < >>> https://github.com/apache/calcite/pull/785> >>> >>> https://issues.apache.org/jira/browse/CALCITE-2266 < >>> https://issues.apache.org/jira/browse/CALCITE-2266> >>> >>> I made a quick review, and it looks good. I see Vladimir has reviewed. >> Can >>> someone else (not necessarily a committer) take a look? >>> >>> Julian >>> >>> >>> >>
Re: JSON support
I am very glad to see the patch has been accepted，and many thanks to all of you (Michael, Julian, Vladimir, ...) for continuously paying attention to this thread, and for the great review work. Thank you again! Hongze At 2018-11-10 02:30:31, "Julian Hyde" wrote: >Hongze has also just contributed WITHIN GROUP [1] - basically the ability for >aggregate functions to operate on sorted input, the same way that many window >functions do. So, thanks for the great contributions. > >But also, I want to thank our committers (Michael, Vladimir). Shepherding >complex PRs into the code base while maintaining the high standards of the >code is difficult and time-consuming. > >Julian > >[1] https://issues.apache.org/jira/browse/CALCITE-2224 > >> On Nov 9, 2018, at 10:03 AM, Stamatis Zampetakis wrote: >> >> Great addition! Many thanks to all (Hongze, Michael, Vladimir) of you :) >> >> Στις Παρ, 9 Νοε 2018 στις 5:44 μ.μ., ο/η Michael Mior >> έγραψε: >> >>> Just wanted to put out a thanks to Hongze on this thread for the numerous >>> changes that went into the initial pull request which has now landed! Happy >>> to see this completed. >>> >>> -- >>> Michael Mior >>> mm...@apache.org >>> >>> >>> Le mer. 29 août 2018 à 16:11, Julian Hyde a écrit : >>> Somehow I missed this… we have a pull request for JSON support. It’s a >>> big change (both in terms of importance and the amount of effort). https://github.com/apache/calcite/pull/785 < https://github.com/apache/calcite/pull/785> https://issues.apache.org/jira/browse/CALCITE-2266 < https://issues.apache.org/jira/browse/CALCITE-2266> I made a quick review, and it looks good. I see Vladimir has reviewed. >>> Can someone else (not necessarily a committer) take a look? Julian >>>
Re: JSON support
Hongze has also just contributed WITHIN GROUP [1] - basically the ability for aggregate functions to operate on sorted input, the same way that many window functions do. So, thanks for the great contributions. But also, I want to thank our committers (Michael, Vladimir). Shepherding complex PRs into the code base while maintaining the high standards of the code is difficult and time-consuming. Julian [1] https://issues.apache.org/jira/browse/CALCITE-2224 > On Nov 9, 2018, at 10:03 AM, Stamatis Zampetakis wrote: > > Great addition! Many thanks to all (Hongze, Michael, Vladimir) of you :) > > Στις Παρ, 9 Νοε 2018 στις 5:44 μ.μ., ο/η Michael Mior > έγραψε: > >> Just wanted to put out a thanks to Hongze on this thread for the numerous >> changes that went into the initial pull request which has now landed! Happy >> to see this completed. >> >> -- >> Michael Mior >> mm...@apache.org >> >> >> Le mer. 29 août 2018 à 16:11, Julian Hyde a écrit : >> >>> Somehow I missed this… we have a pull request for JSON support. It’s a >> big >>> change (both in terms of importance and the amount of effort). >>> >>> https://github.com/apache/calcite/pull/785 < >>> https://github.com/apache/calcite/pull/785> >>> >>> https://issues.apache.org/jira/browse/CALCITE-2266 < >>> https://issues.apache.org/jira/browse/CALCITE-2266> >>> >>> I made a quick review, and it looks good. I see Vladimir has reviewed. >> Can >>> someone else (not necessarily a committer) take a look? >>> >>> Julian >>> >>> >>> >>
Re: JSON support
Great addition! Many thanks to all (Hongze, Michael, Vladimir) of you :) Στις Παρ, 9 Νοε 2018 στις 5:44 μ.μ., ο/η Michael Mior έγραψε: > Just wanted to put out a thanks to Hongze on this thread for the numerous > changes that went into the initial pull request which has now landed! Happy > to see this completed. > > -- > Michael Mior > mm...@apache.org > > > Le mer. 29 août 2018 à 16:11, Julian Hyde a écrit : > > > Somehow I missed this… we have a pull request for JSON support. It’s a > big > > change (both in terms of importance and the amount of effort). > > > > https://github.com/apache/calcite/pull/785 < > > https://github.com/apache/calcite/pull/785> > > > > https://issues.apache.org/jira/browse/CALCITE-2266 < > > https://issues.apache.org/jira/browse/CALCITE-2266> > > > > I made a quick review, and it looks good. I see Vladimir has reviewed. > Can > > someone else (not necessarily a committer) take a look? > > > > Julian > > > > > > >
Re: JSON support
Just wanted to put out a thanks to Hongze on this thread for the numerous changes that went into the initial pull request which has now landed! Happy to see this completed. -- Michael Mior mm...@apache.org Le mer. 29 août 2018 à 16:11, Julian Hyde a écrit : > Somehow I missed this… we have a pull request for JSON support. It’s a big > change (both in terms of importance and the amount of effort). > > https://github.com/apache/calcite/pull/785 < > https://github.com/apache/calcite/pull/785> > > https://issues.apache.org/jira/browse/CALCITE-2266 < > https://issues.apache.org/jira/browse/CALCITE-2266> > > I made a quick review, and it looks good. I see Vladimir has reviewed. Can > someone else (not necessarily a committer) take a look? > > Julian > > >
Re: JSON support
Thanks for the clarification :) -- Michael Mior mm...@apache.org Le mer. 29 août 2018 à 19:28, Julian Hyde a écrit : > The rules for Parser.jj are a little different. JavaCC needs to parse the > Java fragments inside rules and sometimes it can’t handle modern Java > syntax such as “new ArrayList<>()”. > > > On Aug 29, 2018, at 1:16 PM, Michael Mior wrote: > > > > One thing that jumped out to me was the use of an explicit type when > > calling the ArrayList constructor in the parser. I initially thought this > > was something that Julian had gotten rid of in his big update to support > > Java 8 syntax. However, I see this still persists in Parser.jj . Is this > > intentional? > > -- > > Michael Mior > > mm...@apache.org > > > > > > > > Le mer. 29 août 2018 à 16:11, Julian Hyde a écrit : > > > >> Somehow I missed this… we have a pull request for JSON support. It’s a > big > >> change (both in terms of importance and the amount of effort). > >> > >> https://github.com/apache/calcite/pull/785 < > >> https://github.com/apache/calcite/pull/785> > >> > >> https://issues.apache.org/jira/browse/CALCITE-2266 < > >> https://issues.apache.org/jira/browse/CALCITE-2266> > >> > >> I made a quick review, and it looks good. I see Vladimir has reviewed. > Can > >> someone else (not necessarily a committer) take a look? > >> > >> Julian > >> > >> > >> > >
Re: JSON support
The rules for Parser.jj are a little different. JavaCC needs to parse the Java fragments inside rules and sometimes it can’t handle modern Java syntax such as “new ArrayList<>()”. > On Aug 29, 2018, at 1:16 PM, Michael Mior wrote: > > One thing that jumped out to me was the use of an explicit type when > calling the ArrayList constructor in the parser. I initially thought this > was something that Julian had gotten rid of in his big update to support > Java 8 syntax. However, I see this still persists in Parser.jj . Is this > intentional? > -- > Michael Mior > mm...@apache.org > > > > Le mer. 29 août 2018 à 16:11, Julian Hyde a écrit : > >> Somehow I missed this… we have a pull request for JSON support. It’s a big >> change (both in terms of importance and the amount of effort). >> >> https://github.com/apache/calcite/pull/785 < >> https://github.com/apache/calcite/pull/785> >> >> https://issues.apache.org/jira/browse/CALCITE-2266 < >> https://issues.apache.org/jira/browse/CALCITE-2266> >> >> I made a quick review, and it looks good. I see Vladimir has reviewed. Can >> someone else (not necessarily a committer) take a look? >> >> Julian >> >> >>
Re: JSON support
One thing that jumped out to me was the use of an explicit type when calling the ArrayList constructor in the parser. I initially thought this was something that Julian had gotten rid of in his big update to support Java 8 syntax. However, I see this still persists in Parser.jj . Is this intentional? -- Michael Mior mm...@apache.org Le mer. 29 août 2018 à 16:11, Julian Hyde a écrit : > Somehow I missed this… we have a pull request for JSON support. It’s a big > change (both in terms of importance and the amount of effort). > > https://github.com/apache/calcite/pull/785 < > https://github.com/apache/calcite/pull/785> > > https://issues.apache.org/jira/browse/CALCITE-2266 < > https://issues.apache.org/jira/browse/CALCITE-2266> > > I made a quick review, and it looks good. I see Vladimir has reviewed. Can > someone else (not necessarily a committer) take a look? > > Julian > > >
Re: JSON support
Thanks for surfacing this. I'll take a look now. -- Michael Mior mm...@apache.org Le mer. 29 août 2018 à 16:11, Julian Hyde a écrit : > Somehow I missed this… we have a pull request for JSON support. It’s a big > change (both in terms of importance and the amount of effort). > > https://github.com/apache/calcite/pull/785 < > https://github.com/apache/calcite/pull/785> > > https://issues.apache.org/jira/browse/CALCITE-2266 < > https://issues.apache.org/jira/browse/CALCITE-2266> > > I made a quick review, and it looks good. I see Vladimir has reviewed. Can > someone else (not necessarily a committer) take a look? > > Julian > > >
