[GitHub] incubator-carbondata pull request #100: Handle all dictionary exception more...

2016-08-27 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/100#discussion_r76519971 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala --- @@ -591,29 +591,31 @@ object

[GitHub] incubator-carbondata pull request #100: Handle all dictionary exception more...

2016-08-27 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/100#discussion_r76519992 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala --- @@ -629,22 +631,32 @@ object

[GitHub] incubator-carbondata pull request #105: [CARBONDATA-189] Drop database casca...

2016-08-29 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/105#discussion_r76657713 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala --- @@ -1342,4 +1345,9 @@ class CarbonSqlParser

[GitHub] incubator-carbondata pull request #122: [CARBONDATA-202] Handled exception t...

2016-09-02 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/122#discussion_r77332668 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala --- @@ -588,30 +588,59 @@ object

[GitHub] incubator-carbondata pull request #122: [CARBONDATA-202] Handled exception t...

2016-09-02 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/122#discussion_r77332892 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala --- @@ -588,30 +588,59 @@ object

[GitHub] incubator-carbondata pull request #122: [CARBONDATA-202] Handled exception t...

2016-09-02 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/122#discussion_r77335816 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala --- @@ -791,16 +819,23 @@ object

[GitHub] incubator-carbondata pull request #159: [Issue Number] CARBONDATA-242

2016-09-16 Thread sujith71955
GitHub user sujith71955 opened a pull request: https://github.com/apache/incubator-carbondata/pull/159 [Issue Number] CARBONDATA-242 [Problem] Filter result was not compatible with hive result when a null filter member is present in not in filter model, as per hive no

[GitHub] incubator-carbondata pull request #156: [CARBONDATA-244] Load and delete seg...

2016-09-16 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/156#discussion_r79187047 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -1077,19 +1077,38 @@ object

[GitHub] incubator-carbondata pull request #156: [CARBONDATA-244] Load and delete seg...

2016-09-16 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/156#discussion_r79204842 --- Diff: processing/src/main/java/org/apache/carbondata/lcm/status/SegmentStatusManager.java --- @@ -306,13 +330,18 @@ private Integer

[GitHub] incubator-carbondata pull request #163: Problem:Column heading was missing i...

2016-09-17 Thread sujith71955
GitHub user sujith71955 opened a pull request: https://github.com/apache/incubator-carbondata/pull/163 Problem:Column heading was missing in driver statistics table and sca… Be sure to do all of the following to help us incorporate your contribution quickly and easily

[GitHub] incubator-carbondata pull request #156: [CARBONDATA-244] Load and delete seg...

2016-09-17 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/156#discussion_r79291307 --- Diff: processing/src/main/java/org/apache/carbondata/lcm/locks/CarbonLockUtil.java --- @@ -0,0 +1,64 @@ +/* + * Licensed to the

[GitHub] incubator-carbondata pull request #156: [CARBONDATA-244] Load and delete seg...

2016-09-17 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/156#discussion_r79291346 --- Diff: processing/src/main/java/org/apache/carbondata/lcm/locks/LockUsage.java --- @@ -28,5 +28,7 @@ public static String

[GitHub] incubator-carbondata pull request #156: [CARBONDATA-244] Load and delete seg...

2016-09-17 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/156#discussion_r79291381 --- Diff: processing/src/main/java/org/apache/carbondata/lcm/status/SegmentStatusManager.java --- @@ -287,12 +307,18 @@ private Integer

[GitHub] incubator-carbondata pull request #156: [CARBONDATA-244] Load and delete seg...

2016-09-17 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/156#discussion_r79291710 --- Diff: processing/src/main/java/org/apache/carbondata/lcm/status/SegmentStatusManager.java --- @@ -287,12 +307,18 @@ private Integer

[GitHub] incubator-carbondata pull request #169: [CARBONDATA-250] Filter result is no...

2016-09-17 Thread sujith71955
GitHub user sujith71955 opened a pull request: https://github.com/apache/incubator-carbondata/pull/169 [CARBONDATA-250] Filter result is not proper when Double data type values with 0.0 and -0.0 will be used. [**Problem**] Equals filter query where -0.0 is used in filter model

[GitHub] incubator-carbondata pull request #194: [CARBONDATA-270] Double data type va...

2016-09-23 Thread sujith71955
GitHub user sujith71955 opened a pull request: https://github.com/apache/incubator-carbondata/pull/194 [CARBONDATA-270] Double data type value comparison optimization [Description] Double data type value comparison optimization,EqualsToExpression evaluation for double values first

[GitHub] incubator-carbondata pull request #194: [CARBONDATA-270] Double data type va...

2016-09-23 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/194#discussion_r80221578 --- Diff: core/src/main/java/org/apache/carbondata/scan/filter/FilterUtil.java --- @@ -1401,8 +1401,7 @@ public static void logError

[GitHub] incubator-carbondata pull request #202: [CARBONDATA-278] IS NULL and IS NOT ...

2016-09-27 Thread sujith71955
GitHub user sujith71955 opened a pull request: https://github.com/apache/incubator-carbondata/pull/202 [CARBONDATA-278] IS NULL and IS NOT NULL shall be push down to carbon **Current design** : As per the current design IS NULL and IS NOT NULL filter is been handled by spark layer

[GitHub] incubator-carbondata pull request #189: [CARBONDATA-267] Set block_size for ...

2016-09-29 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/189#discussion_r81280222 --- Diff: format/src/main/thrift/schema.thrift --- @@ -124,6 +124,7 @@ struct TableSchema{ 1: required string table_id; // ID used

[GitHub] incubator-carbondata pull request #189: [CARBONDATA-267] Set block_size for ...

2016-09-29 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/189#discussion_r81280323 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala --- @@ -546,6 +548,18 @@ class CarbonSqlParser

[GitHub] incubator-carbondata pull request #189: [CARBONDATA-267] Set block_size for ...

2016-09-29 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/189#discussion_r81280420 --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/metadata/schema/table/TableSchema.java --- @@ -102,6 +107,14 @@ public void

[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim option

2016-09-29 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/200#discussion_r81281050 --- Diff: hadoop/src/test/java/org/apache/carbondata/hadoop/test/util/StoreCreator.java --- @@ -465,6 +466,7 @@ private static void

[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim option

2016-09-29 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/200#discussion_r81281079 --- Diff: hadoop/src/test/java/org/apache/carbondata/hadoop/test/util/StoreCreator.java --- @@ -465,6 +466,7 @@ private static void

[GitHub] incubator-carbondata pull request #189: [CARBONDATA-267] Set block_size for ...

2016-09-30 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/189#discussion_r81308653 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala --- @@ -546,6 +548,30 @@ class CarbonSqlParser

[GitHub] incubator-carbondata pull request #189: [CARBONDATA-267] Set block_size for ...

2016-09-30 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/189#discussion_r81310297 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -419,6 +420,7 @@ class

[GitHub] incubator-carbondata pull request #148: [CARBONDATA-233] bad record logger s...

2016-10-07 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/148#discussion_r82339778 --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/BadRecordslogger.java --- @@ -89,41

[GitHub] incubator-carbondata pull request #224: [CARBONDATA-239]Add scan_blocklet_nu...

2016-10-10 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/224#discussion_r82729006 --- Diff: core/src/main/java/org/apache/carbondata/scan/processor/AbstractDataBlockIterator.java --- @@ -127,11 +133,15 @@ protected

[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim option

2016-10-11 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/200#discussion_r82758567 --- Diff: processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/UnivocityCsvParser.java --- @@ -102,8 +102,8 @@ public

[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim option

2016-10-12 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/200#discussion_r82968468 --- Diff: processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/UnivocityCsvParser.java --- @@ -102,8 +102,8 @@ public

[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim option

2016-10-12 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/200#discussion_r82968804 --- Diff: processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/UnivocityCsvParser.java --- @@ -102,8 +102,8 @@ public

[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim option

2016-10-12 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/200#discussion_r82977743 --- Diff: processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/UnivocityCsvParser.java --- @@ -102,8 +102,8 @@ public

[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim option

2016-10-12 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/200#discussion_r82977592 --- Diff: processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/UnivocityCsvParser.java --- @@ -102,8 +102,8 @@ public

[GitHub] incubator-carbondata pull request #224: [CARBONDATA-239]Add scan_blocklet_nu...

2016-10-12 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/224#discussion_r82983904 --- Diff: core/src/main/java/org/apache/carbondata/scan/scanner/impl/FilterScanner.java --- @@ -78,10 +80,11 @@ public FilterScanner

[GitHub] incubator-carbondata pull request #241: [CARBONDATA-319] Bad Records logging...

2016-10-15 Thread sujith71955
GitHub user sujith71955 opened a pull request: https://github.com/apache/incubator-carbondata/pull/241 [CARBONDATA-319] Bad Records logging for column data type is not proper **Problem:** Bad Records logging for column data type is not proper in case of long, carbon system

[GitHub] incubator-carbondata pull request #194: [CARBONDATA-270] Double data type va...

2016-10-16 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/194#discussion_r83546963 --- Diff: core/src/main/java/org/apache/carbondata/scan/filter/FilterUtil.java --- @@ -1426,4 +1423,25 @@ private static void

[GitHub] incubator-carbondata pull request #194: [CARBONDATA-270] Double data type va...

2016-10-16 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/194#discussion_r83547082 --- Diff: core/src/main/java/org/apache/carbondata/scan/filter/FilterUtil.java --- @@ -1426,4 +1423,25 @@ private static void

[GitHub] incubator-carbondata pull request #246: [CARBONDATA-321] If user changes the...

2016-10-17 Thread sujith71955
GitHub user sujith71955 opened a pull request: https://github.com/apache/incubator-carbondata/pull/246 [CARBONDATA-321] If user changes the blocklet size the queries will b… **Problem:** If user changes the blocklet size (50) the queries will be failed. Currently byte size

[GitHub] incubator-carbondata pull request #246: [CARBONDATA-321] If user changes the...

2016-10-21 Thread sujith71955
Github user sujith71955 closed the pull request at: https://github.com/apache/incubator-carbondata/pull/246 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim property fo...

2016-11-01 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/200#discussion_r85957411 --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenMeta.java

[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim property fo...

2016-11-01 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/200#discussion_r85957803 --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java

[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim property fo...

2016-11-01 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/200#discussion_r85957010 --- Diff: processing/src/main/java/org/apache/carbondata/processing/graphgenerator/GraphGenerator.java --- @@ -998,4 +1000,24 @@ private

[GitHub] incubator-carbondata pull request #296: [CARBONDATA-382]Like Filter Query Op...

2016-11-04 Thread sujith71955
GitHub user sujith71955 opened a pull request: https://github.com/apache/incubator-carbondata/pull/296 [CARBONDATA-382]Like Filter Query Optimization for Dictionary Columns **Like Filter Query Optimization for Dictionary Columns** a) Added pushdown mechanism for the Like filters