[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

Github user nitin-maharana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1771#discussion_r102453548 --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java --- @@ -3085,9 +3085,10 @@ public GuestVlan dedicateGuestVlanRange

[GitHub] cloudstack pull request #:

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/commit/fa85151be962824cc88776a0264e1ac6ef90560c#commitcomment-21082376 In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: In server/src/com/cloud/vm/snapshot

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/1771 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

GitHub user nitin-maharana reopened a pull request: https://github.com/apache/cloudstack/pull/1771 CLOUDSTACK-9611: Dedicating a Guest VLAN range to Project does not work. Description: = Trying to dedicate a guest VLAN range to an account fails. Either API

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou @koushik-das : I implemented the way @ustcweizhou's suggested. It was purely an UI change. But I found an issue while testing. On API side, the entire logic

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : Passing project with domain won't create any issue but not passing any account details when we call the API from default view creates an issue. Because the internal

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : You are correct. We have to remove the domain scope. If we support the domain scope, we need more changes on the logic. In that case we can create a new ticket for that

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : I have modified the code, can you review it one more time. Please see the below snapshot. https://cloud.githubusercontent.com/assets/12583725/23455743/b4d7be00

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1792 @koushik-das : No failure now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1859 ping @rajesh-battala @sowmyakrishn --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1792 @cloudmonger --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1792 @karuturi : Currently running. Will post once completes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1792 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1859 @rajesh-battala : Will update the same in wiki page. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1859 Please find the test plan executed from below link(Updated in wiki page). https://cwiki.apache.org/confluence/display/CLOUDSTACK/NCC+Integration+with+CloudStack+Test+Plan --- If

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : Yes, if domain changes, the project list should change. As per my understanding, a project is similar to an account. When we create a project, by default it is always

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1859 @rajesh-battala : Currently running, will post once completes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : The createProject API allows to created a project under a domain but no idea if there is any support from UI. Whenever I create a project, it always goes to ROOT domain

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : Please verify, I have changed according to your suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 ping @rhtyd @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1859 Ping @sowmyakrishn @jayapalu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1859 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 @ustcweizhou : In case of project view, the projectId is always passed. Also we consider it as project scope but we won't have any option to choose projects from a list because w

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

Github user nitin-maharana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1771#discussion_r104902049 --- Diff: ui/scripts/system.js --- @@ -2090,27 +2090,57 @@ fields

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1771 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1870: CLOUDSTACK-9708: Router deployment failed due to two...

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1870 @remibergsma : Can you please review it again. Fixed the test failures. ping @jayapalu @rajesh-battala --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1859 It has already two LGTMs and contains all successful test results. This is a big change, as time passes there are more chances of conflicts appearance(Already resolved once). If anyone

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1859 @rafaelweingartner : As there are multiple contributors to this feature, If I squash it to one commit, then others are going to lose their part of contributions. Initially, we thought of

[GitHub] cloudstack pull request #2031: CLOUDSTACK - 8672 : Test PR

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/2031 CLOUDSTACK - 8672 : Test PR Currently running with few commit. Please don't review this PR. According to the result of this PR, I will update in original PR(1859). You can

Re: New committer: Dag Sonstebo

Congratulations, Dag!! On Tue, Mar 20, 2018 at 7:34 PM, Paul Angus wrote: > Congratulations, well deserved! > > paul.an...@shapeblue.com > www.shapeblue.com > 53 Chandos Place, Covent Garden, London WC2N 4HSUK > @shapeblue > > > > > -Original Message- > From: Nicolas Vazquez > Sent: 20

Re: Notice that Gabriel Bräscher now works at PCextreme

Congratulations, Gabriel!!! On Tue, Mar 20, 2018 at 10:14 PM, Sateesh Chodapuneedi < sateesh.chodapune...@accelerite.com> wrote: > Congrats Gabriel. > > Regards, > Sateesh > > -Original Message- > From: Wido den Hollander > Reply-To: "dev@cloudstack.apache.org" > Date: Tuesday, 20 Marc

Re: Remove 'md5Hashed' variable from Javascript

+1 On Mon, Apr 9, 2018 at 11:01 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Hello fellow CloudStackers, > > Today I was working on CLOUDSTACK-5235, which is a security issue, and I > noticed a variable ‘md5Hashed’ in the javascript that does not seem to be > useful at all. This

Re: Community opinion regarding Apache events banner in CloudStack's website

+1 for the third option. I think It would even look good if we adjust the vertical alignment of the word "Apache CloudStack" to center. On Wed, Apr 18, 2018 at 12:12 AM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Third option (suggested by Dag) - > https://drive.google.com/open?id

Re: [VOTE] Primate as modern UI for CloudStack

+1 On Mon, 7 Oct 2019 at 8:39 PM, Sven Vogel wrote: > +1 (binding) > > > __ > > Sven Vogel > Teamlead Platform > > EWERK DIGITAL GmbH > Brühl 24, D-04109 Leipzig > > P +49 341 42649 - 99 > F +49 341 42649 -

Prime Minister of India: Commit To Ensuring A Healthy Work-Life Balance For Working Indians #RightToDisconnect

Hey, I just signed the petition "Prime Minister of India: Commit To Ensuring A Healthy Work-Life Balance For Working Indians #RightToDisconnect" and wanted to see if you could help by adding your name. Our goal is to reach 150,000 signatures and we need more support. You can read more and sign th

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1206#issuecomment-164344691 @DaanHoogland : Yes, your idea also looks good. Previously, it was generating a random value only in case of NULL. But if we pass an empty string, it was

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1206#issuecomment-164366344 API with non-empty name: http://10.102.192.122:8080/client/api?command=createVolume&response=json&name=TempVolum

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1206#issuecomment-164411409 @DaanHoogland : In UI, we put the field as required field, so user has to give some name to create a volume. It cannot be null or blank. But according the

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1206#issuecomment-164475760 @DaanHoogland : You mean the name should be an optional field? If that is the case, we should make the field as optional in UI as well as in API

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1150#issuecomment-164514502 Step-1: = ![pr_1150_ss1_nitin](https://cloud.githubusercontent.com/assets/12583725/11789386/1d14793c-a2bc-11e5-9184-f16b84af91f4.png

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/1082 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1082#issuecomment-164723525 Hi @remibergsma : Yes, you are correct. This issue is no more in master. I think this issue was resolved with a different PR. So closing the PR. Thanks

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/823#issuecomment-165074680 @agneya2001 : If the new service offering wants in change of deployment then it should be fine. But the change affects after reboot only. Thanks. --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1206#issuecomment-165076449 @rafaelweingartner : Thanks for the suggestion. I will follow the same to write test cases for this. @DaanHoogland : Should we make the Name field as

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1258 CLOUDSTACK-9186: Root admin cannot see VPC created by Domain admin user Issue: = Root admin cannot see LB rules and Public LB IP addresses created by domain-admin in UI

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1206#issuecomment-165757054 cc @koushik-das @kishankavala --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-166109722 cc @remibergsma @kishankavala --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1264 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing Reproducible Steps: 1.Create a customer gateway for a VPC. 2.Edit it using UI(API call is

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1264#issuecomment-166223258 cc @JayapalUradi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1264#issuecomment-166258585 Hi @ustcweizhou, The error function is not necessary but it is good to write this in call. Here the request doesn't fail but throws an error. Thanks fo

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1273 CLOUDSTACK-9132: API createVolume takes empty string for name parameter Steps to Reproduce: Create a volume using createVolume API where parameter name is empty

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-166556707 Reference(4.6) : https://github.com/apache/cloudstack/pull/1206 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1206#issuecomment-166556945 Made a new PR https://github.com/apache/cloudstack/pull/1273 with master. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/1206 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-166830953 Sure @koushik-das. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-167484496 @rafaelweingartner : Thanks for reviewing the change. The reason to close the old PR is because it was merging with branch 4.6. I started this PR

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-167484956 @remibergsma : I didn't check in other API calls. If i come across any, then will raise the issue. Thanks. --- If your project is set up for it, yo

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-167485441 @rafaelweingartner : The recursive parameter is not necessary here, because we don't provide the domain id parameter. --- If your project is set up f

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-167721727 @rafaelweingartner : I have updated the branch. Can you please review the change. Thanks. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-167765606 @rafaelweingartner : Thats cool. I went through the detail of isBlank, but could not catch. Thank you. I have updated. --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-167773312 Thanks a lot @rafaelweingartner , I learned many things. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-167931759 cc @remibergsma @bhaisaab --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1150#issuecomment-167931844 cc @bhaisaab --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-168115394 cc @kishankavala --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1150#issuecomment-168115562 @remibergsma : Any updates on this? Can you please look at the change if you have a setup. Thanks. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1264#issuecomment-168115603 cc @kishankavala @bhaisaab @remibergsma --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1264#issuecomment-168282637 Sure @remibergsma. I will a PR against 4.7. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-168284288 @remibergsma : Shall I make this one against 4.7. I mean, should I make all pending PRs against 4.7? Is it not going to be merged? --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1300 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing Reproducible Steps: 1.Create a customer gateway for a VPC. 2.Edit it using UI(API call is

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1300#issuecomment-168289311 Reference #1264 (The PR against master). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/1264 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1264#issuecomment-168289642 Closing this PR as made a new PR #1300 (Against 4.7 which will be merged in master later). --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1301 CLOUDSTACK-9186: Root admin cannot see VPC created by Domain admin user Issue: = Root admin cannot see LB rules and Public LB IP addresses created by domain-admin in UI

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1301#issuecomment-168290875 Reference PR #1258 (Against master). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/1258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-168290892 Closing this PR as made a new PR #1301 (Against 4.7 which will be merged in master later). --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-168489232 @remibergsma : My new PRs are failing in 4.7. With the same change it was successful in master. I think there is some issue with the branch. --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1319 CLOUDSTACK-9132: API createVolume takes empty string for name parameter Steps to Reproduce: Create a volume using createVolume API where parameter name is

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1319#issuecomment-169927365 Reference PR #1273 (Against master) with 3 LGTMs. This PR (against 4.7) contains the same code change. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-169927533 Closing this PR as made a new PR #1319 (Against 4.7 which will be merged in master later). --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/1273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1320 CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance Added a new Icon in Instance page to launch the VM from the snapshot. A new icon over VM snapshot object, which

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1150#issuecomment-169931078 Closing this PR as made a new PR #1320 (Against 4.7 which will be merged in master later). --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/1150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1320#issuecomment-169931271 Reference PR #1150 (Against 4.6). This PR (against 4.7) contains the same code change with one conflict which I resolved. --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1321 CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged offerings when called with VM id When calling listServiceOfferings with VM id as parameter. It is returning

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-169934934 Reference PR #823 (Against master). This PR (against 4.7) contains the same code change. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/823#issuecomment-169935147 Closing this PR as made a new PR #1321 (Against 4.7 which will be merged in master later). --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/823 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1319#issuecomment-169935900 Hi @remibergsma, I created all my pending PRs against 4.7. Can you please review once. Thanks. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1327#issuecomment-170453979 @remibergsma: Checked for all alphabet names, its sorting perfectly. But how it is sorting for special character names starting with @, #, etc. Is it

[GitHub] cloudstack pull request: CLOUDSTACK-9221 Allow admin to see user V...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1325#issuecomment-170477896 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1319#issuecomment-170801193 @remibergsma : Any updates on this. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1300#issuecomment-170801305 @kishankavala @koushik-das : Can you please review this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1319#issuecomment-170825451 @mike-tutkowski : Yes, we decided to make random name as a preferred solution. You can refer the detail conversation on this PR #1273 . Thanks for reviewing

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1319#discussion_r49498039 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -476,6 +476,25 @@ public VolumeVO doInTransaction(TransactionStatus

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1319#discussion_r49551329 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -476,6 +476,25 @@ public VolumeVO doInTransaction(TransactionStatus

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1319#issuecomment-171184133 @remibergsma @DaanHoogland : It has got 4 LGTMs. Is it going to be merged? Should it be reviewed by some more people? Thanks. --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1333 CLOUDSTACK-9228: Network update with mistmatch in services require forced option Steps to reproduce: === 1.Bring up CloudStack in advanced zone 2.Create

[GitHub] cloudstack pull request: CLOUDSTACK-9229: Autoscale policy creatio...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1334 CLOUDSTACK-9229: Autoscale policy creation failing in VPC due to zone id missing in createAutoScaleVmProfile Autoscale policy creation is failing on VPC while creating

  1   2   3   >