Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@nathanejohnson thank you for your confirmation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@jburwell that is correct, the lab I tested on is running KVM + ceph.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@nathanejohnson to confirm, the test results in your [26 Aug
comment](https://github.com/apache/cloudstack/pull/1645#issuecomment-242715452)
comment were from a run on KVM + Ceph?
---
If your
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@jburwell , test results were posted earlier in the thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@nathanejohnson @kiwiflyer do you have test results to share for KVM +
Ceph? If not, we need to rollback this PR until we get test confirmation of
the functionality.
---
If your project is s
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@jburwell No I didnt. As I said in the other PR, I only have a xenserver
environment(my test run was only to see it didnt cause any regressions). If you
can get a KVM environment running, which
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@karuturi was this PR tested on KVM?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1645
Failure is not related. Looks like an environment issue(I am checking it).
Merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1645
### ACS CI BVT Run
**Sumarry:**
Build Number 99
Hypervisor xenserver
NetworkType Advanced
Passed=99
Failed=1
Skipped=4
_Link to logs Folder (search
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@kiwiflyer Noted. Looking at the code diff, I dont think it will cause any
regressions. But, just wanted to run the tests once.
---
If your project is set up for it, you can reply to this ema
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@karuturi - So, note that this feature addition only affects KVM when
using RBD as the back-end storage.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1645
### ACS CI BVT Run
**Sumarry:**
Build Number 98
Hypervisor xenserver
NetworkType Advanced
Passed=102
Failed=1
Skipped=4
_Link to logs Folder (search
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1645
I will start our internal CI run on this(it runs the smoke tests and will
post the results here). Once that is successful, I will merge this.
---
If your project is set up for it, you can rep
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@kiwiflyer That seems good indeed. If we are not setting a source format
this looks good indeed.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@jburwell @si @wido
Here are the results of the nosetests. One test did throw an exception
during teardown, but I am not sure that this is anything to be concerned about.
I'll
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
I took a look at the code last night and it seems that we're no longer
specifying the source format when calling qemu-img convert. We're relying on
qemu-img's auto detection of source format
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@jburwell the smoke test completed successfully
Test Snapshot Root Disk ... === TestName: test_01_snapshot_root_disk |
Status : SUCCESS ===
ok
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@wido I don't know that the management server knows explicitly, it doesn't
actually seem to store the disk image format in the snapshot related tables at
all, only in volumes as far as I
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@kiwiflyer So does the mgmt server know the snapshot is now in QCOW2? Or
does it still think it's RAW?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@jburwell as an update, the smoke test has completed successfully, and I'll
let the component tests run overnight. Hopefully they will have finished by
the morning.
---
If your project
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@nathanejohnson excellent. I will keep any eye out for your updates.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@jburwell
I'm hoping that I can spend a good part of today on the requests you've
made on my three open pull requests.
---
If your project is set up for it, you can reply to th
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@nathanejohnson could you please create JIRA ticket for this issue and
prepend the commit message with the ID?
---
If your project is set up for it, you can reply to this email and have your
r
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@kiwiflyer @nathanejohnson as part of your continued evaluation, can you
evaluate the following test cases to ensure this new behavior is verified and
regression tested:
* ``smoke/test
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
Yeah, there seems to be some black magic going on here. We'll dig into this
a bit more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1645
What I see to remember somehow is that the management server/code always
thinks a snapshot is in the same format as the base image was.
So when you try to do something with this snapshot it
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
For reference, here are the DB entries:
