[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1444


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-218579831
  
I think this one is pretty much ready.  I have one code review on this one. 
 Can I get one more person to look over this for me?  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-218579019
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 1
   Errors: 0
 Duration: 9h 12m 09s
```

**Summary of the problem(s):**
```
FAIL: Test redundant router internals
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", 
line 483, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
"Attempt to retrieve google.com index page should be successful once 
rule is added!"
AssertionError: Attempt to retrieve google.com index page should be 
successful once rule is added!
--
Additional details in: /tmp/MarvinLogs/test_network_F298R0/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_11_2016_00_51_52_QTWNUF:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/DeployDataCenter__May_11_2016_00_51_52_QTWNUF/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/DeployDataCenter__May_11_2016_00_51_52_QTWNUF/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/DeployDataCenter__May_11_2016_00_51_52_QTWNUF/runinfo.txt)

**`/tmp/MarvinLogs/test_network_F298R0:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_network_F298R0/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_network_F298R0/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_network_F298R0/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_6U8HTX:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_vpc_routers_6U8HTX/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_vpc_routers_6U8HTX/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_vpc_routers_6U8HTX/runinfo.txt)


Uploads will be available until `2016-07-11 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-217798010
  
Thanks @rafaelweingartner for the updated PR.
LGTM based on code review and verification of PR on simulator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-217537499
  
@swill done ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-217479698
  
Can we get another code review on this one.  Also, can you force push to 
kick off Jenkins again?  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-216957591
  
@koushik-das, You are right.
Those variables that were introduced are all primitives; if they have not 
being loaded, their default value will be zero. We can indeed remove this 
check. 
Thanks for the review and help ;)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1444#discussion_r62006414
  
--- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java ---
@@ -205,14 +205,21 @@ public UserVmResponse newUserVmResponse(ResponseView 
view, String objectName, Us
 
 
userVmResponse.setNetworkKbsWrite((long)vmStats.getNetworkWriteKBs());
 
-if ((userVm.getHypervisorType() != null) && 
(userVm.getHypervisorType().equals(HypervisorType.KVM) || 
userVm.getHypervisorType().equals(HypervisorType.XenServer))) { // support KVM 
and XenServer only util 2013.06.25
+if ((userVm.getHypervisorType() != null) && 
(userVm.getHypervisorType().equals(HypervisorType.KVM) || 
userVm.getHypervisorType().equals(HypervisorType.XenServer) || 
userVm.getHypervisorType().equals(HypervisorType.VMware))) { // support KVM and 
XenServer only util 2013.06.25 . supporting Vmware from 2015.09.02
--- End diff --

I removed the HV checks and ran it on a simulator and worked as expected, 
returned 0 for the newly added fields in response. Since this is supposed to 
work for XS, KVM, VMware anyways, and simulator works as well, guess the check 
can be removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-216597727
  
That is a nice suggestion.
I have done that, what do you think now?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-216569013
  
@rafaelweingartner just checked that the first commit indeed is by someone 
else, though I think it would be still valid to note in your commit (the 2nd 
one) the JIRA ID (same as the first one) and summarize details on what extra 
work you're doing to improve (i.e. why we need it, how we are doing it etc.). 
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1444#discussion_r61870927
  
--- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java ---
@@ -205,14 +205,21 @@ public UserVmResponse newUserVmResponse(ResponseView 
view, String objectName, Us
 
 
userVmResponse.setNetworkKbsWrite((long)vmStats.getNetworkWriteKBs());
 
-if ((userVm.getHypervisorType() != null) && 
(userVm.getHypervisorType().equals(HypervisorType.KVM) || 
userVm.getHypervisorType().equals(HypervisorType.XenServer))) { // support KVM 
and XenServer only util 2013.06.25
+if ((userVm.getHypervisorType() != null) && 
(userVm.getHypervisorType().equals(HypervisorType.KVM) || 
userVm.getHypervisorType().equals(HypervisorType.XenServer) || 
userVm.getHypervisorType().equals(HypervisorType.VMware))) { // support KVM and 
XenServer only util 2013.06.25 . supporting Vmware from 2015.09.02
--- End diff --

@koushik-das,  that is a great question.
I have no idea why we need to check the hypervisor type. This is something 
that probably comes way before @maneesha-p changes, giving that she/he just 
added the check for VMware.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-216508737
  
@rhtyd, I understand and I agree with your concerns. The point here is that 
I am not fragmenting commits, I just cherry picked a commit that was reverted 
and then I fixed the issues it introduced.

About the commit message, both commits are pretty clear what they do, not?

The commit “7ad3c5e” from @maneesha-p, has the Jira ticket and a 
description. 

And the commit “6c3d8ca” that I introduced, has only a title, but it is 
pretty clear what it is doing (it fix issues that were introduced by a PR). Do 
you mean that it should have some Jira ticket opened?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1444#discussion_r61844330
  
--- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java ---
@@ -205,14 +205,21 @@ public UserVmResponse newUserVmResponse(ResponseView 
view, String objectName, Us
 
 
userVmResponse.setNetworkKbsWrite((long)vmStats.getNetworkWriteKBs());
 
-if ((userVm.getHypervisorType() != null) && 
(userVm.getHypervisorType().equals(HypervisorType.KVM) || 
userVm.getHypervisorType().equals(HypervisorType.XenServer))) { // support KVM 
and XenServer only util 2013.06.25
+if ((userVm.getHypervisorType() != null) && 
(userVm.getHypervisorType().equals(HypervisorType.KVM) || 
userVm.getHypervisorType().equals(HypervisorType.XenServer) || 
userVm.getHypervisorType().equals(HypervisorType.VMware))) { // support KVM and 
XenServer only util 2013.06.25 . supporting Vmware from 2015.09.02
--- End diff --

@maneesha-p @rafaelweingartner 
Is there any need for all the HV checks? In case these properties are not 
supported in some HV, the values can be defaulted to something like 0 or -1.
Due to the checks it cannot be run in simulator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-216436317
  
@rafaelweingartner for a project with thousands of commits, splitting the 
commits for a PR or bug that solves for the same logical issue results in 
fragmented history. Both commits can individually improve the commit messages, 
at least they can be amended to including the JIRA bug ID, detail description 
(what it is, what it solves etc.). Those things are important and useful when 
we look back in future. If commits are split into multiple ones, it creates 
issue to track them, to port them etc. I suggest you squash them into one 
commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-216266457
  
I think the two commits are fine in this case, so just leave it as it is.  
👍 

Can we get some LGTM code reviews on this one?  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-216264551
  
@rhtyd I think it would not be a good idea to squash these commits. We will 
lose the history if we do it here.

I only cherry picked the changes done by @maneesha-p and were reverted a 
while back. Then, I fixed some of the issues that commit introduced. 

Also, there is no conflict with the master version, do we really need to 
rebase again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-216226029
  
@rafaelweingartner please rebase against master, and squash changes to a 
single commit

tag:easypr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-215847599
  
ya, that is interesting.  a couple people have mentioned similar tools.  
once I get the repo moved to the new github org I can start look into adding 
such tooling...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-215833023
  
Ok, I will do that.
I can help youwith that (If we get access to the VM).
It would be nice, something like this plugin 
"https://github.com/janinko/ghprb;, then we could use sentences such "test this 
please" or "retest this please". I have used it, and it is very interesting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-215832199
  
Just do a force push again.  Jenkins is being a bit of a princess recently, 
so we just have to keep trying.  This has been happening to a lot of PRs and it 
is almost never related to the PR.  Maybe I should get my hands dirty and see 
if I can improve the Jenkins implementation, but I just don't have time right 
now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-215829693
  
@swill Jenkins is complaining about a file called "testsmallfileinactive", 
but I have not introduced any sort of file like that. Is that some sort of 
trash that was left behind on the Jenkins VM?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-215822574
  
@swill conflicts solved


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-215554170
  
@rafaelweingartner please rebase as we currently have merge conflicts.  
Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-215122425
  
I would like to get at least one LGTM in this PR.  The code is basically 
the same as the previous one other than the fixes to the potential NPE issues.  
I think we should get some reviews here regardless.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-215111745
  
@swill, I am so sorry, I had forgotten this PR. I opened the email to help 
in a review thinking that this was from someone else.

Are you sure we can count the LGTMs from other PR here?
We have not received any LGTMs. I do not know if the code was reviewed 
though.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-215109078
  
Ran the usage tests to make sure everything is passing.  Don't worry about 
the snapshot issue, it is not related to this PR.

I think this PR is ready if I count the LGTM votes from the previous PR.  
Any final thoughts???


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-215108116
  


### CI RESULTS

```
Tests Run: 18
  Skipped: 0
   Failed: 0
   Errors: 2
```

**Summary of the problem(s):**
```
ERROR: Test Create/Delete a manual snap shot and verify
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/component/test_project_usage.py", 
line 1376, in test_01_snapshot_usage
snapshot = Snapshot.create(self.apiclient, volumes[0].id)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1014, in 
create
return Snapshot(apiclient.createSnapshot(cmd).__dict__)
  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", 
line 797, in createSnapshot
response = self.connection.marvinRequest(command, 
response_type=response, method=method)
  File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", 
line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createsnapshot failed, due to: 
errorCode: 530, errorText:KVM Snapshot is not supported: 1
--
Additional details in: /tmp/MarvinLogs/test_usage_0CACSG/results.txt
```

```
ERROR: Test Create/Delete a manual snap shot and verify
--
Traceback (most recent call last):
  File "/data/git/cs1/cloudstack/test/integration/component/test_usage.py", 
line 1300, in test_01_snapshot_usage
snapshot = Snapshot.create(self.apiclient, volumes[0].id)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1014, in 
create
return Snapshot(apiclient.createSnapshot(cmd).__dict__)
  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", 
line 797, in createSnapshot
response = self.connection.marvinRequest(command, 
response_type=response, method=method)
  File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", 
line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createsnapshot failed, due to: 
errorCode: 530, errorText:KVM Snapshot is not supported: 1
--
Additional details in: /tmp/MarvinLogs/test_usage_0CACSG/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/test_usage_0CACSG:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_usage_0CACSG/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_usage_0CACSG/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_usage_0CACSG/runinfo.txt)

**`/tmp/MarvinLogs/test_usage_46FO5S:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_usage_46FO5S/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_usage_46FO5S/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_usage_46FO5S/runinfo.txt)


Uploads will be available until `2016-06-27 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-215094461
  
The issues that we see here are environment issues that sometimes show up.  
They are not related to this PR.  

I am running another set of usage specific integration tests.  I am not 
sure of the state of these tests, so I will post the results when they are done 
and we can go from there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-215090037
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 3
   Errors: 0
```

**Summary of the problem(s):**
```
FAIL: Test redundant router internals
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", 
line 290, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
"Attempt to retrieve google.com index page should be successful!"
AssertionError: Attempt to retrieve google.com index page should be 
successful!
--
Additional details in: /tmp/MarvinLogs/test_network_NAELYA/results.txt
```

```
FAIL: test_03_vpc_privategw_restart_vpc_cleanup 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
265, in test_03_vpc_privategw_restart_vpc_cleanup
self.performVPCTests(vpc_off, True)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
324, in performVPCTests
self.check_pvt_gw_connectivity(vm1, public_ip_1, vm2.nic[0].ipaddress)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
559, in check_pvt_gw_connectivity
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_network_NAELYA/results.txt
```

```
FAIL: test_04_rvpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
277, in test_04_rvpc_privategw_static_routes
self.performVPCTests(vpc_off)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
324, in performVPCTests
self.check_pvt_gw_connectivity(vm1, public_ip_1, vm2.nic[0].ipaddress)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
559, in check_pvt_gw_connectivity
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_network_NAELYA/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__Apr_27_2016_06_50_55_VQRZDI:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/DeployDataCenter__Apr_27_2016_06_50_55_VQRZDI/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/DeployDataCenter__Apr_27_2016_06_50_55_VQRZDI/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/DeployDataCenter__Apr_27_2016_06_50_55_VQRZDI/runinfo.txt)

**`/tmp/MarvinLogs/test_network_NAELYA:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_network_NAELYA/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_network_NAELYA/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_network_NAELYA/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_Z0GM3S:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_vpc_routers_Z0GM3S/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_vpc_routers_Z0GM3S/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_vpc_routers_Z0GM3S/runinfo.txt)


Uploads will be available until `2016-06-27 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and 

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1444#discussion_r58480834
  
--- Diff: 
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
 ---
@@ -484,6 +489,10 @@ public DomainBlockStats answer(final InvocationOnMock 
invocation) throws Throwab
 // IO traffic as generated by the logic above, must be greater 
than zero
 Assert.assertTrue(vmStat.getDiskReadKBs() > 0);
 Assert.assertTrue(vmStat.getDiskWriteKBs() > 0);
+// Memory limit of VM must be greater than zero
--- End diff --

Ok, that does make sense.  I will get this tested and we will go from 
there.  Thanks for the review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1444#discussion_r58375427
  
--- Diff: 
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
 ---
@@ -484,6 +489,10 @@ public DomainBlockStats answer(final InvocationOnMock 
invocation) throws Throwab
 // IO traffic as generated by the logic above, must be greater 
than zero
 Assert.assertTrue(vmStat.getDiskReadKBs() > 0);
 Assert.assertTrue(vmStat.getDiskWriteKBs() > 0);
+// Memory limit of VM must be greater than zero
--- End diff --

I have read and given some time to think about this test. It is very big 
and complicated, but those are other issues that are due to the method itself 
that is being tested. 

About the test coditional, I believe that the “>=” is right. Because if 
you are checking the freeMemory, that method can return zero (0) in cases that 
you are using all of the memory that is being allocated to the VM. I think that 
the comment in the test case is misleading us.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1444#discussion_r58316653
  
--- Diff: 
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
 ---
@@ -484,6 +489,10 @@ public DomainBlockStats answer(final InvocationOnMock 
invocation) throws Throwab
 // IO traffic as generated by the logic above, must be greater 
than zero
 Assert.assertTrue(vmStat.getDiskReadKBs() > 0);
 Assert.assertTrue(vmStat.getDiskWriteKBs() > 0);
+// Memory limit of VM must be greater than zero
--- End diff --

@maneesha-p: can you shed some light on this?

> You specify that memory must be greater than zero in this comment, but it 
uses >= in the actual logic. Can you explain?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-200473159
  
Can we continue the conversation at #1444 please.  This commit has been 
reverted and has been pulled into #1444 to continue QA of the code.  Please 
come contribute at #1444 and continue getting this code ready for production.  
Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-199497512
  
Hey Guys, Sorry I have been MIA on this.  I have been traveling and have 
limited connectivity.  

I am going to revert this merge.  There are visible problems with this 
merge and there were no integration tests run.  @rafaelweingartner has offered 
to merge these changes into #1444, which fix the issues in this commit and 
allow us to run integration tests on this commit before merging it in.

Sorry for the delay following up on this and getting a clear resolution in 
place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-199270124
  
Guys, LGTMs or not, there were no integration test results posted so it 
shouldn't have been merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-199254175
  
@DaanHoogland I don't see any reason for closing master in this case. If an 
issue is noticed after a merge, it definitely needs to be tracked and fixed. 
Releasing a branch can definitely be blocked if the issues (particularly 
regressions) are not addressed but I don't see any reason to close master for 
other commits. I think that closing master makes sense only if build is broken 
or there is a blocking regression introduced after the last release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-199227949
  
@kishankavala you are formally correct and we had not closed master for 
release so I don't blame you for the merge. The issue as brought up by @swill 
is not to blame anybody for the merge but to preserve the quality of master 
before doing so. I am just saying that we should close master now and not merge 
anything before this is fixed or reverted, whatever.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[kishankavala]

Github user kishankavala commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-199222784
  
@swill @remibergsma @DaanHoogland PR was open since Sep 2015. Review from 
@swill came after the PR was merged on Mar 17 2016. By then, there were code 
reviews and tests done with 3 LGTMs. I merged the PR as per the current 
process.  
Unfortunately all reviewers missed the issued mentioned by @swill   
Thanks to @rafaelweingartner https://github.com/apache/cloudstack/pull/1444 
addresses the runtime exception issues.
Unless there are issues with PR 1444, I do not see a need to revert this 
merge. Can we all please review PR 1444 and close this issue?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-199209886
  
@swill I would not allow any other merge before this is fixed or reverted!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-198515978
  
@swill Please do proceed with revert, I totally agree.

`git revert -m 1 dc0ba6bd1a774d3ff4bc4a4dcc00e1434ab1f6e3` will do. Let me 
know if you need help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-197904412
  
@swill you can create a PR if you want.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/780


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/780#discussion_r56508756
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -3026,11 +3031,16 @@ public VmStatsEntry getVmStat(final Connect conn, 
final String vmName) throws Li
 try {
 dm = getDomain(conn, vmName);
--- End diff --

I believe here we can have a null pointer in very specific cases. For 
instance, if this code is being executed while a call to destroy the VM that 
has the name “vmName”; this getDomain would return a null value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-197890163
  
I see this was merged into master this morning.  Hmmm...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/780#discussion_r56509710
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ---
@@ -3332,7 +3332,14 @@ public PowerState getVmState(final Connection conn, 
final String vmName) {
 
vmStatsAnswer.setDiskReadKBs(vmStatsAnswer.getDiskReadKBs() + 
getDataAverage(dataNode, col, numRows) / 1000);
 } else if (param.matches("vbd_.*_write")) {
 
vmStatsAnswer.setDiskWriteKBs(vmStatsAnswer.getDiskWriteKBs() + 
getDataAverage(dataNode, col, numRows) / 1000);
+} else if (param.contains("memory_internal_free")) {
--- End diff --

I know you just followed the way the code was written here before, but this 
“if/else/if/else……” structure is too big; I believe to introduce some 
changes like this here; it would be much appreciated a refactoring. I do not 
mean a huge refactoring, only the extraction of this if/else structure to a 
method and then using some other clever way to do these checks and to retrieve 
the values. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-197939345
  
@rafaelweingartner I don't mind waiting a bit, but runtime exceptions need 
to be taken seriously.  As the 4.9 RM, it is my responsibility to make sure 
this type of stuff is sorted out BEFORE it gets merged into master.  I welcome 
others to give feedback, but I would recommend that we do a `git revert` on 
this merge and at the very least code defensively around the runtime exceptions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/780#discussion_r56508389
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -3026,11 +3031,16 @@ public VmStatsEntry getVmStat(final Connect conn, 
final String vmName) throws Li
 try {
 dm = getDomain(conn, vmName);
 final DomainInfo info = dm.getInfo();
+final MemoryStatistic[] mems = dm.memoryStats(NUMMEMSTATS);
  //number of memory statistics required.
 
 final VmStatsEntry stats = new VmStatsEntry();
+
 stats.setNumCPUs(info.nrVirtCpu);
 stats.setEntityType("vm");
 
+stats.setMemoryKBs(info.maxMem);
+stats.setTargetMemoryKBs(info.memory);
+stats.setIntFreeMemoryKBs((double) mems[0].getValue());
--- End diff --

the same problem pointed out by @swill at line 3128, may happen here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-197932674
  
@swill, I understand your position; as you, I also think that there was 
room for improvements in this PR (especially to avoid possible runtime 
exception). However, reverting a PR is always something complicated. I believe 
we should wait to hear feedback from others, before taking any decision.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-197917819
  
@ustcweizhou the point is more that there are things in this PR that I am 
not comfortable with and as the 4.9 RM, I need to be comfortable with the code 
that goes into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-197893296
  
should we revert this merge in favor of fixing these issues?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill]

Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/780#discussion_r56506811
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -3115,6 +3125,9 @@ public VmStatsEntry getVmStat(final Connect conn, 
final String vmName) throws Li
 newStat._bytesRead = bytes_rd;
 newStat._bytesWrote = bytes_wr;
 newStat._timestamp = now;
+newStat._intmemfree = mems[0].getValue();
--- End diff --

Is this guaranteed to have a result?  This looks like it is prime to 
introduce a Null Pointer Exception...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/780#discussion_r56509815
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -4879,10 +4889,16 @@ private VirtualMachineGuestOsIdentifier 
translateGuestOsIdentifier(String cpuArc
 } else if 
(objProp.getName().contains(instanceNameCustomField)) {
--- End diff --

Here it is the same as in CitrixResourceBase.java. I know you just followed 
the way the code was written here before, but this “if/else/if/else……” 
structure is too big; I believe to introduce some changes like this here; it 
would be much appreciated a refactoring. I do not mean a huge refactoring, only 
the extraction of this if/else structure to a method and then using some other 
clever way to do these checks and to retrieve the values. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[kishankavala]

Github user kishankavala commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-197262533
  
Tested Manually. memorykbs, memoryintfreekbs,memorytargetkbs are listed 
correctly.
LGTM.


`1a574e9d1-8057-4195-a8b3-2117e9059652VM-a574e9d1-8057-4195-a8b3-2117e9059652VM-a574e9d1-8057-4195-a8b3-2117e9059652adminee621684-952a-11e5-abd2-d4ae52cb9a54adminee5bfd6f-952a-11e5-abd2-d4ae52cb9a54ROOT2015-11-27T23:30:46+0530Runningfalseb5503a30-f55b-4889-94c2-32a73c6b4166KK57382ec5-87e1-4c0b-9df1-02b2cba04971Rack3Pod1Host44ee3b1574-952a-11e5-abd2-d4ae52cb9a54CentOS
 5.6(64-bit) no GUI (XenServer)CentOS 
5.6(64-bit) no GUI 
(XenServer)false1d88488d-6651-4a63-b865-a3a5f4115dd6custom45121280.04%000111310721513107200ee4c163d-952a-11e5-abd2-d4ae52cb9a540ROOT66347c35-f51f-4527-bb59-50a976d90927d97370e1-7fb3-44be-8af5-9515c1d624a2n1255.255.255.010.1.1.110.1.1.14vlan://514vlan://514GuestIsolatedtr
 
ue02:00:66:75:00:01XenServeri-2-3-VM{hypervisortoolsversion=xenserver56}truetrue142`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[maneesha-p]

Github user maneesha-p commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/780#discussion_r56314421
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ---
@@ -3332,7 +3332,14 @@ public PowerState getVmState(final Connection conn, 
final String vmName) {
 
vmStatsAnswer.setDiskReadKBs(vmStatsAnswer.getDiskReadKBs() + 
getDataAverage(dataNode, col, numRows) / 1000);
 } else if (param.matches("vbd_.*_write")) {
 
vmStatsAnswer.setDiskWriteKBs(vmStatsAnswer.getDiskWriteKBs() + 
getDataAverage(dataNode, col, numRows) / 1000);
+} else if (param.contains("memory_internal_free")) {
+
vmStatsAnswer.setIntFreeMemoryKBs(vmStatsAnswer.getIntFreeMemoryKBs() + 
getDataAverage(dataNode, col, numRows) / 1000);
--- End diff --

Updated.Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[kishankavala]

Github user kishankavala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/780#discussion_r56311601
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ---
@@ -3332,7 +3332,14 @@ public PowerState getVmState(final Connection conn, 
final String vmName) {
 
vmStatsAnswer.setDiskReadKBs(vmStatsAnswer.getDiskReadKBs() + 
getDataAverage(dataNode, col, numRows) / 1000);
 } else if (param.matches("vbd_.*_write")) {
 
vmStatsAnswer.setDiskWriteKBs(vmStatsAnswer.getDiskWriteKBs() + 
getDataAverage(dataNode, col, numRows) / 1000);
+} else if (param.contains("memory_internal_free")) {
+
vmStatsAnswer.setIntFreeMemoryKBs(vmStatsAnswer.getIntFreeMemoryKBs() + 
getDataAverage(dataNode, col, numRows) / 1000);
--- End diff --

Bytes to KB conversion should use 1024 instead of 1000


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[maneesha-p]

Github user maneesha-p commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-188171070
  
@remibergsma @wido @bhaisaab  2 LGTMs can it be merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-176693950
  
This looks good to me. Hard to test though :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[maneesha-p]

Github user maneesha-p commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-176683204
  
@bhaisaab @wido @remibergsma Plz review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-175665865
  
@maneesha-p please rebase against latest branch and resubmit


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-139915515
  
@remibergsma @maneesha-p Indeed. We have the information, so why not KVM? 
That would cover allmost all cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[maneesha-p]

Github user maneesha-p commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-139961981
  
@wido @remibergsma I am sorry I changed it for kvm but updated the 
description wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-139296681
  
@maneesha-p Why not for KVM?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[maneesha-p]

Github user maneesha-p commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/780#discussion_r39034863
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -4751,7 +4760,7 @@ private VirtualMachineGuestOsIdentifier 
translateGuestOsIdentifier(String cpuArc
 }
 }
 }
-vmResponseMap.put(name, new 
VmStatsEntry(Integer.parseInt(maxCpuUsage), networkReadKBs, networkWriteKBs, 
Integer.parseInt(numberCPUs), "vm"));
+vmResponseMap.put(name, new 
VmStatsEntry(Double.parseDouble(memkb)*1000,Double.parseDouble(guestMemusage)*1000,Double.parseDouble(memlimit)*1000,
 Double.parseDouble(maxCpuUsage), networkReadKBs, networkWriteKBs, 
Integer.parseInt(numberCPUs), "vm"));
--- End diff --

@karuturi  Incorporated the changes.Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[karuturi]

Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/780#discussion_r39122432
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -4662,8 +4663,14 @@ private VirtualMachineGuestOsIdentifier 
translateGuestOsIdentifier(String cpuArc
 }
 String instanceNameCustomField = "value[" + key + "]";
 
+String numCpuStr = "summary.config.numCpu";
+String cpuUseStr = "summary.quickStats.overallCpuUsage";
+String guestMemUseStr = "summary.quickStats.guestMemoryUsage";
+String memLimitStr = "resourceConfig.memoryAllocation.limit";
+String memMbStr = "config.hardware.memoryMB";
+
--- End diff --

same here. private static final and caps


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-139109578
  
I see tests only for LibrvirtResource. They are missing for StatsCollector, 
CitrixResourceBase, VmwareResource


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[karuturi]

Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/780#discussion_r39122397
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -189,6 +190,7 @@
 private long _hvVersion;
 private long _kernelVersion;
 private int _timeout;
+private int _nummemstats =2;
--- End diff --

Can you make this private static final and probably use caps for the 
constants?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-138524943
  
LGTM (though not tested in an environment), anyone wants to review @wido 
@remibergsma @wilderrodrigues ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[karuturi]

Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/780#discussion_r38916972
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -2981,11 +2985,16 @@ public VmStatsEntry getVmStat(final Connect conn, 
final String vmName) throws Li
 try {
 dm = getDomain(conn, vmName);
 final DomainInfo info = dm.getInfo();
+final MemoryStatistic[] mems = dm.memoryStats(2);
--- End diff --

What does 2 mean? Can you use a constant and probably add a comment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[karuturi]

Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/780#discussion_r38917202
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -4663,7 +4663,7 @@ private VirtualMachineGuestOsIdentifier 
translateGuestOsIdentifier(String cpuArc
 String instanceNameCustomField = "value[" + key + "]";
 
 ObjectContent[] ocs =
-hyperHost.getVmPropertiesOnHyperHost(new String[] {"name", 
"summary.config.numCpu", "summary.quickStats.overallCpuUsage", 
instanceNameCustomField});
+hyperHost.getVmPropertiesOnHyperHost(new String[] {"name", 
"summary.config.numCpu", 
"summary.quickStats.overallCpuUsage","summary.quickStats.guestMemoryUsage","resourceConfig.memoryAllocation.limit","config.hardware.memoryMB",
 instanceNameCustomField});
--- End diff --

Can you make them constants and reuse the constants in L4685?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[karuturi]

Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/780#discussion_r38917337
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -4751,7 +4760,7 @@ private VirtualMachineGuestOsIdentifier 
translateGuestOsIdentifier(String cpuArc
 }
 }
 }
-vmResponseMap.put(name, new 
VmStatsEntry(Integer.parseInt(maxCpuUsage), networkReadKBs, networkWriteKBs, 
Integer.parseInt(numberCPUs), "vm"));
+vmResponseMap.put(name, new 
VmStatsEntry(Double.parseDouble(memkb)*1000,Double.parseDouble(guestMemusage)*1000,Double.parseDouble(memlimit)*1000,
 Double.parseDouble(maxCpuUsage), networkReadKBs, networkWriteKBs, 
Integer.parseInt(numberCPUs), "vm"));
--- End diff --

Is there a possibility that one of the values is not returned and hence can 
be null? calling parseDouble on a null value will throw NPE


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[manuiiit]

GitHub user manuiiit opened a pull request:

https://github.com/apache/cloudstack/pull/780

CLOUDSTACK-8800 : Improved the listVirtualMachines API call to include 
memory utilization information for a VM

for xenserver,hyperv and for vmware.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuiiit/cloudstack pull-19

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/780.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #780


commit f973d89602c5386f2f00659ebb49432194f303d6
Author: Maneesha P 
Date:   2015-07-22T19:15:00Z

Fixed Coverity issue "Dereference null return value" by adding a Null Value 
Exception

commit f34530f79a6e3070c03ee92a8312ad1a822aeffa
Author: Maneesha P 
Date:   2015-07-23T12:01:47Z

Fixed Coverity issue "Dereference null return value"

commit 7d595078ba72318b7fed19726e9bf019d4714eef
Author: manuiiit 
Date:   2015-07-28T12:06:48Z

Fixed Coverity issue "Dereference null return value"

commit 380e160e7c79aa5f6886003a92f62560ec940c6b
Author: Maneesha.P 
Date:   2015-08-05T07:14:43Z

Merge remote-tracking branch 'upstream/master'

commit c3b46ede7362d6866950ada8b48961ff6acad1dd
Author: Maneesha.P 
Date:   2015-08-18T07:09:02Z

Merge remote-tracking branch 'upstream/master'

commit 22d4976a5f8e5b7d62f60455f7794befd941a741
Author: Maneesha.P 
Date:   2015-09-07T06:18:31Z

Merge remote-tracking branch 'upstream/master' into HEAD

commit 5e3203d0ca9f00b0c9ef2a3b74c94efaf726af96
Author: Maneesha.P 
Date:   2015-08-25T03:56:55Z

CLOUDSTACK-8800 : Improved the listVirtualMachines API call to include 
memory utilization information for a VM for xenserver

for hyperv

and for vmware




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[manuiiit]

Github user manuiiit closed the pull request at:

https://github.com/apache/cloudstack/pull/774


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[manuiiit]

GitHub user manuiiit opened a pull request:

https://github.com/apache/cloudstack/pull/774

CLOUDSTACK-8800 : Improved the listVirtualMachines API call to include 
memory utilization information for a VM

for xenserver,hyperv and for vmware

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuiiit/cloudstack pull-17

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #774


commit afe9fa5f4dbed4f2b304586a057a4871335344f5
Author: Maneesha.P 
Date:   2015-08-25T03:56:55Z

CLOUDSTACK-8800 : Improved the listVirtualMachines API call to include 
memory utilization information for a VM for xenserver

for hyperv

and for vmware




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---