JDK 9 EA Build 178 & JDK 8u152 b05 are available on jdk.java.net

Hi Benedikt, *JDK 9 Early Access* build 178 is available at : - jdk.java.net/9/ A summary of all the changes in this build are listed here . Changes which were introduced since the last availability email that may be of interest :

Re: [daemon] moving to git ? and bump java version.

Hi Gary, I will take a look at pending issues if something is blocker to release, I see already 9 issues are done for 1.1.0 release . if we are ok with these 9, anyone can release it. BTW how do you guys decide that "this is a time to release!" for any component ? Regards, Amey On Jul 16,

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

Note: it's worth running the following: mvn versions:display-dependency-updates -U and mvn versions:display-plugin-updates -U to check for possible version updates These give: [INFO] The following dependencies in Dependencies have newer versions: [INFO] junit:junit

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

Thanks for pointing those out, sebb. I'll be sure to get all of those committed to master. Hopefully the Mockito jump isn't too much work. :) On Mon, Jul 17, 2017 at 1:48 AM, sebb wrote: > Note: it's worth running the following: > > mvn versions:display-dependency-updates

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

Thanks! Looks like PMD moved the Java rulesets to rulesets/java/*. I'll update that in master and make sure it's ready for the next release. fwiw, fixing that did not raise any new issues or warnings. On Sun, Jul 16, 2017 at 7:08 PM, Gary Gregory wrote: > I noticed it

Re: [daemon] moving to git ? and bump java version.

There is no fixed process to determine when it is releases time. Sometimes a component has momentum and a release manager is picked and leads the way, sometimes a committer needs a release and volunteers to manage a release. Gary On Jul 17, 2017 06:00, "Amey Jadiye" wrote:

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user garydgregory commented on the issue: https://github.com/apache/commons-imaging/pull/27 Yes, you want a fresh PR. Gary On Mon, Jul 17, 2017 at 9:59 AM, TheRealHaui wrote: > As the pull request is already closed shall

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127770520 --- Diff: src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java --- @@ -0,0 +1,41 @@ +package

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 As the pull request is already closed shall I reopen another with the same name? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127768831 --- Diff: src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java --- @@ -66,6 +64,22 @@ protected File

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127770670 --- Diff: src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java --- @@ -0,0 +1,41 @@ +package

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

I've migrated Mockito code before, and the migration is pretty simple depending on how complex your usage is. It could be as simple as changing an import or two. On 17 July 2017 at 10:11, Carl Hall wrote: > Thanks for pointing those out, sebb. I'll be sure to get all of

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127761190 --- Diff: src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java --- @@ -0,0 +1,35 @@ +package

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127768274 --- Diff: src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java --- @@ -0,0 +1,35 @@ +package

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127769590 --- Diff: src/test/java/org/apache/commons/imaging/formats/jpeg/segments/JfifSegmentTest.java --- @@ -0,0 +1,35 @@ +package

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127782716 --- Diff: src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java --- @@ -17,24 +17,22 @@ package

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127781644 --- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java --- @@ -0,0 +1,44 @@ +package org.apache.commons.imaging; +

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127780455 --- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java --- @@ -0,0 +1,44 @@ +package org.apache.commons.imaging; +

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127782811 --- Diff: src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java --- @@ -66,6 +64,22 @@ protected File

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127780127 --- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java --- @@ -0,0 +1,44 @@ +package org.apache.commons.imaging; +

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127782170 --- Diff: src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java --- @@ -0,0 +1,36 @@ +package

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127783301 --- Diff: src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcTypeLookupTest.java --- @@ -0,0 +1,28 @@ +package

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127783226 --- Diff: src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java --- @@ -0,0 +1,35 @@ +package

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 Improvements made in #28. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127778422 --- Diff: src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java --- @@ -66,6 +64,22 @@ protected File

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127775941 --- Diff: src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeByteTest.java --- @@ -0,0 +1,37 @@ +package

[GitHub] commons-imaging pull request #28: Increase code coverage one

GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-imaging/pull/28 Increase code coverage one Added various improvements to selected Unit Tests. You can merge this pull request into a Git repository by running: $ git pull

Re: [daemon] moving to git ? and bump java version.

On Jul 16, 2017 11:49 AM, "Matt Sicker" wrote: C quality somewhat depends on which version of C you're trying to remain compatible with (I'm guessing C89 due to Windows, though I could be wrong). Valgrind and other tracing tools are typically used. Valgrind is a default

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127781676 --- Diff: src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java --- @@ -0,0 +1,36 @@ +package

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127782199 --- Diff: src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java --- @@ -0,0 +1,36 @@ +package

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127781398 --- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java --- @@ -0,0 +1,44 @@ +package org.apache.commons.imaging; +

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127782141 --- Diff: src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java --- @@ -0,0 +1,36 @@ +package

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127782622 --- Diff: src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java --- @@ -17,24 +17,22 @@ package

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127781095 --- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java --- @@ -0,0 +1,44 @@ +package org.apache.commons.imaging; +

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127781035 --- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java --- @@ -0,0 +1,44 @@ +package org.apache.commons.imaging; +

[GitHub] commons-imaging pull request #28: Increase code coverage one

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/28#discussion_r127781871 --- Diff: src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java --- @@ -0,0 +1,36 @@ +package

[GitHub] commons-collections pull request #5: gitignore and CollectionUtils improveme...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #18: COLLECTIONS-586 PatriciaTrie prefixMap...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #9: COLLECTIONS-551

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #15: Allow minus index

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #12: [COLLECTIONS-573] Add CollectionUtils#...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #24: add-some-Unit-Tests Added some Unit Te...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #13: [COLLECTIONS-574] Improve ListUtils#lo...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #3: Added MultiValuedLinkedHashMap to prese...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #21: Add VI[M] temporary files to .gitignor...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #18: COLLECTIONS-586 PatriciaTrie prefixMap...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #13: [COLLECTIONS-574] Improve ListUtils#lo...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #15: Allow minus index

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #9: COLLECTIONS-551

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #10: Add CollectionUtils#containsQuietly me...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #21: Add VI[M] temporary files to .gitignor...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #12: [COLLECTIONS-573] Add CollectionUtils#...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #3: Added MultiValuedLinkedHashMap to prese...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #5: gitignore and CollectionUtils improveme...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #22: [COLLECTIONS-600] Null-safe implementa...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #10: Add CollectionUtils#containsQuietly me...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #24: add-some-Unit-Tests Added some Unit Te...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #19: COLLECTIONS-575: Add synchronized queu...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #22: [COLLECTIONS-600] Null-safe implementa...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-collections pull request #19: COLLECTIONS-575: Add synchronized queu...

Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [daemon] moving to git ? and bump java version.

At thus point I would like to see: - A release - Go through JIRA and fix issues - A release We can update to Java 6 to allow the project to be built by Java 9 at any time, no big deal IMO. Crud, the oldest Java I have installed is Java 6. Hm, I'll push out Java 6 as the req and get that out of

[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-collections/pull/24 What does it mean that the asfgit bot closed my pull request? Was it accepted or rejected? Or even worse - ignored completely? As there is no reaction in this pull request

[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-collections/pull/24 @jvz Thanks for your answer! I really haven't got any glue as I am not so much experienced with the habits here at Github and Open Source development conventions in general!

[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...

Github user jvz commented on the issue: https://github.com/apache/commons-collections/pull/24 It usually means it was merged manually and closed via a commit message, though it could've been an accident. --- If your project is set up for it, you can reply to this email and have your

[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...

Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/24 Actually that's not true today. It's a side effect of my moving collections to git, but I will look at this and try to pull it in tomorrow morning (UTC-4). --- If your project is set

[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-collections/pull/24 Okay ... Now it's getting definitely a little bit wired. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] commons-imaging issue #28: Increase code coverage one

Github user garydgregory commented on the issue: https://github.com/apache/commons-imaging/pull/28 You want a fresh PR, yes, but you still need to base it off of git master, not just continue the previous patch please. --- If your project is set up for it, you can reply to this

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

Let's not get side-tracked here, this is a [VOTE] thread ;-) Gary On Mon, Jul 17, 2017 at 8:46 AM, Matt Sicker wrote: > I've migrated Mockito code before, and the migration is pretty simple > depending on how complex your usage is. It could be as simple as changing > an

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127854991 --- Diff: src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java --- @@ -353,10 +355,11 @@ private void checkBuiltInFormat(final String

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127854299 --- Diff: src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java --- @@ -55,11 +55,11 @@ public void testExtendedFormats() {

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127854120 --- Diff: src/test/java/org/apache/commons/text/AlphabetConverterTest.java --- @@ -201,4 +207,97 @@ private void test(final Character[] originalChars,

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127855372 --- Diff: src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java --- @@ -426,10 +517,13 @@ public void testSetFormatsByArgumentIndex() {

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127856024 --- Diff: src/test/java/org/apache/commons/text/similarity/LevenshteinResultsTest.java --- @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127855540 --- Diff: src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java --- @@ -476,8 +578,8 @@ public Format getFormat(final String name,

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127855137 --- Diff: src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java --- @@ -373,14 +376,15 @@ private void checkBuiltInFormat(final String

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127854930 --- Diff: src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java --- @@ -338,10 +339,11 @@ private void checkBuiltInFormat(final String

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127854888 --- Diff: src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java --- @@ -338,10 +339,11 @@ private void checkBuiltInFormat(final String

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127855769 --- Diff: src/test/java/org/apache/commons/text/StrSubstitutorTest.java --- @@ -17,21 +17,16 @@ package org.apache.commons.text;

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127854963 --- Diff: src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java --- @@ -353,10 +355,11 @@ private void checkBuiltInFormat(final String

[GitHub] commons-text issue #56: add-some-Unit Tests

Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/56 [](https://coveralls.io/builds/12432497) Coverage increased (+1.04%) to 98.34% when pulling

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127854015 --- Diff: src/test/java/org/apache/commons/text/AlphabetConverterTest.java --- @@ -201,4 +207,97 @@ private void test(final Character[] originalChars,

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127854827 --- Diff: src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java --- @@ -295,41 +295,42 @@ public void testEqualsHashcode() {

[GitHub] commons-text pull request #56: add-some-Unit Tests

Github user jbduncan commented on a diff in the pull request: https://github.com/apache/commons-text/pull/56#discussion_r127855604 --- Diff: src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java --- @@ -488,10 +590,10 @@ public Format getFormat(final String name,

[GitHub] commons-text issue #56: add-some-Unit Tests

Github user jbduncan commented on the issue: https://github.com/apache/commons-text/pull/56 Oh sorry @TheRealHaui, I just reread my main comment in my review from a few minutes ago, and I realise that I may have sounded confrontational. I had not meant to come across as such, so I

[GitHub] commons-text pull request #56: add-some-Unit Tests

GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-text/pull/56 add-some-Unit Tests I have created new Unit Tests which cover previously untested lines of code which I want to contribute. You can merge this pull request into a Git repository by

[GitHub] commons-imaging pull request #27: Increase code coverage one

Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/27#discussion_r127843760 --- Diff: src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeByteTest.java --- @@ -0,0 +1,37 @@ +package

Re: [lang] - Remove RandomStringUtils deprecation / move it to [text]?

Thanks, I will raise PR soon, and for this we don't have to wait for 2.x , that's good part. Regards, Amey On Sun, Jul 16, 2017, 3:41 PM Pascal Schumacher wrote: > Hello Amey, > > that seems to be the cleanest solution (although the one requiring the > most work). > >