[GitHub] asfgit closed pull request #3: GEOMETRY-6: Making CartesianXD fields private

asfgit closed pull request #3: GEOMETRY-6: Making CartesianXD fields private URL: https://github.com/apache/commons-geometry/pull/3 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] darkma773r opened a new pull request #2: GEOMETRY-2: Points and Vectors API Updates

darkma773r opened a new pull request #2: GEOMETRY-2: Points and Vectors API Updates URL: https://github.com/apache/commons-geometry/pull/2 The main driver behind these changes was to try to clean up the API as it relates to points and vectors. The interfaces did not allow enough

[GitHub] darkma773r opened a new pull request #3: GEOMETRY-6: Making CartesianXD fields private

darkma773r opened a new pull request #3: GEOMETRY-6: Making CartesianXD fields private URL: https://github.com/apache/commons-geometry/pull/3 Changing protected fields to private. This is an automated message from the Apache

[GitHub] asfgit closed pull request #5: README files

asfgit closed pull request #5: README files URL: https://github.com/apache/commons-geometry/pull/5 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork),

[GitHub] darkma773r opened a new pull request #4: Points/Vectors as VALJOs

darkma773r opened a new pull request #4: Points/Vectors as VALJOs URL: https://github.com/apache/commons-geometry/pull/4 Making all point and vector concrete classes meet the requirements for VALJOs. Also, addressing the comment from GEOMETRY-2 about the placement of the Serializable

[GitHub] darkma773r opened a new pull request #5: README files

darkma773r opened a new pull request #5: README files URL: https://github.com/apache/commons-geometry/pull/5 Adding initial README files (as generated by mvn commons:readme-md). This is an automated message from the Apache

[GitHub] darkma773r commented on issue #4: Points/Vectors as VALJOs

darkma773r commented on issue #4: Points/Vectors as VALJOs URL: https://github.com/apache/commons-geometry/pull/4#issuecomment-406465161 I'm closing this pull request and making a new one that combines changes from GEOMETRY-3 and GEOMETRY-4 so that we can have a clean CheckStyle report

[GitHub] darkma773r opened a new pull request #6: Points/Vectors as VALJOs with Cleanup

darkma773r opened a new pull request #6: Points/Vectors as VALJOs with Cleanup URL: https://github.com/apache/commons-geometry/pull/6 This combines the changes from GEOMETRY-3 (Points/Vectors and VALJOs) and GEOMETRY-4 (Cleanup CheckStyle and SpotBugs Issues).

[GitHub] asfgit closed pull request #7: Polar and Spherical Coordinates

asfgit closed pull request #7: Polar and Spherical Coordinates URL: https://github.com/apache/commons-geometry/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] darkma773r opened a new pull request #7: Polar and Spherical Coordinates

darkma773r opened a new pull request #7: Polar and Spherical Coordinates URL: https://github.com/apache/commons-geometry/pull/7 Adds support for polar and spherical coordinates (GEOMETRY-7). This is an automated message from

[GitHub] darkma773r opened a new pull request #1: GEOMETRY-1: Initial Code Commit

darkma773r opened a new pull request #1: GEOMETRY-1: Initial Code Commit URL: https://github.com/apache/commons-geometry/pull/1 Moving over existing geometry code from commons-math. This is an automated message from the

[GitHub] darkma773r closed pull request #14: GEOMETRY-14: Initial AffineTransform3D class

darkma773r closed pull request #14: GEOMETRY-14: Initial AffineTransform3D class URL: https://github.com/apache/commons-geometry/pull/14 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] darkma773r opened a new pull request #15: GEOMETRY-23: Remove Point?D

darkma773r opened a new pull request #15: GEOMETRY-23: Remove Point?D URL: https://github.com/apache/commons-geometry/pull/15 Removing Euclidean point classes and making Vector?D implement Point. This is an automated message

[GitHub] darkma773r opened a new pull request #14: GEOMETRY-14: Initial AffineTransform3D class

darkma773r opened a new pull request #14: GEOMETRY-14: Initial AffineTransform3D class URL: https://github.com/apache/commons-geometry/pull/14 This is an initial merge request for the work on GEOMETRY-14, primarily to gain feedback on the new transform architecture in 3D space before

[GitHub] darkma773r opened a new pull request #8: Geometry 9

darkma773r opened a new pull request #8: Geometry 9 URL: https://github.com/apache/commons-geometry/pull/8 Additional vector/point methods and some cleanup. This is an automated message from the Apache Git Service. To respond

[GitHub] darkma773r opened a new pull request #12: Geometry 19

darkma773r opened a new pull request #12: Geometry 19 URL: https://github.com/apache/commons-geometry/pull/12 Build updates to support JDK 10. This is an automated message from the Apache Git Service. To respond to the

[GitHub] darkma773r commented on issue #12: Geometry 19

darkma773r commented on issue #12: Geometry 19 URL: https://github.com/apache/commons-geometry/pull/12#issuecomment-423707558 Closing this pr based on the discussion here: https://issues.apache.org/jira/projects/GEOMETRY/issues/GEOMETRY-19. In short, the issue is not with commons-geometry

[GitHub] darkma773r closed pull request #12: Geometry 19

darkma773r closed pull request #12: Geometry 19 URL: https://github.com/apache/commons-geometry/pull/12 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] asfgit closed pull request #11: Geometry 17

asfgit closed pull request #11: Geometry 17 URL: https://github.com/apache/commons-geometry/pull/11 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork),

[GitHub] darkma773r opened a new pull request #13: GEOMETRY-20

darkma773r opened a new pull request #13: GEOMETRY-20 URL: https://github.com/apache/commons-geometry/pull/13 Removing getNorm1(), getNormInf(), distance1(), and distanceInf() Vector methods to simplify and streamline API

[GitHub] asfgit closed pull request #13: GEOMETRY-20

asfgit closed pull request #13: GEOMETRY-20 URL: https://github.com/apache/commons-geometry/pull/13 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork),

[GitHub] emopers opened a new pull request #28: Close ObjectOutputStream before calling toByteArray on underlying ByteArrayOutputStream

emopers opened a new pull request #28: Close ObjectOutputStream before calling toByteArray on underlying ByteArrayOutputStream URL: https://github.com/apache/commons-dbcp/pull/28 When an `ObjectOutputStream` instance wraps an underlying `ByteArrayOutputStream` instance, it is

[GitHub] paroxayte opened a new pull request #28: add support priority based iteration over options supplied to CommandLine

paroxayte opened a new pull request #28: add support priority based iteration over options supplied to CommandLine URL: https://github.com/apache/commons-cli/pull/28 CommandLine stores the options parsed as ArrayList. I changed this to what is essentially an iterable priority queue. I

[GitHub] kinow opened a new pull request #65: Fix simple Checkstyle and PMD issues introduced in 4.3

kinow opened a new pull request #65: Fix simple Checkstyle and PMD issues introduced in 4.3 URL: https://github.com/apache/commons-collections/pull/65 Fixes new issues found while voting on 4.3 RC2. Re-created site locally to confirm that the issues are gone. All tests passing OK.

[GitHub] saschaszott commented on issue #100: TEXT-104: Jaro Winkler Distance refers to similarity

saschaszott commented on issue #100: TEXT-104: Jaro Winkler Distance refers to similarity URL: https://github.com/apache/commons-text/pull/100#issuecomment-450560249 Travis is complaining about two changes breaking downward compatibility: * field `INDEX_NOT_FOUND` was removed (this

[GitHub] ajs6f opened a new pull request #53: COMMONSRDF-80: Bumping Jena version 3.5.0 => 3.9.0

ajs6f opened a new pull request #53: COMMONSRDF-80: Bumping Jena version 3.5.0 => 3.9.0 URL: https://github.com/apache/commons-rdf/pull/53 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ajs6f edited a comment on issue #53: COMMONSRDF-80: Bumping Jena version 3.5.0 => 3.9.0

ajs6f edited a comment on issue #53: COMMONSRDF-80: Bumping Jena version 3.5.0 => 3.9.0 URL: https://github.com/apache/commons-rdf/pull/53#issuecomment-450557976 As another Jena committer, I'd be happier with that too. Thoughts? @stain? @wikier? Others?

[GitHub] ajs6f commented on issue #53: COMMONSRDF-80: Bumping Jena version 3.5.0 => 3.9.0

ajs6f commented on issue #53: COMMONSRDF-80: Bumping Jena version 3.5.0 => 3.9.0 URL: https://github.com/apache/commons-rdf/pull/53#issuecomment-450557976 As another Jena committer, I'd be happier with that too. Thoughts? @stain ? @wikier? Others?

[GitHub] saschaszott opened a new pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity

saschaszott opened a new pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity URL: https://github.com/apache/commons-text/pull/100 Provide class `JaroWinklerSimilarity` to compute JW similarity (reuses protected methods of `JaroWinklerDistance`). Changed the

[GitHub] acoburn commented on issue #53: COMMONSRDF-80: Bumping Jena version 3.5.0 => 3.9.0

acoburn commented on issue #53: COMMONSRDF-80: Bumping Jena version 3.5.0 => 3.9.0 URL: https://github.com/apache/commons-rdf/pull/53#issuecomment-450525975 The jena dependency is currently tied to the `jena-osgi` artifact. I think it would be much better to set the dependency to

[GitHub] kinow opened a new pull request #40: IMAGING-220: replace while by if in the JPEG decoder extend method

kinow opened a new pull request #40: IMAGING-220: replace while by if in the JPEG decoder extend method URL: https://github.com/apache/commons-imaging/pull/40 Looking at the specification and other implementations (see JIRA ticket for links), it appears to me that the `while` in the

[GitHub] kinow opened a new pull request #39: IMAGING-219: prevent infinite loop when decompressing RGBE input file

kinow opened a new pull request #39: IMAGING-219: prevent infinite loop when decompressing RGBE input file URL: https://github.com/apache/commons-imaging/pull/39 The `decompress` method has an input stream. It compares if the value returned by `.read()` is greater than 128, otherwise

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244820498 ## File path: src/main/native/org/apache/commons/crypto/cipher/OpenSslNative.c

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244816990 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817494 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817423 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244820275 ## File path: src/main/native/org/apache/commons/crypto/cipher/OpenSslNative.c

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817987 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244812522 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817336 ## File path: src/main/java/org/apache/commons/crypto/jna/OpenSslJna.java

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244812584 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817093 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244818314 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817688 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244810727 ## File path: src/main/java/org/apache/commons/crypto/OpenSslInfoNative.java

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244812689 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817779 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244819457 ## File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244812371 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244818064 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244810868 ## File path: src/main/java/org/apache/commons/crypto/OpenSslInfoNative.java

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244810433 ## File path: Makefile.common ## @@ -179,11 +179,11 @@

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244810053 ## File path: .gitignore ## @@ -1,37 +0,0 @@ -*~ Review comment:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244810551 ## File path: pom.xml ## @@ -1,33 +1,29 @@ -

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244819798 ## File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244818921 ## File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244819839 ## File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244811499 ## File path:

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817116 ## File path:

[GitHub] PascalSchumacher opened a new pull request #101: Java 13

PascalSchumacher opened a new pull request #101: Java 13 URL: https://github.com/apache/commons-text/pull/101 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] coveralls commented on issue #101: Java 13

coveralls commented on issue #101: Java 13 URL: https://github.com/apache/commons-text/pull/101#issuecomment-451686264 [](https://coveralls.io/builds/20921744) Coverage remained the same at 97.878% when pulling

[GitHub] coveralls edited a comment on issue #101: Java 13

coveralls edited a comment on issue #101: Java 13 URL: https://github.com/apache/commons-text/pull/101#issuecomment-451686264 [](https://coveralls.io/builds/2097) Coverage remained the same at 97.878% when pulling

[GitHub] PascalSchumacher commented on issue #101: Java 13

PascalSchumacher commented on issue #101: Java 13 URL: https://github.com/apache/commons-text/pull/101#issuecomment-451686639 For some reason skipping JaCoCo on java 13 does not seem to work and this causes the build to fail.

[GitHub] coveralls edited a comment on issue #101: Java 13

coveralls edited a comment on issue #101: Java 13 URL: https://github.com/apache/commons-text/pull/101#issuecomment-451686264 [](https://coveralls.io/builds/20922317) Coverage remained the same at 97.878% when pulling

[GitHub] coveralls edited a comment on issue #101: Java 13

coveralls edited a comment on issue #101: Java 13 URL: https://github.com/apache/commons-text/pull/101#issuecomment-451686264 [](https://coveralls.io/builds/20921816) Coverage remained the same at 97.878% when pulling

[GitHub] coveralls edited a comment on issue #101: Java 13

coveralls edited a comment on issue #101: Java 13 URL: https://github.com/apache/commons-text/pull/101#issuecomment-451686264 [](https://coveralls.io/builds/20922266) Coverage remained the same at 97.878% when pulling

[GitHub] asfgit closed pull request #101: Java 13

asfgit closed pull request #101: Java 13 URL: https://github.com/apache/commons-text/pull/101 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the

[GitHub] chtompki commented on issue #29: DBCP-534 Allow for manual connection eviction

chtompki commented on issue #29: DBCP-534 Allow for manual connection eviction URL: https://github.com/apache/commons-dbcp/pull/29#issuecomment-454748606 No worries :-) This is an automated message from the Apache Git

[GitHub] CasualSuperman commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul…

CasualSuperman commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul… URL: https://github.com/apache/commons-collections/pull/54#issuecomment-455831752 Looks like it's set up to skip in

[GitHub] CasualSuperman commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul…

CasualSuperman commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul… URL: https://github.com/apache/commons-collections/pull/54#issuecomment-455834018 > Yeah I did that. If the artifact is a pom only module, japicmp kinda blows up and falls over.

[GitHub] chtompki commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul…

chtompki commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul… URL: https://github.com/apache/commons-collections/pull/54#issuecomment-455833842 Yeah I did that. If the artifact is a pom only module, japicmp kinda blows up and falls over. So we

[GitHub] chtompki commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul…

chtompki commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul… URL: https://github.com/apache/commons-collections/pull/54#issuecomment-455833862 @britter - try japicmp version 0.13

[GitHub] kinow merged pull request #65: Fix simple Checkstyle and PMD issues introduced in 4.3

kinow merged pull request #65: Fix simple Checkstyle and PMD issues introduced in 4.3 URL: https://github.com/apache/commons-collections/pull/65 This is an automated message from the Apache Git Service. To respond to the

[GitHub] chtompki commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul…

chtompki commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul… URL: https://github.com/apache/commons-collections/pull/54#issuecomment-455834253 CuriousI've not seen that before. Will likely try it.

[GitHub] CasualSuperman closed pull request #66: COLLECTIONS-709 Set Entry count to 0 after remove

CasualSuperman closed pull request #66: COLLECTIONS-709 Set Entry count to 0 after remove URL: https://github.com/apache/commons-collections/pull/66 This is an automated message from the Apache Git Service. To respond to

[GitHub] chtompki merged pull request #29: DBCP-534 Allow for manual connection eviction

chtompki merged pull request #29: DBCP-534 Allow for manual connection eviction URL: https://github.com/apache/commons-dbcp/pull/29 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@commons.apache.org

[GitHub] garydgregory commented on issue #29: DBCP-534 Allow for manual connection eviction

garydgregory commented on issue #29: DBCP-534 Allow for manual connection eviction URL: https://github.com/apache/commons-dbcp/pull/29#issuecomment-454558160 Thank you all :-) This is an automated message from the Apache Git

[GitHub] CasualSuperman opened a new pull request #66: COLLECTIONS-709 Set Entry count to 0 after remove

CasualSuperman opened a new pull request #66: COLLECTIONS-709 Set Entry count to 0 after remove URL: https://github.com/apache/commons-collections/pull/66 After removing the last element of a MultiSet, the Entry doesn't have a count of 0. This makes the count accurate after removing the

[GitHub] grimreaper commented on issue #66: COLLECTIONS-709 Set Entry count to 0 after remove

grimreaper commented on issue #66: COLLECTIONS-709 Set Entry count to 0 after remove URL: https://github.com/apache/commons-collections/pull/66#issuecomment-455824429 This seems reasonable to me. This is an automated

[GitHub] coveralls commented on issue #91: run time support is added for openssl 1.0 and 1.1 for UNIX

coveralls commented on issue #91: run time support is added for openssl 1.0 and 1.1 for UNIX URL: https://github.com/apache/commons-crypto/pull/91#issuecomment-448120136 [](https://coveralls.io/builds/20689145)

[GitHub] coveralls edited a comment on issue #91: run time support is added for openssl 1.0 and 1.1 for UNIX

coveralls edited a comment on issue #91: run time support is added for openssl 1.0 and 1.1 for UNIX URL: https://github.com/apache/commons-crypto/pull/91#issuecomment-448120136 [](https://coveralls.io/builds/20689468)

[GitHub] ossdev07 opened a new pull request #91: run time support is added for openssl 1.0 and 1.1 for UNIX

ossdev07 opened a new pull request #91: run time support is added for openssl 1.0 and 1.1 for UNIX URL: https://github.com/apache/commons-crypto/pull/91 This patch will check for both libcrypto library in system and will create libcommons-crypto.so using those. In this patch absolute name

[GitHub] asfgit closed pull request #99: Spotbugs java 12

asfgit closed pull request #99: Spotbugs java 12 URL: https://github.com/apache/commons-text/pull/99 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] PascalSchumacher opened a new pull request #98: Enable jacoco on java 11+

PascalSchumacher opened a new pull request #98: Enable jacoco on java 11+ URL: https://github.com/apache/commons-text/pull/98 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] asfgit closed pull request #98: Enable jacoco on java 11+

asfgit closed pull request #98: Enable jacoco on java 11+ URL: https://github.com/apache/commons-text/pull/98 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] coveralls commented on issue #98: Enable jacoco on java 11+

coveralls commented on issue #98: Enable jacoco on java 11+ URL: https://github.com/apache/commons-text/pull/98#issuecomment-449002179 [](https://coveralls.io/builds/20739101) Coverage remained the same at 97.878%

[GitHub] PascalSchumacher opened a new pull request #99: Spotbugs java 12

PascalSchumacher opened a new pull request #99: Spotbugs java 12 URL: https://github.com/apache/commons-text/pull/99 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] coveralls commented on issue #99: Spotbugs java 12

coveralls commented on issue #99: Spotbugs java 12 URL: https://github.com/apache/commons-text/pull/99#issuecomment-449017556 [](https://coveralls.io/builds/20740061) Coverage remained the same at 97.878% when pulling

[GitHub] darkma773r opened a new pull request #17: Minor Cleanup

darkma773r opened a new pull request #17: Minor Cleanup URL: https://github.com/apache/commons-geometry/pull/17 - Removing unused internal methods - Using better test names - Adding javadocs This is an automated message

[GitHub] mina86 commented on issue #35: Turn CSVRecord into a List

mina86 commented on issue #35: Turn CSVRecord into a List URL: https://github.com/apache/commons-csv/pull/35#issuecomment-449403846 FYI, you can do `StreamSupport.stream(record.splitterator(), false)` to convert CSVRecord into a stream though it’s less efficient in some cases (since the

[GitHub] darkma773r closed pull request #17: Minor Cleanup

darkma773r closed pull request #17: Minor Cleanup URL: https://github.com/apache/commons-geometry/pull/17 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] darkma773r commented on issue #17: Minor Cleanup

darkma773r commented on issue #17: Minor Cleanup URL: https://github.com/apache/commons-geometry/pull/17#issuecomment-449592466 I'm closing this. The changes here will be part of another PR that has a JIRA issue associated with it. This one does not.

[GitHub] darkma773r opened a new pull request #18: Geometry 31: Standardize Method Names

darkma773r opened a new pull request #18: Geometry 31: Standardize Method Names URL: https://github.com/apache/commons-geometry/pull/18 Standardizing method names with commons-numbers and shortening names where possible. This also includes some minor cleanup.

[GitHub] jvz opened a new pull request #72: [IO-596] Add DeleteFiles utility class

jvz opened a new pull request #72: [IO-596] Add DeleteFiles utility class URL: https://github.com/apache/commons-io/pull/72 This class provides configurable strategies to delete files and directories. Signed-off-by: Matt Sicker @reviewbybees @garydgregory @jeffret-b

[GitHub] jvz commented on issue #72: [IO-596] Add DeleteFiles utility class

jvz commented on issue #72: [IO-596] Add DeleteFiles utility class URL: https://github.com/apache/commons-io/pull/72#issuecomment-450040762 Note that the build is failing as there is currently an existing unit test that tests a non-existent method.

[GitHub] asciborek commented on a change in pull request #72: [IO-596] Add DeleteFiles utility class

asciborek commented on a change in pull request #72: [IO-596] Add DeleteFiles utility class URL: https://github.com/apache/commons-io/pull/72#discussion_r244072727 ## File path: src/main/java/org/apache/commons/io/DeleteFiles.java ## @@ -0,0 +1,339 @@ +/* + * Licensed to

[GitHub] jvz commented on a change in pull request #72: [IO-596] Add DeleteFiles utility class

jvz commented on a change in pull request #72: [IO-596] Add DeleteFiles utility class URL: https://github.com/apache/commons-io/pull/72#discussion_r244167531 ## File path: src/main/java/org/apache/commons/io/DeleteFiles.java ## @@ -0,0 +1,339 @@ +/* + * Licensed to the

[GitHub] darkma773r opened a new pull request #16: GEOMETRY-14: Adding Transform Classes

darkma773r opened a new pull request #16: GEOMETRY-14: Adding Transform Classes URL: https://github.com/apache/commons-geometry/pull/16 Adding AffineTransformMatrix?D, QuaternionRotation, and AxisAngleSequence classes. Removing previous Rotation class.

[GitHub] aremily commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2

aremily commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-449669500 The CI build is on Ubuntu 14.04 with OpenSSL 1.0.1. I had to loosen the version checking to support the 1.0.1

[GitHub] coveralls commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

coveralls commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-449676652 [![Coverage

  1   2   3   4   >