Re: [csv] Can CSV-42 be closed?
Le 05/08/2013 23:59, Gary Gregory a écrit : Do we want to do anything about this for 1.0? 1.x? Ever? I'm fine with the IOException, I suggest closing this issue. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [csv] Can CSV-42 be closed?
2013/8/6 Emmanuel Bourg ebo...@apache.org Le 05/08/2013 23:59, Gary Gregory a écrit : Do we want to do anything about this for 1.0? 1.x? Ever? I'm fine with the IOException, I suggest closing this issue. Agreed, but please make sure that Bob Smith is added to the contributors section of pom.xml (don't know if he is already listed there) Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
Re: [csv] Can CSV-42 be closed?
On Tue, Aug 6, 2013 at 6:16 AM, Benedikt Ritter brit...@apache.org wrote: 2013/8/6 Emmanuel Bourg ebo...@apache.org Le 05/08/2013 23:59, Gary Gregory a écrit : Do we want to do anything about this for 1.0? 1.x? Ever? I'm fine with the IOException, I suggest closing this issue. Agreed, but please make sure that Bob Smith is added to the contributors section of pom.xml (don't know if he is already listed there) Done. JIRA resolved. Thread closed. Gary Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Editionhttp://www.manning.com/bauer3/ JUnit in Action, Second Edition http://www.manning.com/tahchiev/ Spring Batch in Action http://www.manning.com/templier/ Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
Re: [csv] Can CSV-42 be closed?
On 5 August 2013 22:59, Gary Gregory garydgreg...@gmail.com wrote: WRT https://issues.apache.org/jira/browse/CSV-42 There is one remaining issue it seems: Added an ignoreEncapsulationTrailingCharacters field. This is used to either ignore or append characters that are after an encapsulated value. Previously an IOException was being thrown here, which I don't think is ever a good idea. Do we want to do anything about this for 1.0? 1.x? Ever? If characters appear between the encapsulated value and the next delimiter, the input is clearly broken, and this needs to be signalled somehow. Does not have to be IOE, but the default should be to inform the user. It might perhaps be worth adding an option to provide alternative behaviour, but I think it will need to be more than just a boolean, as there are at least 3 options: - exception - ignore - append to parsed value But I don't think this is needed for 1.0. To close the main issue, I suggest creating a new one just for this. But it should be postponed for now. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Editionhttp://www.manning.com/bauer3/ JUnit in Action, Second Edition http://www.manning.com/tahchiev/ Spring Batch in Action http://www.manning.com/templier/ Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [csv] Can CSV-42 be closed?
Procedural question: Isn't the issue itself the proper place for this discussion? On Mon, Aug 5, 2013 at 11:59 PM, Gary Gregory garydgreg...@gmail.comwrote: WRT https://issues.apache.org/jira/browse/CSV-42 There is one remaining issue it seems: Added an ignoreEncapsulationTrailingCharacters field. This is used to either ignore or append characters that are after an encapsulated value. Previously an IOException was being thrown here, which I don't think is ever a good idea. Do we want to do anything about this for 1.0? 1.x? Ever? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition http://www.manning.com/bauer3/ JUnit in Action, Second Edition http://www.manning.com/tahchiev/ Spring Batch in Action http://www.manning.com/templier/ Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- That's what prayers are ... it's frightened people trying to make friends with the bully! Terry Pratchett. The Last Hero
Re: [csv] Can CSV-42 be closed?
On 5 August 2013 23:35, Jochen Wiedmann jochen.wiedm...@gmail.com wrote: Procedural question: Isn't the issue itself the proper place for this discussion? I would say that the issue is usually the best place for comments about technical matters to do with the issue. The dev mailing list is usually better for strategy discussions, but any relevant conclusions should be copied to the issue. But there will [almost] always be exceptions to both... On Mon, Aug 5, 2013 at 11:59 PM, Gary Gregory garydgreg...@gmail.comwrote: WRT https://issues.apache.org/jira/browse/CSV-42 There is one remaining issue it seems: Added an ignoreEncapsulationTrailingCharacters field. This is used to either ignore or append characters that are after an encapsulated value. Previously an IOException was being thrown here, which I don't think is ever a good idea. Do we want to do anything about this for 1.0? 1.x? Ever? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition http://www.manning.com/bauer3/ JUnit in Action, Second Edition http://www.manning.com/tahchiev/ Spring Batch in Action http://www.manning.com/templier/ Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- That's what prayers are ... it's frightened people trying to make friends with the bully! Terry Pratchett. The Last Hero - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
