[GitHub] cordova-lib pull request: CB-8053: Including a project reference i...

2014-11-20 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/121 CB-8053: Including a project reference in a plugin fails on Windows plat... When working with the Windows platform, the existing logic to add a project reference was expecting two things

[GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-02-10 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/164 CB-8123 Plugin references can target specific windows platforms. Adds support for `target`, `versions` and `arch` attributes on `lib-file` and `framework` elements in the windows platform

[GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-02-11 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/164#issuecomment-73999167 Thanks Jesse! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-02-17 Thread TimBarham
Github user TimBarham closed the pull request at: https://github.com/apache/cordova-lib/pull/164 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-01-28 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/155 CB-8123 Plugin references can target specific windows platforms. Adds support for `target`, `versions` and `arch` attributes on `lib-file` and `framework` elements in the windows platform

[GitHub] cordova-docs pull request: CB-8123 Plugin references can target sp...

2015-01-28 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-docs/pull/263 CB-8123 Plugin references can target specific windows platforms. Adds documentation for the new `target`, `versions` and `arch` attributes on `lib-file` and `framework` elements

[GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-02-10 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/155#issuecomment-73799000 I'll close this PR, and open a new, cleaned up PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-lib pull request: CB-8472 Can't find config.xml error inst...

2015-02-15 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/167 CB-8472 Can't find config.xml error installing platform after plugin. Recent changes to the process of adding a platform meant we were trying to trying to install plugins for the platform

[GitHub] cordova-docs pull request: CB-8123 Plugin references can target sp...

2015-02-15 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-docs/pull/263#issuecomment-74453943 The code changes that this PR documents have been merged. Could someone merge these doc changes? Thanks! --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request: CB-8472 Can't find config.xml error inst...

2015-02-15 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/167#issuecomment-74453817 @agrieve could you take a look at this? It impacts on refactoring work you've recently done here. --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-02-10 Thread TimBarham
Github user TimBarham closed the pull request at: https://github.com/apache/cordova-lib/pull/155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-docs pull request: CB-8123 Plugin references can target sp...

2015-02-15 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-docs/pull/263#issuecomment-74470571 Thanks Sergey! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...

2015-03-18 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/187#issuecomment-83217204 Jesse - we couldn't use `target` for `config-file`, because there was already a `target` attribute that had a different meaning. So it was decided to go

[GitHub] cordova-lib pull request: CB-8670 Error when set engine name to c...

2015-03-13 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/185 CB-8670 Error when set engine name to cordova-windows in plugin.xml If you create an `engine` element with `name=cordova-windows` (rather than `cordova-windows8`) in `plugin.xml`, like

[GitHub] cordova-lib pull request: CB-8737 Available platforms list include...

2015-03-24 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/190 CB-8737 Available platforms list includes extraneous values. Using the latest sources, if you list available platforms the output includes two extraneous values (`getPlatformProject

[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...

2015-03-24 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-85797578 Grrr... I merged instead of rebasing. Are we ok with that? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: CB-8596 Expose APIs to retrieve platform...

2015-03-24 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/191 CB-8596 Expose APIs to retrieve platforms and plugins from config.xml Provides third parties access to platform and plugin information stored in `config.xml` without having to go through

[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...

2015-03-24 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-85841367 Ok, I've cleaned it up. It's ready to merge now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-lib pull request: CB-8737 Available platforms list include...

2015-03-25 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/190#discussion_r27118067 --- Diff: cordova-lib/src/platforms/platforms.js --- @@ -102,5 +102,10 @@ function getPlatformProject(platform, platformRootDir

[GitHub] cordova-lib pull request: CB-8737 Available platforms list include...

2015-03-25 Thread TimBarham
Github user TimBarham closed the pull request at: https://github.com/apache/cordova-lib/pull/190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-coho pull request: CB-8760 Issues with 'platform list'.

2015-03-27 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-coho/pull/67 CB-8760 Issues with 'platform list'. Added support for updating `windows` and `browser` platform versions. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-browser pull request: CB-8760 'platform list' shows wrong ...

2015-03-27 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-browser/pull/11 CB-8760 'platform list' shows wrong version for browser platform. Updated version file for `browser` platform (note that this relies on a change in `coho` to keep it in sync). You can

[GitHub] cordova-windows pull request: CB-8760 'platform list' doesn't show...

2015-03-27 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-windows/pull/64 CB-8760 'platform list' doesn't show version for windows platform. Added version file for `windows` platform (note that this relies on a change in `coho` to keep it in sync). You can

[GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...

2015-03-27 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/194 CB-8754 Auto-restoring a plugin fails when adding a platform. Start with a blank Cordova app, then enter the following: cordova plugin add org.apache.cordova.camera --save

[GitHub] cordova-lib pull request: CB-8756 Make 'plugin --save' work more l...

2015-03-27 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/195 CB-8756 Make 'plugin --save' work more like 'npm install' 1. `plugin add --save` now always saves version (in the form `^x.y.z`) 2. `plugin add --save` now always overwrites an existing

[GitHub] cordova-lib pull request: CB-8756 Make 'plugin --save' work more l...

2015-03-27 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/195#issuecomment-86949466 Sorry, this PR points to the wrong JIRA issue (a bug I closed as a dup of the one this PR should point to). Will close and open a new PR. --- If your project

[GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...

2015-03-27 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/194#discussion_r27298469 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -223,11 +211,13 @@ module.exports = { * @param {Boolean} determines if we are using

[GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...

2015-03-27 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/194#discussion_r27299568 --- Diff: cordova-lib/src/util/npm-helper.js --- @@ -0,0 +1,76 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-lib pull request: CB-8756 Make 'plugin --save' work more l...

2015-03-27 Thread TimBarham
Github user TimBarham closed the pull request at: https://github.com/apache/cordova-lib/pull/195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib pull request: CB-8741 Make plugin --save work more lik...

2015-03-27 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/198 CB-8741 Make plugin --save work more like npm install. 1. `plugin add --save` now always saves version (in the form `^x.y.z`) 2. `plugin add --save` now always overwrites an existing

[GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...

2015-03-27 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/194#issuecomment-86962408 Thanks Andrew. Changes made! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...

2015-03-03 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/175#discussion_r25737174 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -236,15 +231,22 @@ function initSettings() { module.exports.settings

[GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...

2015-03-03 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/175#discussion_r25746864 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -218,10 +205,18 @@ module.exports = { /** * @method initSettings

[GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...

2015-03-03 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/175#discussion_r25672017 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -236,15 +231,22 @@ function initSettings() { module.exports.settings

[GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...

2015-03-03 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/175#discussion_r25672404 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_

[GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...

2015-03-03 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/175#discussion_r25671898 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -218,10 +205,18 @@ module.exports = { /** * @method initSettings

[GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...

2015-03-03 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/175#discussion_r25672462 --- Diff: cordova-lib/src/plugman/uninstall.js --- @@ -47,7 +47,7 @@ function uninstall(platform, project_dir, id, plugins_dir, options

[GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-01-29 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/155#issuecomment-72114968 The tests use path.join(), but jsproj uses hard-coded backslashes (which is reasonable, because normally it would only run on Windows). This problem is showing up

[GitHub] cordova-lib pull request: CB-8784 Prepare with no platforms should...

2015-04-01 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/200 CB-8784 Prepare with no platforms should restore all platforms. If `prepare` is called with no platforms specified, we prepare all installed platforms but don't restore any from `config.xml

[GitHub] cordova-lib pull request: Save/Restore for plugins and platforms

2015-04-13 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/166#issuecomment-92610783 I believe the decision was made not to implement `restore`, since it happens automatically on `prepare`. --- If your project is set up for it, you can reply

[GitHub] cordova-js pull request: check the window.cordova object a little ...

2015-05-04 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-js/pull/109#issuecomment-98912776 :thumbsup: I can verify this fixes the Ripple break. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-browser pull request: CB-8760 'platform list' shows wrong ...

2015-04-06 Thread TimBarham
Github user TimBarham closed the pull request at: https://github.com/apache/cordova-browser/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-browser pull request: CB-8760 'platform list' shows wrong ...

2015-04-06 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-browser/pull/11#issuecomment-90262726 Thanks Jesse. I'll close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-8784 Prepare with no platforms should...

2015-04-05 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/200#issuecomment-89910673 Thanks Jesse. I had followed that previous conversation. My thinking here was that we decided to auto-restore on prepare. The gist seemed to be that we would auto

[GitHub] cordova-lib pull request: CB-8799 Save plugin/platform src and ver...

2015-04-06 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/202 CB-8799 Save plugin/platform src and version to 'spec' attribute. When `--save` option is used, plugin and platform source location or version value is saved to `spec` attribute

[GitHub] cordova-windows pull request: CB-8760 'platform list' doesn't show...

2015-04-06 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-windows/pull/64#issuecomment-90088078 Hi - could someone take a look at this? A related change ([PR67](https://github.com/apache/cordova-coho/pull/67)) was merged, but this should really go in also

[GitHub] cordova-browser pull request: CB-8760 'platform list' shows wrong ...

2015-04-06 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-browser/pull/11#issuecomment-90088049 Hi - could someone take a look at this? A related change ([PR67](https://github.com/apache/cordova-coho/pull/67)) was merged, but this should really go in also

[GitHub] cordova-lib pull request: CB-8807 Platform Add fails to add plugin...

2015-04-08 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/205 CB-8807 Platform Add fails to add plugins with variables. When a plugin that uses variables is automatically installed for a new platform, it fails with the following exception

[GitHub] cordova-lib pull request: CB-9051 Plugins don't get re-added if pl...

2015-05-20 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/223 CB-9051 Plugins don't get re-added if platforms folder deleted. To avoid attempting to add a plugin twice while adding a platform (a scenario that can occur now with automatic restore

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-05 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-109377681 It's certainly a common JavaScript recommendation to always use strict equality / inequality operators so you don't accidentally get an invalid match because

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-05 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-109383817 Heh - I tried turning on the JSHint rule in `cordova-lib` just for kicks. 150 hits :). --- If your project is set up for it, you can reply to this email

[GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve module.

2015-06-05 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/238 CB-9127 Implements cordova-serve module. This takes code and functionality from `cordova-browser` and `cordova-lib` (`cordova serve` command) and combines it in a single module. There's

[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...

2015-06-05 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/215#discussion_r31854039 --- Diff: doc/build.txt --- @@ -18,6 +19,9 @@ all/the specified platforms. --emulator . Deploy to an emulator

[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...

2015-06-05 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-cli/pull/215#issuecomment-109445919 :+1: apart from the one small thing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...

2015-06-05 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/215#discussion_r31853375 --- Diff: doc/build.txt --- @@ -18,6 +19,9 @@ all/the specified platforms. --emulator . Deploy to an emulator

[GitHub] cordova-lib pull request: CB-8627: Only update fetch.json when plu...

2015-06-05 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/228#issuecomment-109485385 As I general design point, I don't like the idea of breaking the `save_fetch_metadata()` call out so it needs to be called separately, for two reasons

[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...

2015-06-02 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108135207 Hey @stevengill ... could you take a look at this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: Fix four failing tests on Windows.

2015-06-02 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/233#issuecomment-108146017 Bummer... AppVeyor is still broken (which I pretty much expected since its failure is different from what I was seeing - but it would have been nice :smile

[GitHub] cordova-lib pull request: Fix four failing tests on Windows.

2015-06-02 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/233 Fix four failing tests on Windows. Two tests fail on Windows in a non-admin command window because they rely on creating symlinks. Since creating the symlinks isn't the purpose of the test

[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...

2015-06-02 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/232 CB-9108 Handle version ranges when add platform with --usegit. Adding a platform using a version range didn't work with `--usegit`, since it would try to use that version range as a git tag

[GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve module.

2015-06-09 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/238#discussion_r32035480 --- Diff: cordova-serve/src/server.js --- @@ -0,0 +1,137 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve module.

2015-06-09 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/238#discussion_r32038525 --- Diff: cordova-serve/src/browser.js --- @@ -0,0 +1,100 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve module.

2015-06-09 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/238#discussion_r32038377 --- Diff: cordova-serve/src/server.js --- @@ -0,0 +1,137 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve module.

2015-06-09 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/238#discussion_r32032171 --- Diff: cordova-serve/src/server.js --- @@ -0,0 +1,137 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve module.

2015-06-09 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/238#discussion_r32036336 --- Diff: cordova-serve/src/platform.js --- @@ -0,0 +1,55 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve module.

2015-06-09 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/238#discussion_r32033238 --- Diff: cordova-serve/src/server.js --- @@ -0,0 +1,137 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve module.

2015-06-09 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/238#discussion_r32032235 --- Diff: cordova-serve/src/server.js --- @@ -0,0 +1,137 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve module.

2015-06-09 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/238#discussion_r32032618 --- Diff: cordova-serve/src/server.js --- @@ -0,0 +1,137 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve module.

2015-06-09 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/238#discussion_r32036239 --- Diff: cordova-serve/src/platform.js --- @@ -0,0 +1,55 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9147 Adding a platform via caret vers...

2015-06-10 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/244#discussion_r32095091 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -364,6 +364,26 @@ function fetchPlugin(plugin, client, useNpmRegistry

[GitHub] cordova-lib pull request: CB-9147 Adding a platform via caret vers...

2015-06-10 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/244#discussion_r32095108 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -364,6 +364,26 @@ function fetchPlugin(plugin, client, useNpmRegistry

[GitHub] cordova-lib pull request: Adds license headers to files in templat...

2015-06-09 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/243 Adds license headers to files in templates folder. Also, updates code that uses the template files when building plugins to strip the license so its not included in users' projects (note we

[GitHub] cordova-lib pull request: CB-9147 Adding a platform via caret vers...

2015-06-10 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/244#discussion_r32094913 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -360,6 +360,12 @@ function getPluginVariables(variables){ function

[GitHub] cordova-lib pull request: CB-9147 Adding a platform via caret vers...

2015-06-10 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/244#discussion_r32094927 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -360,6 +360,12 @@ function getPluginVariables(variables){ function

[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...

2015-06-03 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108567398 Sounds good regarding the discuss thread, @omefire and @stevengill. In the mean time, I've pushed this so we can proceed with the tools release. --- If your

[GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve module.

2015-06-09 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/238#discussion_r32059774 --- Diff: cordova-serve/src/server.js --- @@ -0,0 +1,137 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9147 Adding a platform via caret vers...

2015-06-09 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/244#discussion_r32076025 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -364,6 +364,28 @@ function fetchPlugin(plugin, client, useNpmRegistry

[GitHub] cordova-lib pull request: CB-9147 Adding a platform via caret vers...

2015-06-09 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/244 CB-9147 Adding a platform via caret version adds wrong version It adds the very latest version rather than the latest matching version. Internally we are using a version of `npm

[GitHub] cordova-lib pull request: CB-9225 Adds plugman support for the Win...

2015-06-22 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/251#issuecomment-114177934 Mefire - in response to your first question, yeah - `plugman` provides some tools to get started building your plugin - creates the initial structure

[GitHub] cordova-browser pull request: Update 'cordova run browser' command...

2015-06-19 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-browser/pull/12 Update 'cordova run browser' command to use cordova-serve module. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova

[GitHub] cordova-lib pull request: Updates 'cordova serve' command to use c...

2015-06-19 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/250 Updates 'cordova serve' command to use cordova-serve module. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib tb

[GitHub] cordova-lib pull request: Adds plugman support for the Windows pla...

2015-06-19 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/251 Adds plugman support for the Windows platform. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib tb-plugman-windows

[GitHub] cordova-lib pull request: CB-9225 Adds plugman support for the Win...

2015-06-20 Thread TimBarham
Github user TimBarham closed the pull request at: https://github.com/apache/cordova-lib/pull/251 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-windows pull request: CB-9252: Migrate WinJS to an NPM dep...

2015-06-26 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/93#discussion_r33372216 --- Diff: bin/lib/create.js --- @@ -98,6 +106,16 @@ module.exports.run = function (argv) { return Q.resolve(); }; +function

[GitHub] cordova-coho pull request: Initial coho handling for the new cordo...

2015-06-11 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-coho/pull/84#issuecomment-111262521 Ah, good question. I'll try it out. I tried a few scenarios, and was trying to think of one where having two items in the repo list pointing to the same repo

[GitHub] cordova-coho pull request: Initial coho handling for the new cordo...

2015-06-10 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-coho/pull/84 Initial coho handling for the new cordova-serve module in cordova-lib. 1. Adds `cordova-serve` as another repo in coho's list of repos (it actually just points to the `cordova-lib` repo

[GitHub] cordova-coho pull request: Handle multiple modules within a single...

2015-06-16 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-coho/pull/85#issuecomment-112478743 Thanks @stevengill! Will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-9188 Confusing error after delete plu...

2015-06-16 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/249 CB-9188 Confusing error after delete plugin folder then prepare. Catch this scenario and display a useful message. You can merge this pull request into a Git repository by running

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

2015-06-16 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/247#issuecomment-112552487 Thanks for the update, @ogoguel. Squashed and merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-coho pull request: Handle multiple modules within a single...

2015-06-13 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-coho/pull/85 Handle multiple modules within a single repo. This change includes logic to handle multiple modules within a single repo, and adds specific handling for the `cordova-serve` module

[GitHub] cordova-coho pull request: Handle multiple modules within a single...

2015-06-13 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-coho/pull/85#issuecomment-111766010 Ok, @stevengill, let me know what you think :smile:. In particular, do you think the `update-release-notes` command will solve the issue you mentioned - picking

[GitHub] cordova-coho pull request: Initial coho handling for the new cordo...

2015-06-13 Thread TimBarham
Github user TimBarham closed the pull request at: https://github.com/apache/cordova-coho/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-coho pull request: Initial coho handling for the new cordo...

2015-06-13 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-coho/pull/84#issuecomment-111765452 Ok, I'm gonna close this an open a new PR with a much more complete change. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: CB-9177 Use tilde instead of caret when ...

2015-06-14 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/248 CB-9177 Use tilde instead of caret when save to config.xml. Also ensures `platform save` saves version with tilde. You can merge this pull request into a Git repository by running

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-17 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-coho/pull/86#issuecomment-112934635 Looks good (well, apart from those blank lines you insist on adding at the beginning of blocks :smile:). --- If your project is set up for it, you can reply

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-17 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32650218 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-17 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32650376 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout

[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag

2015-06-15 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/214#discussion_r32484109 --- Diff: doc/platform.txt --- @@ -5,7 +5,10 @@ Synopsis Manage project platforms add plat-spec [...].. add specified

[GitHub] cordova-lib pull request: CB-9114: Log deprecation message when --...

2015-06-15 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/234#discussion_r32483383 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -68,6 +68,13 @@ function addHelper(cmd, hooksRunner, projectRoot, targets, opts

[GitHub] cordova-lib pull request: CB-9114: Log deprecation message when --...

2015-06-15 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/234#discussion_r32484031 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -68,6 +68,13 @@ function addHelper(cmd, hooksRunner, projectRoot, targets, opts

  1   2   3   >