[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/244 Oops sorry, I'll re-open the issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-ios/pull/244 Thanks, @shazron I noticed that you've marked the Jira Issue as resolved. In order to completely fix it we should also merge https://github.com/apache/cordova-android/pull/326 and https://github.com/apache/cordova-lib/pull/485. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/244 Merged into master: https://github.com/apache/cordova-ios/commit/c6587cffe7afded445500c2f30addfdf65290797 -- you can close this PR. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-ios/pull/244 You're right, it seems that currently the `--link` option is disregarded in the `resource-file` and `framework` handlers. I've changed them and now you can see the difference in the linking style with the `phonegap-facebook-plugin`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/244 I tested this on the `cordova-plugin-console` plugin and `phonegap-facebook-plugin`. The results before and after applying the patch are the same. In the `PROJECTNAME/plugins` folder, the folder for the plugin itself is linked, and not its contents individually (same as before the patch). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-ios/pull/244 See https://github.com/Wizcorp/phonegap-facebook-plugin/tree/master/platforms/android/FacebookLib and https://github.com/Telerik-Verified-Plugins/Telerik-AppFeedback/tree/master/src/android/FeedbackLib as two examples of such libraries. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-ios/pull/244 I'm not sure if the same behavior can be reproduced with `cordova-ios`. But since the code is exactly the same as the one in `cordova-android` I thought it might be good idea to keep it consistent and fix it here as well. Basically the scenario is to install a plugin which contains a custom Android library code with `--link`. All intermediate build files are created inside a `build` sub-directory and they leak into the plugin's directory. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/244 Thanks! LGTM. What "temporary files" leak, do you have more info on that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/244 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/244?src=pr) is 53.18% (diff: 11.11%) > Merging [#244](https://codecov.io/gh/apache/cordova-ios/pull/244?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will decrease coverage by **0.31%** ```diff @@ master #244 diff @@ == Files12 12 Lines 1028 1036 +8 Methods 145147 +2 Messages 0 0 Branches169171 +2 == + Hits550551 +1 - Misses 478485 +7 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [582e357...15b4fdc](https://codecov.io/gh/apache/cordova-ios/compare/582e35776f01ee03f32f0986de181bcf5eb4d232...15b4fdc6655b034888eb20122df9560c0b42195b?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
