[GitHub] cordova-lib pull request #499: Cb 11960

2017-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/499 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #499: Cb 11960

2017-01-30 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r98560154 --- Diff: cordova-lib/spec-plugman/fetch.spec.js --- @@ -214,20 +214,23 @@ describe('fetch', function() { it('Test 017 : should fetch from a

[GitHub] cordova-lib pull request #499: Cb 11960

2017-01-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r97895425 --- Diff: cordova-lib/spec-cordova/fixtures/basePkgJson4/package.json --- @@ -5,7 +5,7 @@ "main": "index.js", "dependencies": {

[GitHub] cordova-lib pull request #499: Cb 11960

2017-01-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r97894467 --- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js --- @@ -680,10 +681,10 @@ describe('update config.xml to include platforms in pkg.json',

[GitHub] cordova-lib pull request #499: Cb 11960

2017-01-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r97894300 --- Diff: cordova-lib/spec-cordova/fixtures/basePkgJson4/package.json --- @@ -5,7 +5,7 @@ "main": "index.js", "dependencies": {

[GitHub] cordova-lib pull request #499: Cb 11960

2017-01-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r97894545 --- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js --- @@ -697,18 +698,18 @@ describe('update config.xml to include platforms in pkg.json',

[GitHub] cordova-lib pull request #499: Cb 11960

2017-01-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r97894565 --- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js --- @@ -697,18 +698,18 @@ describe('update config.xml to include platforms in pkg.json',

[GitHub] cordova-lib pull request #499: Cb 11960

2017-01-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r97894506 --- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js --- @@ -697,18 +698,18 @@ describe('update config.xml to include platforms in pkg.json',

[GitHub] cordova-lib pull request #499: Cb 11960

2016-11-18 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r88704297 --- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js --- @@ -414,6 +414,80 @@ describe('tests platform/spec restore with --save', function () {

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85018233 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84999160 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85015269 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85012246 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85014503 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85012170 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85010504 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85013772 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85018072 --- Diff: cordova-lib/spec-cordova/pkgJson.spec.js --- @@ -0,0 +1,348 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85011439 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r8503 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85011190 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85010911 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85015289 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85012879 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85010828 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85012532 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85011010 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84999093 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85015369 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85011274 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85010510 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85010529 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85001497 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85010730 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85011104 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84996266 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84996343 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84994538 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84994925 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85001631 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85000290 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84999753 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84995508 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85002184 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84999589 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85002357 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85001447 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84997203 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84999210 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84995973 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85002140 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84995444 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84998011 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84997761 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84997132 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84997032 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-11 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r82916012 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -298,8 +326,24 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-10 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/499 Cb 11960 ### Platforms affected Will work when adding all platforms. ### What does this PR do? When adding or removing a platform (with --save), the specified