Re: [Vote] 4.3.1 iOS Release

2016-12-02 Thread Shazron
The vote has now closed. The results are: Positive Binding Votes: 4 Shazron Abdullah Jesse MacFadyen Filip Maj Kerri Shotts The vote has passed. On Fri, Dec 2, 2016 at 5:01 PM, Jesse wrote: > I vote +1: > * Ran coho audit-license-headers > * Ran coho check-license > * Ran coho verify-archive

Re: [Vote] 4.3.1 iOS Release

2016-12-02 Thread Jesse
I vote +1: * Ran coho audit-license-headers * Ran coho check-license * Ran coho verify-archive * created a new cordova project and added ios@4.3.1 and ran it successfully @purplecabbage risingj.com On Fri, Dec 2, 2016 at 4:53 PM, Filip Maj wrote: > I vote +1 > > I ran the following tests again

Re: [Vote] 4.3.1 iOS Release

2016-12-02 Thread Filip Maj
I vote +1 I ran the following tests against an iOS 10.1 iPhone 7 plus simulator 1. mobilespec autotests - i get the two media failures that seem to be expected (at least per Kerri’s vote) - i get file.spec.147 failure every time w/ code:1 NOT_FOUND_ERR. manual file tests all pass fine, though. -

Re: [Vote] 4.3.1 iOS Release

2016-12-01 Thread Kerri Shotts
I vote +1: Created mobilespec for ios Ran mobilespec auto tests on iOS emulator, some failures (all expected on my end: file-transfer & 2 media tests) Ran npm test, no errors Created hello-world app via CLI, OK Ran on device OK Upgraded app via CLI, OK Ran cordova-lib tests, no errors Tested stor

Re: [Vote] 4.3.1 iOS Release

2016-11-30 Thread Jesse
This should be in a discuss thread. @purplecabbage risingj.com On Wed, Nov 30, 2016 at 8:24 PM, Steven Gill wrote: > We don't update the deps every release. It is more just a reminder to check > them, make sure bundled deps match wanted. If releaser is feeling > ambitious, they can update the

Re: [Vote] 4.3.1 iOS Release

2016-11-30 Thread Steven Gill
We don't update the deps every release. It is more just a reminder to check them, make sure bundled deps match wanted. If releaser is feeling ambitious, they can update the deps. Might require more in depth testing. We have run into issues updating deps before (like shelljs). Something like greenke

Re: [Vote] 4.3.1 iOS Release

2016-11-30 Thread Filip Maj
The release notes in coho [1] note to check npm outdated dependencies. When I run that against commit 0c201c42344f63c7590c4190ba2285fa199300bb, I get: ~/src/cordova-ios on master via ⬢ v6.9.1 ➔ npm outdated --depth=0 Package Current Wanted Latest Location nodeunit0.8.8 0.8.8 0.10.2 co