Re: Fix crash on cordova-windows@5

2018-02-08 Thread Chris Brody 
Reverting d5ddcb4 (fix for CB-12499) would resolve the test failure. (This
change is not part of 5.x.) Would this be an option?

If not, what else can we do to ship a release that fixes the crash on
Windows 8.1? Is there anything else I can do?

Workaround is still to use cordova-windows@4. This has been broken for way
too long.

On Thu, Feb 8, 2018 at 7:34 AM, Jan Piotrowski  wrote:

> (5.x doesn't have the broken test because VS2017 wasn't a thing back then.
> It's highly probably that if one would test 5.x with VS2017 it would also
> be broken.)
>
> (Broken test is https://issues.apache.org/jira/browse/CB-13834 if anyone
> wants to help me debug/understand)
>
> 2018-02-08 13:05 GMT+01:00 Chris Brody :
>
> > The 5.0.x branch does not have the failing test. This is why I proposed
> > fixing the crash there.
> >
> > If 6.0.0 would be unblocked and released today then I would be happy.
> >
> > On Thu, Feb 8, 2018 at 6:57 AM, julio cesar sanchez <
> > jcesarmob...@gmail.com>
> > wrote:
> >
> > > The release of 6.0.0 is blocked because of a test, so a possible
> > > 5.0.1/5.1.0 will probably be blocked for the same reason.
> > >
> > > If the 6.0.0 gets unblocked and can be released, is that good for you?
> or
> > > you need the 5.0.1/5.1.0 for some reason?
> > >
> > > 2018-02-08 12:42 GMT+01:00 Chris Brody :
> > >
> > > > I was hoping to get this fixed for a customer. The last time I
> > published
> > > a
> > > > change on my fork was was outdated pretty quickly. For now I will say
> > > that
> > > > they have to use cordova-android@4 for Windows 8.,1 until we get a
> new
> > > > release with this crash resolved.
> > > >
> > > > Since #247 was already merged into 5.0.x I would be happiest to see
> it
> > > > released. I do not see how this kind of a fix could confuse anyone.
> Or
> > > am I
> > > > missing something here?
> > > >
> > > > On Thu, Feb 8, 2018 at 6:03 AM, Jan Piotrowski  >
> > > > wrote:
> > > >
> > > > > I do not think this change necessitates a 5.0.1 or 5.1 release.
> > Cutting
> > > > > another release before 6.0.0 will just confuse people.
> > > > > Just fork the repo and apply the change on your fork, then use that
> > in
> > > > your
> > > > > app.
> > > > >
> > > > > Although if anyone wants to run the release process, I of course
> > won't
> > > > stop
> > > > > you. (But I will not but focus on 6.0.0).
> > > > >
> > > > > J
> > > > >
> > > > > 2018-02-08 4:44 GMT+01:00 Chris Brody :
> > > > >
> > > > > > Hello team,
> > > > > >
> > > > > > Windows 8.1 (8.1-win) build crashes in cordova-windows@5.0.0
> > > > (CB-12784 &
> > > > > > CB-13175). It took multiple attempts to fix this on the
> > > cordova-windows
> > > > > > master branch which I thought would be released 1-2 weeks ago for
> > > > 5.1.0.
> > > > > I
> > > > > > discovered today that the master branch is now for
> cordova-windows
> > > > 6.0.0,
> > > > > > blocked by a CI test failure. Very frustrating since I still
> > support
> > > a
> > > > > > special sqlite plugin version on Windows 8.1.
> > > > > >
> > > > > > I raised CB-13855 with a proposed fix for cordova-windows@5 in
> > > > > > https://github.com/apache/cordova-windows/pull/247 (tested). As
> > > stated
> > > > > in
> > > > > > PR #247 I did not do everything the usual way, purpose is to get
> > this
> > > > > fixed
> > > > > > ASAP.
> > > > > >
> > > > > > Please let me know if there is anything else you need me to do to
> > get
> > > > > this
> > > > > > fix into a new cordova-windows@5 release ASAP. It has been
> broken
> > > for
> > > > > way
> > > > > > too long.
> > > > > >
> > > > > > Thanks and best regards,
> > > > > > Chris
> > > > > >
> > > > > > https://www.linkedin.com/in/chrisbrody/
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: Fix crash on cordova-windows@5

2018-02-08 Thread Jan Piotrowski 
(5.x doesn't have the broken test because VS2017 wasn't a thing back then.
It's highly probably that if one would test 5.x with VS2017 it would also
be broken.)

(Broken test is https://issues.apache.org/jira/browse/CB-13834 if anyone
wants to help me debug/understand)

2018-02-08 13:05 GMT+01:00 Chris Brody :

> The 5.0.x branch does not have the failing test. This is why I proposed
> fixing the crash there.
>
> If 6.0.0 would be unblocked and released today then I would be happy.
>
> On Thu, Feb 8, 2018 at 6:57 AM, julio cesar sanchez <
> jcesarmob...@gmail.com>
> wrote:
>
> > The release of 6.0.0 is blocked because of a test, so a possible
> > 5.0.1/5.1.0 will probably be blocked for the same reason.
> >
> > If the 6.0.0 gets unblocked and can be released, is that good for you? or
> > you need the 5.0.1/5.1.0 for some reason?
> >
> > 2018-02-08 12:42 GMT+01:00 Chris Brody :
> >
> > > I was hoping to get this fixed for a customer. The last time I
> published
> > a
> > > change on my fork was was outdated pretty quickly. For now I will say
> > that
> > > they have to use cordova-android@4 for Windows 8.,1 until we get a new
> > > release with this crash resolved.
> > >
> > > Since #247 was already merged into 5.0.x I would be happiest to see it
> > > released. I do not see how this kind of a fix could confuse anyone. Or
> > am I
> > > missing something here?
> > >
> > > On Thu, Feb 8, 2018 at 6:03 AM, Jan Piotrowski 
> > > wrote:
> > >
> > > > I do not think this change necessitates a 5.0.1 or 5.1 release.
> Cutting
> > > > another release before 6.0.0 will just confuse people.
> > > > Just fork the repo and apply the change on your fork, then use that
> in
> > > your
> > > > app.
> > > >
> > > > Although if anyone wants to run the release process, I of course
> won't
> > > stop
> > > > you. (But I will not but focus on 6.0.0).
> > > >
> > > > J
> > > >
> > > > 2018-02-08 4:44 GMT+01:00 Chris Brody :
> > > >
> > > > > Hello team,
> > > > >
> > > > > Windows 8.1 (8.1-win) build crashes in cordova-windows@5.0.0
> > > (CB-12784 &
> > > > > CB-13175). It took multiple attempts to fix this on the
> > cordova-windows
> > > > > master branch which I thought would be released 1-2 weeks ago for
> > > 5.1.0.
> > > > I
> > > > > discovered today that the master branch is now for cordova-windows
> > > 6.0.0,
> > > > > blocked by a CI test failure. Very frustrating since I still
> support
> > a
> > > > > special sqlite plugin version on Windows 8.1.
> > > > >
> > > > > I raised CB-13855 with a proposed fix for cordova-windows@5 in
> > > > > https://github.com/apache/cordova-windows/pull/247 (tested). As
> > stated
> > > > in
> > > > > PR #247 I did not do everything the usual way, purpose is to get
> this
> > > > fixed
> > > > > ASAP.
> > > > >
> > > > > Please let me know if there is anything else you need me to do to
> get
> > > > this
> > > > > fix into a new cordova-windows@5 release ASAP. It has been broken
> > for
> > > > way
> > > > > too long.
> > > > >
> > > > > Thanks and best regards,
> > > > > Chris
> > > > >
> > > > > https://www.linkedin.com/in/chrisbrody/
> > > > >
> > > >
> > >
> >
>

Re: Fix crash on cordova-windows@5

2018-02-08 Thread Chris Brody 
The 5.0.x branch does not have the failing test. This is why I proposed
fixing the crash there.

If 6.0.0 would be unblocked and released today then I would be happy.

On Thu, Feb 8, 2018 at 6:57 AM, julio cesar sanchez 
wrote:

> The release of 6.0.0 is blocked because of a test, so a possible
> 5.0.1/5.1.0 will probably be blocked for the same reason.
>
> If the 6.0.0 gets unblocked and can be released, is that good for you? or
> you need the 5.0.1/5.1.0 for some reason?
>
> 2018-02-08 12:42 GMT+01:00 Chris Brody :
>
> > I was hoping to get this fixed for a customer. The last time I published
> a
> > change on my fork was was outdated pretty quickly. For now I will say
> that
> > they have to use cordova-android@4 for Windows 8.,1 until we get a new
> > release with this crash resolved.
> >
> > Since #247 was already merged into 5.0.x I would be happiest to see it
> > released. I do not see how this kind of a fix could confuse anyone. Or
> am I
> > missing something here?
> >
> > On Thu, Feb 8, 2018 at 6:03 AM, Jan Piotrowski 
> > wrote:
> >
> > > I do not think this change necessitates a 5.0.1 or 5.1 release. Cutting
> > > another release before 6.0.0 will just confuse people.
> > > Just fork the repo and apply the change on your fork, then use that in
> > your
> > > app.
> > >
> > > Although if anyone wants to run the release process, I of course won't
> > stop
> > > you. (But I will not but focus on 6.0.0).
> > >
> > > J
> > >
> > > 2018-02-08 4:44 GMT+01:00 Chris Brody :
> > >
> > > > Hello team,
> > > >
> > > > Windows 8.1 (8.1-win) build crashes in cordova-windows@5.0.0
> > (CB-12784 &
> > > > CB-13175). It took multiple attempts to fix this on the
> cordova-windows
> > > > master branch which I thought would be released 1-2 weeks ago for
> > 5.1.0.
> > > I
> > > > discovered today that the master branch is now for cordova-windows
> > 6.0.0,
> > > > blocked by a CI test failure. Very frustrating since I still support
> a
> > > > special sqlite plugin version on Windows 8.1.
> > > >
> > > > I raised CB-13855 with a proposed fix for cordova-windows@5 in
> > > > https://github.com/apache/cordova-windows/pull/247 (tested). As
> stated
> > > in
> > > > PR #247 I did not do everything the usual way, purpose is to get this
> > > fixed
> > > > ASAP.
> > > >
> > > > Please let me know if there is anything else you need me to do to get
> > > this
> > > > fix into a new cordova-windows@5 release ASAP. It has been broken
> for
> > > way
> > > > too long.
> > > >
> > > > Thanks and best regards,
> > > > Chris
> > > >
> > > > https://www.linkedin.com/in/chrisbrody/
> > > >
> > >
> >
>

Re: Fix crash on cordova-windows@5

2018-02-08 Thread julio cesar sanchez 
The release of 6.0.0 is blocked because of a test, so a possible
5.0.1/5.1.0 will probably be blocked for the same reason.

If the 6.0.0 gets unblocked and can be released, is that good for you? or
you need the 5.0.1/5.1.0 for some reason?

2018-02-08 12:42 GMT+01:00 Chris Brody :

> I was hoping to get this fixed for a customer. The last time I published a
> change on my fork was was outdated pretty quickly. For now I will say that
> they have to use cordova-android@4 for Windows 8.,1 until we get a new
> release with this crash resolved.
>
> Since #247 was already merged into 5.0.x I would be happiest to see it
> released. I do not see how this kind of a fix could confuse anyone. Or am I
> missing something here?
>
> On Thu, Feb 8, 2018 at 6:03 AM, Jan Piotrowski 
> wrote:
>
> > I do not think this change necessitates a 5.0.1 or 5.1 release. Cutting
> > another release before 6.0.0 will just confuse people.
> > Just fork the repo and apply the change on your fork, then use that in
> your
> > app.
> >
> > Although if anyone wants to run the release process, I of course won't
> stop
> > you. (But I will not but focus on 6.0.0).
> >
> > J
> >
> > 2018-02-08 4:44 GMT+01:00 Chris Brody :
> >
> > > Hello team,
> > >
> > > Windows 8.1 (8.1-win) build crashes in cordova-windows@5.0.0
> (CB-12784 &
> > > CB-13175). It took multiple attempts to fix this on the cordova-windows
> > > master branch which I thought would be released 1-2 weeks ago for
> 5.1.0.
> > I
> > > discovered today that the master branch is now for cordova-windows
> 6.0.0,
> > > blocked by a CI test failure. Very frustrating since I still support a
> > > special sqlite plugin version on Windows 8.1.
> > >
> > > I raised CB-13855 with a proposed fix for cordova-windows@5 in
> > > https://github.com/apache/cordova-windows/pull/247 (tested). As stated
> > in
> > > PR #247 I did not do everything the usual way, purpose is to get this
> > fixed
> > > ASAP.
> > >
> > > Please let me know if there is anything else you need me to do to get
> > this
> > > fix into a new cordova-windows@5 release ASAP. It has been broken for
> > way
> > > too long.
> > >
> > > Thanks and best regards,
> > > Chris
> > >
> > > https://www.linkedin.com/in/chrisbrody/
> > >
> >
>

Re: Fix crash on cordova-windows@5

2018-02-08 Thread Chris Brody 
I was hoping to get this fixed for a customer. The last time I published a
change on my fork was was outdated pretty quickly. For now I will say that
they have to use cordova-android@4 for Windows 8.,1 until we get a new
release with this crash resolved.

Since #247 was already merged into 5.0.x I would be happiest to see it
released. I do not see how this kind of a fix could confuse anyone. Or am I
missing something here?

On Thu, Feb 8, 2018 at 6:03 AM, Jan Piotrowski  wrote:

> I do not think this change necessitates a 5.0.1 or 5.1 release. Cutting
> another release before 6.0.0 will just confuse people.
> Just fork the repo and apply the change on your fork, then use that in your
> app.
>
> Although if anyone wants to run the release process, I of course won't stop
> you. (But I will not but focus on 6.0.0).
>
> J
>
> 2018-02-08 4:44 GMT+01:00 Chris Brody :
>
> > Hello team,
> >
> > Windows 8.1 (8.1-win) build crashes in cordova-windows@5.0.0 (CB-12784 &
> > CB-13175). It took multiple attempts to fix this on the cordova-windows
> > master branch which I thought would be released 1-2 weeks ago for 5.1.0.
> I
> > discovered today that the master branch is now for cordova-windows 6.0.0,
> > blocked by a CI test failure. Very frustrating since I still support a
> > special sqlite plugin version on Windows 8.1.
> >
> > I raised CB-13855 with a proposed fix for cordova-windows@5 in
> > https://github.com/apache/cordova-windows/pull/247 (tested). As stated
> in
> > PR #247 I did not do everything the usual way, purpose is to get this
> fixed
> > ASAP.
> >
> > Please let me know if there is anything else you need me to do to get
> this
> > fix into a new cordova-windows@5 release ASAP. It has been broken for
> way
> > too long.
> >
> > Thanks and best regards,
> > Chris
> >
> > https://www.linkedin.com/in/chrisbrody/
> >
>

Re: Fix crash on cordova-windows@5

2018-02-08 Thread Jan Piotrowski 
I do not think this change necessitates a 5.0.1 or 5.1 release. Cutting
another release before 6.0.0 will just confuse people.
Just fork the repo and apply the change on your fork, then use that in your
app.

Although if anyone wants to run the release process, I of course won't stop
you. (But I will not but focus on 6.0.0).

J

2018-02-08 4:44 GMT+01:00 Chris Brody :

> Hello team,
>
> Windows 8.1 (8.1-win) build crashes in cordova-windows@5.0.0 (CB-12784 &
> CB-13175). It took multiple attempts to fix this on the cordova-windows
> master branch which I thought would be released 1-2 weeks ago for 5.1.0. I
> discovered today that the master branch is now for cordova-windows 6.0.0,
> blocked by a CI test failure. Very frustrating since I still support a
> special sqlite plugin version on Windows 8.1.
>
> I raised CB-13855 with a proposed fix for cordova-windows@5 in
> https://github.com/apache/cordova-windows/pull/247 (tested). As stated in
> PR #247 I did not do everything the usual way, purpose is to get this fixed
> ASAP.
>
> Please let me know if there is anything else you need me to do to get this
> fix into a new cordova-windows@5 release ASAP. It has been broken for way
> too long.
>
> Thanks and best regards,
> Chris
>
> https://www.linkedin.com/in/chrisbrody/
>