[jira] [Commented] (CURATOR-460) Timed tolerance for connection suspended leads to simultaneous leaders

2018-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426354#comment-16426354 ] ASF GitHub Bot commented on CURATOR-460: Github user arrodrigues commented on a d

[GitHub] curator pull request #262: [CURATOR-460] Timed tolerance for connection susp...

2018-04-04 Thread arrodrigues
Github user arrodrigues commented on a diff in the pull request: https://github.com/apache/curator/pull/262#discussion_r179319128 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java --- @@ -253,6 +253,7 @@ private void processEv

[GitHub] curator pull request #262: [CURATOR-460] Timed tolerance for connection susp...

2018-04-04 Thread arrodrigues
Github user arrodrigues commented on a diff in the pull request: https://github.com/apache/curator/pull/262#discussion_r179319231 --- Diff: curator-recipes/src/test/java/org/apache/curator/framework/recipes/leader/TestLeaderLatch.java --- @@ -222,6 +223,35 @@ public void notLeader

[jira] [Commented] (CURATOR-460) Timed tolerance for connection suspended leads to simultaneous leaders

2018-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426355#comment-16426355 ] ASF GitHub Bot commented on CURATOR-460: Github user arrodrigues commented on a d

[GitHub] curator issue #262: [CURATOR-460] Timed tolerance for connection suspended l...

2018-04-04 Thread cammckenzie
Github user cammckenzie commented on the issue: https://github.com/apache/curator/pull/262 Thanks for the updates, I think this looks good. I still think we need to look at the default behaviour of the ConnectionStateListener though. Currently, a LOST event will only be inject

[jira] [Commented] (CURATOR-460) Timed tolerance for connection suspended leads to simultaneous leaders

2018-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426441#comment-16426441 ] ASF GitHub Bot commented on CURATOR-460: Github user cammckenzie commented on the