[GitHub] rmannibucau commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-18 Thread git
l always hit a pitfall. Do you know any framework using $$ and would break cxf unwrapping the class? If so we can surely just make the suffixes configurable. Throughts? This is an automated message from the Apache Git Servic

[GitHub] rmannibucau commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-18 Thread git
l always hit a pitfall. Do you know any framework using $$ and would break cxf unwrapping the class? If so we can surely just make the suffixes configurable. Thoughts? This is an automated message from the Apache Git Servic

[GitHub] asfgit closed pull request #310: Cache URITemplates instead of creating them over and over resulting i?

2017-09-18 Thread git
asfgit closed pull request #310: Cache URITemplates instead of creating them over and over resulting i? URL: https://github.com/apache/cxf/pull/310 This is an automated message from the Apache Git Service. To respond

[GitHub] sberyozkin commented on issue #310: Cache URITemplates instead of creating them over and over resulting i?

2017-09-18 Thread git
lash being added by default, so your code is fine. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about th

[GitHub] johnament commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-18 Thread git
re, and explicitly activating it in CDI, but would be concerned with being over eager with the swap out. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to g

[GitHub] reta commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-18 Thread git
self? F.e. in case of OWB, we could use`NormalScopeProxyFactory.unwrapInstance(o)`, something similar should be available for Weld as well. Not ideal either, but more reliable may be? Thoughts? This is an automated message

[GitHub] reta commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-19 Thread git
moved outside CDI integration, @rmannibucau any particular reasons to do that? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment.

[GitHub] johnament commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-19 Thread git
the discussion. Do we still want to move outside the CDI module? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment.

[GitHub] xldai opened a new pull request #314: CXF-7509 The authSupplier property is ignored in case of OSGi http co?

2017-09-19 Thread git
xldai opened a new pull request #314: CXF-7509 The authSupplier property is ignored in case of OSGi http co? URL: https://github.com/apache/cxf/pull/314 ?nduit configuration This is an automated message from the Apache Git

[GitHub] ffang closed pull request #314: CXF-7509 The authSupplier property is ignored in case of OSGi http co?

2017-09-19 Thread git
ffang closed pull request #314: CXF-7509 The authSupplier property is ignored in case of OSGi http co? URL: https://github.com/apache/cxf/pull/314 This is an automated message from the Apache Git Service. To respond

[GitHub] rmannibucau commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-19 Thread git
integrations. Very few server uses cdi extension to comply to spec but all use proxies. Since the perf and behavior shouldnt hurt it can be added to the default IMO This is an automated message from the Apache Git Service. To resp

[GitHub] sberyozkin commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
showing itself on the CDI path ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] sberyozkin commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
ers are not opening any issues... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastruct

[GitHub] rmannibucau commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
--- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rmannibucau commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
tually except CDI uses proxies. It will happen each time a lib is using subclassing proxies, CDI is one big consumer but there are a lot of other ways to get it even in plain standalone. This is an automated message from the

[GitHub] sberyozkin commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
u are right; I'm just not sure the proposed ClassUnwrapper should be called there by default every time ClassHelper is called, may be do it in 2 stages, 1) test as part of the CDI 2) move it to the core ? This is an automated messa

[GitHub] rmannibucau commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
eview comment: Works for me This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] sberyozkin commented on issue #315: [CXF-7512] Support searching swaggerUi by name and version in all bun?

2017-09-22 Thread git
:-) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] sberyozkin commented on issue #315: [CXF-7512] Support searching swaggerUi by name and version in all bun?

2017-09-22 Thread git
like ? You may end up liking it :-) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] sberyozkin commented on issue #315: [CXF-7512] Support searching swaggerUi by name and version in all bun?

2017-09-22 Thread git
a swaggerUiName property without '/' This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] cschneider commented on issue #315: [CXF-7512] Support searching swaggerUi by name and version in all bun?

2017-09-22 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

[GitHub] cschneider opened a new pull request #315: [CXF-7512] Support searching swaggerUi by name and version in all bun?

2017-09-22 Thread git
cschneider opened a new pull request #315: [CXF-7512] Support searching swaggerUi by name and version in all bun? URL: https://github.com/apache/cxf/pull/315 ?dles This is an automated message from the Apache Git Service

[GitHub] johnament commented on issue #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
> <https://github.com/apache/cxf/pull/313#discussion_r14036>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAGmh5HMBhr0c0Q4hzG8G44zuxOsC72Cks5skZSDgaJpZM4Pau6x> > . > T

[GitHub] reta commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
@sberyozkin suggestion for 2 stages, let us start from CDI first, and than make a decision if it worth going to core or not. Make sense? This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] reta closed pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
reta closed pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration. URL: https://github.com/apache/cxf/pull/313 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] reta commented on issue #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] reta commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-18 Thread git
` like @rmannibucau pointed out as well. Should be pretty good heuristic, what do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to t

[GitHub] johnament commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-18 Thread git
comment: Well, I don't think Weld has a behavior like `unwrapInstance` but it could be done by us if its Weld. I also figured that checking by name would be easier since it avoid any compile time dependencies. This is an autom

[GitHub] nhtzr closed pull request #253: [CXF-7309] JAX-RS @Context fields throw NPE in OSGI hot deployed filters

2017-09-18 Thread git
nhtzr closed pull request #253: [CXF-7309] JAX-RS @Context fields throw NPE in OSGI hot deployed filters URL: https://github.com/apache/cxf/pull/253 This is an automated message from the Apache Git Service. To respond

[GitHub] sberyozkin commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
n yes, please merge :-), I did not really contribute myself This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries abou

[GitHub] reta commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
) so it kind of explains its purpose. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.a

[GitHub] reta commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
beryozkin are we good to merge? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastruct

[GitHub] johnament commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
r what the plan is, just leave it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@i

[GitHub] johnament commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration.

2017-09-20 Thread git
tion.getProperty("org.apache.cxf.cdi.useCdiUnwrapper", "true"))) { Review comment: Sure This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to

[GitHub] gonzalad commented on issue #20: FEDIZ-212: fix logout when no httpSession present

2017-10-10 Thread git
ext().getUserPrincipal() != null) { ``` block or be kept outside. I've just tested both way, it works both way. Thanks ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] gonzalad opened a new pull request #20: FEDIZ-212: fix logout when no httpSession present

2017-10-09 Thread git
(i.e. from different OIDC Clients) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] davidkarlsen opened a new pull request #317: CXF-7524: Use property from parentclass

2017-10-05 Thread git
davidkarlsen opened a new pull request #317: CXF-7524: Use property from parentclass URL: https://github.com/apache/cxf/pull/317 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] asfgit closed pull request #317: CXF-7524: Use property from parentclass

2017-10-05 Thread git
asfgit closed pull request #317: CXF-7524: Use property from parentclass URL: https://github.com/apache/cxf/pull/317 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] sberyozkin commented on issue #318: CXF-7506: Upgrade guava

2017-10-06 Thread git
which requires newer guava This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] davidkarlsen commented on issue #318: CXF-7506: Upgrade guava

2017-10-06 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] sberyozkin commented on issue #318: CXF-7506: Upgrade guava

2017-10-06 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] davidkarlsen closed pull request #318: CXF-7506: Upgrade guava

2017-10-06 Thread git
davidkarlsen closed pull request #318: CXF-7506: Upgrade guava URL: https://github.com/apache/cxf/pull/318 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] davidkarlsen commented on issue #318: CXF-7506: Upgrade guava

2017-10-06 Thread git
davidkarlsen commented on issue #318: CXF-7506: Upgrade guava URL: https://github.com/apache/cxf/pull/318#issuecomment-334740076 Agreed - close the jira and abandon this. This is an automated message from the Apache Git

[GitHub] sberyozkin commented on issue #318: CXF-7506: Upgrade guava

2017-10-06 Thread git
requires newer guava This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] ffang closed pull request #319: [CXF-7528] Tone down logging when unregistering CXF servlet in OSGi d?

2017-10-11 Thread git
ffang closed pull request #319: [CXF-7528] Tone down logging when unregistering CXF servlet in OSGi d? URL: https://github.com/apache/cxf/pull/319 This is an automated message from the Apache Git Service. To respond

[GitHub] ffang closed pull request #320: [CXF-7529] Clean up JAX-RS RuntimeDelegate when rt-frontend-jaxrs bun?

2017-10-11 Thread git
ffang closed pull request #320: [CXF-7529] Clean up JAX-RS RuntimeDelegate when rt-frontend-jaxrs bun? URL: https://github.com/apache/cxf/pull/320 This is an automated message from the Apache Git Service. To respond

[GitHub] gnodet opened a new pull request #316: [CXF-7519] The cxf-rt-transports-http-jetty should not rely on the ol?

2017-09-27 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] gnodet commented on issue #316: [CXF-7519] The cxf-rt-transports-http-jetty should not rely on the ol?

2017-09-28 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] gnodet closed pull request #316: [CXF-7519] The cxf-rt-transports-http-jetty should not rely on the ol?

2017-09-28 Thread git
gnodet closed pull request #316: [CXF-7519] The cxf-rt-transports-http-jetty should not rely on the ol? URL: https://github.com/apache/cxf/pull/316 This is an automated message from the Apache Git Service. To respond

[GitHub] sberyozkin commented on issue #20: FEDIZ-212: fix logout when no httpSession present

2017-10-09 Thread git
? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] davidkarlsen opened a new pull request #318: CXF-7506: Upgrade guava

2017-10-05 Thread git
davidkarlsen opened a new pull request #318: CXF-7506: Upgrade guava URL: https://github.com/apache/cxf/pull/318 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] deki commented on issue #318: CXF-7506: Upgrade guava

2017-10-05 Thread git
... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] davidkarlsen commented on issue #318: CXF-7506: Upgrade guava

2017-10-05 Thread git
... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] grgrzybek opened a new pull request #319: [CXF-7528] Tone down logging when unregistering CXF servlet in OSGi d?

2017-10-11 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] grgrzybek opened a new pull request #320: [CXF-7529] Clean up JAX-RS RuntimeDelegate when rt-frontend-jaxrs bun?

2017-10-11 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

cxf pull request: httpj:engine-factory

2012-04-02 Thread Git at Apache
GitHub user seijoed opened the pull request at https://github.com/apache/cxf/pull/1 httpj:engine-factory You can merge this pull request into a Git repository by running $ git pull https://github.com/seijoed/cxf trunk Alternatively you can review and apply these changes as the patch

cxf pull request: httpj:engine-factory

2012-04-03 Thread Git at Apache
Github user seijoed closed the pull request at https://github.com/apache/cxf/pull/1