Re: Compiler.setExternalDFDLVariable(s) considered challenged

2020-03-26 Thread Steve Lawrence
, unlock when none are in flight. >> >> setters can then block waiting for the lock to be freed. >> >> That's guaranteed to be compatible with any correct current practice. >> >> I just hate to put all that complexity in there. >> >> From: Steve Lawr

Re: Compiler.setExternalDFDLVariable(s) considered challenged

2020-03-26 Thread Beckerle, Mike
us out of trouble. From: Steve Lawrence Sent: Thursday, March 26, 2020 7:39 AM To: dev@daffodil.apache.org Subject: Re: Compiler.setExternalDFDLVariable(s) considered challenged Even if we did add the locking, it's still possible to use these incorrectly,

Re: Compiler.setExternalDFDLVariable(s) considered challenged

2020-03-26 Thread Steve Lawrence
_ > From: Steve Lawrence > Sent: Wednesday, March 25, 2020 3:44 PM > To: dev@daffodil.apache.org > Subject: Re: Compiler.setExternalDFDLVariable(s) considered challenged > > My one minor concern about the locking after parse/unparse is that it

Re: Compiler.setExternalDFDLVariable(s) considered challenged

2020-03-25 Thread Beckerle, Mike
d. That's guaranteed to be compatible with any correct current practice. I just hate to put all that complexity in there. From: Steve Lawrence Sent: Wednesday, March 25, 2020 3:44 PM To: dev@daffodil.apache.org Subject: Re: Compiler.setExternalDFDLVariable(s) consid

Re: Compiler.setExternalDFDLVariable(s) considered challenged

2020-03-25 Thread Steve Lawrence
t later. It will still work, > just get deprecation warnings. > > ________ > From: Steve Lawrence > Sent: Wednesday, March 25, 2020 12:05 PM > To: dev@daffodil.apache.org > Subject: Re: Compiler.setExternalDFDLVariable(s) considered challenged > >

Re: Compiler.setExternalDFDLVariable(s) considered challenged

2020-03-25 Thread Beckerle, Mike
just get deprecation warnings. From: Steve Lawrence Sent: Wednesday, March 25, 2020 12:05 PM To: dev@daffodil.apache.org Subject: Re: Compiler.setExternalDFDLVariable(s) considered challenged This feels like the right approach. Thoughts on instead of having to

Re: Compiler.setExternalDFDLVariable(s) considered challenged

2020-03-25 Thread Steve Lawrence
ere were no setters and simply more arguments > to the parse/unparse calls. > > ____________ > From: Beckerle, Mike > Sent: Wednesday, March 25, 2020 11:29 AM > To: dev@daffodil.apache.org > Subject: Re: Compiler.setExternalDFDLVariable(s) considered challen

Re: Compiler.setExternalDFDLVariable(s) considered challenged

2020-03-25 Thread Steve Lawrence
Agreed on deprecating setting variables in the Compiler. It really just doesn't make sense to be doing that. Definitely seems reasonable to add the ability to set variables when calling parse/unparse as that's the most threadsafe way to handle it, and feels natural to me. Note that we still have o

Re: Compiler.setExternalDFDLVariable(s) considered challenged

2020-03-25 Thread Beckerle, Mike
ly more arguments to the parse/unparse calls. From: Beckerle, Mike Sent: Wednesday, March 25, 2020 11:29 AM To: dev@daffodil.apache.org Subject: Re: Compiler.setExternalDFDLVariable(s) considered challenged To respond to my own thread here, I think given th

Re: Compiler.setExternalDFDLVariable(s) considered challenged

2020-03-25 Thread Beckerle, Mike
To respond to my own thread here, I think given that we allow multiple simultaneous calls to parse/unparse from different threads, we must say that the DataProcessor object is immutable once parse or unparse are called. I suppose we could say that it is mutable, but behavior is undetermined if a