[dpdk-dev] [PATCH] vhost: Fix retrieval of numa information in PMD

2016-04-07 Thread Yuanhan Liu
On Wed, Apr 06, 2016 at 09:37:53AM +, Loftus, Ciara wrote: > > > > On Wed, Apr 06, 2016 at 03:49:25PM +0900, Tetsuya Mukawa wrote: > > > On 2016/04/06 1:09, Ciara Loftus wrote: > > > > After some testing, it was found that retrieving numa information > > > > about a vhost device via a call to

[dpdk-dev] [PATCH] vhost: Fix retrieval of numa information in PMD

2016-04-07 Thread Yuanhan Liu
On Wed, Apr 06, 2016 at 06:12:07PM +0200, Thomas Monjalon wrote: > 2016-04-07 00:09, Yuanhan Liu: > > On Wed, Apr 06, 2016 at 09:37:53AM +, Loftus, Ciara wrote: > > > > On Wed, Apr 06, 2016 at 03:49:25PM +0900, Tetsuya Mukawa wrote: > > > > > Hi, > > > > > > > > > > I appreciate fixing it. > >

[dpdk-dev] ovs crash when running traffic from VM to VM over DPDK and vhostuser

2016-04-07 Thread Yuanhan Liu
On Tue, Apr 05, 2016 at 08:36:19PM +, Yi Ba wrote: > > Program received signal SIGSEGV, Segmentation fault. > [Switching to Thread 0x7ff1ddffb700 (LWP 21287)] > 0x00450da7 in update_secure_len (vec_idx=0x7ff1ddff27f8, > secure_len=0x7ff1ddff27fc, id=13948, vq=0x7fe7992c8940) > at

[dpdk-dev] [PATCH v2] doc: update overview

2016-04-07 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, April 6, 2016 4:27 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] doc: update overview > > 2016-04-05 10:54, Wenzhuo Lu: > > Update the

[dpdk-dev] [PATCH] doc: announce per queue stats support for ixgbe

2016-04-07 Thread Wenzhuo Lu
Fixes: 83a4a15404ef (doc: fill nics features matrix for e1000/igb and ixgbe) Reported-by: Thomas Monjalon Signed-off-by: Wenzhuo Lu --- doc/guides/nics/overview.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst

[dpdk-dev] [PATCH v3 1/4] bnx2x: Update documentation

2016-04-07 Thread Rasesh Mody
Hi Bruce, > From: Bruce Richardson [mailto:bruce.richardson at intel.com] > Sent: Wednesday, April 06, 2016 7:33 AM > > On Tue, Apr 05, 2016 at 05:37:05PM -0700, Rasesh Mody wrote: > > Signed-off-by: Harish Patil > > Signed-off-by: Rasesh Mody > > --- > > doc/guides/nics/bnx2x.rst|1 +

[dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get

2016-04-07 Thread Rasesh Mody
> From: Van Haaren, Harry [mailto:harry.van.haaren at intel.com] > Sent: Wednesday, April 06, 2016 7:33 AM > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rasesh Mody > > Subject: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get > > Hi Rasesh, > > > +

[dpdk-dev] XEN netfront PMD support

2016-04-07 Thread Xie, Huawei
Hi Stephen: I recall that you ever send a netfront PMD patch. I think that is one missing piece for running PMD in XEN domU. There are still users requiring that feature. Could you resend that patch? I could help review.

[dpdk-dev] [PATCH] vhost: ABI/API change announcement due to refactor

2016-04-07 Thread Panu Matilainen
On 04/06/2016 09:53 AM, Yuanhan Liu wrote: > We currently exposed way too many fields (or even structures) than > necessary. For example, vhost_virtqueue struct should NOT be exposed > to user at all: application just need to tell the right queue id to > locate a specific queue, and that's all.

[dpdk-dev] [PATCH v2] doc: update overview

2016-04-07 Thread Thomas Monjalon
2016-04-07 01:34, Lu, Wenzhuo: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > stats per queue X > > > X > > > > You have not filled stats per queue. Is it because of an issue with > > queue_stats_mapping? > I

[dpdk-dev] XEN netfront PMD support

2016-04-07 Thread Thomas Monjalon
2016-04-07 06:20, Xie, Huawei: > Hi Stephen: > I recall that you ever send a netfront PMD patch. I think that is one > missing piece for running PMD in XEN domU. There are still users > requiring that feature. Could you resend that patch? I could help review. It has been resent by Jan Blunck:

[dpdk-dev] [PATCH v2] doc: update nic overview

2016-04-07 Thread Thomas Monjalon
Hi Mark, I'm waiting for these small comments. Please could you rebase your patch and fix it if needed? 2016-04-06 10:33, Thomas Monjalon: > 2016-04-01 16:55, Chen Jing D: > > - stats per queue X > >X > > + stats per queue

[dpdk-dev] [PATCH v2] doc: update nic overview

2016-04-07 Thread Chen, Jing D
Hi, Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, April 07, 2016 3:54 PM > To: Chen, Jing D > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] doc: update nic overview > > Hi Mark, > > I'm waiting for these small

[dpdk-dev] [PATCH v2] doc: update overview

2016-04-07 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, April 7, 2016 3:38 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] doc: update overview > > 2016-04-07 01:34, Lu, Wenzhuo: > > From: Thomas

[dpdk-dev] DPDK namespace

2016-04-07 Thread Marc
On 6 April 2016 at 22:21, Dave Neary wrote: > Hi, > > On 04/06/2016 08:07 AM, Panu Matilainen wrote: > >> +1: it's a bit weird to keep both, especially for a long while, that > >> every time we turn a rte_ prefix to dpdk_ prefix, we break applications. > >> Instead of breaking applications many

[dpdk-dev] DPDK namespace

2016-04-07 Thread Thomas Monjalon
Thank you everyone for the feedbacks. 2016-04-05 15:56, Thomas Monjalon: > The goal of this email is to get some feedback on how important it is > to fix the DPDK namespace. Everybody agree every symbols must be prefixed. Checking and fixing the namespace consistency will be in the roadmap. It

[dpdk-dev] DPDK namespace

2016-04-07 Thread Panu Matilainen
On 04/07/2016 12:18 PM, Thomas Monjalon wrote: > Thank you everyone for the feedbacks. > > 2016-04-05 15:56, Thomas Monjalon: >> The goal of this email is to get some feedback on how important it is >> to fix the DPDK namespace. > > Everybody agree every symbols must be prefixed. Checking and

[dpdk-dev] [PATCH v3] doc: update nic overview

2016-04-07 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add feature support list for fm10k, fm10k-vec, fm10kvf and fm10kvf-vec. Signed-off-by: Chen Jing D(Mark) --- v3: - rebase to latest repo - Add a few feature set that fm10k support v2: - fix a typo doc/guides/nics/overview.rst | 106

[dpdk-dev] DPDK namespace

2016-04-07 Thread Marc Sune
2016-04-07 11:33 GMT+02:00 Panu Matilainen : > On 04/07/2016 12:18 PM, Thomas Monjalon wrote: > >> Thank you everyone for the feedbacks. >> >> 2016-04-05 15:56, Thomas Monjalon: >> >>> The goal of this email is to get some feedback on how important it is >>> to fix the DPDK namespace. >>> >> >>

[dpdk-dev] [PATCH] doc: update multi process memory image

2016-04-07 Thread Thomas Monjalon
2016-04-06 14:17, Harry van Haaren: > This patch updates the titles in the multiprocess memory image > to read "Primary Process" and "Secondary Process" instead of > "DPDK Server Process" and "Customer Client Process". > > The rest of the image has been converted from PNG to SVG. > >

[dpdk-dev] [PATCH] doc: update nics features matrix for mlx

2016-04-07 Thread Adrien Mazarguil
Enable "other kdrv" because both NICs require kernel support to work. Unicast and multicast MAC filters are also enabled as both address types can be filtered on through the MAC add/remove/set callbacks. Signed-off-by: Adrien Mazarguil --- doc/guides/nics/overview.rst | 6 +++--- 1 file

[dpdk-dev] [PATCH v3] doc: update nic overview

2016-04-07 Thread Thomas Monjalon
> From: "Chen Jing D(Mark)" > > Add feature support list for fm10k, fm10k-vec, fm10kvf and > fm10kvf-vec. > > Signed-off-by: Chen Jing D(Mark) [...] > perf doc > = = = = = = = = = = = = = = = = = = = = = = = = = = > = = = = = = = The last line need to be extended

[dpdk-dev] Reg: promiscuous mode on VF

2016-04-07 Thread bharath paulraj
Hi Team, May I have some update on my previous mail? I am here stuck in flow creation. Thanks, Bharath On Thu, Mar 31, 2016 at 4:13 PM, bharath paulraj wrote: > Hi Michael and All, > > I am unable to set the rule to receive the packet on the VF. > Below is my setup. > > 1. Creating

[dpdk-dev] [PATCH] vhost: call rte_vhost_enable_guest_notification only on enabled queues

2016-04-07 Thread Loftus, Ciara
> > If the vhost PMD were configured with more queues than the guest, the old > code would segfault in rte_vhost_enable_guest_notification due to a NULL > virtqueue pointer. > > Fixes: ee584e9710b9 ("vhost: add driver on top of the library") > Signed-off-by: Rich Lane > --- >

[dpdk-dev] [PATCH v2] ivshmem: avoid infinite loop when concatenating adjacent segments

2016-04-07 Thread Anatoly Burakov
This patch aligns the logic used to check for the presence of adjacent segments in has_adjacent_segments() with the logic used in cleanup_segments() when actually deciding to concatenate or not a pair of segments. Additionally, adjacent segments are no longer considered overlapping to avoid

[dpdk-dev] [PATCH v2] cryptodev: Remove EXPERIMENTAL label

2016-04-07 Thread Fiona Trahe
The cryptodev API was introduced in the DPDK 2.2 release. Since then it has - been reviewed and iterated for the DPDK 16.04 release - had extensive use by the l2fwd-crypto app, the ipsec-secgw example app, the test app. We believe it is now stable

[dpdk-dev] [PATCH v2] cryptodev: Remove EXPERIMENTAL label

2016-04-07 Thread Trahe, Fiona
Sorry for spam, accidental resend > -Original Message- > From: Trahe, Fiona > Sent: Thursday, April 07, 2016 11:56 AM > To: dev at dpdk.org > Cc: Doherty, Declan; Trahe, Fiona > Subject: [PATCH v2] cryptodev: Remove EXPERIMENTAL label > > The cryptodev API was introduced in the DPDK 2.2

[dpdk-dev] [PATCH] ethdev: fix CID 124557 unchecked return value

2016-04-07 Thread Slawomir Mrozowicz
It fix coverity issue: CID 124557 (#1 of 1): Unchecked return value (CHECKED_RETURN) 3. check_return: Calling rte_eth_tx_buffer_set_err_callback without checking return value (as is done elsewhere 6 out of 7 times). Fixes: d6c99e62c852 ("ethdev: add buffered Tx") Signed-off-by: Slawomir

[dpdk-dev] [PATCH] vhost: call rte_vhost_enable_guest_notification only on enabled queues

2016-04-07 Thread Tan, Jianfeng
Hi, On 4/7/2016 8:29 AM, Rich Lane wrote: > If the vhost PMD were configured with more queues than the guest, the old > code would segfault in rte_vhost_enable_guest_notification due to a NULL > virtqueue pointer. > > Fixes: ee584e9710b9 ("vhost: add driver on top of the library") >

[dpdk-dev] On DPDK ABI policy

2016-04-07 Thread Panu Matilainen
[ change of subject since this is about ABI policy, not namespacing ] On 04/07/2016 01:16 PM, Marc Sune wrote: > > > 2016-04-07 11:33 GMT+02:00 Panu Matilainen >: > > On 04/07/2016 12:18 PM, Thomas Monjalon wrote: > > Thank you everyone for the

[dpdk-dev] Port 0 Link Down - L2fwd sample application

2016-04-07 Thread Vivek Gupta
Hi I have binded eth0 and eth1 with DPDK and then tried to run the l2fwd example as below ./build/l2fwd -c f -n 4 -- -q 8 -p 0x11 but each time I get error * Checking link status.. Port 0 Link Down Port 1 Link Down

[dpdk-dev] Port 0 Link Down - L2fwd sample application

2016-04-07 Thread Marc Sune
2016-04-07 14:50 GMT+02:00 Vivek Gupta : > Hi > > I have binded eth0 and eth1 with DPDK and then tried to run the l2fwd > example as below > > ./build/l2fwd -c f -n 4 -- -q 8 -p 0x11 but each time I get error > * > Checking link status.. > Port 0 Link Down

[dpdk-dev] [PATCH] app/test: fix array subscript is above array bounds for gcc 4.5

2016-04-07 Thread Tomasz Kulasek
cc1: warnings being treated as errors DPDK/app/test/test_cryptodev.c: In function 'test_snow3g_encrypted_authenti cation.clone.3': DPDK/x86_64-ivshmem-linuxapp-gcc/include/rte_memcpy.h:796:14: error: array subscript is above array bounds compilation terminated due to -Wfatal-errors. ROOT OF

[dpdk-dev] [PATCH] app/test: fix array subscript is above array bounds for gcc 4.5

2016-04-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tomasz Kulasek > Sent: Thursday, April 07, 2016 2:07 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] app/test: fix array subscript is above array > bounds for gcc 4.5 > > cc1: warnings being treated as

[dpdk-dev] Port 0 Link Down - L2fwd sample application

2016-04-07 Thread Vivek Gupta
I have installed DPDK 2.2 version and didn?t build source coe. From: Marc Sune [mailto:marcde...@gmail.com] Sent: Thursday, April 07, 2016 6:27 PM To: Vivek Gupta Cc: dev at dpdk.org Subject: Re: [dpdk-dev] Port 0 Link Down - L2fwd sample application 2016-04-07 14:50 GMT+02:00 Vivek Gupta

[dpdk-dev] [PATCH] l2fwd-crypto: fix coverity defect

2016-04-07 Thread Pablo de Lara
When parsing crypto device type, the string was being copied with strcpy(), which could overflow the destination buffer (which is 32 byte long), so snprintf() should be used instead. This fixes coverity issue 124575: /examples/l2fwd-crypto/main.c: 1005 in l2fwd_crypto_parse_args_long_options()

[dpdk-dev] Kernel panic in KNI

2016-04-07 Thread Matt Laswell
Hey Robert, Thanks for the insight. I work with Jay on the code he's asking about; we only have one mbuf pool that we use for all packets. Mostly, this is for the reasons that you describe, as well as for the sake of simplicity. As it happens, the stack trace we're seeing makes it look as

[dpdk-dev] [PATCH] app/test: fix array subscript is above array bounds for gcc 4.5

2016-04-07 Thread Kulasek, TomaszX
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, April 7, 2016 15:15 > To: Kulasek, TomaszX ; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH] app/test: fix array subscript is above > array bounds for gcc 4.5 > > > > > -Original Message- > > From: dev

[dpdk-dev] [PATCH v2] app/test: fix array subscript is above array bounds for gcc 4.5

2016-04-07 Thread Tomasz Kulasek
cc1: warnings being treated as errors DPDK/app/test/test_cryptodev.c: In function 'test_snow3g_encrypted_authenti cation.clone.3': DPDK/x86_64-ivshmem-linuxapp-gcc/include/rte_memcpy.h:796:14: error: array subscript is above array bounds compilation terminated due to -Wfatal-errors. ROOT OF

[dpdk-dev] [PATCH v2] app/test: fix array subscript is above array bounds for gcc 4.5

2016-04-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tomasz Kulasek > Sent: Thursday, April 07, 2016 3:02 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] app/test: fix array subscript is above array > bounds for gcc 4.5 > > cc1: warnings being treated

[dpdk-dev] Potential deadlock in KNI RX path

2016-04-07 Thread Ferruh Yigit
On 4/6/2016 9:22 PM, Jay Rolette wrote: > Over a year ago, Neil pointed out that calling netif_rx() from > kni_net_rx_normal() was a bug and could cause lockups. Here's the comment: > > http://dpdk.org/ml/archives/dev/2015-March/015783.html > > Looking at the current code base, it is still

[dpdk-dev] [RFC] vhost user: add error handling for fd > 1023

2016-04-07 Thread Christian Ehrhardt
Hi Patrick, On Tue, Apr 5, 2016 at 10:40 AM, Patrik Andersson R < patrik.r.andersson at ericsson.com> wrote: > > The described fault situation arises due to the fact that there is a bug > in an OpenStack component, Neutron or Nova, that fails to release ports > on VM deletion. This typically

[dpdk-dev] [PATCH] doc: new l2fwd-crypto sample app guide

2016-04-07 Thread Pablo de Lara
Signed-off-by: Pablo de Lara --- .../sample_app_ug/img/l2_fwd_encrypt_flow.svg | 194 + doc/guides/sample_app_ug/index.rst | 3 + doc/guides/sample_app_ug/l2_forward_crypto.rst | 467 + 3 files changed, 664 insertions(+) create mode 100644

[dpdk-dev] XEN netfront PMD support

2016-04-07 Thread Xie, Huawei
On 4/7/2016 3:52 PM, Thomas Monjalon wrote: > 2016-04-07 06:20, Xie, Huawei: >> Hi Stephen: >> I recall that you ever send a netfront PMD patch. I think that is one >> missing piece for running PMD in XEN domU. There are still users >> requiring that feature. Could you resend that patch? I could

[dpdk-dev] [PATCH] vhost: call rte_vhost_enable_guest_notification only on enabled queues

2016-04-07 Thread Loftus, Ciara
> On 4/7/2016 8:29 AM, Rich Lane wrote: > > If the vhost PMD were configured with more queues than the guest, the > old > > code would segfault in rte_vhost_enable_guest_notification due to a NULL > > virtqueue pointer. > > > > Fixes: ee584e9710b9 ("vhost: add driver on top of the library") > >

[dpdk-dev] [PATCH] doc: announce API changes for device objects

2016-04-07 Thread David Marchand
Following discussions with Jan, here is a deprecation notice to prepare for hotplug and rte_device changes to come in 16.07. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 12 1 file changed, 12 insertions(+) diff --git

[dpdk-dev] [PATCH] doc: announce API changes for device objects

2016-04-07 Thread Jan Viktorin
On Thu, 7 Apr 2016 17:33:17 +0200 David Marchand wrote: > Following discussions with Jan, here is a deprecation notice to prepare for > hotplug and rte_device changes to come in 16.07. > > Signed-off-by: David Marchand > --- > doc/guides/rel_notes/deprecation.rst | 12 > 1 file

[dpdk-dev] [PATCH] kni: fix possible deadlock

2016-04-07 Thread Ferruh Yigit
netif_rx() should be used in interrupt context. Replace it with netif_rx_ni() which is safe to use in process context. Signed-off-by: Ferruh Yigit --- lib/librte_eal/linuxapp/kni/kni_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/kni/kni_net.c

[dpdk-dev] [PATCH v1] doc: fix release notes for 16.04

2016-04-07 Thread John McNamara
Fix grammar, spelling and formatting of DPDK 16.04 release notes. Signed-off-by: John McNamara --- doc/guides/rel_notes/release_16_04.rst | 266 + 1 file changed, 104 insertions(+), 162 deletions(-) diff --git a/doc/guides/rel_notes/release_16_04.rst

[dpdk-dev] [PATCH] doc: new l2fwd-crypto sample app guide

2016-04-07 Thread Declan Doherty
On 07/04/16 15:49, Pablo de Lara wrote: > Signed-off-by: Pablo de Lara > --- > .../sample_app_ug/img/l2_fwd_encrypt_flow.svg | 194 + > doc/guides/sample_app_ug/index.rst | 3 + > doc/guides/sample_app_ug/l2_forward_crypto.rst | 467 > +

[dpdk-dev] [PATCH] l2fwd-crypto: fix coverity defect

2016-04-07 Thread Declan Doherty
On 07/04/16 14:23, Pablo de Lara wrote: > When parsing crypto device type, the string was being copied > with strcpy(), which could overflow the destination buffer > (which is 32 byte long), so snprintf() should be used instead. > > This fixes coverity issue 124575: > >

[dpdk-dev] [PATCH] doc: announce per queue stats support for ixgbe

2016-04-07 Thread Thomas Monjalon
2016-04-07 10:08, Wenzhuo Lu: > Fixes: 83a4a15404ef (doc: fill nics features matrix for e1000/igb and ixgbe) > > Reported-by: Thomas Monjalon > Signed-off-by: Wenzhuo Lu Applied, thanks

[dpdk-dev] [PATCH] doc: update nics features matrix for mlx

2016-04-07 Thread Thomas Monjalon
2016-04-07 12:34, Adrien Mazarguil: > Enable "other kdrv" because both NICs require kernel support to work. > > Unicast and multicast MAC filters are also enabled as both address types can > be filtered on through the MAC add/remove/set callbacks. > > Signed-off-by: Adrien Mazarguil Applied,

[dpdk-dev] [PATCH] examples: fix not all queues drained in l3fwd-*

2016-04-07 Thread Tomasz Kulasek
In l3fwd-acl and l3fwd-power not all tx ports was included in tx_port_id array, used to periodically drain only available ports. This caused that some packets can remain in buffer when application stops to receiving packets or when size of burst is small. Fixes: e2366e74e029 ("examples: use

[dpdk-dev] [PATCH v1] doc: fix release notes for 16.04

2016-04-07 Thread Thomas Monjalon
2016-04-07 17:02, John McNamara: > Fix grammar, spelling and formatting of DPDK 16.04 release notes. > > Signed-off-by: John McNamara Applied, thanks

[dpdk-dev] [PATCH] ethdev: fix CID 124557 unchecked return value

2016-04-07 Thread Thomas Monjalon
2016-04-07 13:46, Slawomir Mrozowicz: > It fix coverity issue: > CID 124557 (#1 of 1): Unchecked return value (CHECKED_RETURN) > 3. check_return: Calling rte_eth_tx_buffer_set_err_callback without checking > return value (as is done elsewhere 6 out of 7 times). Lines must be wrapped. > Fixes:

[dpdk-dev] vmxnet3 driver - vlan offload is on end descriptor

2016-04-07 Thread John Guzik
With the new jumbo frame patch a latent bug has appeared to have been uncovered: the VLAN offload is on the last rx descriptor, when rcd->eop is true, not the first rx descriptor, when rcd->sop is true and rcd->eop could be false. Most likely the reason this has not been seen before is that for

[dpdk-dev] [PATCH] doc: announce API changes for device objects

2016-04-07 Thread Jan Viktorin
On Thu, 7 Apr 2016 19:00:43 +0200 David Marchand wrote: > On Thu, Apr 7, 2016 at 5:46 PM, Jan Viktorin > wrote: > > On Thu, 7 Apr 2016 17:33:17 +0200 > > David Marchand wrote: > > > >> Following discussions with Jan, here is a deprecation notice to prepare for > >> hotplug and rte_device

[dpdk-dev] [PATCH v2] ivshmem: avoid infinite loop when concatenating adjacent segments

2016-04-07 Thread Thomas Monjalon
> This patch aligns the logic used to check for the presence of > adjacent segments in has_adjacent_segments() with the logic used > in cleanup_segments() when actually deciding to concatenate or > not a pair of segments. Additionally, adjacent segments are > no longer considered overlapping to

[dpdk-dev] [PATCH] vhost: call rte_vhost_enable_guest_notification only on enabled queues

2016-04-07 Thread Thomas Monjalon
> > If the vhost PMD were configured with more queues than the guest, the old > > code would segfault in rte_vhost_enable_guest_notification due to a NULL > > virtqueue pointer. > > > > Fixes: ee584e9710b9 ("vhost: add driver on top of the library") > > Signed-off-by: Rich Lane > > Acked-by:

[dpdk-dev] [PATCH] doc: announce API changes for device objects

2016-04-07 Thread David Marchand
On Thu, Apr 7, 2016 at 7:09 PM, Jan Viktorin wrote: > On Thu, 7 Apr 2016 19:00:43 +0200 > David Marchand wrote: >> >> Following discussions with Jan, here is a deprecation notice to prepare >> >> for >> >> hotplug and rte_device changes to come in 16.07. >> > As a result, the current rte_driver

[dpdk-dev] [PATCH] doc: announce API changes for device objects

2016-04-07 Thread Jan Viktorin
On Thu, 7 Apr 2016 17:33:17 +0200 David Marchand wrote: > Following discussions with Jan, here is a deprecation notice to prepare for > hotplug and rte_device changes to come in 16.07. > > Signed-off-by: David Marchand > --- Acked-by: Jan Viktorin

[dpdk-dev] [PATCH] kni: fix possible deadlock

2016-04-07 Thread Thomas Monjalon
2016-04-07 16:55, Ferruh Yigit: > netif_rx() should be used in interrupt context. Replace it with > netif_rx_ni() which is safe to use in process context. > > Signed-off-by: Ferruh Yigit Applied, thanks

[dpdk-dev] vmxnet3 driver - vlan offload is on end descriptor

2016-04-07 Thread Thomas Monjalon
2016-04-07 17:11, John Guzik: > With the new jumbo frame patch a latent bug has appeared to have been > uncovered: the VLAN offload is on the last rx descriptor, when rcd->eop is > true, not the first rx descriptor, when rcd->sop is true and rcd->eop could > be false. > Most likely the reason

[dpdk-dev] vmxnet3 driver - vlan offload is on end descriptor

2016-04-07 Thread Stephen Hemminger
On Thu, 7 Apr 2016 17:11:19 + John Guzik wrote: > With the new jumbo frame patch a latent bug has appeared to have been > uncovered: the VLAN offload is on the last rx descriptor, when rcd->eop is > true, not the first rx descriptor, when rcd->sop is true and rcd->eop could > be false. >

[dpdk-dev] [PATCH v2] app/test: fix array subscript is above array bounds for gcc 4.5

2016-04-07 Thread Thomas Monjalon
> > Using uint8_t as a size of copied block prevents to evaluate in rte_memcpy > > code for length bigger than 255, causing the problem. > > > > v2 changes: > > - added fixline > > > > Fixes: 8bdf665fe6c0 ("app/test: add SNOW 3G") > > > > Signed-off-by: Tomasz Kulasek > > Acked-by: Pablo de

[dpdk-dev] [PATCH] l2fwd-crypto: fix coverity defect

2016-04-07 Thread Thomas Monjalon
> > When parsing crypto device type, the string was being copied > > with strcpy(), which could overflow the destination buffer > > (which is 32 byte long), so snprintf() should be used instead. > > > > This fixes coverity issue 124575: [...] > > Fixes: commit 49f79e86480d ("examples/l2fwd-crypto:

[dpdk-dev] Potential deadlock in KNI RX path

2016-04-07 Thread Jay Rolette
On Thu, Apr 7, 2016 at 9:33 AM, Ferruh Yigit wrote: > On 4/6/2016 9:22 PM, Jay Rolette wrote: > > Over a year ago, Neil pointed out that calling netif_rx() from > > kni_net_rx_normal() was a bug and could cause lockups. Here's the > comment: > > > >

[dpdk-dev] ethdev: replacement for rte_pci_dev_ids.h?

2016-04-07 Thread Sean Hope (shope)
Hello, I see that rte_pci_dev_ids.h has been removed. We are using it on our product to get supported device ids. I understand the desire to move that data out of a central place and into each driver. Any chance that instead of living in a .c file, that each driver could hold it in a .h file so

[dpdk-dev] vmxnet3 driver - vlan offload is on end descriptor

2016-04-07 Thread Yong Wang
On 4/7/16, 10:34 AM, "Thomas Monjalon" wrote: >2016-04-07 17:11, John Guzik: >> With the new jumbo frame patch a latent bug has appeared to have been >> uncovered: the VLAN offload is on the last rx descriptor, when rcd->eop is >> true, not the first rx descriptor, when rcd->sop is true and

[dpdk-dev] [PATCH] bnx2x: Update documentation

2016-04-07 Thread Rasesh Mody
Please apply the documentation patch for 16.04. Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst|1 + doc/guides/nics/overview.rst | 20 ++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst

[dpdk-dev] ethdev: replacement for rte_pci_dev_ids.h?

2016-04-07 Thread Thomas Monjalon
2016-04-07 18:10, Sean Hope: > Hello, > > I see that rte_pci_dev_ids.h has been removed. No it has not been removed (yet): http://dpdk.org/browse/dpdk/tree/lib/librte_eal/common/include/rte_pci_dev_ids.h > We are using it on our product to get supported device ids. > > I understand

[dpdk-dev] Packet drops at lower tc transmit-rates.

2016-04-07 Thread Sridhar.V.Iyer
Hi all, We are using DPDK 1.7 in our application. We are running into an issue where a lower transmit-rate configured at the traffic class of a subport is causing complete packet drops. Here are few parameters to clear up some context: Packet length = 728 byte Port rate

[dpdk-dev] [PATCH v1] doc: fix spellings

2016-04-07 Thread John McNamara
Fix some spelling errors and typos. Signed-off-by: John McNamara --- doc/guides/nics/i40e.rst | 2 +- doc/guides/nics/ixgbe.rst | 4 ++-- doc/guides/sample_app_ug/ipsec_secgw.rst | 6 +++--- doc/guides/sample_app_ug/l2_forward_cat.rst| 2 +-

[dpdk-dev] DPDK namespace

2016-04-07 Thread Matthew Hall
On Thu, Apr 07, 2016 at 12:16:34PM +0200, Marc Sune wrote: > I keep not understanding the ABI policy, and particularly why ABI changes > have to be announced once cycle before _if_ there is already at least one > ABI change proposed. DPDK applications will have to recompile anyway. > > This

[dpdk-dev] On DPDK ABI policy

2016-04-07 Thread Matthew Hall
On Thu, Apr 07, 2016 at 02:51:35PM +0300, Panu Matilainen wrote: > LTS releases could help the situation somewhat, but then again > people tend to still want those new fancy things backported (you > know, have the cake and eat it too) but that can't be done because > of ABI breakage, so they're

[dpdk-dev] [PATCH] ixgbe: checkpatch cleanups

2016-04-07 Thread Stephen Hemminger
Run ixgbe driver through checkpatch and edit away all the nasty bits. Fix line spacing, some bad indentation, and in a couple of cases use short circuit (already there) return to lessen indentation. Signed-off-by: Stephen Hemminger --- v2 - fix more things found by checkpatch