[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

2016-06-14 Thread Michael S. Tsirkin
On Mon, May 09, 2016 at 11:22:04AM -0700, Yuanhan Liu wrote: > On Mon, May 09, 2016 at 04:25:38PM +, Xie, Huawei wrote: > > On 5/7/2016 2:36 PM, Yuanhan Liu wrote: > > > However, Michael claims some concerns: he made a good point: a crash > > > is happening means some memory is corrupted, and

[dpdk-dev] [PATCH v4 2/8] lib/librte_ether: defind RX/TX lock mode

2016-06-14 Thread Lu, Wenzhuo
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, June 13, 2016 6:48 PM > To: Lu, Wenzhuo; Tao, Zhe; dev at dpdk.org > Cc: Richardson, Bruce; Chen, Jing D; Liang, Cunming; Wu, Jingjing; Zhang, > Helin > Subject: RE: [PATCH v4 2/8] lib/librte_ether: defind

[dpdk-dev] [PATCH 29/29] ixgbe/base: update README

2016-06-14 Thread Xing, Beilei
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, June 14, 2016 12:29 AM > To: Xing, Beilei ; Zhang, Helin > > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 29/29] ixgbe/base: update README > > On 5/6/2016 7:07 AM, Beilei Xing wrote: > > update README. > It

[dpdk-dev] [PATCH v2] i40e: fix VLAN filter in promiscuous mode

2016-06-14 Thread Jingjing Wu
VLAN filter didn't work if promiscuous mode is enabled. That is because i40e driver uses MAC VLAN table for the l2 filtering and internal switch. And the VLAN table is disabled by default. So in promiscuous mode, the VSI can receive packets if they don't match any entry in MAC VLAN table, even

[dpdk-dev] [PATCH v2] i40e: modify the meaning of single VLAN type

2016-06-14 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Monday, June 13, 2016 4:04 PM > To: Wu, Jingjing > Cc: dev at dpdk.org; Xing, Beilei > Subject: [PATCH v2] i40e: modify the meaning of single VLAN type > > In current i40e codebase, if single VLAN header is added in a packet, > it's

[dpdk-dev] [PATCH v10 0/3] i40e: add floating VEB support for i40e

2016-06-14 Thread Wu, Jingjing
> -Original Message- > From: Tao, Zhe > Sent: Monday, June 13, 2016 4:03 PM > To: dev at dpdk.org > Cc: Tao, Zhe ; Wu, Jingjing > Subject: [PATCH v10 0/3] i40e: add floating VEB support for i40e > > This patch-set add the support for floating VEB in i40e. > All the VFs VSIs can decide

[dpdk-dev] [PATCH v1 02/28] eal: extract function eal_parse_sysfs_valuef

2016-06-14 Thread Shreyansh Jain
Hi Jan, > -Original Message- > From: Jan Viktorin [mailto:viktorin at rehivetech.com] > Sent: Monday, June 13, 2016 7:55 PM > To: Shreyansh Jain > Cc: dev at dpdk.org; David Marchand ; Thomas > Monjalon > ; Bruce Richardson intel.com>; > Declan Doherty ; jianbo.liu at linaro.org; >

[dpdk-dev] [PATCH] fm10k: fix VF cannot receive broadcast traffic

2016-06-14 Thread Chen, Jing D
Hi, > -Original Message- > From: Wang, Xiao W > Sent: Monday, June 06, 2016 5:01 PM > To: Chen, Jing D > Cc: dev at dpdk.org; Wang, Xiao W > Subject: [PATCH] fm10k: fix VF cannot receive broadcast traffic > > When app tries promisc/allmulti setting, fm10k will check if a valid glort >

[dpdk-dev] [PATCH v3] i40e: fix olflags for vector Rx

2016-06-14 Thread Zhe Tao
Problem: The flag for RSS and flow director is not set correctly in the vector Rx function, so the upper layer APP which base on the related flags will not work correctly. Fix this problem by change the shuffle table. the original shuffle table is not correct. Fixes: 9ed94e5bb04e ("i40e: add

[dpdk-dev] [PATCH v11 0/3] i40e: add floating VEB support for i40e

2016-06-14 Thread Zhe Tao
This patch-set add the support for floating VEB in i40e. All the VFs VSIs can decide whether to connect to the legacy VEB/VEPA or the floating VEB. When connect to the floating VEB a new floating VEB is created. Now all the VFs need to connect to floating VEB or legacy VEB, cannot connect to both

[dpdk-dev] [PATCH v11 1/3] i40e: support floating VEB config

2016-06-14 Thread Zhe Tao
Add the new floating related argument option in the devarg. Using this parameter, all the samples can decide whether to use legacy VEB/VEPA or floating VEB. To enable this feature, the user should pass a devargs parameter to the EAL like "-w 84:00.0,enable_floatingVEB=1", and the application will

[dpdk-dev] [PATCH v11 2/3] i40e: add floating VEB support in i40e

2016-06-14 Thread Zhe Tao
This patch add the support for floating VEB in i40e. All the VFs VSIs can decide whether to connect to the legacy VEB/VEPA or the floating VEB. When connect to the floating VEB a new floating VEB is created. Now all the VFs need to connect to floating VEB or legacy VEB, cannot connect to both of

[dpdk-dev] [PATCH v11 3/3] i40e: add floating VEB extension support

2016-06-14 Thread Zhe Tao
To enable this feature, the user should pass a devargs parameter to the EAL like "-w 84:00.0,enable_floatingVEB=1", and the application will make sure the PMD will use the floating VEB feature for all the VFs created by this PF device. Also you can specifiy which VF need to connect to this

[dpdk-dev] [PATCH v11 0/3] i40e: add floating VEB support for i40e

2016-06-14 Thread Zhe Tao
On Tue, Jun 14, 2016 at 01:57:11PM +0800, Zhe Tao wrote: > This patch-set add the support for floating VEB in i40e. > All the VFs VSIs can decide whether to connect to the legacy VEB/VEPA or > the floating VEB. When connect to the floating VEB a new floating VEB is > created. Now all the VFs need

[dpdk-dev] [PATCH 00/24] Refactor mlx5 to improve performance

2016-06-14 Thread NĂ©lio Laranjeiro
On Mon, Jun 13, 2016 at 11:50:48AM -0700, Javier Blazquez wrote: >[...] > This is a very exciting patch. I applied it and reran some microbenchmarks > of mine that test the TX and RX paths separately. These are the results I > got: > > TX path (burst = 64 packets) > > 1 thread - 2 ports - 4

[dpdk-dev] [PATCH v2 00/30] ixgbe/base: update base driver

2016-06-14 Thread Beilei Xing
Update base driver for ixgbe, mainly work on new features and bug fixes. v2 changes: Fix typos and update commit log. Separate [patch 18/29] into two patches. Beilei Xing (30): ixgbe/base: add new VF requests for mailbox API ixgbe/base: add sgmii link for X550 ixgbe/base: fix problematic

[dpdk-dev] [PATCH v2 01/30] ixgbe/base: add new VF requests for mailbox API

2016-06-14 Thread Beilei Xing
It adds two new VF requests of IXGBE_VF_GET_RETA and IXGBE_VF_GET_RSS_KEY for mailbox API. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_mbx.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_mbx.h

[dpdk-dev] [PATCH v2 03/30] ixgbe/base: fix problematic return value

2016-06-14 Thread Beilei Xing
An error code indicating that the PF rejects the MAC address change should be returned, in case that the PF has already assigned a MAC for the VF. Fixes: af75078fece3 ("first public release") Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_vf.c | 4 +++- 1 file changed, 3

[dpdk-dev] [PATCH v2 04/30] ixgbe/base: add mac link setup for x550a SFP

2016-06-14 Thread Beilei Xing
This patch adds ixgbe_setup_mac_link_sfp_x550a for x550a SFP. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_type.h | 4 +++ drivers/net/ixgbe/base/ixgbe_x550.c | 64 - drivers/net/ixgbe/base/ixgbe_x550.h | 3 ++ 3 files changed, 70

[dpdk-dev] [PATCH v2 05/30] ixgbe/base: fix checksum error of checking PHY token

2016-06-14 Thread Beilei Xing
This patch sets the Host Interface PHY token command checksum to the checksum default of 0xFF, therefore the checksum is not checked by the firmware. Otherwise the command fails with a checksum failed error. Fixes: 86b8fb293fdf ("ixgbe/base: add sw-firmware sync for resource sharing")

[dpdk-dev] [PATCH v2 06/30] ixgbe/base: refactor eee setup for x550

2016-06-14 Thread Beilei Xing
Break ixgbe_setup_eee_X550 down to better handle a change from if statements to switch statements needed to add X550EM_A KR support. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_x550.c | 174 ++-- 1 file changed, 105 insertions(+), 69 deletions(-)

[dpdk-dev] [PATCH v2 07/30] ixgbe/base: change access method

2016-06-14 Thread Beilei Xing
Use the method pointers instead of direct function calls so that the right thing will happen on X550EM_a. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_x550.c | 84 ++--- 1 file changed, 42 insertions(+), 42 deletions(-) diff --git

[dpdk-dev] [PATCH v2 08/30] ixgbe/base: add KR support for X550EM_A devices

2016-06-14 Thread Beilei Xing
Implement KR support for X550EM_A devices. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_x550.c | 51 + 1 file changed, 41 insertions(+), 10 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c

[dpdk-dev] [PATCH v2 10/30] ixgbe/base: clear stale pool mappings

2016-06-14 Thread Beilei Xing
This patch adds clearing the pool mappings when configuring default MAC addresses for the interface. Without this there will be the risk of leaking an address into pool 0 which really belongs to VF 0 when SR-IOV is enabled. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_82599.c |

[dpdk-dev] [PATCH v2 11/30] ixgbe/base: rename macro of TDL

2016-06-14 Thread Beilei Xing
This patch renames IXGBE_PVFTTDLEN to IXGBE_PVFTDLEN according to abbreviation of Transmit Descriptor Length in datasheet. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_type.h

[dpdk-dev] [PATCH v2 09/30] ixgbe/base: add link mac setup for x550a SFP+

2016-06-14 Thread Beilei Xing
This patch updates ixgbe_setup_mac_link_sfp_x550a for x550 SFP+. ixgbe_set_lan_id_multi_port_pcie has been updated to set the MAC instance(0/1) which is needed when configuring the external PHY, since x550a has two instances of MGPK. The MAC instance is read from the EEPROM. Signed-off-by: Beilei

[dpdk-dev] [PATCH v2 13/30] ixgbe/base: fix for code style

2016-06-14 Thread Beilei Xing
The ixgbe_vf.h file did not use __ and instead used which is not the standard used in every other file. Fixes: af75078fece3 ("first public release") Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_vf.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH v2 12/30] ixgbe/base: fix error path to release lock

2016-06-14 Thread Beilei Xing
When there is an error getting the PHY token, the error path fails to release the locks that it has taken. Release those locks in that failure case. Fixes: 86b8fb293fdf ("ixgbe/base: add sw-firmware sync for resource sharing) Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_x550.c |

[dpdk-dev] [PATCH v2 14/30] ixgbe/base: fix firmware commands on x550em_a

2016-06-14 Thread Beilei Xing
This patch fixes firmware commands on x550em_a. For one thing, the checksum value was not being set. Fixes: 0790adeb5675 ("ixgbe/base: support X550em_a device") Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_x550.c | 19 ++- 1 file changed, 10 insertions(+), 9

[dpdk-dev] [PATCH v2 16/30] ixgbe/base: add new phy definitions

2016-06-14 Thread Beilei Xing
It adds new phy definitions. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_phy.c | 16 +- drivers/net/ixgbe/base/ixgbe_type.h | 14 +- drivers/net/ixgbe/base/ixgbe_x550.c | 303 ++-- drivers/net/ixgbe/base/ixgbe_x550.h | 43 + 4 files

[dpdk-dev] [PATCH v2 18/30] ixgbe/base: add function to reset swfw semaphore

2016-06-14 Thread Beilei Xing
For X540 and forward it is possible if a system reset occur at the right time to leave the SWFW semaphore high. This new function will attempt to grab and release the semaphore. If the grab times out it will still release the semaphore placing it in a known good state. The idea is to call this

[dpdk-dev] [PATCH v2 17/30] ixgbe/base: change device IDs

2016-06-14 Thread Beilei Xing
There're two device IDs changed from 15C6/15C7 to 15E4/15E5 cause PHY info changes. Make the change and use 15C6/15C7 for the backplane SGMII. Clean up some discovery kludges from the previous shared ID, and also add 15C6/15C7 to ixgbe_set_mdio_speed just for paranoia to control MDIO speed even

[dpdk-dev] [PATCH v2 19/30] ixgbe/base: fix possible race issue

2016-06-14 Thread Beilei Xing
This patch fixes possible race issue between ports when issuing host interface command by acquiring/releasing the management host interface semaphore in ixgbe_host_interface_command. Fixes: 36f43e8679ae ("ixgbe/base: refactor manageability block communication") Signed-off-by: Beilei Xing ---

[dpdk-dev] [PATCH v2 21/30] ixgbe/base: limit PHY token accessing to MDIO only

2016-06-14 Thread Beilei Xing
This patch limits getting and putting the PHY Token to PHY MDIO access only by adding ixgbe_read_phy_reg_x550a and ixgbe_write_phy_reg_x550a. The PHY Token is only needed to synchronize access to the MDIO shared between the two MAC instance. Signed-off-by: Beilei Xing ---

[dpdk-dev] [PATCH v2 23/30] ixgbe/base: add bypassing VLVF

2016-06-14 Thread Beilei Xing
This patch adds support for the VLVF to be bypassed when adding or removing a VFTA entry. The PF can utilize the default pool while preserving the VLVF for the VFs use. Meanwhile, update corresponding VF ops and drivers where corresponding ops is invoked. Signed-off-by: Beilei Xing ---

[dpdk-dev] [PATCH v2 26/30] ixgbe/base: fix endianness issues

2016-06-14 Thread Beilei Xing
This patch fixes endianness issues about host interface command. Fixes: ad66a85dce9a ("ixgbe/base: new FW values") Fixes: 0790adeb5675 ("ixgbe/base: support X550em_a device") Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_osdep.h | 1 + drivers/net/ixgbe/base/ixgbe_type.h | 17

[dpdk-dev] [PATCH v2 25/30] ixgbe/base: use u8 to replace u16 for a variable

2016-06-14 Thread Beilei Xing
Since PCIe standard defines maximum of 8 functions per device lan_id is a value 0..7. Because of that, lan_id don't need to be u16. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_common.c | 2 +- drivers/net/ixgbe/base/ixgbe_type.h | 2 +- 2 files changed, 2 insertions(+), 2

[dpdk-dev] [PATCH v2 29/30] ixgbe/base: define if enable crosstalk work around

2016-06-14 Thread Beilei Xing
A work around for a new crosstalk erratum that causes link flap in entry cages has been introduced. So this patch defines the bit in NVM that will tell software if this work around is needed. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_type.h | 1 + 1 file changed, 1

[dpdk-dev] [PATCH v2 22/30] ixgbe/base: simplify add/remove VLANs

2016-06-14 Thread Beilei Xing
This patch simplifies the adding and removing VLANs from VFTA/VLVF/VLVFB registers. The logic to determine registers has been simplified to (vid / 32) and (1 - vid / 32). Many conditional paths and checks are no longer needed with this patch. Signed-off-by: Beilei Xing ---

[dpdk-dev] [PATCH v2 30/30] ixgbe/base: update README

2016-06-14 Thread Beilei Xing
The ixgbe base driver was updated according to version cid-10g-shared-code.2016.04.12 released by ND. The changes include: Added sgmii link for X550. Added mac link setup for x550a SFP and SFP+. Added KR support for x550em_a. Added new phy definitions for M88E1500. Added support for the VLVF to

[dpdk-dev] [PATCH v2 20/30] ixgbe/base: fix register access error

2016-06-14 Thread Beilei Xing
This patch corrects the FLA/GSCL/GSCN access offset value according to the datasheet. Fixes: 0790adeb5675 ("ixgbe/base: support X550em_a device") Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_type.h | 42 - 1 file changed, 41 insertions(+), 1

[dpdk-dev] [PATCH v2 15/30] ixgbe/base: refactor NW management interface ops

2016-06-14 Thread Beilei Xing
This patch adds ixgbe_read_mng_if_sel_x550em to read NW_MNG_IF_SEL register and save fields such as PHY MDIO_ADD. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_type.h | 2 ++ drivers/net/ixgbe/base/ixgbe_x550.c | 48 +++-- 2 files changed, 32

[dpdk-dev] [PATCH v2 24/30] ixgbe/base: unify coding style

2016-06-14 Thread Beilei Xing
This patch changes static keyword to STATIC definition, which can be redefined depending on the compiler used. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_x550.c | 38 ++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git

[dpdk-dev] [PATCH v2 28/30] ixgbe/base: add flow control autoneg for x550a

2016-06-14 Thread Beilei Xing
This patch adds x550a flow control auto negotiation support. ixgbe_setup_fc_x550a and ixgbe_fc_autoneg_X550a functions where added to setup and enable flow control. MAC ops function pointer fc_autoneg was added so that hardware specific fc autoneg functions can be called from

[dpdk-dev] [PATCH v2 27/30] ixgbe/base: allow setting mac anti spoofing per vf

2016-06-14 Thread Beilei Xing
Make ixgbe_set_mac_anti_spoofing() consistent with the other functions that deal with setting VLAN and Ethertype spoofing by changing the prototype to accept a VF parameter. Also change the logic for writing the PFVFSPOOF register to be similar to the MAC and Ethertype functions. Signed-off-by:

[dpdk-dev] [PATCH v2 02/30] ixgbe/base: add sgmii link for X550

2016-06-14 Thread Beilei Xing
It adds sgmii link for X550. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_type.h | 9 +++ drivers/net/ixgbe/base/ixgbe_x550.c | 127 +--- 2 files changed, 127 insertions(+), 9 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_type.h

[dpdk-dev] Performance hit - NICs on different CPU sockets

2016-06-14 Thread Take Ceara
Hi Keith, On Mon, Jun 13, 2016 at 9:35 PM, Wiles, Keith wrote: > > On 6/13/16, 9:07 AM, "dev on behalf of Take Ceara" on behalf of dumitru.ceara at gmail.com> wrote: > >>Hi, >> >>I'm reposting here as I didn't get any answers on the dpdk-users mailing list. >> >>We're working on a stateful

[dpdk-dev] Performance hit - NICs on different CPU sockets

2016-06-14 Thread Take Ceara
Hi Bruce, On Mon, Jun 13, 2016 at 4:28 PM, Bruce Richardson wrote: > On Mon, Jun 13, 2016 at 04:07:37PM +0200, Take Ceara wrote: >> Hi, >> >> I'm reposting here as I didn't get any answers on the dpdk-users mailing >> list. >> >> We're working on a stateful traffic generator (www.warp17.net)

[dpdk-dev] [PATCH v3] ixgbe: configure VLAN TPID

2016-06-14 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Xing, Beilei > Sent: Tuesday, June 14, 2016 3:21 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org; Xing, Beilei > Subject: [PATCH v3] ixgbe: configure VLAN TPID > > The patch enables configuring the ether types of both inner and outer > VLANs. > >

[dpdk-dev] [PATCH v3] eal: out-of-bounds write

2016-06-14 Thread Slawomir Mrozowicz
Overrunning array mcfg->memseg of 256 44-byte elements at element index 257 using index j. Fixed by add condition with message information. Fixes: af75078fece3 ("first public release") Coverity ID 13282 Signed-off-by: Slawomir Mrozowicz --- lib/librte_eal/linuxapp/eal/eal_memory.c | 19

[dpdk-dev] [PATCH v5 00/10] Include resources in tests

2016-06-14 Thread Hunt, David
On 13/6/2016 7:32 PM, Thomas Monjalon wrote: >> Jan Viktorin (10): >>app/test: introduce resources for tests >>mk: define objcopy-specific target and arch >>app/test: support resources externally linked >>app/test: add functions to create files from resources >>app/test:

[dpdk-dev] [PATCH v8 0/6] virtio support for container

2016-06-14 Thread Yuanhan Liu
Series Acked-by: Yuanhan Liu --yliu On Mon, Jun 13, 2016 at 06:38:57AM +, Jianfeng Tan wrote: > v8: > - Change to use max_queue_pairs instead of queue_pairs to initialize >and deinitialize queues. > - Remove vhost-kernel support. > > v7: > - CONFIG_RTE_VIRTIO_VDEV ->

[dpdk-dev] [PATCH v2] mbuf: new flag when Vlan is stripped

2016-06-14 Thread Olivier MATZ
Hi Konstantin, On 06/13/2016 06:31 PM, Ananyev, Konstantin wrote: > > Hi Olivier, > >> >> Hi Konstantin, >> >> On 06/13/2016 04:42 PM, Ananyev, Konstantin wrote: The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting in PMDs not advertising the same flags in similar

[dpdk-dev] [PATCH v5 00/10] Include resources in tests

2016-06-14 Thread Thomas Monjalon
2016-06-14 09:23, Hunt, David: > > On 13/6/2016 7:32 PM, Thomas Monjalon wrote: > >> Jan Viktorin (10): > >>app/test: introduce resources for tests > >>mk: define objcopy-specific target and arch > >>app/test: support resources externally linked > >>app/test: add functions to

[dpdk-dev] [PATCH v4 2/8] lib/librte_ether: defind RX/TX lock mode

2016-06-14 Thread Ananyev, Konstantin
Hi Wenzhuo, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 3. I thought the plan was to introduce a locking in all > > > > > > > > appropriate control path functions (dev_start/dev_stop etc.) > > > > > > > > Without that locking version of RX/TX seems a bit useless. > > > > > >

[dpdk-dev] [PATCH v3] i40e: fix olflags for vector Rx

2016-06-14 Thread Azarewicz, PiotrX T
> Problem: > The flag for RSS and flow director is not set correctly in the vector Rx > function, so the upper layer APP which base on the related flags will not work > correctly. > > Fix this problem by change the shuffle table. the original shuffle table is > not > correct. > > Fixes:

[dpdk-dev] [PATCH v2 1/2] mempool: allow for user-owned mempool caches

2016-06-14 Thread Lazaros Koromilas
Hi Olivier, I have it in my queue, I'll do my best to have it before the deadline. Thanks! Lazaros. On Mon, Jun 13, 2016 at 1:21 PM, Olivier Matz wrote: > Hi Lazaros, > > On 05/11/2016 11:56 AM, Olivier MATZ wrote: >> Hi Lazaros, >> >> Sorry for the late review. Please find some comments, >>

[dpdk-dev] [PATCH] config: make libarchive optional

2016-06-14 Thread Thomas Monjalon
The commit 66819e6 has introduced a dependency on libarchive to be able to use some tar resources in the unit tests. It is now an optional dependency because some systems do not have it installed. If CONFIG_RTE_APP_TEST_RESOURCE_TAR is disabled, the PCI test will not be run. When a "configure"

[dpdk-dev] [PATCH v2] mbuf: new flag when Vlan is stripped

2016-06-14 Thread Ananyev, Konstantin
Hi Olivier > > Hi Konstantin, > > On 06/13/2016 06:31 PM, Ananyev, Konstantin wrote: > > > > Hi Olivier, > > > >> > >> Hi Konstantin, > >> > >> On 06/13/2016 04:42 PM, Ananyev, Konstantin wrote: > The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting in > PMDs not

[dpdk-dev] [PATCH v3 4/9] app/testpmd: remove fwd_config_setup from fwd_config_display

2016-06-14 Thread Iremonger, Bernard
Hi Pablo, > > > Subject: [PATCH v3 4/9] app/testpmd: remove fwd_config_setup from > > > fwd_config_display > > > > > > Remove fwd_config_setup from fwd_config_display and check that > > > forwarding has been setup before displaying forwarding configuration. > > > Add call to fwd_config_setup

[dpdk-dev] [PATCH] mlx: fix compilation with older Glibc

2016-06-14 Thread Adrien Mazarguil
A missing define in the previous patch causes additional compilation issues. Fixes: 3025206f5060 ("mlx: fix compilation with recent Glibc") Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile | 1 + drivers/net/mlx5/Makefile | 1 + 2 files changed, 2 insertions(+) diff --git

[dpdk-dev] [PATCH v3] eal: out-of-bounds write

2016-06-14 Thread Sergio Gonzalez Monroy
On 14/06/2016 10:02, Slawomir Mrozowicz wrote: > Overrunning array mcfg->memseg of 256 44-byte elements > at element index 257 using index j. > Fixed by add condition with message information. > > Fixes: af75078fece3 ("first public release") > Coverity ID 13282 > > Signed-off-by: Slawomir

[dpdk-dev] [PATCH v2] mbuf: new flag when Vlan is stripped

2016-06-14 Thread Olivier MATZ
On 06/14/2016 11:15 AM, Ananyev, Konstantin wrote: If we decide to generalize the ixgbe behavior for all PMDs for this flag, it will break the applications relying on this flag but with other PMDs. So for the same reason we added a new PKT_RX_VLAN_STRIPPED we cannot change

[dpdk-dev] [PATCH v9 0/8] add packet capture framework

2016-06-14 Thread Reshma Pattan
This patch set include below changes 1)Changes to librte_ether. 2)A new library librte_pdump added for packet capture framework. 3)A new app/pdump tool added for packet capturing. 4)Test pmd changes done to initialize packet capture framework. 5)Documentation update. 1)librte_pdump

[dpdk-dev] [PATCH v9 2/8] ethdev: add new api to add Rx callback as head of the list

2016-06-14 Thread Reshma Pattan
Added new public api rte_eth_add_first_rx_callback to add given callback as head of the list. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 35 ++ lib/librte_ether/rte_ethdev.h | 28 +++

[dpdk-dev] [PATCH v9 4/8] ethdev: make get port by name and get name by port public

2016-06-14 Thread Reshma Pattan
Converted rte_eth_dev_get_port_by_name to a public API. Converted rte_eth_dev_get_name_by_port to a public API. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 4 ++-- lib/librte_ether/rte_ethdev.h | 29 +

[dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet capturing support

2016-06-14 Thread Reshma Pattan
The new librte_pdump library is added for packet capturing support. Added public api rte_pdump_init, applications should call this as part of their application setup to have packet capturing framework ready. Added public api rte_pdump_uninit to uninitialize the packet capturing framework. Added

[dpdk-dev] [PATCH v9 6/8] app/pdump: add pdump tool for packet capturing

2016-06-14 Thread Reshma Pattan
New tool added for packet capturing on dpdk. This tool supports command line options. This tool runs as secondary process by default. Command line supports various parameters to capture the packets. User should pass on a)port and queue (or) b)pci address and queue (or) c)device name and queue to

[dpdk-dev] [PATCH v9 1/8] ethdev: use locks to protect Rx/Tx callback lists

2016-06-14 Thread Reshma Pattan
Added spinlocks around add/remove logic of Rx and Tx callbacks to avoid corruption of callback lists in multithreaded context. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 82 +-- 1 file changed, 40 insertions(+), 42 deletions(-) diff

[dpdk-dev] [PATCH v9 3/8] ethdev: add new fields to ethdev info struct

2016-06-14 Thread Reshma Pattan
New fields nb_rx_queues and nb_tx_queues are added to rte_eth_dev_info structure. Changes to API rte_eth_dev_info_get() are done to update these new fields to rte_eth_dev_info object. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 2 ++ lib/librte_ether/rte_ethdev.h

[dpdk-dev] [PATCH v9 7/8] app/testpmd: add pdump initialization uninitialization

2016-06-14 Thread Reshma Pattan
Call rte_pdump_init and rte_pdump_uninit for packet capturing initialization and uninitialization. Signed-off-by: Reshma Pattan --- app/test-pmd/testpmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index dd6b046..9707cfc 100644 ---

[dpdk-dev] [PATCH v9 8/8] doc: update doc for packet capture framework

2016-06-14 Thread Reshma Pattan
Added programmers guide for librte_pdump. Added sample application guide for app/pdump application. Updated release note for packet capture framework changes. Signed-off-by: Reshma Pattan Acked-by: John McNamara --- MAINTAINERS | 3 +

[dpdk-dev] [PATCH] config: make libarchive optional

2016-06-14 Thread Jan Viktorin
Hello Thomas, On Tue, 14 Jun 2016 10:59:49 +0200 Thomas Monjalon wrote: > The commit 66819e6 has introduced a dependency on libarchive to be able > to use some tar resources in the unit tests. > It is now an optional dependency because some systems do not have it > installed. I am surprised

[dpdk-dev] [PATCH v10 0/3] mempool: add external mempool manager

2016-06-14 Thread David Hunt
Here's the latest version of the External Mempool Manager patchset. It's re-based on top of the latest head as of 14/6/2016, including Olivier's 35-part patch series on mempool re-org [1] [1] http://dpdk.org/ml/archives/dev/2016-May/039229.html v10 changes: * changed the _put/_get op names to

[dpdk-dev] [PATCH v10 1/3] mempool: support external mempool operations

2016-06-14 Thread David Hunt
Until now, the objects stored in a mempool were internally stored in a ring. This patch introduces the possibility to register external handlers replacing the ring. The default behavior remains unchanged, but calling the new function rte_mempool_set_handler() right after

[dpdk-dev] [PATCH v10 2/3] app/test: test external mempool manager

2016-06-14 Thread David Hunt
Use a minimal custom mempool external ops and check that it also passes basic mempool autotests. Signed-off-by: Olivier Matz Signed-off-by: David Hunt --- app/test/test_mempool.c | 122 +++- 1 file changed, 120 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH v10 3/3] mbuf: make default mempool ops configurable at build

2016-06-14 Thread David Hunt
By default, the mempool ops used for mbuf allocations is a multi producer and multi consumer ring. We could imagine a target (maybe some network processors?) that provides an hardware-assisted pool mechanism. In this case, the default configuration for this architecture would contain a different

[dpdk-dev] [PATCH] config: make libarchive optional

2016-06-14 Thread Thomas Monjalon
2016-06-14 11:33, Jan Viktorin: > Thomas Monjalon wrote: > > +ifeq ($(CONFIG_RTE_APP_TEST_RESOURCE_TAR),y) > > +$(eval $(call linked_tar_resource,test_resource_tar,test_resource.c)) > > +SRCS-y += test_pci.c > > +$(eval $(call linked_tar_resource,test_pci_sysfs,test_pci_sysfs)) > > +LDLIBS +=

[dpdk-dev] [PATCH] mlx: fix icc compilation error

2016-06-14 Thread Ferruh Yigit
Compilation errors: mlx4: CC mlx4.o .../dpdk/drivers/net/mlx4/mlx4.c(5409): error #188: enumerated type mixed with another type priv->intr_handle.type = 0; ^ mlx5: CC em_rxtx.o .../dpdk/drivers/net/mlx5/mlx5_rxq.c(282): error #188: enumerated

[dpdk-dev] [PATCH v5 0/2] app/test: rework crypto AES unit test

2016-06-14 Thread Fan Zhang
This patchset reworks the crypto AES unit test by introducing a new unified test function. This patchset depends on the following patches/patchsets: "qat: fix phys address of content descriptor" (http://dpdk.org/dev/patchwork/patch/13137/) and "Add AES Counter mode support for AES-NI MB PMD"

[dpdk-dev] [PATCH v5 2/2] app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit tests

2016-06-14 Thread Fan Zhang
This patch adds the HMAC-SHA224 and HMAC-SHA384 digest generation and verification tests to crypto Signed-off-by: Fan Zhang --- app/test/test_cryptodev_aes.c | 26 app/test/test_cryptodev_aes.h | 296 ++ 2 files changed, 322 insertions(+) diff

[dpdk-dev] [PATCH v5 1/2] app/test: reworks the crypto AES unit test

2016-06-14 Thread Fan Zhang
This patch reworks the crypto AES unit test by introducing a new unified test function Signed-off-by: Fan Zhang --- app/test/Makefile |1 + app/test/test_cryptodev.c | 1613 ++-- app/test/test_cryptodev_aes.c

[dpdk-dev] [PATCH v2] config: make libarchive optional

2016-06-14 Thread Thomas Monjalon
The commit 66819e6 has introduced a dependency on libarchive to be able to use some tar resources in the unit tests. It is now an optional dependency because some systems do not have it installed. If CONFIG_RTE_APP_TEST_RESOURCE_TAR is disabled, the PCI test will not be run. When a "configure"

[dpdk-dev] [PATCH v2 3/3] doc: add keepalive enhancement documentation

2016-06-14 Thread Remy Horton
On 08/06/2016 10:52, Thomas Monjalon wrote: > 2016-05-18 10:30, Remy Horton: > > There is no explanation and it is totally normal, because this patch > must be squashed with the code change. > >> Signed-off-by: Remy Horton >> --- >> doc/guides/rel_notes/release_16_07.rst | 5 + >> 1 file

[dpdk-dev] [PATCH] mlx: fix icc compilation error

2016-06-14 Thread Bruce Richardson
On Tue, Jun 14, 2016 at 10:51:37AM +0100, Ferruh Yigit wrote: > Compilation errors: > mlx4: > CC mlx4.o > .../dpdk/drivers/net/mlx4/mlx4.c(5409): error #188: enumerated type > mixed with another type > priv->intr_handle.type = 0; > ^ > > mlx5: >

[dpdk-dev] [PATCH v2 01/15] i40e/base: remove HMC AQ APIs

2016-06-14 Thread Bruce Richardson
On Tue, May 24, 2016 at 02:22:55PM +0800, Helin Zhang wrote: > HMC AQ APIs were removed from the latest datasheet, and > hence remove its implementations and relevant. > > Signed-off-by: Helin Zhang Still haven't clarified what HMC stands for :-) Looking up an old data sheet, I guess it

[dpdk-dev] [PATCH v2 04/15] i40e/base: trim the code

2016-06-14 Thread Bruce Richardson
On Tue, May 24, 2016 at 02:22:58PM +0800, Helin Zhang wrote: > It trim the source code, with limiting pieces of code for > PF or VF driver only, code style fixes, and annotation > rewording. > > Signed-off-by: Helin Zhang > --- > drivers/net/i40e/base/i40e_adminq.c | 52 >

[dpdk-dev] [PATCH v2 05/15] i40e/base: fixup Geneve VNI for HW use

2016-06-14 Thread Bruce Richardson
On Tue, May 24, 2016 at 02:22:59PM +0800, Helin Zhang wrote: > The hardware doesn't layout the Geneve VNI (Virtual Network > Identifier) quite the same as the VxLAN VNI, so it needs to > adjust it before sending through the AQ commands as the > workaround. > > Signed-off-by: Helin Zhang Missing

[dpdk-dev] [PATCH v2 00/30] ixgbe/base: update base driver

2016-06-14 Thread Ferruh Yigit
On 6/14/2016 7:59 AM, Beilei Xing wrote: > Update base driver for ixgbe, mainly work on new features and bug fixes. > > v2 changes: > Fix typos and update commit log. > Separate [patch 18/29] into two patches. > ... > > Acked-by: Helin Zhang > Series Reviewed-by Ferruh Yigit

[dpdk-dev] [PATCH v2 00/30] ixgbe/base: update base driver

2016-06-14 Thread Ferruh Yigit
On 6/14/2016 11:36 AM, Ferruh Yigit wrote: > On 6/14/2016 7:59 AM, Beilei Xing wrote: >> Update base driver for ixgbe, mainly work on new features and bug fixes. >> >> v2 changes: >> Fix typos and update commit log. >> Separate [patch 18/29] into two patches. >> > ... >> >> Acked-by: Helin Zhang

[dpdk-dev] [PATCH v10 1/3] mempool: support external mempool operations

2016-06-14 Thread Shreyansh Jain
Hi, > -Original Message- > From: David Hunt [mailto:david.hunt at intel.com] > Sent: Tuesday, June 14, 2016 3:16 PM > To: dev at dpdk.org > Cc: olivier.matz at 6wind.com; viktorin at rehivetech.com; > jerin.jacob at caviumnetworks.com; Shreyansh Jain ; > David Hunt > Subject: [PATCH v10

[dpdk-dev] [PATCH v10 2/3] app/test: test external mempool manager

2016-06-14 Thread Shreyansh Jain
> -Original Message- > From: David Hunt [mailto:david.hunt at intel.com] > Sent: Tuesday, June 14, 2016 3:16 PM > To: dev at dpdk.org > Cc: olivier.matz at 6wind.com; viktorin at rehivetech.com; > jerin.jacob at caviumnetworks.com; Shreyansh Jain ; > David Hunt > Subject: [PATCH v10 2/3]

[dpdk-dev] [PATCH v10 3/3] mbuf: make default mempool ops configurable at build

2016-06-14 Thread Shreyansh Jain
> -Original Message- > From: David Hunt [mailto:david.hunt at intel.com] > Sent: Tuesday, June 14, 2016 3:16 PM > To: dev at dpdk.org > Cc: olivier.matz at 6wind.com; viktorin at rehivetech.com; > jerin.jacob at caviumnetworks.com; Shreyansh Jain ; > David Hunt > Subject: [PATCH v10 3/3]

[dpdk-dev] [PATCH v3 00/20] vhost ABI/API refactoring

2016-06-14 Thread Yuanhan Liu
Applied to dpdk-next-virtio. --yliu On Tue, Jun 07, 2016 at 11:51:50AM +0800, Yuanhan Liu wrote: > v3: - adapted the new vhost ABI/API changes to tep_term example, to make > sure not break build at least. > - bumped the ABI version to 3 > > NOTE: I created a branch at dpdk.org

[dpdk-dev] [PATCH v3 0/6] vhost: add vhost-user client mode and reconnect ability

2016-06-14 Thread Yuanhan Liu
Applied to dpdk-next-virtio. --yliu On Tue, Jun 07, 2016 at 12:05:02PM +0800, Yuanhan Liu wrote: > v3: - make the "reconnect" feature be default for client mode, as it's > good to handle guest OS restart with less effort. > - fix var not-initilized error pointed out by Rich >

[dpdk-dev] [PATCH v4 0/9] app/testpmd: forwarding

2016-06-14 Thread Bernard Iremonger
Modify testpmd to allow stop, close, detach and attach of a port without stopping forwarding. Changes in v4: rebased to latest master reworked patch 4 Changes in v3: rebased to latest master. added patch 9 app/testpmd: stop forwarding on exit reworked and renamed patch 4 app/testpmd: remove

[dpdk-dev] [PATCH v4 1/9] app/testpmd: add function port_is_forwarding

2016-06-14 Thread Bernard Iremonger
Add function port_is_forwarding to check whether a port is forwarding or not. Signed-off-by: Bernard Iremonger --- app/test-pmd/config.c | 18 +- app/test-pmd/testpmd.h | 3 ++- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c

[dpdk-dev] [PATCH v4 2/9] app/testpmd: don't update fwding config when attaching/detaching a port

2016-06-14 Thread Bernard Iremonger
Remove checks on test_done variable. Remove code to update forwarding configuration. Fixes: edab33b1c01d ("app/testpmd: support port hotplug") Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 28 +--- 1 file changed, 1 insertion(+), 27 deletions(-) diff

[dpdk-dev] [PATCH v4 3/9] app/testpmd: check port is not forwarding in stop_port and close_port

2016-06-14 Thread Bernard Iremonger
Add calls to port_is_forwarding function. Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 7a1e470..f22d1b6 100644 ---

[dpdk-dev] [PATCH v4 4/9] app/testpmd: remove fwd_config_setup from fwd_config_display

2016-06-14 Thread Bernard Iremonger
Add call to fwd_config_setup to init_config. Remove fwd_config_setup from fwd_config_display. Add call to fwd_config_setup for corelist, coremask and nbcore setup. Add call to fwd_config_setup for portlist, portmask and nbport setup. Add call to fwd_config_setup for rxq, txq, rxd and txd setup.

  1   2   3   >