Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-05 Thread Fady Bader
> -Original Message- > From: Kinsella, Ray > Sent: Thursday, July 2, 2020 5:57 PM > To: Fady Bader ; dev@dpdk.org > Cc: Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com; ocard...@microsoft.com; > pallavi.ka.

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow META item validation

2020-07-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Shy Shyman > Sent: Sunday, June 28, 2020 12:37 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow META item validation > > When flow is inserted with meta match i

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-05 Thread Thomas Monjalon
05/07/2020 09:00, Fady Bader: > > On 30/06/2020 11:49, Kinsella, Ray wrote: > > > On 22/06/2020 12:55, Fady Bader wrote: > > >> --- a/lib/librte_eal/include/rte_function_versioning.h > > >> +++ b/lib/librte_eal/include/rte_function_versioning.h > > >> @@ -11,6 +11,10 @@ > > >> #error Use of functi

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-05 Thread Fady Bader
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, July 5, 2020 11:38 AM > To: Kinsella, Ray ; Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com; > ocard...@microsoft.com; pallavi.ka...

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-05 Thread Thomas Monjalon
04/07/2020 16:44, Ajit Khaparde: > On Thu, Jul 2, 2020 at 11:40 PM Jerin Jacob wrote: > > When adding overlapping API(rte_eth_mirror_rule_set()) in the same > > library(ethdev). > > Please depreciate the old API. > > We should not have two separate paths for the same function in the > > same ethde

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-05 Thread Thomas Monjalon
05/07/2020 10:51, Fady Bader: > From: Thomas Monjalon > > 05/07/2020 09:00, Fady Bader: > > > > On 30/06/2020 11:49, Kinsella, Ray wrote: > > > > > On 22/06/2020 12:55, Fady Bader wrote: > > > > >> --- a/lib/librte_eal/include/rte_function_versioning.h > > > > >> +++ b/lib/librte_eal/include/rte_f

[dpdk-dev] [PATCH 00/20] add Mellanox RegEx PMD

2020-07-05 Thread Ori Kam
This patch series introduce the Mellanox BF2 RegEx PMD. Mellanox BF2 RegEx PMD implement the API defined in the regexdev lib [1]. This PMD allows a DPDK application to offload the RegEx functionality to Mellanox BF2 RegEx engine. [1] https://patches.dpdk.org/cover/72792/ Francis Kelly (1):

[dpdk-dev] [PATCH 04/20] common/mlx5: add mlx5 regex command structs

2020-07-05 Thread Ori Kam
From: Yuval Avnery Add regex commands structs to support regex. Signed-off-by: Yuval Avnery --- drivers/common/mlx5/mlx5_prm.h | 89 +- 1 file changed, 88 insertions(+), 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx

[dpdk-dev] [PATCH 01/20] regex/mlx5: add RegEx PMD layer and mlx5 driver

2020-07-05 Thread Ori Kam
From: Yuval Avnery This commit introduce the RegEx pull mode drivers class, and adds Mellanox RegEx PMD. Signed-off-by: Yuval Avnery Signed-off-by: Ori Kam --- config/common_base| 5 +++ drivers/Makefile | 2 + drivers/common/

[dpdk-dev] [PATCH 03/20] common/mlx5: add MMO and regexp structs/opcodes

2020-07-05 Thread Ori Kam
From: Yuval Avnery Added General purpose PRM MMO structs, and regex specific structs. Signed-off-by: Yuval Avnery Signed-off-by: Ori Kam --- drivers/common/mlx5/mlx5_prm.h | 40 1 file changed, 40 insertions(+) diff --git a/drivers/common/mlx5/mlx5_pr

[dpdk-dev] [PATCH 06/20] regex/mlx5: add probe function

2020-07-05 Thread Ori Kam
This commit adds the probe function to the RegEx PMD. Signed-off-by: Parav Pandit Signed-off-by: Ori Kam --- drivers/regex/mlx5/Makefile | 3 + drivers/regex/mlx5/meson.build | 2 +- drivers/regex/mlx5/mlx5_regex.c | 215 drivers/regex/mlx5/mlx5

[dpdk-dev] [PATCH 02/20] regex/mlx5: add log utils

2020-07-05 Thread Ori Kam
From: Yuval Avnery Add the DRV_LOG macro which should be used for error prints. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/mlx5_regex.c | 4 drivers/regex/mlx5/mlx5_regex_utils.h | 19 +++ 3 f

[dpdk-dev] [PATCH 05/20] common/mlx5: add support for regex capability query

2020-07-05 Thread Ori Kam
From: Yuval Avnery Update hca cap struct and common query hca cap function. Signed-off-by: Yuval Avnery --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++ drivers/common/mlx5/mlx5_prm.h | 9 +++-- 3 files changed, 12 insertions(+), 2 deleti

[dpdk-dev] [PATCH 10/20] regex/mlx5: add engine status check

2020-07-05 Thread Ori Kam
This commit checks the engine status. Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index d264ecd..c469a10 100644 --- a/drivers/regex/m

[dpdk-dev] [PATCH 08/20] regex/mlx5: add RXP register definitions

2020-07-05 Thread Ori Kam
From: Parav Pandit This commit indroduce the mlx5_rxp_csrs.h file. This file holds all the relevant defines for the RXP engine. Signed-off-by: Parav Pandit Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_rxp_csrs.h | 338 + 1 file changed, 338 insertions

[dpdk-dev] [PATCH 07/20] common/mlx5: add rxp database set cmd

2020-07-05 Thread Ori Kam
This commit adds the database set command for the RXP engine. Signed-off-by: Ori Kam --- drivers/common/mlx5/mlx5_devx_cmds.c| 104 drivers/common/mlx5/mlx5_devx_cmds.h| 8 +- drivers/common/mlx5/rte_common_mlx5_version.map | 3 + 3 files chan

[dpdk-dev] [PATCH 09/20] common/mlx5: add write and read RXP registers

2020-07-05 Thread Ori Kam
This commits add the write and read RXP registers functionality. Signed-off-by: Ori Kam --- drivers/common/mlx5/mlx5_devx_cmds.c| 78 + drivers/common/mlx5/mlx5_devx_cmds.h| 10 drivers/common/mlx5/rte_common_mlx5_version.map | 2 + 3 files c

[dpdk-dev] [PATCH 11/20] regex/mlx5: add get info function

2020-07-05 Thread Ori Kam
This commit adds the get info function. Signed-off-by: Ori Kam --- drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/meson.build | 1 + drivers/regex/mlx5/mlx5_regex.c | 5 - drivers/regex/mlx5/mlx5_regex.h | 5 + drivers/regex/mlx5/mlx5_rxp.c | 41

[dpdk-dev] [PATCH 15/20] regex/mlx5: add send queue support

2020-07-05 Thread Ori Kam
This commit introduce the SQ creation. The SQ is used for enqueuing a job. In order to support out of order matches, we create number os SQ per one applicaiton QP. Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.h | 2 + drivers/regex/mlx5/mlx5_regex_control.c | 169 +

[dpdk-dev] [PATCH 12/20] regex/mlx5: add configure function

2020-07-05 Thread Ori Kam
This commit implements the configure function. This function is responsible to configure the RegEx engine. Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 2 + drivers/regex/mlx5/mlx5_regex.h | 15 +++ drivers/regex/mlx5/mlx5_rxp.c | 279 +++-

[dpdk-dev] [PATCH 14/20] regex/mlx5: add completion queue creation

2020-07-05 Thread Ori Kam
This commit adds the creation of CQ Signed-off-by: Ori Kam --- drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/meson.build | 1 + drivers/regex/mlx5/mlx5_regex.c | 1 + drivers/regex/mlx5/mlx5_regex.h | 4 +- drivers/regex/mlx5/mlx5_regex_contro

[dpdk-dev] [PATCH 17/20] regex/mlx5: fastpath setup

2020-07-05 Thread Ori Kam
From: Yuval Avnery Allocated and register input/output buffers and metadata. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/regex/mlx5/Makefile | 1 + drivers/regex/mlx5/meson.build | 1 + drivers/regex/mlx5/mlx5_regex.h | 8 ++ drivers/regex/m

[dpdk-dev] [PATCH 13/20] regex/mlx5: add program rules support

2020-07-05 Thread Ori Kam
From: Francis Kelly This commit introduce the ability to program rules to the RegEx engine. Signed-off-by: Francis Kelly Acked-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 33 ++ drivers/regex/mlx5/mlx5_regex.h | 55 ++- drivers/regex/mlx5/mlx5_rxp.c | 1039 +++

[dpdk-dev] [PATCH 16/20] common/mlx5: add match tuple hw layout

2020-07-05 Thread Ori Kam
From: Yuval Avnery Add the found match tuple. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/common/mlx5/mlx5_prm.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index bfbc58b..874dde6 100644 --- a/drivers

[dpdk-dev] [PATCH 19/20] regex/mlx5: implement dequeue function

2020-07-05 Thread Ori Kam
From: Yuval Avnery Implement dequeue function for the regex API. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 1 + drivers/regex/mlx5/mlx5_regex.h | 4 ++ drivers/regex/mlx5/mlx5_regex_control.c | 1 + drivers/regex/mlx5/mlx5_re

[dpdk-dev] [PATCH 20/20] maintainers: add maintainers to regexdev lib

2020-07-05 Thread Ori Kam
This commit adds a maintainers to RegEx lib and to the new Mellanox RegEx PMD. Signed-off-by: Ori Kam --- MAINTAINERS | 15 +++ 1 file changed, 15 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 53a5e9a..d11306a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -447,6 +447,11

[dpdk-dev] [PATCH 18/20] regex/mlx5: add enqueue implementation

2020-07-05 Thread Ori Kam
From: Yuval Avnery Will look for a free SQ to send the job on. doorbell will be given when sq is full, or no more jobs on the burst. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 1 + drivers/regex/mlx5/mlx5_regex.h | 6 ++ drivers/

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-05 Thread Ori Kam
Hi Andrew, I replied to some of your comments. Best, Ori > -Original Message- > From: dev On Behalf Of Andrew Rybchenko > Sent: Saturday, July 4, 2020 4:05 PM > Subject: Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte > flow > > On 7/2/20 9:43 PM, Jiawei Wang wrote

Re: [dpdk-dev] [PATCH] add flow shared action API

2020-07-05 Thread Ori Kam
Hi Jerin, PSB, Thanks, Ori > -Original Message- > From: Jerin Jacob > Sent: Saturday, July 4, 2020 3:33 PM > dpdk-dev > Subject: Re: [dpdk-dev] [PATCH] add flow shared action API > > On Sat, Jul 4, 2020 at 3:40 PM Andrey Vesnovaty > wrote: > > > > > > Thanks, > > > > Andrey Vesnovaty

[dpdk-dev] Epoll installation in FreeBSD

2020-07-05 Thread Ibtisam Tariq
Hey. I've tried to install a new copy of FreeBSD. But it can't find the sys/epoll.h header file. I have searched and sys/epoll.h is not available on FreeBSD. The output of meson builds on FreeBSD. -- Has header "sys/epoll.h" : NO

Re: [dpdk-dev] [PATCH v2] build: remove special handling for node library

2020-07-05 Thread Thomas Monjalon
04/07/2020 16:22, Jerin Jacob: > On Thu, Jul 2, 2020 at 9:39 PM Thomas Monjalon wrote: > > > > The node library had a need of being linked as a whole > > to make some constructors effective. > > Now that all libraries are linked with --whole-archive, > > there is no need to have this library separ

Re: [dpdk-dev] [PATCH 01/20] regex/mlx5: add RegEx PMD layer and mlx5 driver

2020-07-05 Thread Wang, Haiyue
> -Original Message- > From: dev On Behalf Of Ori Kam > Sent: Sunday, July 5, 2020 17:23 > To: jer...@marvell.com; Wang, Xiang W ; > ma...@mellanox.com; > viachesl...@mellanox.com; Thomas Monjalon ; Shahaf > Shuler ; > Ray Kinsella ; Neil Horman > Cc: g...@marvell.com; dev@dpdk.org; pbh

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-07-05 Thread Jeff Guo
hi, xavier On 7/3/2020 9:28 AM, Wei Hu (Xavier) wrote: Hi, Heinrich Kuhn & Jerin Jacob & Nithin Dabilpuram & Kiran Kumar K &   Rasesh Mody & Shahed Shaikh & Qi Zhang & Xiao Wang & Beilei Xing & Jeff Guo. Could you please help to review this patch and give 'Acked-by' if there are no objects.

[dpdk-dev] [Bug 501] igb: segfault in rte_eth_tx_done_cleanup() when using advanced descriptors

2020-07-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=501 Bug ID: 501 Summary: igb: segfault in rte_eth_tx_done_cleanup() when using advanced descriptors Product: DPDK Version: 19.05 Hardware: All OS: All Status

Re: [dpdk-dev] [dpdk-dev v4 1/3] net/iavf: refactor for hash flow

2020-07-05 Thread Jeff Guo
hi, qi On 7/3/2020 10:24 PM, Zhang, Qi Z wrote: -Original Message- From: Guo, Jia Sent: Friday, July 3, 2020 11:57 AM To: Zhang, Qi Z ; Wu, Jingjing ; Xing, Beilei Cc: dev@dpdk.org; Guo, Junfeng ; Yang, Qiming ; Su, Simei ; Guo, Jia Subject: [dpdk-dev v4 1/3] net/iavf: refactor for

Re: [dpdk-dev] [PATCH 01/20] regex/mlx5: add RegEx PMD layer and mlx5 driver

2020-07-05 Thread Ori Kam
Hi Wang, > -Original Message- > From: Wang, Haiyue > Sent: Sunday, July 5, 2020 1:59 PM > To: Ori Kam ; jer...@marvell.com; Wang, Xiang W > ; Matan Azrad ; Slava > Ovsiienko ; Thomas Monjalon > ; Shahaf Shuler ; Ray > Kinsella ; Neil Horman > Cc: g...@marvell.com; dev@dpdk.org; pbhagavat

Re: [dpdk-dev] [PATCH v3 1/2] rte_flow: add eCPRI key fields to flow API

2020-07-05 Thread Ori Kam
Hi Bing, > -Original Message- > From: Bing Zhao > Sent: Thursday, July 2, 2020 3:54 PM > Subject: [PATCH v3 1/2] rte_flow: add eCPRI key fields to flow API > > Add a new item "rte_flow_item_ecpri" in order to match eCRPI header. > > eCPRI is a packet based protocol used in the fronthaul

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add eCPRI in flow creation patterns

2020-07-05 Thread Ori Kam
Hi Bing, > -Original Message- > From: Bing Zhao > Sent: Thursday, July 2, 2020 3:54 PM > To: Ori Kam ; john.mcnam...@intel.com; > marko.kovace...@intel.com; Thomas Monjalon ; > ferruh.yi...@intel.com; arybche...@solarflare.com; olivier.m...@6wind.com > Cc: dev@dpdk.org; wenzhuo...@intel.c

[dpdk-dev] [PATCH v5 2/3] mempool: use generic memory management

2020-07-05 Thread Fady Bader
Using generic memory management calls instead of Unix memory management calls for mempool. Signed-off-by: Fady Bader --- lib/librte_mempool/rte_mempool.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_me

[dpdk-dev] [PATCH v5 1/3] eal: disable function versioning on Windows

2020-07-05 Thread Fady Bader
Function versioning implementation is not supported by Windows. Function versioning was disabled on Windows. Signed-off-by: Fady Bader --- lib/librte_eal/include/rte_function_versioning.h | 2 +- lib/meson.build | 5 + 2 files changed, 6 insertions(+), 1 dele

[dpdk-dev] [PATCH v5 0/3] build mempool on Windows

2020-07-05 Thread Fady Bader
Added changes in order to build mempool lib on windows. v5: * disabled function versioning on Windows in lib/meson.build. v4: * Fixed some commit messages and added comments to unclear code. v3: * Rebased on current master and v5 of "eal/windows: ring build on Windows". v2: * Re

[dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows

2020-07-05 Thread Fady Bader
Some eal functions are used by mempool lib but not exported on Windows. The functions were exported. Added mempool to supported libraries for Windows compilation. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 6 ++ lib/librte_eal/rte_eal_version.map | 1 + lib/meson.buil

Re: [dpdk-dev] [PATCH v5 2/3] mempool: use generic memory management

2020-07-05 Thread Andrew Rybchenko
On 7/5/20 2:46 PM, Fady Bader wrote: > Using generic memory management calls instead of Unix memory management > calls for mempool. > > Signed-off-by: Fady Bader Acked-by: Andrew Rybchenko

Re: [dpdk-dev] Questions about rte_flow_create APIs

2020-07-05 Thread Ori Kam
Hi Oulijun, First small comment, I think you sent the mail in HTML format, please next time send it as plain text. From: oulijun Sent: Friday, July 3, 2020 9:45 AM To: Ori Kam ; ferruh.yi...@intel.com Cc: dev@dpdk.org; us...@dpdk.org Subject: Questions about rte_flow_create APIs Hi, Guys I a

Re: [dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows

2020-07-05 Thread David Marchand
On Sun, Jul 5, 2020 at 1:47 PM Fady Bader wrote: > diff --git a/lib/librte_eal/rte_eal_version.map > b/lib/librte_eal/rte_eal_version.map > index 196eef5afa..9ad843c754 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -395,4 +395,5 @@ INTERNAL { >

Re: [dpdk-dev] [PATCH v5 2/3] mempool: use generic memory management

2020-07-05 Thread Dmitry Kozlyuk
On Sun, 5 Jul 2020 14:46:28 +0300, Fady Bader wrote: [snip] > /* populate the mempool with an anonymous mapping */ > @@ -740,20 +741,20 @@ rte_mempool_populate_anon(struct rte_mempool *mp) > } > > /* get chunk of virtually continuous memory */ > - addr = mmap(NULL, size, PROT_RE

Re: [dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-07-05 Thread Thomas Monjalon
04/07/2020 15:36, Jerin Jacob: > On Mon, May 25, 2020 at 2:59 PM Bruce Richardson > wrote: > > > > On Sun, May 24, 2020 at 06:13:22PM +0200, Thomas Monjalon wrote: > > > Bruce, as maintainer of l2fwd example, any opinion about this change? > > > > > Assuming all previous discussion on it is resolv

Re: [dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows

2020-07-05 Thread Fady Bader
> -Original Message- > From: David Marchand > Sent: Sunday, July 5, 2020 3:01 PM > To: Fady Bader > Cc: dev ; Thomas Monjalon ; Tasnim > Bashar ; Tal Shnaiderman ; > Yohad Tor ; Dmitry Kozlyuk > ; Harini Ramakrishnan > ; Omar Cardona > ; Pallavi Kadam ; Ranjit > Menon ; Olivier Matz ; >

Re: [dpdk-dev] [PATCH v5 2/3] mempool: use generic memory management

2020-07-05 Thread Fady Bader
> -Original Message- > From: Dmitry Kozlyuk > Sent: Sunday, July 5, 2020 3:08 PM > To: Fady Bader > Cc: dev@dpdk.org; Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; harini.ramakrish...@microsoft.com; > ocard...@microsoft.com; pallavi.ka...@intel.com; ranjit.me...@i

Re: [dpdk-dev] [RFC] ethdev: add fragment attribute to IPv6 item

2020-07-05 Thread Andrew Rybchenko
On 6/2/20 10:04 PM, Adrien Mazarguil wrote: > Hi Ori, Andrew, Delek, > > (been a while eh?) > > On Tue, Jun 02, 2020 at 06:28:41PM +, Ori Kam wrote: >> Hi Andrew, >> >> PSB, > [...] diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index b0e4199..3bc8ce1 10064

Re: [dpdk-dev] [PATCH v2 6/8] vhost: add support for virtio get status message

2020-07-05 Thread Xia, Chenbo
Hi Adrian, > -Original Message- > From: dev On Behalf Of Adrian Moreno > Sent: Thursday, July 2, 2020 4:33 PM > To: dev@dpdk.org; Ye, Xiaolong ; > shah...@mellanox.com; ma...@mellanox.com; maxime.coque...@redhat.com; > Wang, Xiao W ; viachesl...@mellanox.com > Cc: jasow...@redhat.com; l..

Re: [dpdk-dev] [PATCH] net/i40e: fix getting eeprom information

2020-07-05 Thread Igor Ryzhov
CCing i40e maintainers. This is a trivial fix without which getting module EEPROM doesn't work at all. On Thu, Jul 2, 2020 at 3:37 PM Pavel Ivashchenko wrote: > Signed-off-by: Pavel Ivashchenko > --- > drivers/net/i40e/i40e_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

Re: [dpdk-dev] [PATCH 1/2] ethdev: allow negative values in flow rule types

2020-07-05 Thread Andrew Rybchenko
On 6/25/20 7:03 PM, Gregory Etelson wrote: > RTE flow items & actions use positive values in item & action type. > Negative values are reserved for PMD private types. PMD > items & actions usually are not exposed to application and are not > used to create RTE flows. > > The patch allows applicati

Re: [dpdk-dev] [PATCH 0/2] ethdev: tunnel offload model

2020-07-05 Thread Andrew Rybchenko
On 6/25/20 7:03 PM, Gregory Etelson wrote: > Hardware vendors implement tunneled traffic offload techniques > differently. Although RTE flow API provides tools capable to offload > all sorts of network stacks, software application must reference this > hardware differences in flow rules compilation

[dpdk-dev] [PATCH v6 2/3] mempool: use generic memory management

2020-07-05 Thread Fady Bader
Using generic memory management calls instead of Unix memory management calls for mempool. Signed-off-by: Fady Bader --- lib/librte_mempool/rte_mempool.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte

[dpdk-dev] [PATCH v6 0/3] build mempool on Windows

2020-07-05 Thread Fady Bader
Added changes in order to build mempool lib on windows. v6: * fixed generic memory management usage. * removed unneeded exports. v5: * disabled function versioning on Windows in lib/meson.build. v4: * Fixed some commit messages and added comments to unclear code. v3: * Rebas

[dpdk-dev] [PATCH v6 1/3] eal: disable function versioning on Windows

2020-07-05 Thread Fady Bader
Function versioning implementation is not supported by Windows. Function versioning was disabled on Windows. Signed-off-by: Fady Bader --- lib/librte_eal/include/rte_function_versioning.h | 2 +- lib/meson.build | 5 + 2 files changed, 6 insertions(+), 1 dele

[dpdk-dev] [PATCH v6 3/3] mempool: mempool build on Windows

2020-07-05 Thread Fady Bader
Some eal functions are used by mempool lib but not exported on Windows. The functions were exported. Added mempool to supported libraries for Windows compilation. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 6 ++ lib/meson.build| 2 +- 2 files chang

Re: [dpdk-dev] [PATCH v4 1/2] net/virtio: add vhost-user protocol features support

2020-07-05 Thread Xia, Chenbo
> -Original Message- > From: Adrian Moreno > Sent: Friday, July 3, 2020 11:57 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Wang, Zhihong > ; Wang, Xiao W ; Yigit, > Ferruh ; maxime.coque...@redhat.com > Subject: [PATCH v4 1/2] net/virtio: add vhost-user protocol features support > > From:

Re: [dpdk-dev] [PATCH v4 2/2] net/virtio: add reply-ack support to Virtio-user

2020-07-05 Thread Xia, Chenbo
> -Original Message- > From: Adrian Moreno > Sent: Friday, July 3, 2020 11:57 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Wang, Zhihong > ; Wang, Xiao W ; Yigit, > Ferruh ; maxime.coque...@redhat.com > Subject: [PATCH v4 2/2] net/virtio: add reply-ack support to Virtio-user > > From: Maxi

Re: [dpdk-dev] [PATCH v6 1/3] eal: disable function versioning on Windows

2020-07-05 Thread Tal Shnaiderman
> From: Fady Bader > Subject: [PATCH v6 1/3] eal: disable function versioning on Windows > > Function versioning implementation is not supported by Windows. > Function versioning was disabled on Windows. > > Signed-off-by: Fady Bader Reviewed-by: Tal Shnaiderman

Re: [dpdk-dev] [PATCH] build: fix memory init failures with 32-bit builds

2020-07-05 Thread Thomas Monjalon
02/07/2020 13:19, Ferruh Yigit: > On 7/2/2020 11:57 AM, Bruce Richardson wrote: > > When building with meson, the default size of virtual address space > > reserved for mapping pages was globally set at 512GB, which is too big for > > use in 32-bit processes. To match the behaviour with "make", we

Re: [dpdk-dev] [PATCH 2/2] ethdev: tunnel offload model

2020-07-05 Thread Andrew Rybchenko
Hi Gregory, I'm sorry for the review with t many questions without any suggestions on how to answer it. Please, see below. On 6/25/20 7:03 PM, Gregory Etelson wrote: > From: Eli Britstein > > Hardware vendors implement tunneled traffic offload techniques > differently. Although RTE flow API

Re: [dpdk-dev] [PATCH v3] build: check functionality rather than binutils version

2020-07-05 Thread Thomas Monjalon
04/07/2020 13:48, Bruce Richardson: > Rather than checking the binutils version number, which can lead to > unnecessary disabling of AVX512 if fixes have been backported to distro > versions, we can instead check the output of "as" from binutils to see if > it is correct. > > The check in the scri

Re: [dpdk-dev] [PATCH v6 2/3] mempool: use generic memory management

2020-07-05 Thread Dmitry Kozlyuk
On Sun, 5 Jul 2020 16:47:45 +0300, Fady Bader wrote: > Using generic memory management calls instead of Unix memory management > calls for mempool. > > Signed-off-by: Fady Bader [snip] > /* populate the mempool with an anonymous mapping */ > @@ -740,20 +741,17 @@ rte_mempool_populate_anon(stru

Re: [dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin queues setup

2020-07-05 Thread Asaf Penso
Regards, Asaf Penso > -Original Message- > From: dev On Behalf Of Wisam Jaddo > Sent: Tuesday, June 30, 2020 11:10 AM > To: Thomas Monjalon ; Jack Min > ; david.march...@redhat.com > Cc: dev@dpdk.org; Wisam Monther > Subject: [dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin

Re: [dpdk-dev] [PATCH v3 0/4] improve runtime loading of shared drivers

2020-07-05 Thread Thomas Monjalon
03/07/2020 12:23, Bruce Richardson: > This set includes a number of small improvements for handling the loading > of drivers at runtime using the EAL -d flag. > > It limits the loading of files to only those files which end in .so, which > means that one can pass in the whole "drivers/" subfolder

Re: [dpdk-dev] [PATCH] eal: don't use default library path for static binaries

2020-07-05 Thread Thomas Monjalon
29/06/2020 18:15, Bruce Richardson: > On Mon, Jun 29, 2020 at 08:41:46AM -0700, Stephen Hemminger wrote: > > Bruce Richardson wrote: > > > On Mon, Jun 29, 2020 at 10:11:58AM +0100, Bruce Richardson wrote: > > > > On Fri, Jun 26, 2020 at 10:05:42AM -0700, Stephen Hemminger wrote: > > > > > Bruce

Re: [dpdk-dev] [PATCH v2 4/7] net/mlx5: add the validate sample action

2020-07-05 Thread Ori Kam
Hi Jiawei > -Original Message- > From: Jiawei Wang > Subject: [PATCH v2 4/7] net/mlx5: add the validate sample action > > Add sample action validate function. > > For Sample flow support NIC-RX and FDB domain, must include an > action of a dest TIR in NIC_RX. > > Only NIC_RX support wi

Re: [dpdk-dev] [PATCH v2 6/7] net/mlx5: update translate function for sample action

2020-07-05 Thread Ori Kam
Hi Jiawei, > -Original Message- > From: Jiawei Wang > Subject: [PATCH v2 6/7] net/mlx5: update translate function for sample action > > Translate the attribute of sample action that include sample ratio > and sub actions list, then create the sample DR action. > > Signed-off-by: Jiawei

Re: [dpdk-dev] [PATCH v2] trace: simplify trace point registration

2020-07-05 Thread Thomas Monjalon
04/07/2020 17:14, David Marchand: > RTE_TRACE_POINT_DEFINE and RTE_TRACE_POINT_REGISTER must come in pairs. > Merge them and let RTE_TRACE_POINT_REGISTER handle the constructor part. > > Signed-off-by: David Marchand > Acked-by: Jerin Jacob Applied, thanks

Re: [dpdk-dev] [PATCH v3 0/3] Experimental/internal libraries cleanup

2020-07-05 Thread Thomas Monjalon
+Cc maintainers of the problematic libraries: - librte_fib - librte_rib - librte_gro - librte_member - librte_rawdev 26/06/2020 10:16, David Marchand: > Following discussions on the mailing list and the 05/20 TB meeting, here > is a series that drops the spe

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-05 Thread Thomas Monjalon
05/07/2020 11:00, Thomas Monjalon: > 05/07/2020 10:51, Fady Bader: > > From: Thomas Monjalon > > > 05/07/2020 09:00, Fady Bader: > > > > > On 30/06/2020 11:49, Kinsella, Ray wrote: > > > > > > On 22/06/2020 12:55, Fady Bader wrote: > > > > > >> --- a/lib/librte_eal/include/rte_function_versioning.

Re: [dpdk-dev] [PATCH v6 2/3] mempool: use generic memory management

2020-07-05 Thread Thomas Monjalon
05/07/2020 15:47, Fady Bader: > Using generic memory management calls instead of Unix memory management > calls for mempool. > > Signed-off-by: Fady Bader Acks received on previous versions are missing. Please attention to all details.

Re: [dpdk-dev] [PATCH v6 1/3] eal: disable function versioning on Windows

2020-07-05 Thread Thomas Monjalon
05/07/2020 15:47, Fady Bader: > Function versioning implementation is not supported by Windows. > Function versioning was disabled on Windows. was -> is > Signed-off-by: Fady Bader > --- > lib/librte_eal/include/rte_function_versioning.h | 2 +- > lib/meson.build

Re: [dpdk-dev] [PATCH v6 3/3] mempool: mempool build on Windows

2020-07-05 Thread Thomas Monjalon
05/07/2020 15:47, Fady Bader: > Some eal functions are used by mempool lib but not exported on Windows. eal -> EAL > The functions were exported. > Added mempool to supported libraries for Windows compilation. Please reserve the past tense for stating how it was before the patch.

Re: [dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin queues setup

2020-07-05 Thread Thomas Monjalon
30/06/2020 10:10, Wisam Jaddo: > The hairpin queue is the one that start from normal rxq, > and will be less than nr_queues where nr_queues is the > sum of normal and hairpin > > Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") > Cc: wis...@mellanox.com > > Signed-off-by: Wis

Re: [dpdk-dev] [PATCH v2] sched: fix port time rounding error

2020-07-05 Thread Thomas Monjalon
Cristian, Jasvinder, please review. 25/06/2020 11:59, alangordonde...@gmail.com: > From: Alan Dewar > > The QoS scheduler works off port time that is computed from the number > of CPU cycles that have elapsed since the last time the port was > polled. It divides the number of elapsed cycles to

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix references to /dev/huge

2020-07-05 Thread Thomas Monjalon
23/06/2020 07:55, Sarosh Arif: > change /dev/huge to /dev/hugepages > > Bugzilla ID: 492 > Signed-off-by: Sarosh Arif Please could you explain why /dev/hugepages must be used, in the commit log for the record? FYI, a similar change was done in the website by Stephen.

Re: [dpdk-dev] [PATCH v4 3/4] regexdev: add regexdev core functions

2020-07-05 Thread Thomas Monjalon
02/07/2020 09:46, Ori Kam: > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -30,6 +30,8 @@ option('max_lcores', type: 'integer', value: 128, > description: 'maximum number of cores/threads supported by EAL') > option('max_numa_nodes', type: 'integer', value: 4, > description: '

Re: [dpdk-dev] [PATCH v4 1/4] regexdev: introduce regexdev subsystem

2020-07-05 Thread Thomas Monjalon
02/07/2020 09:46, Ori Kam: > From: Jerin Jacob > --- a/config/common_base > +++ b/config/common_base > # > +# Compile regex device support > +# > +CONFIG_RTE_LIBRTE_REGEXDEV=y > + > +# > # Compile librte_ring > # > CONFIG_RTE_LIBRTE_RING=y > @@ -1141,3 +1146,4 @@ CONFIG_RTE_APP_CRYPTO_PERF=y >

Re: [dpdk-dev] [PATCH v4 0/4] add RegEx class

2020-07-05 Thread Thomas Monjalon
02/07/2020 09:45, Ori Kam: > config/common_base |8 + > config/meson.build |1 + > doc/api/doxy-api-index.md|1 + > doc/api/doxy-api.conf.in |1 + > doc/guides/prog_guide/index.rst

Re: [dpdk-dev] [PATCH v4 1/2] vhost: introduce async enqueue registration API

2020-07-05 Thread Liu, Yong
Hi Patrick, Few comments are inline, others are fine to me. Regards, Marvin > diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c > index 0d822d6..58ee3ef 100644 > --- a/lib/librte_vhost/vhost.c > +++ b/lib/librte_vhost/vhost.c > @@ -332,8 +332,13 @@ > { > if (vq_is_packed(de

Re: [dpdk-dev] [PATCH v2 6/8] vhost: add support for virtio get status message

2020-07-05 Thread Xia, Chenbo
Hi Adrian, > -Original Message- > From: dev On Behalf Of Adrian Moreno > Sent: Thursday, July 2, 2020 4:33 PM > To: dev@dpdk.org; Ye, Xiaolong ; > shah...@mellanox.com; ma...@mellanox.com; maxime.coque...@redhat.com; > Wang, Xiao W ; viachesl...@mellanox.com > Cc: jasow...@redhat.com; l..

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-05 Thread Ajit Khaparde
On Sun, Jul 5, 2020 at 3:19 AM Ori Kam wrote: > Hi Andrew, > > I replied to some of your comments. > Best, > Ori > > -Original Message- > > From: dev On Behalf Of Andrew Rybchenko > > Sent: Saturday, July 4, 2020 4:05 PM > > Subject: Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-05 Thread Ajit Khaparde
On Sun, Jul 5, 2020 at 1:55 AM Thomas Monjalon wrote: > 04/07/2020 16:44, Ajit Khaparde: > > On Thu, Jul 2, 2020 at 11:40 PM Jerin Jacob > wrote: > > > When adding overlapping API(rte_eth_mirror_rule_set()) in the same > > > library(ethdev). > > > Please depreciate the old API. > > > We should n

[dpdk-dev] [PATCH v2 0/3] Updates for HFN in PDCP

2020-07-05 Thread Akhil Goyal
Changes in v2: updated test and test-crypto-perf for better test coverage to include both HFN override and per session HFN in testing. Akhil Goyal (3): drivers/crypto: fix 18bit PDCP cases with HFN override test/crypto: update PDCP HFN scenarios test/crypto-perf: add option to enable sessio

[dpdk-dev] [PATCH v2 1/3] drivers/crypto: fix 18bit PDCP cases with HFN override

2020-07-05 Thread Akhil Goyal
In case of RTA_SEC_ERA = 8, where the length of shared desc is large for some of PDCP cases, the descriptor buffer cannot hold 2 extra words when HFN override is enabled. As a result, the descriptor fails. This patch converts one of the keys from immediate key to reference key hence reducing the l

[dpdk-dev] [PATCH v2 3/3] test/crypto-perf: add option to enable session HFN

2020-07-05 Thread Akhil Goyal
Add a new option for PDCP cases to enable use of session based fixed HFN value instead of per packet HFN which was enabled by hfn override feature. By default HFN override is enabled and if session based fixed HFN need to be tested, add "--pdcp-ses-hfn-en" in the command line. Signed-off-by: Akhil

[dpdk-dev] [PATCH v2 2/3] test/crypto: update PDCP HFN scenarios

2020-07-05 Thread Akhil Goyal
As per current framework of PDCP testing, app can only support either HFN override or fixed session HFN values but not both. Now to enable both, either we duplicate all PDCP cases(>100) for both override and fixed HFN. It will look clumsy as the number of cases will be very high without much value

[dpdk-dev] [PATCH v3 0/3] Updates for HFN in PDCP

2020-07-05 Thread Akhil Goyal
changes in v3: - fix checkpatch warning - changes were accidently done in test_pdcp_proto_SGL instead of test_pdcp_proto. Fixed. Changes in v2: updated test and test-crypto-perf for better test coverage to include both HFN override and per session HFN in testing. *** BLURB HERE *** Akhil Goyal

[dpdk-dev] [PATCH v3 1/3] drivers/crypto: fix 18bit PDCP cases with HFN override

2020-07-05 Thread Akhil Goyal
In case of RTA_SEC_ERA = 8, where the length of shared desc is large for some of PDCP cases, the descriptor buffer cannot hold 2 extra words when HFN override is enabled. As a result, the descriptor fails. This patch converts one of the keys from immediate key to reference key hence reducing the l

[dpdk-dev] [PATCH v3 2/3] test/crypto: update PDCP HFN scenarios

2020-07-05 Thread Akhil Goyal
As per current framework of PDCP testing, app can only support either HFN override or fixed session HFN values but not both. Now to enable both, either we duplicate all PDCP cases(>100) for both override and fixed HFN. It will look clumsy as the number of cases will be very high without much value

[dpdk-dev] [PATCH v3 3/3] test/crypto-perf: add option to enable session HFN

2020-07-05 Thread Akhil Goyal
Add a new option for PDCP cases to enable use of session based fixed HFN value instead of per packet HFN which was enabled by hfn override feature. By default HFN override is enabled and if session based fixed HFN need to be tested, add "--pdcp-ses-hfn-en" in the command line. Signed-off-by: Akhil

Re: [dpdk-dev] [PATCH v2 0/3] Updates for HFN in PDCP

2020-07-05 Thread Hemant Agrawal
Series- Acked-by: Hemant Agrawal -Original Message- From: Akhil Goyal Sent: Monday, July 6, 2020 10:52 AM To: dev@dpdk.org Cc: Hemant Agrawal ; Akhil Goyal Subject: [PATCH v2 0/3] Updates for HFN in PDCP Importance: High Changes in v2: updated test and test-crypto-perf for better test

Re: [dpdk-dev] [PATCH v5 00/51] net/bnxt: add features for host-based flow management

2020-07-05 Thread Ajit Khaparde
On Fri, Jul 3, 2020 at 2:05 PM Ajit Khaparde wrote: > v1->v2: > - update commit message > - rebase patches against latest changes in the tree > - fix signed-off-by tags > - update release notes > > v2->v3: > - fix compilation issues > > v3->v4: > - rebase against latest dpdk-next-net > > v4

Re: [dpdk-dev] [PATCH v3 0/3] Updates for HFN in PDCP

2020-07-05 Thread Akhil Goyal
> changes in v3: > - fix checkpatch warning > - changes were accidently done in test_pdcp_proto_SGL instead of > test_pdcp_proto. Fixed. > > Changes in v2: > updated test and test-crypto-perf for better test coverage > to include both HFN override and per session HFN in testing. > v3 applied to

Re: [dpdk-dev] [PATCH v4 3/4] regexdev: add regexdev core functions

2020-07-05 Thread Ori Kam
> -Original Message- > From: Thomas Monjalon > Sent: Monday, July 6, 2020 12:08 AM > Subject: Re: [dpdk-dev] [PATCH v4 3/4] regexdev: add regexdev core functions > > 02/07/2020 09:46, Ori Kam: > > --- a/meson_options.txt > > +++ b/meson_options.txt > > @@ -30,6 +30,8 @@ option('max_lco

Re: [dpdk-dev] [PATCH 1/3] ring: remove experimental tag for ring reset API

2020-07-05 Thread Kinsella, Ray
On 03/07/2020 19:46, Honnappa Nagarahalli wrote: > > >> >> On 03/07/2020 11:26, Feifei Wang wrote: >>> Remove the experimental tag for rte_ring_reset API that have been >>> around for 4 releases. >>> >>> Signed-off-by: Feifei Wang >>> Reviewed-by: Honnappa Nagarahalli >>> Reviewed-by: Ruifen

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-07-05 Thread Wei Hu (Xavier)
Hi, Jeff Guo On 2020/7/5 19:22, Jeff Guo wrote: hi, xavier On 7/3/2020 9:28 AM, Wei Hu (Xavier) wrote: Hi, Heinrich Kuhn & Jerin Jacob & Nithin Dabilpuram & Kiran Kumar K & Rasesh Mody & Shahed Shaikh & Qi Zhang & Xiao Wang & Beilei Xing & Jeff Guo. Could you please help to review this

  1   2   >