On 08/01/2018 06:47 PM, Kevin Traynor wrote:
On 05/28/2018 04:31 AM, Andy Green wrote:
Hi -
Between 18.02 and the putative 18.05 there were changes in the way the
meter stuff deals with its config.
I updated the related code in lagopus, but I get warnings about using
the new APIs (it'
/home/agreen/projects/dpdk/lib/librte_table/rte_table_hash_cuckoo.c:110:16:
error: cast between incompatible function types from ‘rte_table_hash_op_hash’
{aka ‘long unsigned int (*)(void *, void *, unsigned int, long unsigned int)’}
to ‘uint32_t (*)(const void *, uint32_t, uint32_t)’ {aka ‘uns
/ buffer overflow issue fixed here, I think it'd
be a really good idea to run this stuff through Coverity.
They will give you a free account for OSS projects here
https://scan.coverity.com/
---
Andy Green (18):
lib: ret_table: workaround hash function cast error
drivers: bus: pci
In function ‘pci_get_kernel_driver_by_path’,
inlined from ‘pci_scan_one.isra.1’ at
/home/agreen/projects/dpdk/drivers/bus/pci/linux/pci.c:317:8:
/home/agreen/projects/dpdk/drivers/bus/pci/linux/pci.c:57:3: error: ‘strncpy’
specified bound depends on the length of the source argument
[-Werror
The actual descriptor for qm_mr_entry is 64-byte aligned.
But the original code plays a trick, and puts a u8 common to the
three descriptor subtypes in the union afterwards outside their
structure definitions.
Unfortunately since they compose a struct qm_fd with alignment
8, this trick destroys t
/home/agreen/projects/dpdk/drivers/net/axgbe/axgbe_phy_impl.c:576:6: error:
‘__builtin_memcmp_eq’ reading 16 bytes from a region of size 9
[-Werror=stringop-overflow=]
if (memcmp(&sfp_eeprom->base[AXGBE_SFP_BASE_VENDOR_NAME],
^
AXG
/home/agreen/projects/dpdk/drivers/net/nfp/nfpcore/nfp_resource.c:76:2: error:
‘strncpy’ output may be truncated copying 8 bytes from a string of length 8
[-Werror=stringop-truncation]
strncpy(name_pad, res->name, sizeof(name_pad));
---
drivers/net/nfp/nfpcore/nfp_resource.c |6 +++---
1 f
/home/agreen/projects/dpdk/drivers/net/qede/qede_main.c: In function
‘qed_slowpath_start’:
/home/agreen/projects/dpdk/drivers/net/qede/qede_main.c:307:3: error: ‘strncpy’
output may be truncated copying 12 bytes from a string of length 127
[-Werror=stringop-truncation]
strncpy((char *)drv_ver
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
index 4e6c66624..9f6704a7f 100644
--- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
+++ b
/home/agreen/projects/dpdk/app/proc-info/main.c: In function
‘nic_xstats_display’:
/home/agreen/projects/dpdk/app/proc-info/main.c:495:45: error: ‘%s’ directive
writing up to 255 bytes into a region of size between 165 and 232
[-Werror=format-overflow=]
sprintf(buf, "PUTVAL %s/dpdkstat-port.
/home/agreen/projects/dpdk/app/test-pmd/cmdline.c:64:10: fatal error:
rte_pmd_dpaa.h: No such file or directory
#include
^~~~
---
app/test-pmd/Makefile |1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
index 60ae9b9c1..a0f
/home/agreen/projects/dpdk/drivers/net/vdev_netvsc/vdev_netvsc.c:335:2: error:
passing argument 2 to restrict-qualified parameter aliases with argument 1
[-Werror=restrict]
ret = readlink(buf, buf, size);
^~~
---
drivers/net/vdev_netvsc/vdev_netvsc.c |7 ---
1 file changed, 4 inserti
---
drivers/net/sfc/sfc_ethdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index e42d55350..e9bb283e0 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -742,7 +742,7 @@ sfc_xstat
/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:669:2: error: ‘memcpy’
forming offset [5, 6] is out of the bounds [0, 4] of object ‘tmp’ with type
‘uint32_t’ {aka ‘unsigned int’} [-Werror=array-bounds]
memcpy(&hw->mac_addr[0], &tmp, sizeof(struct ether_addr));
---
drivers/net/nfp/nfp_net.
---
drivers/net/qede/base/ecore_int.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/qede/base/ecore_int.c
b/drivers/net/qede/base/ecore_int.c
index f43781ba4..c809d84ef 100644
--- a/drivers/net/qede/base/ecore_int.c
+++ b/drivers/net/qede/base/ecore
---
app/test-bbdev/test_bbdev_vector.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-bbdev/test_bbdev_vector.c
b/app/test-bbdev/test_bbdev_vector.c
index addef0572..5ad2a6535 100644
--- a/app/test-bbdev/test_bbdev_vector.c
+++ b/app/test-bbdev/test_bbdev_vector.
---
app/test-bbdev/test_bbdev_vector.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test-bbdev/test_bbdev_vector.c
b/app/test-bbdev/test_bbdev_vector.c
index 5ad2a6535..373f94984 100644
--- a/app/test-bbdev/test_bbdev_vector.c
+++ b/app/test-bbdev/test_bbdev_vecto
---
drivers/net/vdev_netvsc/vdev_netvsc.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c
b/drivers/net/vdev_netvsc/vdev_netvsc.c
index c11794137..c36ec0f9a 100644
--- a/drivers/net/vdev_netvsc/vdev_netvsc.c
+++ b/drivers/net/
---
drivers/net/sfc/sfc_ethdev.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index e9bb283e0..bd5f17f33 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -662,10 +662,13 @@
/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c: In function
‘nfp_pf_pci_probe’:
/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:3160:23: error: ‘%s’
directive writing up to 99 bytes into a region of size 76
[-Werror=format-overflow=]
sprintf(fw_name, "%s/%s.nffw", DEFAULT_FW_PATH, s
tches actually fix problems in
the code.
If you don't care about Coverity, let me know and I will register this
project there and send you fixes when I have time.
Andrew.
[1]
http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line
On 05/08/2018 07:30 AM, Andy
On 05/08/2018 04:58 PM, Bruce Richardson wrote:
On Tue, May 08, 2018 at 12:29:53PM +0800, Andy Green wrote:
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
b/drivers/net/nfp
On May 8, 2018 10:17:18 PM GMT+08:00, Jasvinder Singh
wrote:
>Add dedicated parameter structure for cuckoo hash. The cuckoo hash from
>librte_hash uses slightly different prototype for the hash function (no
>key_mask parameter, 32-bit seed and return value) that require either
>of the following
On 05/09/2018 04:02 AM, Shaikh, Shahed wrote:
-Original Message-
From: dev On Behalf Of Bruce Richardson
Sent: Tuesday, May 8, 2018 2:53 PM
To: dev-boun...@dpdk.org
Cc: Andy Green ; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant
and NUL
On
[-Werror=stringop-overflow=]
strncpy(dri_name, name + 1, strlen(name + 1) + 1);
Signed-off-by: Andy Green
---
drivers/bus/pci/linux/pci.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
index 4630a8057..a73ee49c2
rking on fixing this, so you probably don't
want to apply this. However it's necessary for build to continue atm)
Signed-off-by: Andy Green
---
lib/librte_table/rte_table_hash_cuckoo.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_table/rte_table_ha
.
---
Andy Green (18):
lib/libtre_table: workaround hash function cast error
drivers/bus/pci: fix strncpy dangerous code
drivers/bus/dpaa: fix inconsistent struct alignment
drivers/net/axgbe: fix broken eeprom string comp
drivers/net/nfp/nfpcore: fix strncpy misuse
Signed-off-by: Andy Green
---
drivers/net/vdev_netvsc/vdev_netvsc.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c
b/drivers/net/vdev_netvsc/vdev_netvsc.c
index e0d3c1c7c..41662304b 100644
--- a/drivers/net/vdev_netvsc
/home/agreen/projects/dpdk/app/test-pmd/cmdline.c:64:10:
fatal error: rte_pmd_dpaa.h: No such file or directory
#include
^~~~
Signed-off-by: Andy Green
---
app/test-pmd/Makefile |1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-pmd/Makefile b/app/test-pmd
/home/agreen/projects/dpdk/drivers/net/vdev_netvsc/
vdev_netvsc.c:335:2:error: passing argument 2 to restrict-
qualified parameter aliases with argument 1 [-Werror=restrict]
ret = readlink(buf, buf, size);
^~~
Signed-off-by: Andy Green
---
drivers/net/vdev_netvsc/vdev_netvsc.c |8
Signed-off-by: Andy Green
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
index 4e6c66624..52b294888 100644
--- a/drivers/net/nfp
OR_NAME],
^
AXGBE_BEL_FUSE_VENDOR, AXGBE_SFP_BASE_VENDOR_NAME_LEN))
Signed-off-by: Andy Green
---
drivers/net/axgbe/axgbe_phy_impl.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/axgbe/axgbe_phy_impl.c
b/drivers/net/axgbe/axgbe_phy_impl.c
index dfa908dd8..97
tination
of size 256
sprintf(buf, "PUTVAL %s/dpdkstat-port.%u/%s-%s N:%"
^~~
PRIu64"\n", host_id, port_id, counter_type,
~~~
xstats_names[i].name, values[i]);
Signed-off-by: Andy
Signed-off-by: Andy Green
---
drivers/net/qede/base/ecore_int.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/qede/base/ecore_int.c
b/drivers/net/qede/base/ecore_int.c
index f43781ba4..d9e22b5ed 100644
--- a/drivers/net/qede/base/ecore_int.c
+++ b
*)drv_version.name, (const char *)params->name,
^
MCP_DRV_VER_STR_SIZE - 4);
~
Signed-off-by: Andy Green
---
drivers/net/qede/qede_main.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --
structs in
the union).
The final struct layout should be unchanged.
Signed-off-by: Andy Green
---
drivers/bus/dpaa/base/qbman/qman.c | 14 +++---
drivers/bus/dpaa/include/fsl_qman.h | 24 +---
2 files changed, 20 insertions(+), 18 deletions(-)
diff --git a/drivers
Signed-off-by: Andy Green
---
drivers/net/sfc/sfc_ethdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index ef5e9ecb2..a8c0f8e19 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
LT_FW_PATH, serial);
Signed-off-by: Andy Green
---
drivers/net/nfp/nfp_net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 199aac40b..d5f0e54e8 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
Signed-off-by: Andy Green
---
drivers/net/sfc/sfc_ethdev.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index e42d55350..ef5e9ecb2 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc
/home/agreen/projects/dpdk/drivers/net/nfp/nfpcore/nfp_resource.c:
76:2:error: ‘strncpy’ output may be truncated copying 8 bytes from
a string of length 8 [-Werror=stringop-truncation]
strncpy(name_pad, res->name, sizeof(name_pad));
Signed-off-by: Andy Green
---
drivers/net/nfp/nfpc
/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:669:2:
error: ‘memcpy’ forming offset [5, 6] is out of the bounds
[0, 4] of object ‘tmp’ with type ‘uint32_t’ {aka ‘unsigned
int’} [-Werror=array-bounds] memcpy(&hw->mac_addr[0],
&tmp, sizeof(struct ether_addr));
Signed-off-by:
Signed-off-by: Andy Green
---
app/test-bbdev/test_bbdev_vector.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-bbdev/test_bbdev_vector.c
b/app/test-bbdev/test_bbdev_vector.c
index addef0572..5ad2a6535 100644
--- a/app/test-bbdev/test_bbdev_vector.c
+++ b/app
Signed-off-by: Andy Green
---
app/test-bbdev/test_bbdev_vector.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test-bbdev/test_bbdev_vector.c
b/app/test-bbdev/test_bbdev_vector.c
index 5ad2a6535..373f94984 100644
--- a/app/test-bbdev/test_bbdev_vector.c
+++ b/app
OR_NAME],
^
AXGBE_BEL_FUSE_VENDOR, AXGBE_SFP_BASE_VENDOR_NAME_LEN))
Signed-off-by: Andy Green
---
drivers/net/axgbe/axgbe_phy_impl.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/axgbe/axgbe_phy_impl.c
b/drivers/net/axgbe/axgbe_phy_impl.c
index dfa908dd8..97
[-Werror=stringop-overflow=]
strncpy(dri_name, name + 1, strlen(name + 1) + 1);
Signed-off-by: Andy Green
---
drivers/bus/pci/linux/pci.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
index 4630a8057..a73ee49c2
.
These are almost entirely related to signed / unsigned
or truncation without explicit casts inside dpdk
headers.
---
Andy Green (40):
drivers/bus/pci: fix strncpy dangerous code
drivers/bus/dpaa: fix inconsistent struct alignment
drivers/net/axgbe: fix broken eeprom string comp
Signed-off-by: Andy Green
Acked-by: Alejandro Lucero
Tested-by: Alejandro Lucero
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
/home/agreen/projects/dpdk/drivers/net/nfp/nfpcore/nfp_resource.c:
76:2:error: ‘strncpy’ output may be truncated copying 8 bytes from
a string of length 8 [-Werror=stringop-truncation]
strncpy(name_pad, res->name, sizeof(name_pad));
Signed-off-by: Andy Green
---
drivers/net/nfp/nfpc
agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:3176:2:
note: ‘sprintf’ output between 25 and 124 bytes into a
destination of size 100
sprintf(fw_name, "%s/%s", DEFAULT_FW_PATH, card);
Signed-off-by: Andy Green
---
drivers/net/nfp/nfp_net.c |4 ++--
1 file changed, 2 insertions(+)
/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:669:2:
error: ‘memcpy’ forming offset [5, 6] is out of the bounds
[0, 4] of object ‘tmp’ with type ‘uint32_t’ {aka ‘unsigned
int’} [-Werror=array-bounds] memcpy(&hw->mac_addr[0],
&tmp, sizeof(struct ether_addr));
Signed-off-by:
structs in
the union).
The final struct layout should be unchanged.
Signed-off-by: Andy Green
Acked-by: Hemant Agrawal
Tested-by: Hemant Agrawal
---
drivers/bus/dpaa/base/qbman/qman.c | 14 +++---
drivers/bus/dpaa/include/fsl_qman.h | 24 +---
2 files changed, 20
Signed-off-by: Andy Green
---
drivers/net/qede/base/ecore_int.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/qede/base/ecore_int.c
b/drivers/net/qede/base/ecore_int.c
index f43781ba4..d9e22b5ed 100644
--- a/drivers/net/qede/base/ecore_int.c
+++ b
*)drv_version.name, (const char *)params->name,
^
MCP_DRV_VER_STR_SIZE - 4);
~
Signed-off-by: Andy Green
---
drivers/net/qede/qede_main.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --
Signed-off-by: Andy Green
---
drivers/net/sfc/sfc_ethdev.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index e42d55350..ef5e9ecb2 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc
Signed-off-by: Andy Green
---
drivers/net/sfc/sfc_ethdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index ef5e9ecb2..a8c0f8e19 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
Signed-off-by: Andy Green
---
app/test-bbdev/test_bbdev_vector.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-bbdev/test_bbdev_vector.c
b/app/test-bbdev/test_bbdev_vector.c
index addef0572..5ad2a6535 100644
--- a/app/test-bbdev/test_bbdev_vector.c
+++ b/app
Signed-off-by: Andy Green
---
drivers/net/vdev_netvsc/vdev_netvsc.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c
b/drivers/net/vdev_netvsc/vdev_netvsc.c
index dca25761d..f1d036152 100644
--- a/drivers/net/vdev_netvsc
tination
of size 256
sprintf(buf, "PUTVAL %s/dpdkstat-port.%u/%s-%s N:%"
^~~
PRIu64"\n", host_id, port_id, counter_type,
~~~
xstats_names[i].name, values[i]);
Signed-off-by: Andy
/home/agreen/projects/dpdk/drivers/net/vdev_netvsc/
vdev_netvsc.c:335:2:error: passing argument 2 to restrict-
qualified parameter aliases with argument 1 [-Werror=restrict]
ret = readlink(buf, buf, size);
^~~
Signed-off-by: Andy Green
---
drivers/net/vdev_netvsc/vdev_netvsc.c |8
/home/agreen/projects/dpdk/app/test-pmd/cmdline.c:64:10:
fatal error: rte_pmd_dpaa.h: No such file or directory
#include
^~~~
Signed-off-by: Andy Green
---
app/test-pmd/Makefile |1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-pmd/Makefile b/app/test-pmd
Signed-off-by: Andy Green
---
app/test-bbdev/test_bbdev_vector.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test-bbdev/test_bbdev_vector.c
b/app/test-bbdev/test_bbdev_vector.c
index 5ad2a6535..373f94984 100644
--- a/app/test-bbdev/test_bbdev_vector.c
+++ b/app
rte_lcore_id();
Signed-off-by: Andy Green
---
lib/librte_eal/common/include/rte_lcore.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/include/rte_lcore.h
b/lib/librte_eal/common/include/rte_lcore.h
index 1a2f37eaa..6e09d9181 100644
--- a/lib/librte_
int, but we want to
return it as uint32_t. Its only defined valid return
values are positive integers or zero, which is OK for
uint32_t. So just add an explicit cast.
Signed-off-by: Andy Green
---
lib/librte_eal/common/include/rte_common.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-
Signed-off-by: Andy Green
---
.../common/include/arch/x86/rte_memcpy.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
index 5ead68ab2..f9ea0ab69
rc/dpdk/build/include/rte_random.h:53:6:
warning: conversion to 'long unsigned int' from 'long int'
may change the sign of the result [-Wsign-conversion]
val += lrand48();
Signed-off-by: Andy Green
---
lib/librte_eal/common/include/rte_random.h |6 +++---
1 file chan
/projects/lagopus/src/dpdk/build/include/rte_spinlock.h:
In function 'rte_try_tm':
/projects/lagopus/src/dpdk/build/include/rte_spinlock.h:82:2:
warning: ISO C90 forbids mixed declarations and code
[-Wdeclaration-after-statement]
int retries = RTE_RTM_MAX_RETRIES;
Signed-off-by:
uint32_t prod_tail = r->prod.tail;
Signed-off-by: Andy Green
---
lib/librte_ring/rte_ring_generic.h |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/librte_ring/rte_ring_generic.h
b/lib/librte_ring/rte_ring_generic.h
index 5b110425f..c2d482bc9 100644
--- a/lib/libr
unsigned int, then call a private
api taking an int, which finally calls an api taking an
unsigned int.
Convert the private api to take unsigned int removing
5 x warning similar to that shown above.
Signed-off-by: Andy Green
---
lib/librte_ring/rte_ring.h |4 ++--
lib/librte_r
Signed-off-by: Andy Green
---
lib/librte_mbuf/rte_mbuf.h | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 4fd9a0d9e..a2a37a311 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
/projects/lagopus/src/dpdk/build/include/rte_dev.h:54:2:
warning: ISO C90 forbids mixed declarations and
code [-Wdeclaration-after-statement]
char buffer[vsnprintf(NULL, 0, fmt, ap) + 1];
Signed-off-by: Andy Green
---
lib/librte_eal/common/include/rte_dev.h | 15 +--
1 file
differences to the atomic16 are signed, but the
atomic16 itself is unsigned. It needs to be
made explicit with casts.
Signed-off-by: Andy Green
---
lib/librte_mbuf/rte_mbuf.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib
6:
note: in expansion of macro 'RTE_MIN'
m->data_off = RTE_MIN(RTE_PKTMBUF_HEADROOM,
(uint16_t)m->buf_len);
RTE_PKTMBUF_HEADROOM is typ 128, so it doesn't make trouble.
Signed-off-by: Andy Green
---
lib/librte_mbuf/rte_mbuf.h |3 ++-
1 file changed, 2 insertions(+), 1 deletio
tr_t)(ptr1) -
(uintptr_t)(ptr2))
^
/projects/lagopus/src/dpdk/build/include/rte_mbuf.h:1360:13:
note: in expansion of macro 'RTE_PTR_DIFF'
*buf_len = RTE_PTR_DIFF(shinfo, buf_addr);
Signed-off-by: Andy Green
---
lib/librte_mbuf/rte_mbuf.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
Signed-off-by: Andy Green
---
lib/librte_mbuf/rte_mbuf.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 0580ec8a0..169f3d3b0 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -1577,7
ned-off-by: Andy Green
---
lib/librte_net/rte_ether.h |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h
index 01d57f0ae..bee2b34f0 100644
--- a/lib/librte_net/rte_ether.h
+++ b/lib/librte_net/rte_ether.h
@@ -350,
Signed-off-by: Andy Green
---
lib/librte_mbuf/rte_mbuf.h | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 169f3d3b0..3cd76abbc 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf
/projects/lagopus/src/dpdk/build/include/rte_ether.h:213:13:
warning: conversion from 'int' to 'uint8_t'
{aka 'unsigned char'} may change value [-Wconversion]
addr[0] &= ~ETHER_GROUP_ADDR;
/* clear multicast bit */
Signed-off-by: Andy Green
---
lib/librte
Signed-off-by: Andy Green
---
.../common/include/generic/rte_byteorder.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/include/generic/rte_byteorder.h
b/lib/librte_eal/common/include/generic/rte_byteorder.h
index 9bed85cca..8ffbac394 100644
Signed-off-by: Andy Green
---
lib/librte_ethdev/rte_ethdev.h | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 7ccf4bae6..2487e1d2d 100644
--- a/lib/librte_ethdev/rte_ethdev.h
'} may change value [-Wconversion]
init_val = crc32c_sse42_u32(d.u32[0], init_val);
Signed-off-by: Andy Green
---
lib/librte_hash/rte_hash_crc.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/librte_hash/rte_hash_crc.h b/lib/librte_hash/rte_hash
/projects/lagopus/src/dpdk/build/include/rte_ethdev.h:3860:10:
warning: conversion to 'int' from 'uint32_t' {aka 'unsigned int'}
may change the sign of the result [-Wsign-conversion]
return (*dev->dev_ops->rx_queue_count)(dev, queue_id);
Signed-off-by
Signed-off-by: Andy Green
---
lib/librte_eal/common/include/rte_string_fns.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/include/rte_string_fns.h
b/lib/librte_eal/common/include/rte_string_fns.h
index fcbb42e00..51413a55e 100644
--- a/lib
/projects/lagopus/src/dpdk/build/include/rte_hash_crc.h:
In function 'crc32c_2words':
/projects/lagopus/src/dpdk/build/include/rte_hash_crc.h:347:2:
warning: ISO C90 forbids mixed declarations and code
[-Wdeclaration-after-statement]
uint32_t crc, term1, term2;
Signed-off-by:
rsion]
buffer->error_callback(&buffer->pkts[sent], to_send - sent,
Signed-off-by: Andy Green
---
lib/librte_ethdev/rte_ethdev.h |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index c84dc44b8..a7c
On 05/10/2018 02:17 PM, Jerin Jacob wrote:
-Original Message-
Date: Thu, 10 May 2018 10:46:18 +0800
From: Andy Green
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs
User-Agent: StGit/unknown-version
The following series gets current master
On 05/10/2018 02:12 PM, Jerin Jacob wrote:
-Original Message-
Date: Thu, 10 May 2018 10:46:18 +0800
From: Andy Green
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs
User-Agent: StGit/unknown-version
The following series gets current master
On 05/10/2018 05:11 PM, Jerin Jacob wrote:
-Original Message-
Date: Thu, 10 May 2018 14:46:42 +0800
From: Andy Green
To: Jerin Jacob
CC: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0
On 05/10/2018 05:52 PM, De Lara Guarch, Pablo wrote:
Hi Andy,
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green
Sent: Thursday, May 10, 2018 3:46 AM
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs
The
On 05/10/2018 07:58 PM, Jerin Jacob wrote:
-Original Message-
Date: Thu, 10 May 2018 19:44:34 +0800
From: Andy Green
To: Jerin Jacob
CC: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0
On 05/10/2018 06:21 PM, Luca Boccassi wrote:
On Thu, 2018-05-10 at 10:46 +0800, Andy Green wrote:
The following series gets current master able to build
itself, and allow lagopus to build against it, on Fedora 28 +
x86_64 using gcc 8.0.1.
The first 17 patches have already been through two
On 05/10/2018 09:49 PM, Luca Boccassi wrote:
On Thu, 2018-05-10 at 14:36 +0100, Bruce Richardson wrote:
On Thu, May 10, 2018 at 01:35:49PM +0100, Luca Boccassi wrote:
On Thu, 2018-05-10 at 20:23 +0800, Andy Green wrote:
On 05/10/2018 06:21 PM, Luca Boccassi wrote:
On Thu, 2018-05-10 at 10
On 05/10/2018 09:36 PM, Bruce Richardson wrote:
On Thu, May 10, 2018 at 01:35:49PM +0100, Luca Boccassi wrote:
On Thu, 2018-05-10 at 20:23 +0800, Andy Green wrote:
On 05/10/2018 06:21 PM, Luca Boccassi wrote:
On Thu, 2018-05-10 at 10:46 +0800, Andy Green wrote:
The following series gets
On 05/10/2018 09:53 PM, Andy Green wrote:
On 05/10/2018 09:49 PM, Luca Boccassi wrote:
On Thu, 2018-05-10 at 14:36 +0100, Bruce Richardson wrote:
On Thu, May 10, 2018 at 01:35:49PM +0100, Luca Boccassi wrote:
On Thu, 2018-05-10 at 20:23 +0800, Andy Green wrote:
On 05/10/2018 06:21 PM
On 05/11/2018 03:18 AM, Stephen Hemminger wrote:
On Thu, 10 May 2018 10:49:20 +0800
Andy Green wrote:
/projects/lagopus/src/dpdk/build/include/rte_ethdev.h:3860:10:
warning: conversion to 'int' from 'uint32_t' {aka 'unsigned int'}
may change the sign of
On 05/11/2018 03:17 AM, Stephen Hemminger wrote:
On Thu, 10 May 2018 10:49:40 +0800
Andy Green wrote:
Signed-off-by: Andy Green
---
lib/librte_eal/common/include/rte_string_fns.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/include
On 05/10/2018 11:01 PM, Stephen Hemminger wrote:
On Thu, 10 May 2018 20:13:31 +0800
Andy Green wrote:
I appreciate the reply.
But why bother having a subject line at all if it is going to be
mechanically enforced that nothing in it is allowed to be "useful"?
That really doesn&#x
On 05/11/2018 08:29 AM, Andy Green wrote:
On 05/10/2018 11:01 PM, Stephen Hemminger wrote:
On Thu, 10 May 2018 20:13:31 +0800
Andy Green wrote:
I appreciate the reply.
But why bother having a subject line at all if it is going to be
mechanically enforced that nothing in it is allowed to
This series allows dpdk master to build on Fedora 28,
with the x86_64 default config.
---
Andy Green (18):
devtools/check-git: provide more generic grep pattern
net/nfp: solve buffer overflow
bus/pci: replace strncpy dangerous code
bus/dpaa: solve inconsistent struct
On Fedora 28, every patch is faulted for
"Wrong headline uppercase", because [A-Z] is not
always case sensitive.
Change to use [[:upper:]]
---
devtools/check-git-log.sh |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:3176:2:
note: ‘sprintf’ output between 25 and 124 bytes into a
destination of size 100
sprintf(fw_name, "%s/%s", DEFAULT_FW_PATH, card);
Signed-off-by: Andy Green
---
drivers/net/nfp/nfp_net.c |4 ++--
1 file changed, 2 insertions(+)
1 - 100 of 339 matches
Mail list logo
