[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-10 Thread Rahul Lakkireddy
On Tue, Jul 07, 2015 at 10:50:23 +, Burakov, Anatoly wrote: > Hi Rahul, > > > However, unsigned long seems to be working fine for all builds. > > unsigned long it is then, if there aren't any other objections. > > Thanks, > Anatoly Hi Alejandro, Are you planning to update the original

[dpdk-dev] [PATCH v3] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-13 Thread Rahul Lakkireddy
fix 32-bit compilation: http://dpdk.org/ml/archives/dev/2015-July/020963.html Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables") Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - Use unsigned long instead and updated the commit log. v2: - For

[dpdk-dev] [PATCH] doc: Spell fixes, re-organize and update CXGBE documentation

2015-07-16 Thread Rahul Lakkireddy
Fix spelling and grammar errors. Re-organize sections for better explanation in the documentation. Add a section describing compilation of CXGBE with DPDK. Add a note describing that CXGBE currently only supports binding to PF4. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi

[dpdk-dev] Does FreeBSD's nic_uio have bind/unbind interface support?

2015-07-16 Thread Rahul Lakkireddy
Hi All, It seems that on FreeBSD, nic_uio currently only binds the devices matched in rte_pci_dev_ids.h. On Linux, it's possible to bind any listed device with igb_uio or vfio. The pci device ids supported by cxgbe PMD, maintained in a table, are not part of rte_pci_dev_ids.h. Hence, Chelsio

[dpdk-dev] [PATCH 0/3] cxgbe: Fix compilation and enable FreeBSD support for CXGBE PMD

2015-07-18 Thread Rahul Lakkireddy
updates cxgbe documentation to reflect the FreeBSD support for CXGBE PMD. Rahul Lakkireddy (3): nic_uio: Fix to allow any device to be bound to nic_uio cxgbe: Enable and fix FreeBSD compilation for CXGBE PMD doc: Update documentation to reflect FreeBSD support for CXGBE PMD config

[dpdk-dev] [PATCH 1/3] nic_uio: Fix to allow any device to be bound to nic_uio

2015-07-18 Thread Rahul Lakkireddy
-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 46 + 1 file changed, 12 insertions(+), 34 deletions(-) diff --git a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c index 2354e84

[dpdk-dev] [PATCH 2/3] cxgbe: Enable and fix FreeBSD compilation for CXGBE PMD

2015-07-18 Thread Rahul Lakkireddy
Fix "MACRO redefined" and "function redefined" compilation errors in FreeBSD by adding CXGBE prefix to them. Also remove reference to a linux header linux/if_ether.h and use DPDK macros directly. Finally, enable CXGBE PMD for FreeBSD. Signed-off-by: Rahul Lakkireddy

[dpdk-dev] [PATCH 3/3] doc: Update documentation to reflect FreeBSD support for CXGBE PMD

2015-07-18 Thread Rahul Lakkireddy
in Linux in order for the new firmware to be loaded. 5. Typo fixes. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- doc/guides/nics/cxgbe.rst | 280 +++--- 1 file changed, 267 insertions(+), 13 deletions(-) diff --git a/doc/guides/nics

[dpdk-dev] [PATCH v2 0/3] cxgbe: Fix compilation and enable FreeBSD support for CXGBE PMD

2015-07-20 Thread Rahul Lakkireddy
updates cxgbe documentation to reflect the FreeBSD support for CXGBE PMD. v2: - Replace "Intel(R) DPDK" with just "DPDK" in device description for nic_uio. Rahul Lakkireddy (3): nic_uio: Fix to allow any device to be bound to nic_uio cxgbe: Enable and fix FreeBSD compilation

[dpdk-dev] [PATCH v2 2/3] cxgbe: Enable and fix FreeBSD compilation for CXGBE PMD

2015-07-20 Thread Rahul Lakkireddy
Fix "MACRO redefined" and "function redefined" compilation errors in FreeBSD by adding CXGBE prefix to them. Also remove reference to a linux header linux/if_ether.h and use DPDK macros directly. Finally, enable CXGBE PMD for FreeBSD. Signed-off-by: Rahul Lakkireddy

[dpdk-dev] [PATCH v2 3/3] doc: Update documentation to reflect FreeBSD support for CXGBE PMD

2015-07-20 Thread Rahul Lakkireddy
in Linux in order for the new firmware to be loaded. 5. Typo fixes. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - No changes. doc/guides/nics/cxgbe.rst | 280 +++--- 1 file changed, 267 insertions(+), 13 deletions(-) diff --git

[dpdk-dev] [PATCH v2 1/3] nic_uio: Fix to allow any device to be bound to nic_uio

2015-07-20 Thread Rahul Lakkireddy
Hi David, On Mon, Jul 20, 2015 at 09:43:57 +0200, David Marchand wrote: >Hum, what bothers me is that you do not rely on the same criteria to >re-attach the devices to nic_uio. >See below. > > ?lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 48 > +

[dpdk-dev] [PATCH v3 0/3] cxgbe: Fix compilation and enable FreeBSD support for CXGBE PMD

2015-07-21 Thread Rahul Lakkireddy
updates cxgbe documentation to reflect the FreeBSD support for CXGBE PMD. v3: - Use checks for bus, slot, and function info instead of vendor and device during nic_uio probe for better consistency. v2: - Replace "Intel(R) DPDK" with just "DPDK" in device description for nic_ui

[dpdk-dev] [PATCH v3 1/3] nic_uio: Fix to allow any device to be bound to nic_uio

2015-07-21 Thread Rahul Lakkireddy
-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - Use checks for bus, slot, and function info instead of vendor and device during nic_uio probe for better consistency. v2: - Replace "Intel(R) DPDK" with just "DPDK" in device description for nic_uio. lib/librt

[dpdk-dev] [PATCH v3 2/3] cxgbe: Enable and fix FreeBSD compilation for CXGBE PMD

2015-07-21 Thread Rahul Lakkireddy
Fix "MACRO redefined" and "function redefined" compilation errors in FreeBSD by adding CXGBE prefix to them. Also remove reference to a linux header linux/if_ether.h and use DPDK macros directly. Finally, enable CXGBE PMD for FreeBSD. Signed-off-by: Rahul Lakkireddy

[dpdk-dev] [PATCH v3 3/3] doc: Update documentation to reflect FreeBSD support for CXGBE PMD

2015-07-21 Thread Rahul Lakkireddy
in Linux in order for the new firmware to be loaded. 5. Typo fixes. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - No changes. v2: - No changes. doc/guides/nics/cxgbe.rst | 280 +++--- 1 file changed, 267 insertions(+), 13

[dpdk-dev] [PATCH v2 00/11] Chelsio Terminator 5 (T5) 10G/40G Poll Mode Driver

2015-06-02 Thread Rahul Lakkireddy
returned by link update eth_dev operation. - Few bug fixes and code cleanup. Rahul Lakkireddy (11): cxgbe: add hardware specific api for all supported Chelsio T5 series adapters. cxgbe: add cxgbe poll mode driver. cxgbe: add device configuration and RX support for cxgbe PMD. cxgbe: add TX

[dpdk-dev] [PATCH v2 02/11] cxgbe: add cxgbe poll mode driver.

2015-06-02 Thread Rahul Lakkireddy
Adds cxgbe poll mode driver for DPDK under drivers/net/cxgbe directory. This patch: 1. Adds the Makefile to compile cxgbe pmd. 2. Registers and initializes the cxgbe pmd driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - Move files to new directory under drivers/net

[dpdk-dev] [PATCH v2 03/11] cxgbe: add device configuration and RX support for cxgbe PMD.

2015-06-02 Thread Rahul Lakkireddy
Adds RX support for the cxgbe poll mode driver. This patch: 1. Adds rx queue related eth_dev_ops. 2. Adds RSS support. 3. Adds dev_configure() and dev_infos_get() eth_dev_ops. 4. Adds rx_pkt_burst for receiving packets. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2

[dpdk-dev] [PATCH v2 05/11] cxgbe: add device related operations for cxgbe PMD.

2015-06-02 Thread Rahul Lakkireddy
Adds dev_start(), dev_stop(), and dev_close() eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - This patch is a subset of patch 2/5 submitted in v1. - Few changes related to tx bug fixes. drivers/net/cxgbe/cxgbe.h| 4

[dpdk-dev] [PATCH v2 06/11] cxgbe: add port statistics for cxgbe PMD.

2015-06-02 Thread Rahul Lakkireddy
Adds stats_get() and stats_reset() eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - This patch is a subset of patch 2/5 submitted in v1. drivers/net/cxgbe/cxgbe.h| 2 + drivers/net/cxgbe/cxgbe_ethdev.c | 83

[dpdk-dev] [PATCH v2 07/11] cxgbe: add link related functions for cxgbe PMD.

2015-06-02 Thread Rahul Lakkireddy
Adds link update, promiscuous and multicast related eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - This patch is a subset of patch 2/5 submitted in v1. - Update cxgbe_dev_link_update() to return correct value. drivers/net/cxgbe

[dpdk-dev] [PATCH v2 04/11] cxgbe: add TX support for cxgbe PMD.

2015-06-02 Thread Rahul Lakkireddy
Adds TX support for the cxgbe poll mode driver. This patch: 1. Adds tx queue related eth_dev_ops. 2. Adds tx_pkt_burst for transmitting packets. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - This patch is a subset of patch 2/5 submitted in v1. - Few bug fixes for tx

[dpdk-dev] [PATCH v2 08/11] cxgbe: add flow control functions for cxgbe PMD.

2015-06-02 Thread Rahul Lakkireddy
Adds flow control related eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - This patch is a subset of patch 2/5 submitted in v1. drivers/net/cxgbe/cxgbe_ethdev.c | 54 1 file changed, 54

[dpdk-dev] [PATCH v2 01/11] cxgbe: add hardware specific api for all supported Chelsio T5 series adapters.

2015-06-02 Thread Rahul Lakkireddy
Adds hardware specific api for all the Chelsio T5 adapters under drivers/net/cxgbe/base directory. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - Move files to new directory under drivers/net/cxgbe/base and update commit log. - Few bug fixes related to tx. drivers

[dpdk-dev] [PATCH v2 09/11] doc: add cxgbe PMD documentation under doc/guides/nics/cxgbe.rst

2015-06-02 Thread Rahul Lakkireddy
Adds cxgbe poll mode driver documentation under the usual doc/guides/nics/ directory with the rest of the drivers. The documentation covers cxgbe implementation details, features and limitations, prerequisites, configuration, and a sample application usage. Signed-off-by: Rahul Lakkireddy

[dpdk-dev] [PATCH v2 10/11] config: enable cxgbe PMD for compilation and linking.

2015-06-02 Thread Rahul Lakkireddy
Changes to: 1. config/common_linuxapp to add macros for cxgbe pmd. 2. drivers/net/Makefile to add cxgbe pmd to the compile list. 3. mk/rte.app.mk to add cxgbe pmd to link. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - Move changes from lib/Makefile to drivers/net

[dpdk-dev] [PATCH v2 11/11] maintainers: claim responsibility for cxgbe PMD.

2015-06-02 Thread Rahul Lakkireddy
Update MAINTAINERS file to claim responsibility for the cxgbe PMD. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - Replace the old cxgbe directory entry with the new entry and order it alphabetically. MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git

[dpdk-dev] [PATCH v2 02/11] cxgbe: add cxgbe poll mode driver.

2015-06-18 Thread Rahul Lakkireddy
> > Please merge also the maintainer infos. > Will merge build config and maintainers with the Makefile patch > 2015-06-01 23:00, Rahul Lakkireddy: > > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0])) > > RTE_DIM may be used Will fix this in v3. Thanks, Rahul

[dpdk-dev] [PATCH v3 1/9] cxgbe: add hardware specific api for all supported Chelsio T5 series adapters.

2015-06-18 Thread Rahul Lakkireddy
Adds hardware specific api for all the Chelsio T5 adapters under drivers/net/cxgbe/base directory. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - No changes v2: - Move files to new directory under drivers/net/cxgbe/base and update commit log. - Few bug fixes related

[dpdk-dev] [PATCH v3 2/9] cxgbe: add cxgbe poll mode driver.

2015-06-18 Thread Rahul Lakkireddy
. drivers/net/Makefile to add cxgbe pmd to the compile list. 3. mk/rte.app.mk to add cxgbe pmd to link. Update MAINTAINERS file to claim responsibility for the cxgbe PMD. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - Merge patches 10 and 11 with this patch to enable

[dpdk-dev] [PATCH v3 3/9] cxgbe: add device configuration and RX support for cxgbe PMD.

2015-06-18 Thread Rahul Lakkireddy
Adds RX support for the cxgbe poll mode driver. This patch: 1. Adds rx queue related eth_dev_ops. 2. Adds RSS support. 3. Adds dev_configure() and dev_infos_get() eth_dev_ops. 4. Adds rx_pkt_burst for receiving packets. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3

[dpdk-dev] [PATCH v3 5/9] cxgbe: add device related operations for cxgbe PMD.

2015-06-18 Thread Rahul Lakkireddy
Adds dev_start(), dev_stop(), and dev_close() eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. - Few changes related to tx bug fixes. drivers/net/cxgbe/cxgbe.h

[dpdk-dev] [PATCH v3 7/9] cxgbe: add link related functions for cxgbe PMD.

2015-06-18 Thread Rahul Lakkireddy
Adds link update, promiscuous and multicast related eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. - Update cxgbe_dev_link_update() to return correct value

[dpdk-dev] [PATCH v3 6/9] cxgbe: add port statistics for cxgbe PMD.

2015-06-18 Thread Rahul Lakkireddy
Adds stats_get() and stats_reset() eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. drivers/net/cxgbe/cxgbe.h| 2 + drivers/net/cxgbe/cxgbe_ethdev.c

[dpdk-dev] [PATCH v3 9/9] doc: add cxgbe PMD documentation under doc/guides/nics/cxgbe.rst

2015-06-18 Thread Rahul Lakkireddy
Adds cxgbe poll mode driver documentation under the usual doc/guides/nics/ directory with the rest of the drivers. The documentation covers cxgbe implementation details, features and limitations, prerequisites, configuration, and a sample application usage. Signed-off-by: Rahul Lakkireddy

[dpdk-dev] [PATCH v3 8/9] cxgbe: add flow control functions for cxgbe PMD.

2015-06-18 Thread Rahul Lakkireddy
Adds flow control related eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. drivers/net/cxgbe/cxgbe_ethdev.c | 54 1

[dpdk-dev] [PATCH] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-06-18 Thread Rahul Lakkireddy
Hi Thomas, On Wed, Jun 17, 2015 at 14:09:35 +0200, Thomas Monjalon wrote: > Hi Rahul, > > 2015-06-16 19:46, Rahul Lakkireddy: > > After the commit-id 90a1633b2 (eal/linux: allow to map BARs with MSI-X > > tables), > > Please show this information before the S

[dpdk-dev] Query on Filtering Support in DPDK

2015-12-02 Thread Rahul Lakkireddy
Hi Thomas, On Monday, November 11/30/15, 2015 at 05:43:18 -0800, Thomas Monjalon wrote: > Hi, > > 2015-11-30 18:19, Rahul Lakkireddy: > > 1. Add a new action 'switch' that will: > >* Allow re-direction to different ports in hardware. > > > >Also, for

[dpdk-dev] [PATCH] cxgbe: explictly mark this as pci_driver

2015-12-03 Thread Rahul Lakkireddy
.name = "rte_cxgbe_pmd", > .id_table = cxgb4_pci_tbl, > .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC, > -- > 2.1.4 > Acked-by: Rahul Lakkireddy

[dpdk-dev] [RFC 0/3] ethdev: Enhancements to flow director filter

2015-12-10 Thread Rahul Lakkireddy
are not affected. Posting this series mainly for discussion on API change. Once this is agreeable then, I will post the cxgbe PMD changes to use the new API. Rahul Lakkireddy (3): ethdev: add packet filter flow and new behavior switch to fdir testpmd: add an example to show packet filter flow doc

[dpdk-dev] [RFC 1/3] ethdev: add packet filter flow and new behavior switch to fdir

2015-12-10 Thread Rahul Lakkireddy
for port, mac, vlan, and nat. Ex: allows to provide new ip and port addresses to rewrite the fields of packets matching a filter rule before NAT'ing. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- lib/librte_ether/rte_eth_ctrl.h | 112 +++- 1

[dpdk-dev] [RFC 2/3] testpmd: add an example to show packet filter flow

2015-12-10 Thread Rahul Lakkireddy
Extend the existing flow_director_filter to add support for packet filter flow. Also shows how to pass the extra behavior arguments to rewrite fields in matched filter rules. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- app/test-pmd/cmdline.c | 435

[dpdk-dev] [RFC 3/3] doc: announce ABI change for filtering support

2015-12-10 Thread Rahul Lakkireddy
Current filtering support will be enhanced to accommodate support for Chelsio T5 hardware filtering support. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes

[dpdk-dev] [RFC 1/3] ethdev: add packet filter flow and new behavior switch to fdir

2015-12-11 Thread Rahul Lakkireddy
Hi Andrey, On Thursday, December 12/10/15, 2015 at 07:46:42 -0800, Chilikin, Andrey wrote: > Hi Rahul, > > If ABI for fdir is going to be changed should we then take more general > approach to accommodate other NICs as well? For example, for > "rte_eth_ipv4_flow" you have "tos" and "proto"

[dpdk-dev] [PATCH] cxgbe: fix unnecessary check for freelist existence while freeing rxq

2015-12-11 Thread Rahul Lakkireddy
check for freelist existence. Thanks to John McNamara for reporting it. Coverity issue: 107108 Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support") Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/sge.c | 2 +- 1 file changed, 1

[dpdk-dev] [RFC 3/3] doc: announce ABI change for filtering support

2015-12-15 Thread Rahul Lakkireddy
/15, 2015 at 19:31:04 +0530, Rahul Lakkireddy wrote: > Current filtering support will be enhanced to accommodate support > for Chelsio T5 hardware filtering support. > > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Kumar Sanghvi > --- > doc/guides/rel_notes/deprecatio

[dpdk-dev] [RFC 3/3] doc: announce ABI change for filtering support

2015-12-15 Thread Rahul Lakkireddy
Hi Thomas, On Tuesday, December 12/15/15, 2015 at 00:55:20 -0800, Thomas Monjalon wrote: > 2015-12-15 14:10, Rahul Lakkireddy: > > Hi Thomas, > > > > I am preparing a v2 of this series where I will be accomodating some > > more fields to be considered for filteri

[dpdk-dev] [PATCH] doc: announce ABI change for extending filtering support

2015-12-15 Thread Rahul Lakkireddy
Current filtering support will be enhanced to accommodate support for Chelsio T5 hardware filtering support. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- doc/guides/rel_notes/deprecation.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes

[dpdk-dev] [RFC v2 0/2] ethdev: Enhancements to flow director filter

2015-12-23 Thread Rahul Lakkireddy
the above new changes. 6. Dropped Patch 3 since the ABI announcement has already been merged. Rahul Lakkireddy (2): ethdev: add packet filter flow and new behavior switch to fdir testpmd: add an example to show packet filter flow app/test-pmd/cmdline.c | 528

[dpdk-dev] [RFC v2 1/2] ethdev: add packet filter flow and new behavior switch to fdir

2015-12-23 Thread Rahul Lakkireddy
. Ex: allows to provide new ip and port addresses to rewrite the fields of packets matching a filter rule before NAT'ing. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: 1. Added ttl to rte_eth_ipv4_flow and tc, flow_label, next_header, and hop_limit to rte_eth_ipv6_flow

[dpdk-dev] [RFC v2 2/2] testpmd: add an example to show packet filter flow

2015-12-23 Thread Rahul Lakkireddy
Extend the existing flow_director_filter to add support for packet filter flow. Also shows how to pass the extra behavior arguments to rewrite fields in matched filter rules. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: 1. Added new field filter-type to allow specifying

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-06-23 Thread Rahul Lakkireddy
allow to map BARs with MSI-X tables") Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - For fixing 32-bit build failure, rather than converting uint32_t var to uint64_t as done in v1, taking a different approach instead to revert a part of above commit-id so as to use th

[dpdk-dev] [PATCH v3 3/9] cxgbe: add device configuration and RX support for cxgbe PMD.

2015-06-30 Thread Rahul Lakkireddy
On Sun, Jun 28, 2015 at 21:34:28 +0200, Thomas Monjalon wrote: > 2015-06-18 17:47, Rahul Lakkireddy: > > Adds RX support for the cxgbe poll mode driver. This patch: > > > > 1. Adds rx queue related eth_dev_ops. > > 2. Adds RSS support. > > 3. Adds dev_configure(

[dpdk-dev] [PATCH v3 2/9] cxgbe: add cxgbe poll mode driver.

2015-06-30 Thread Rahul Lakkireddy
Hi Thomas, On Sun, Jun 28, 2015 at 21:32:32 +0200, Thomas Monjalon wrote: > 2015-06-18 17:47, Rahul Lakkireddy: > > +Chelsio cxgbe > > +M: Rahul Lakkireddy > > +F: drivers/net/cxgbe/ > > +F: doc/guides/nics/cxgbe.rst > > Just a detail: the doc file is added in

[dpdk-dev] [PATCH v4 0/9] Chelsio Terminator 5 (T5) 10G/40G Poll Mode Driver

2015-06-30 Thread Rahul Lakkireddy
the return value returned by link update eth_dev operation. - Few bug fixes and code cleanup. Rahul Lakkireddy (9): cxgbe: add hardware specific api for all supported Chelsio T5 series adapters. cxgbe: add cxgbe poll mode driver. cxgbe: add device configuration and RX support for cxgbe PMD

[dpdk-dev] [PATCH v4 1/9] cxgbe: add hardware specific api for all supported Chelsio T5 series adapters.

2015-06-30 Thread Rahul Lakkireddy
Adds hardware specific api for all the Chelsio T5 adapters under drivers/net/cxgbe/base directory. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4: - No changes v3: - No changes v2: - Move files to new directory under drivers/net/cxgbe/base and update commit log. - Few

[dpdk-dev] [PATCH v4 2/9] cxgbe: add cxgbe poll mode driver.

2015-06-30 Thread Rahul Lakkireddy
. drivers/net/Makefile to add cxgbe pmd to the compile list. 3. mk/rte.app.mk to add cxgbe pmd to link. Update MAINTAINERS file to claim responsibility for the cxgbe PMD. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4: - Moved cxgbe doc entry in MAINTAINERS from patch 2

[dpdk-dev] [PATCH v4 3/9] cxgbe: add device configuration and RX support for cxgbe PMD.

2015-06-30 Thread Rahul Lakkireddy
Adds RX support for the cxgbe poll mode driver. This patch: 1. Adds rx queue related eth_dev_ops. 2. Adds RSS support. 3. Adds dev_configure() and dev_infos_get() eth_dev_ops. 4. Adds rx_pkt_burst for receiving packets. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4

[dpdk-dev] [PATCH v4 4/9] cxgbe: add TX support for cxgbe PMD.

2015-06-30 Thread Rahul Lakkireddy
Adds TX support for the cxgbe poll mode driver. This patch: 1. Adds tx queue related eth_dev_ops. 2. Adds tx_pkt_burst for transmitting packets. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4: - Remove unused code to fix clang compilation. v3: - No changes. v2

[dpdk-dev] [PATCH v4 6/9] cxgbe: add port statistics for cxgbe PMD.

2015-06-30 Thread Rahul Lakkireddy
Adds stats_get() and stats_reset() eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4: - No changes. v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. drivers/net/cxgbe/cxgbe.h| 2 + drivers/net

[dpdk-dev] [PATCH v4 7/9] cxgbe: add link related functions for cxgbe PMD.

2015-06-30 Thread Rahul Lakkireddy
Adds link update, promiscuous and multicast related eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4: - No changes. v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. - Update cxgbe_dev_link_update

[dpdk-dev] [PATCH v4 8/9] cxgbe: add flow control functions for cxgbe PMD.

2015-06-30 Thread Rahul Lakkireddy
Adds flow control related eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4: - No changes. v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. drivers/net/cxgbe/cxgbe_ethdev.c | 54

[dpdk-dev] [PATCH v4 9/9] doc: add cxgbe PMD documentation under doc/guides/nics/cxgbe.rst

2015-06-30 Thread Rahul Lakkireddy
Adds cxgbe poll mode driver documentation under the usual doc/guides/nics/ directory with the rest of the drivers. The documentation covers cxgbe implementation details, features and limitations, prerequisites, configuration, and a sample application usage. Signed-off-by: Rahul Lakkireddy

[dpdk-dev] [PATCH v4 0/9] Chelsio Terminator 5 (T5) 10G/40G Poll Mode Driver

2015-07-01 Thread Rahul Lakkireddy
On Tue, Jun 30, 2015 at 23:01:39 +0200, Thomas Monjalon wrote: > 2015-06-30 04:58, Rahul Lakkireddy: > > This series of patches add the CXGBE Poll Mode Driver support for Chelsio > > Terminator 5 series of 10G/40G adapters. The CXGBE PMD is split into > > multiple > >

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-07 Thread Rahul Lakkireddy
Hi Alejandro, On Mon, Jul 06, 2015 at 16:45:01 +0100, Alejandro Lucero wrote: > Hi all, > > From the kernel VFIO maintainer: > > "I suppose in the short term, mmap should not be advertised as available > on 32bit hosts. Thanks," > > So, as VFIO support for 32bit systems is broken, DPDK should

[dpdk-dev] [PATCH 0/3] cxgbe: RX perf fixes, doc update, and add support for more devices

2015-07-07 Thread Rahul Lakkireddy
T5 devices. Rahul Lakkireddy (3): cxgbe: Fix RX performance for cxgbe PMD. cxgbe: Add more supported Chelsio T5 devices. doc: Update cxgbe documentation doc/guides/nics/cxgbe.rst | 84 ++- drivers/net/cxgbe/base/adapter.h| 2 + drivers/net/cxgbe/base

[dpdk-dev] [PATCH 1/3] cxgbe: Fix RX performance for cxgbe PMD.

2015-07-07 Thread Rahul Lakkireddy
CXGBE PMD rx allocates a new mbuf everytime, which could lead to performance hit. Instead, do bulk allocation of mbufs and re-use them. Also, simplify the overall rx-handler, and update its logic to fix rx perf. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net

[dpdk-dev] [PATCH 2/3] cxgbe: Add more supported Chelsio T5 devices.

2015-07-07 Thread Rahul Lakkireddy
Update pci id table to include more supported Chelsio T5 devices. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/base/t4_pci_id_tbl.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/cxgbe/base/t4_pci_id_tbl.h b/drivers/net/cxgbe/base

[dpdk-dev] [PATCH 3/3] doc: Update cxgbe documentation

2015-07-07 Thread Rahul Lakkireddy
Update cxgbe documentation with the following: 1. Add instructions on how to flash firmware and config file on Chelsio T5 devices. 2. Add a list of supported devices. 3. Add instructions on how to enable and disable flow control via testpmd. Signed-off-by: Rahul Lakkireddy Signed-off

[dpdk-dev] [PATCH 1/3] cxgbe: Fix RX performance for cxgbe PMD.

2015-07-09 Thread Rahul Lakkireddy
Hi Thomas, On Tue, Jul 07, 2015 at 23:30:38 +0200, Thomas Monjalon wrote: > 2015-07-07 22:42, Rahul Lakkireddy: > > CXGBE PMD rx allocates a new mbuf everytime, which could lead to performance > > hit. Instead, do bulk allocation of mbufs and re-use them. > > > > Al

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

2016-07-26 Thread Rahul Lakkireddy
On Monday, July 07/25/16, 2016 at 09:40:02 -0700, John Fastabend wrote: > On 16-07-25 04:32 AM, Rahul Lakkireddy wrote: > > Hi Adrien, > > > > On Thursday, July 07/21/16, 2016 at 19:07:38 +0200, Adrien Mazarguil wrote: > >> Hi Rahul, > >> > >>

[dpdk-dev] removal of old deprecation notice for Chelsio filtering

2016-07-28 Thread Rahul Lakkireddy
Hi Thomas, On Thursday, July 07/28/16, 2016 at 01:29:20 -0700, Thomas Monjalon wrote: > Hi Rahul, > > We still have this deprecation notice: > > * ABI changes are planned for adding four new flow types. This impacts > RTE_ETH_FLOW_MAX. The release 2.2 does not contain these ABI changes, >

[dpdk-dev] [PATCH] doc: remove deprecation notice related to new flow types

2016-07-28 Thread Rahul Lakkireddy
Remove deprecation notice pertaining to introduction of new flow types in favor of a more generic filtering infrastructure proposal. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 deletions(-) diff --git a/doc

[dpdk-dev] [PATCH 1/5] pci: fix access to PCI config space in bsd

2016-06-01 Thread Rahul Lakkireddy
Hi Bruce, On Tuesday, May 05/31/16, 2016 at 09:20:13 -0700, Bruce Richardson wrote: > On Fri, May 06, 2016 at 01:13:15PM +0530, Rahul Lakkireddy wrote: > > PCIOCREAD and PCIOCWRITE ioctls to read/write PCI config space fail > > with EPERM due to missing write permission. Fix by o

[dpdk-dev] [PATCH v2 0/6] cxgbe: Optimize tx/rx for 40GbE and add Jumbo Frame support for CXGBE PMD

2015-10-21 Thread Rahul Lakkireddy
Hi Thomas, On Tuesday, October 10/20/15, 2015 at 09:51:07 -0700, Thomas Monjalon wrote: > 2015-10-08 19:16, Rahul Lakkireddy: > > This series of patches improve forwarding performance for Chelsio T5 40GbE > > cards and add Jumbo Frame support for cxgbe pmd. Also updat

[dpdk-dev] [PATCH 16/20] cxgbe: copy pci device info to eth_dev data

2015-09-29 Thread Rahul Lakkireddy
Hi Bernard, On Monday, September 09/28/15, 2015 at 14:03:34 +0100, Bernard Iremonger wrote: > Signed-off-by: Bernard Iremonger > --- > drivers/net/cxgbe/cxgbe_ethdev.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c >

[dpdk-dev] [PATCH 0/5] Chelsio Terminator 5 (T5) 10G/40G Poll Mode Driver

2015-05-22 Thread Rahul Lakkireddy
. More information on the CXGBE PMD can be found in the documentation added by the third patch. Also, the CXGBE PMD is enabled for compilation and linking by the fourth patch. Finally, update MAINTAINERS file to claim responsibility for the CXGBE PMD. Rahul Lakkireddy (5): cxgbe: add hardware

[dpdk-dev] [PATCH 1/5] cxgbe: add hardware specific api for all supported Chelsio T5 series adapters.

2015-05-22 Thread Rahul Lakkireddy
Adds hardware specific api for all the Chelsio T5 adapters under lib/librte_pmd_cxgbe/cxgbe directory. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- lib/librte_pmd_cxgbe/cxgbe/adapter.h| 560 ++ lib/librte_pmd_cxgbe/cxgbe/common.h | 401 lib

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-22 Thread Rahul Lakkireddy
Adds cxgbe poll mode driver for DPDK under lib/librte_pmd_cxgbe directory. This patch: 1. Adds the Makefile to compile cxgbe pmd. 2. Registers and initializes the cxgbe pmd driver. 3. Implements the necessary eth_dev_ops. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- lib

[dpdk-dev] [PATCH 3/5] doc: add cxgbe PMD documentation under doc/guides/nics/cxgbe.rst

2015-05-22 Thread Rahul Lakkireddy
Adds cxgbe poll mode driver documentation under the usual doc/guides/nics/ directory with the rest of the drivers. The documentation covers cxgbe implementation details, features and limitations, prerequisites, configuration, and a sample application usage. Signed-off-by: Rahul Lakkireddy

[dpdk-dev] [PATCH 4/5] config: enable cxgbe PMD for compilation and linking.

2015-05-22 Thread Rahul Lakkireddy
Changes to: 1. config/common_linuxapp to add macros for cxgbe pmd. 2. lib/Makefile to add cxgbe pmd to the compile list. 3. mk/rte.app.mk to add cxgbe pmd to link. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- config/common_linuxapp | 10 ++ lib/Makefile

[dpdk-dev] [PATCH 5/5] maintainers: claim responsibility for cxgbe PMD.

2015-05-22 Thread Rahul Lakkireddy
Update MAINTAINERS file to claim responsibility for the cxgbe PMD. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- MAINTAINERS |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0477e7d..37b7472 100644 --- a/MAINTAINERS

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-23 Thread Rahul Lakkireddy
On Fri, May 22, 2015 at 09:43:20 -0700, Stephen Hemminger wrote: > On Fri, 22 May 2015 18:54:20 +0530 > Rahul Lakkireddy wrote: > > > +/** > > + * fls - find last (most-significant) bit set > > + * @x: the word to search > > + * > > + * This is defined

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-23 Thread Rahul Lakkireddy
On Fri, May 22, 2015 at 09:42:50 -0700, Stephen Hemminger wrote: > On Fri, 22 May 2015 18:54:20 +0530 > Rahul Lakkireddy wrote: > > > +#define pr_err(y, args...) dev_err(0, y, ##args) > > +#define pr_warn(y, args...) dev_warn(0, y, ##args) > > +#define pr_info(y, arg

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-26 Thread Rahul Lakkireddy
On Sat, May 23, 2015 at 11:27:56 +0530, Rahul Lakkireddy wrote: > On Fri, May 22, 2015 at 09:42:50 -0700, Stephen Hemminger wrote: > > On Fri, 22 May 2015 18:54:20 +0530 > > Rahul Lakkireddy wrote: > > > > > +#define pr_err(y, args...) dev_err(0, y, ##args)

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-27 Thread Rahul Lakkireddy
On Tue, May 26, 2015 at 10:24:37 -0700, Stephen Hemminger wrote: > On Tue, 26 May 2015 22:32:07 +0530 > Rahul Lakkireddy wrote: > > > On Sat, May 23, 2015 at 11:27:56 +0530, Rahul Lakkireddy wrote: > > > On Fri, May 22, 2015 at 09:42:50 -0700, Stephen Hemminger wrote: >

[dpdk-dev] [PATCH 3/5] doc: add cxgbe PMD documentation under doc/guides/nics/cxgbe.rst

2015-05-27 Thread Rahul Lakkireddy
On Wed, May 27, 2015 at 07:38:50 +0200, Thomas Monjalon wrote: > 2015-05-22 18:54, Rahul Lakkireddy: > > Adds cxgbe poll mode driver documentation under the usual doc/guides/nics/ > > directory with the rest of the drivers. The documentation covers cxgbe > > implementat

[dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.

2015-05-27 Thread Rahul Lakkireddy
On Tue, May 26, 2015 at 22:49:08 -0700, Thomas Monjalon wrote: > 2015-05-23 11:23, Rahul Lakkireddy: > > We need to rebase anyway since PMDs now seem to have moved to > > drivers/net directory. > > Yes. And the subdirectory should probably be renamed base/. Yes, we will do

[dpdk-dev] [PATCH] ethdev: add a missing sanity check for nb_tx_desc during txq setup

2015-11-20 Thread Rahul Lakkireddy
Add a sanity check for number of tx descriptors requested during tx queue setup. Return -EINVAL if the number requested does not meet the tx descriptor requirements of the device. Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information") Signed-off-by: Rahul Lakkireddy

[dpdk-dev] [PATCH 0/2] cxgbe: Minor fixes in cxgbe pmd

2015-11-20 Thread Rahul Lakkireddy
. Patch 2 replaces spinning for a lock with a better trylock in tx alarm callback. Rahul Lakkireddy (2): cxgbe: fix queue setup failure due to strict min desc requirement cxgbe: fix unnecessary spinning for a lock with trylock instead drivers/net/cxgbe/base/adapter.h | 9 + drivers/net

[dpdk-dev] [PATCH 1/2] cxgbe: fix queue setup failure due to strict min desc requirement

2015-11-20 Thread Rahul Lakkireddy
is to relax this enforcing in CXGBE PMD. A minimum of 128 descriptors seems to be a good number with the least impact on the performance. Fixes: 946c9ed95616 ("cxgbe: get descriptor limits") Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/cxgbe.h | 2

[dpdk-dev] [PATCH 2/2] cxgbe: fix unnecessary spinning for a lock with trylock instead

2015-11-20 Thread Rahul Lakkireddy
CXGBE PMD depends on an alarm to periodically transmit any pending coalesced packets and hence spins for a lock for each tx queue in the alarm callback. A better solution is to try to get a lock whenever possible, instead of spinning for it. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar

[dpdk-dev] |ERROR| pw 9018 ethdev: add a missing sanity check for nb_tx_desc during txq setup

2015-11-20 Thread Rahul Lakkireddy
bel: Intel Niantic on Fedora > Test-Status: ERROR > Patchwork: http://www.dpdk.org/dev/patchwork/patch/9018/ > > DPDK git baseline: e64833f2273ac67becbca10d9f2f1598872dc99e > Patchwork ID: 9018 > http://www.dpdk.org/dev/patchwork/patch/9018/ > Submitter: Rahul Lakkireddy > Date

[dpdk-dev] Query on Filtering Support in DPDK

2015-11-30 Thread Rahul Lakkireddy
Hi, We are working towards adding h/w based filtering support in cxgbe PMD. Chelsio T5 supports carrying out filtering in hardware which supports 3 actions to carry out on a packet which hit a filter viz. 1. Action Pass - Packets hitting a filter rule can be directed to a particular RXQ. 2.

[dpdk-dev] [PATCH 0/6] cxgbe: Optimize tx/rx for 40GbE and add Jumbo Frame support for CXGBE PMD

2015-10-02 Thread Rahul Lakkireddy
This series of patches improve forwarding performance for Chelsio T5 40GbE cards and add Jumbo Frame support for cxgbe pmd. Also update documentation and release notes. Rahul Lakkireddy (6): cxgbe: Optimize forwarding performance for 40G cxgbe: Update device info and perform sanity checks

[dpdk-dev] [PATCH 1/6] cxgbe: Optimize forwarding performance for 40G

2015-10-02 Thread Rahul Lakkireddy
. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/base/t4_regs.h | 16 drivers/net/cxgbe/cxgbe_main.c | 7 +++ drivers/net/cxgbe/sge.c | 17 - 3 files changed, 35 insertions(+), 5 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH 2/6] cxgbe: Update device info and perform sanity checks to enable jumbo frames

2015-10-02 Thread Rahul Lakkireddy
Increase max_rx_pktlen to accommodate jumbo frame size. Perform sanity checks and enable jumbo mode in rx queue setup. Set link mtu based on max_rx_pktlen. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/cxgbe.h| 3 +++ drivers/net/cxgbe

[dpdk-dev] [PATCH 3/6] cxgbe: Update tx path to transmit jumbo frames

2015-10-02 Thread Rahul Lakkireddy
Add a non-coalesce path. Skip coalescing for Jumbo Frames, and send the packet through non-coalesced path if there are enough credits. Also, free these non-coalesced packets while reclaiming credits. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/sge.c

[dpdk-dev] [PATCH 4/6] cxgbe: Update rx path to receive jumbo frames

2015-10-02 Thread Rahul Lakkireddy
Ensure jumbo mode is enabled and that the mbuf data room size can accommodate jumbo size. If the mbuf data room size can't accommodate jumbo size, chain mbufs to jumbo size. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/sge.c | 58

  1   2   >