Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-31 Thread Ye Xiaolong
Hi, Ferruh On 01/29, Ferruh Yigit wrote: [snip] > >Hi Xiaolong, > >Your analysis looks correct, thanks for history provided, it seems renaming >"state" to "status" was not correct [1]. > >The intention of the 'pci_check_and_mask_intx()' is mask the interrupt if it is >from this device, so your sug

Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-29 Thread Ferruh Yigit
On 1/17/2019 2:13 AM, Ye Xiaolong wrote: > On 01/16, Stephen Hemminger wrote: >> On Wed, 16 Jan 2019 15:48:36 +0800 >> Ye Xiaolong wrote: >> >>> Hi, Stephen >>> >>> On 01/15, Stephen Hemminger wrote: On Wed, 16 Jan 2019 08:34:52 +0800 Xiaolong Ye wrote: > The comment for igbu

Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-21 Thread Ye Xiaolong
Hi, Stephen On 01/17, Ye Xiaolong wrote: >On 01/16, Stephen Hemminger wrote: >>On Wed, 16 Jan 2019 15:48:36 +0800 >>Ye Xiaolong wrote: >> >>> Hi, Stephen >>> >>> On 01/15, Stephen Hemminger wrote: >>> >On Wed, 16 Jan 2019 08:34:52 +0800 >>> >Xiaolong Ye wrote: >>> > >>> >> The comment for igb

Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-16 Thread Ye Xiaolong
On 01/16, Stephen Hemminger wrote: >On Wed, 16 Jan 2019 15:48:36 +0800 >Ye Xiaolong wrote: > >> Hi, Stephen >> >> On 01/15, Stephen Hemminger wrote: >> >On Wed, 16 Jan 2019 08:34:52 +0800 >> >Xiaolong Ye wrote: >> > >> >> The comment for igbuio_pci_irqhandler is out of date as the code evolves

Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-16 Thread Stephen Hemminger
On Wed, 16 Jan 2019 15:48:36 +0800 Ye Xiaolong wrote: > Hi, Stephen > > On 01/15, Stephen Hemminger wrote: > >On Wed, 16 Jan 2019 08:34:52 +0800 > >Xiaolong Ye wrote: > > > >> The comment for igbuio_pci_irqhandler is out of date as the code evolves, > >> remove it to avoid misleading. > >> >

Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-15 Thread Ye Xiaolong
Hi, Stephen On 01/15, Stephen Hemminger wrote: >On Wed, 16 Jan 2019 08:34:52 +0800 >Xiaolong Ye wrote: > >> The comment for igbuio_pci_irqhandler is out of date as the code evolves, >> remove it to avoid misleading. >> >> Signed-off-by: Xiaolong Ye >> --- >> kernel/linux/igb_uio/igb_uio.c | 4

Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-15 Thread Ye Xiaolong
On 01/15, Stephen Hemminger wrote: >On Wed, 16 Jan 2019 08:34:52 +0800 >Xiaolong Ye wrote: > >> The comment for igbuio_pci_irqhandler is out of date as the code evolves, >> remove it to avoid misleading. >> >> Signed-off-by: Xiaolong Ye >> --- >> kernel/linux/igb_uio/igb_uio.c | 4 >> 1 fi

Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-15 Thread Stephen Hemminger
On Wed, 16 Jan 2019 08:34:52 +0800 Xiaolong Ye wrote: > The comment for igbuio_pci_irqhandler is out of date as the code evolves, > remove it to avoid misleading. > > Signed-off-by: Xiaolong Ye > --- > kernel/linux/igb_uio/igb_uio.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/