[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165704469 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -956,21 +925,8 @@ private void

[GitHub] drill pull request #1108: DRILL-6130: Fix NPE during physical plan submissio...

GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/1108 DRILL-6130: Fix NPE during physical plan submission for various storage plugins 1. Fixed ser / de issues for Hive, Kafka, Hbase plugins. 2. Added physical plan submission unit test for

Re: LATERAL and UNNEST support for Drill

It’s all consistent - really! Consider ‘x OR NOT y’. Is ‘OR NOT’ an operator? Of course not. ‘NOT’ is a prefix operator, and ‘OR’ applies to its result. Similarly, ‘x JOIN LATERAL y ON (c)’, the ‘LATERAL’ applies to ‘y’ more, and only later does the ‘JOIN’ kick in. ‘LATERAL’ can apply to any

[GitHub] drill issue #1108: DRILL-6130: Fix NPE during physical plan submission for v...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1108 @vdiravka please review. ---

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r165698800 --- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java --- @@ -703,7 +703,18 @@ protected void _setLong(int index, long value) {

Re: LATERAL and UNNEST support for Drill

Internally, within the query engine both LATERAL and CROSS/OUTER APPLY would be essentially doing the same work. After thinking about this some more, from the syntax perspective I do see Julian's point about the CROSS/OUTER APPLY having some advantages over LATERAL. In particular, with LATERAL

Error in Drill 1.13

Hello all, I’m getting ready to submit a PR for a log format plugin for Drill and after I rebased Drill, I’m now getting the following error: java.lang.IncompatibleClassChangeError: Found interface org.apache.drill.exec.ops.FragmentContext, but class was expected at

[GitHub] drill pull request #:

Github user Ben-Zvi commented on the pull request: https://github.com/apache/drill/commit/f911575abd9672866b39926a60c1731bbeee155f#commitcomment-27300995 In exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java: In

[GitHub] drill pull request #:

Github user ilooner commented on the pull request: https://github.com/apache/drill/commit/f911575abd9672866b39926a60c1731bbeee155f#commitcomment-27301156 In exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java: In

Re: Error in Drill 1.13

Hi Charles, FragmentContext used to be a concrete class. Now the FragmentContext has been changed to an interface, and the concrete class that implements it is now FragmentContextImpl Thanks, Tim From: Charles Givre Sent: Friday, February 2,

[jira] [Created] (DRILL-6132) HashPartitionSender leaks memory

Chun Chang created DRILL-6132: - Summary: HashPartitionSender leaks memory Key: DRILL-6132 URL: https://issues.apache.org/jira/browse/DRILL-6132 Project: Apache Drill Issue Type: Bug

[jira] [Created] (DRILL-6133) RecordBatchSizer throws IndexOutOfBounds Exception for union vector

Padma Penumarthy created DRILL-6133: --- Summary: RecordBatchSizer throws IndexOutOfBounds Exception for union vector Key: DRILL-6133 URL: https://issues.apache.org/jira/browse/DRILL-6133 Project:

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1101 An additional comment is that after the defaults were reduced the number of random failures we see in our functional tests decreased to just 3. Typically there are more than that. ---

[GitHub] drill pull request #1096: DRILL-6099 : Push limit past flatten(project) with...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1096#discussion_r165788152 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java --- @@ -55,18 +62,21 @@ public void

[GitHub] drill pull request #1096: DRILL-6099 : Push limit past flatten(project) with...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1096#discussion_r165791415 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java --- @@ -55,18 +62,21 @@ public void

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1101 @Ben-Zvi I have responded to comments and implemented requested changes. Please see latest commits for changes. I have made some additional changes after noticing that some of the batch sizing