[GitHub] drill pull request #1141: DRILL-6197: Skip duplicate entry for OperatorStats

2018-03-01 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1141#discussion_r171485412 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentStats.java --- @@ -31,6 +32,13 @@ public class FragmentStats { // private

[GitHub] drill issue #1140: DRILL-6195: Quering Hive non-partitioned transactional ta...

2018-03-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1140 +1 ---

[jira] [Created] (DRILL-6198) OpenTSDB unit tests fail when Lilith client is run

2018-03-01 Thread Volodymyr Vysotskyi (JIRA)
Volodymyr Vysotskyi created DRILL-6198: -- Summary: OpenTSDB unit tests fail when Lilith client is run Key: DRILL-6198 URL: https://issues.apache.org/jira/browse/DRILL-6198 Project: Apache Drill

[jira] [Created] (DRILL-6199) Filter push down doesn't work with more than one nested subqueries

2018-03-01 Thread Anton Gozhiy (JIRA)
Anton Gozhiy created DRILL-6199: --- Summary: Filter push down doesn't work with more than one nested subqueries Key: DRILL-6199 URL: https://issues.apache.org/jira/browse/DRILL-6199 Project: Apache Drill

[GitHub] drill pull request #1139: DRILL-6189: Security: passwords logging and file p...

2018-03-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1139#discussion_r171512007 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -320,7 +348,7 @@ protected void consumeHandshake(Channe

[GitHub] drill pull request #1139: DRILL-6189: Security: passwords logging and file p...

2018-03-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1139#discussion_r171511274 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -91,6 +91,34 @@ static { userConnection

[GitHub] drill pull request #1139: DRILL-6189: Security: passwords logging and file p...

2018-03-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1139#discussion_r171510779 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -91,6 +91,34 @@ static { userConnection

[GitHub] drill pull request #1139: DRILL-6189: Security: passwords logging and file p...

2018-03-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1139#discussion_r171511391 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -91,6 +91,34 @@ static { userConnection

[GitHub] drill pull request #1139: DRILL-6189: Security: passwords logging and file p...

2018-03-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1139#discussion_r171512422 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java --- @@ -158,7 +162,9 @@ protected void log

[GitHub] drill issue #1137: DRILL-6185: Fixed error while displaying system profiles ...

2018-03-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1137 I meant that we parse text plan, obviously it was generated from the some object. For the future we may consider to create special plan object from initial one which will have structure suit

Re: Avro storage format behaviour

2018-03-01 Thread Arina Yelchiyeva
As Paul has mentioned in PR [1] when we move to new scan framework it will handle implicit columns for all file readers. I guess till that let's treat avro as other file formats (for example, parquet) so users can benefit from implicit columns for this format as well. [1] https://github.com/apache

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r171517376 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/avro/AvroFormatTest.java --- @@ -170,25 +169,35 @@ public void testSimplePrimit

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-01 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r171544478 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/avro/AvroFormatTest.java --- @@ -170,25 +169,35 @@ public void testSimplePrimitiveSch

[GitHub] drill pull request #1142: DRILL-6198: OpenTSDB unit tests fail when Lilith c...

2018-03-01 Thread vvysotskyi
GitHub user vvysotskyi opened a pull request: https://github.com/apache/drill/pull/1142 DRILL-6198: OpenTSDB unit tests fail when Lilith client is run Added method which checks that the default port 10_000 is free, otherwise this method increases port number and checks until free po

Re: [DISCUSS] 1.13.0 release

2018-03-01 Thread Ted Dunning
DRILL-6190 and DRILL-6191 are ready to merge to master for release. Code review and unit tests all pass. On Wed, Feb 28, 2018 at 11:16 PM, Parth Chandra wrote: > Moved Ted's PR's down in the list. Let's see where we are at the end of the > week. > Arina, Volodymyr, ank ETA on JDK 8 work? It's

Re: [DISCUSS] 1.13.0 release

2018-03-01 Thread Parth Chandra
Good show. Updated list: DRILL-6185: Error is displaying while accessing query profiles via the Web-UI -- Ready to commit DRILL-6174: Parquet pushdown planning improvements -- Ready to commit DRILL-6191: Need more information on TCP flags -- Ready to commit DRILL-6190: Packets can be bigger than

[jira] [Created] (DRILL-6200) ERROR Quering hive through HiverServer2 via JDBC!

2018-03-01 Thread Hannibal07 (JIRA)
Hannibal07 created DRILL-6200: - Summary: ERROR Quering hive through HiverServer2 via JDBC! Key: DRILL-6200 URL: https://issues.apache.org/jira/browse/DRILL-6200 Project: Apache Drill Issue Type:

[GitHub] drill pull request #1139: DRILL-6189: Security: passwords logging and file p...

2018-03-01 Thread vladimirtkach
Github user vladimirtkach commented on a diff in the pull request: https://github.com/apache/drill/pull/1139#discussion_r171579096 --- Diff: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStorageConfig.java --- @@ -17,13 +17,15 @@ */ package org

[GitHub] drill issue #1139: DRILL-6189: Security: passwords logging and file permisio...

2018-03-01 Thread vladimirtkach
Github user vladimirtkach commented on the issue: https://github.com/apache/drill/pull/1139 @arina-ielchiieva made changes, please take a look ---

[GitHub] drill pull request #1143: DRILL-1491: Support for JDK 8

2018-03-01 Thread vladimirtkach
GitHub user vladimirtkach opened a pull request: https://github.com/apache/drill/pull/1143 DRILL-1491: Support for JDK 8 Changed jdk version from 7 to 8 in pom.xml, drill-config.sh and others You can merge this pull request into a Git repository by running: $ git pull https://g

[GitHub] drill pull request #1139: DRILL-6189: Security: passwords logging and file p...

2018-03-01 Thread vladimirtkach
Github user vladimirtkach commented on a diff in the pull request: https://github.com/apache/drill/pull/1139#discussion_r171588799 --- Diff: logical/src/main/java/org/apache/drill/common/config/LogicalPlanPersistence.java --- @@ -52,6 +53,7 @@ public LogicalPlanPersistence(DrillCo

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r171607241 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroRecordReader.java --- @@ -295,7 +301,8 @@ private void processPrimitive(fina

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r171606330 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroRecordReader.java --- @@ -154,6 +156,12 @@ public int next() {

[GitHub] drill issue #1138: DRILL-4120: Allow implicit columns for Avro storage forma...

2018-03-01 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1138 As @arina-ielchiieva points out, this change backs out plan-time knowledge of schema. This may not affect run-time accuracy. However, it does mean that queries can be planned, based on not knowin

[GitHub] drill pull request #1141: DRILL-6197: Skip duplicate entry for OperatorStats

2018-03-01 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1141#discussion_r171611927 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentStats.java --- @@ -79,4 +71,21 @@ public void addOperatorStats(OperatorStats st

[GitHub] drill pull request #1142: DRILL-6198: OpenTSDB unit tests fail when Lilith c...

2018-03-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1142#discussion_r171606840 --- Diff: contrib/storage-opentsdb/src/test/java/org/apache/drill/store/openTSDB/TestOpenTSDBPlugin.java --- @@ -51,17 +54,17 @@ public

[GitHub] drill pull request #1142: DRILL-6198: OpenTSDB unit tests fail when Lilith c...

2018-03-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1142#discussion_r171606555 --- Diff: contrib/storage-opentsdb/src/test/java/org/apache/drill/store/openTSDB/TestOpenTSDBPlugin.java --- @@ -51,17 +54,17 @@ public

[GitHub] drill pull request #1142: DRILL-6198: OpenTSDB unit tests fail when Lilith c...

2018-03-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1142#discussion_r171607424 --- Diff: contrib/storage-opentsdb/src/test/java/org/apache/drill/store/openTSDB/TestOpenTSDBPlugin.java --- @@ -185,4 +188,26 @@ public void testD

[GitHub] drill pull request #1142: DRILL-6198: OpenTSDB unit tests fail when Lilith c...

2018-03-01 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1142#discussion_r171618633 --- Diff: contrib/storage-opentsdb/src/test/java/org/apache/drill/store/openTSDB/TestOpenTSDBPlugin.java --- @@ -51,17 +54,17 @@ public class

[GitHub] drill pull request #1142: DRILL-6198: OpenTSDB unit tests fail when Lilith c...

2018-03-01 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1142#discussion_r171617811 --- Diff: contrib/storage-opentsdb/src/test/java/org/apache/drill/store/openTSDB/TestOpenTSDBPlugin.java --- @@ -51,17 +54,17 @@ public class

[GitHub] drill pull request #1142: DRILL-6198: OpenTSDB unit tests fail when Lilith c...

2018-03-01 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1142#discussion_r171620225 --- Diff: contrib/storage-opentsdb/src/test/java/org/apache/drill/store/openTSDB/TestOpenTSDBPlugin.java --- @@ -185,4 +188,26 @@ public void testDescrib

[GitHub] drill issue #1138: DRILL-4120: Allow implicit columns for Avro storage forma...

2018-03-01 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1138 Another thought. The removed code is at plan time. Did the original code have to open each file to retrieve schema? If so, does removing the code remove that load? If so, then this change could b

[jira] [Created] (DRILL-6201) Failed to create input splits: No FileSystem for scheme: maprfs

2018-03-01 Thread Willian Mattos Ribeiro (JIRA)
Willian Mattos Ribeiro created DRILL-6201: - Summary: Failed to create input splits: No FileSystem for scheme: maprfs Key: DRILL-6201 URL: https://issues.apache.org/jira/browse/DRILL-6201 Proje

[jira] [Created] (DRILL-6202) Deprecate usage of IndexOutOfBoundsException to re-alloc vectors

2018-03-01 Thread Vlad Rozov (JIRA)
Vlad Rozov created DRILL-6202: - Summary: Deprecate usage of IndexOutOfBoundsException to re-alloc vectors Key: DRILL-6202 URL: https://issues.apache.org/jira/browse/DRILL-6202 Project: Apache Drill

[GitHub] drill pull request #1141: DRILL-6197: Skip duplicate entry for OperatorStats

2018-03-01 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1141#discussion_r171648058 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentStats.java --- @@ -79,4 +71,21 @@ public void addOperatorStats(OperatorStats stats)

[GitHub] drill issue #1138: DRILL-4120: Allow implicit columns for Avro storage forma...

2018-03-01 Thread vvysotskyi
Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1138 @paul-rogers, schema is taken from the first file in the `FormatSelection`. Therefore for the case, when we have a table with several files with a different scheme, Drill query will fail.

[GitHub] drill pull request #1096: DRILL-6099 : Push limit past flatten(project) with...

2018-03-01 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/1096#discussion_r171708384 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java --- @@ -224,4 +226,64 @@ public Void visitInputRef(RexInputR

[GitHub] drill pull request #1096: DRILL-6099 : Push limit past flatten(project) with...

2018-03-01 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/1096#discussion_r171708410 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java --- @@ -224,4 +226,64 @@ public Void visitInputRef(RexInputR

[GitHub] drill pull request #1096: DRILL-6099 : Push limit past flatten(project) with...

2018-03-01 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/1096#discussion_r171708439 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java --- @@ -224,4 +226,64 @@ public Void visitInputRef(RexInputR

[GitHub] drill pull request #1096: DRILL-6099 : Push limit past flatten(project) with...

2018-03-01 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/1096#discussion_r171708636 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java --- @@ -55,18 +62,21 @@ public void onMatch(RelOpt

[GitHub] drill issue #1096: DRILL-6099 : Push limit past flatten(project) without pus...

2018-03-01 Thread gparai
Github user gparai commented on the issue: https://github.com/apache/drill/pull/1096 @amansinha100 I have addressed your review comments. Please take a look. Thanks! ---

[GitHub] drill pull request #1144: DRILL-6202: Deprecate usage of IndexOutOfBoundsExc...

2018-03-01 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/1144 DRILL-6202: Deprecate usage of IndexOutOfBoundsException to re-alloc vectors You can merge this pull request into a Git repository by running: $ git pull https://github.com/vrozov/drill DRILL-6

[GitHub] drill issue #1096: DRILL-6099 : Push limit past flatten(project) without pus...

2018-03-01 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/1096 Updated version lgtm. +1 ---

[GitHub] drill pull request #1096: DRILL-6099 : Push limit past flatten(project) with...

2018-03-01 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1096#discussion_r171711326 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java --- @@ -55,18 +62,21 @@ public void onMatch(

[GitHub] drill issue #1144: DRILL-6202: Deprecate usage of IndexOutOfBoundsException ...

2018-03-01 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1144 @parthchandra Please take a look. ---

[jira] [Created] (DRILL-6203) Repeated Map Vector does not give correct payload bytecount

2018-03-01 Thread Padma Penumarthy (JIRA)
Padma Penumarthy created DRILL-6203: --- Summary: Repeated Map Vector does not give correct payload bytecount Key: DRILL-6203 URL: https://issues.apache.org/jira/browse/DRILL-6203 Project: Apache Drill

[GitHub] drill pull request #1141: DRILL-6197: Skip duplicate entry for OperatorStats

2018-03-01 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1141#discussion_r171723902 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentStats.java --- @@ -79,4 +71,21 @@ public void addOperatorStats(OperatorStats st

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-03-01 Thread kr-arjun
Github user kr-arjun commented on the issue: https://github.com/apache/drill/pull/1011 @paul-rogers Currently , the Client exception is being output as 'ClientContext.err.println(e.getMessage())' in DrillOnYarn.java. For most of application master launcher failures, only message

[GitHub] drill pull request #1135: DRILL-6040: Added usage for graceful_stop in drill...

2018-03-01 Thread priteshm
Github user priteshm commented on a diff in the pull request: https://github.com/apache/drill/pull/1135#discussion_r171731905 --- Diff: distribution/src/resources/drillbit.sh --- @@ -45,7 +45,7 @@ # configuration file. The option takes precedence over the # DRILL_CONF_DIR

[GitHub] drill pull request #1141: DRILL-6197: Skip duplicate entry for OperatorStats

2018-03-01 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1141#discussion_r171740245 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentStats.java --- @@ -79,4 +71,21 @@ public void addOperatorStats(OperatorStats stats)

[GitHub] drill pull request #1145: DRILL-6187: Exception in RPC communication between...

2018-03-01 Thread sohami
GitHub user sohami opened a pull request: https://github.com/apache/drill/pull/1145 DRILL-6187: Exception in RPC communication between DataClient/Control… …Client and respective servers when bit-to-bit security is on You can merge this pull request into a Git repository by runni

[GitHub] drill issue #1145: DRILL-6187: Exception in RPC communication between DataCl...

2018-03-01 Thread sohami
Github user sohami commented on the issue: https://github.com/apache/drill/pull/1145 @vrozov - Please help to review this PR. It address the concurrency issue during authentication of control/data client to server side. Rather than adding the connection into connection holder righ

[GitHub] drill pull request #1141: DRILL-6197: Skip duplicate entry for OperatorStats

2018-03-01 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1141#discussion_r171748860 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentStats.java --- @@ -79,4 +71,21 @@ public void addOperatorStats(OperatorStats stats)

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is cancel...

2018-03-01 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1105 @arina-ielchiieva @vrozov I believe I have a solution. There were several issues with the original code. 1. It made incorrect assumptions about how cache invalidation works with java **synch

[GitHub] drill pull request #1141: DRILL-6197: Skip duplicate entry for OperatorStats

2018-03-01 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1141#discussion_r171753536 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentStats.java --- @@ -79,4 +71,21 @@ public void addOperatorStats(OperatorStats st

[GitHub] drill pull request #1141: DRILL-6197: Skip duplicate entry for OperatorStats

2018-03-01 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1141#discussion_r171767495 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentStats.java --- @@ -79,4 +71,21 @@ public void addOperatorStats(OperatorStats stats)

[GitHub] drill issue #1141: DRILL-6197: Skip duplicate entry for OperatorStats

2018-03-01 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/1141 +1. ---