[GitHub] drill pull request #1210: DRILL-6270: Add debug startup option flag for dril...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1210#discussion_r182022171 --- Diff: distribution/src/resources/runbit --- @@ -65,6 +65,47 @@ drill_rotate_log () fi } +args=( $@ ) +RBARGS=()

[GitHub] drill pull request #1207: DRILL-6320: Fixed License Headers

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1207 ---

Drill Tests Fail on Local Machine

All, I’m trying to test some things in Drill and the unit tests for the MongoDB are failing. I would like to know: 1. If it is possible to only run the unit tests for the components I am working on OR 2. It it is possible to skip the MongoDB tests 3. If it isn’t, does MongoDB ned to be

[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1203 Forgot to mention, this also resolves DRILL-5261 because of the protobuf carrying the HTTP port info. @arina-ielchiieva / @sohami / @dvjyothsna , please have a review of the changes. ---

[GitHub] drill pull request #1214: DRILL-6331: Revisit Hive Drill native parquet impl...

GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/1214 DRILL-6331: Revisit Hive Drill native parquet implementation to be ex… …posed to Drill optimizations (filter / limit push down, count to direct scan) 1. Factored out common

[jira] [Created] (DRILL-6336) Inconsistent method name.

KuiLIU created DRILL-6336: - Summary: Inconsistent method name. Key: DRILL-6336 URL: https://issues.apache.org/jira/browse/DRILL-6336 Project: Apache Drill Issue Type: Improvement

[GitHub] drill issue #1204: DRILL-6318

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1204 You could try re-pushing the last commit with a different commit ID (change a trailing text in the PR to have Git generate a different ID). I don't see an option within Travis to resubmit. ---

Re: License Header FYI

Hey Tim, I tried building master and encountered an error: mvn clean install -U -Pmapr -Drat.skip=false -Dlicense.skip=false ... [ERROR] Failed to execute goal com.mycila:license-maven-plugin:3.0:check > (default) on project drill-root: Some files do not have the expected > license header ->

[GitHub] drill pull request #1215: DRILL-6338: Do not skip license maven plugin when ...

GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1215 DRILL-6338: Do not skip license maven plugin when formatting generate… …d protobuf files. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Created] (DRILL-6338) License headers are not added to generated proto buf files with new license changes.

Timothy Farkas created DRILL-6338: - Summary: License headers are not added to generated proto buf files with new license changes. Key: DRILL-6338 URL: https://issues.apache.org/jira/browse/DRILL-6338

[GitHub] drill issue #1208: DRILL-6295: PartitionerDecorator may close partitioners w...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1208 +1 LGTM I do not see anymore race conditions ---

Re: Drill Tests Fail on Local Machine

Hi Tim, Here’s the error: Results : Tests in error: MongoTestSuit.initMongo:226 » Error while starting shrded cluster. Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 [INFO] [INFO] BUILD FAILURE [INFO]

[jira] [Created] (DRILL-6337) Kafka plugin, jdbc drill: NoClassDefFoundError: org/apache/hadoop/io/Text

Don Tavoletti created DRILL-6337: Summary: Kafka plugin, jdbc drill: NoClassDefFoundError: org/apache/hadoop/io/Text Key: DRILL-6337 URL: https://issues.apache.org/jira/browse/DRILL-6337 Project:

Re: Drill Tests Fail on Local Machine

Hi Charles, You can cd into the submodule that you want to test and run mvn clean install as usual. This will run only the unit tests for the sub module you cd'ed into. Could you post the tests that are failing for MongoDB along with the exceptions for those tests? If you could provide the

[GitHub] drill pull request #1212: DRILL-6323: Lateral Join - Initial implementation

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1212#discussion_r182172836 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/LateralJoinBatch.java --- @@ -0,0 +1,861 @@ +/* + * Licensed

[GitHub] drill pull request #1212: DRILL-6323: Lateral Join - Initial implementation

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1212#discussion_r182172309 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -186,6 +186,11 @@ private ExecConstants() { public static

[GitHub] drill pull request #1215: DRILL-6338: Do not skip license maven plugin when ...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1215#discussion_r182259451 --- Diff: protocol/pom.xml --- @@ -149,8 +152,12 @@ com.mycila license-maven-plugin +

[GitHub] drill pull request #1212: DRILL-6323: Lateral Join - Initial implementation

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1212#discussion_r182262104 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -186,6 +186,11 @@ private ExecConstants() { public static final

[GitHub] drill pull request #1212: DRILL-6323: Lateral Join - Initial implementation

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1212#discussion_r182259926 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/LateralJoinBatch.java --- @@ -0,0 +1,861 @@ +/* + * Licensed to the

Re: Drill Tests Fail on Local Machine

Here you go cgivre$ locale LANG="en_US.UTF-8" LC_COLLATE="en_US.UTF-8" LC_CTYPE="en_US.UTF-8" LC_MESSAGES="en_US.UTF-8" LC_MONETARY="en_US.UTF-8" LC_NUMERIC="en_US.UTF-8" LC_TIME="en_US.UTF-8" LC_ALL= Thank you VERY much for your help! > On Apr 17, 2018, at 18:53, Timothy Farkas

[GitHub] drill issue #1193: can drill support minio s3 storage

Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1193 Can one of PMCs request INFRA to close the PR? ---

[GitHub] drill issue #1196: DRILL-6286: Fixed incorrect reference to shutdown in dril...

Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1196 +1 ---

Re: Drill Tests Fail on Local Machine

Hi Charles, It looks like some people had issues with the MongoDB test library when their locale was not set properly. Can you provide the output of the locale command on your mac. Thanks, Tim From: Charles Givre Sent: Tuesday, April 17, 2018

[GitHub] drill pull request #1215: DRILL-6338: Do not skip license maven plugin when ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1215#discussion_r182266896 --- Diff: protocol/pom.xml --- @@ -149,8 +152,12 @@ com.mycila license-maven-plugin +

[jira] [Created] (DRILL-6340) Output Batch Control in Project using the RecordBatchSizer

Karthikeyan Manivannan created DRILL-6340: - Summary: Output Batch Control in Project using the RecordBatchSizer Key: DRILL-6340 URL: https://issues.apache.org/jira/browse/DRILL-6340 Project:

[DISCUSS] [Design] Output Batch Sizing in Project using the RecordBatchSizer

Hi, I have been working on a design to do Output Batch Sizing in Project using the RecordBatchSizer. The main challenge lies in dealing with expressions that produce variable-length output columns. The following doc talks about a design for dealing with such variable-length output columns.

[GitHub] drill issue #1215: DRILL-6338: Do not skip license maven plugin when formatt...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1215 @vrozov @arina-ielchiieva Please review. ---

[GitHub] drill issue #1208: DRILL-6295: PartitionerDecorator may close partitioners w...

Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1208 @parthchandra Please review ---

[jira] [Created] (DRILL-6339) New option to disable TopN (for testing Sort)

Boaz Ben-Zvi created DRILL-6339: --- Summary: New option to disable TopN (for testing Sort) Key: DRILL-6339 URL: https://issues.apache.org/jira/browse/DRILL-6339 Project: Apache Drill Issue Type:

License Header FYI

Hi All, Recently the license formatting checks have become stricter and all the license headers have been reformatted. The main benefit from this is that it is no longer allowed to have license headers in java doc comments. This will help keep our javadocs clean when we publish them. By

[GitHub] drill pull request #1217: DRILL-6302: Fixed NPE in Drillbit close method

GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1217 DRILL-6302: Fixed NPE in Drillbit close method @sohami Please review You can merge this pull request into a Git repository by running: $ git pull https://github.com/dvjyothsna/drill

Re: Drill Tests Fail on Local Machine

Hi Tim, Thanks for getting back with me. I’m on a Mac with High Sierra. Here’s my Java info: java -version java version "1.8.0_65" Java(TM) SE Runtime Environment (build 1.8.0_65-b17) Java HotSpot(TM) 64-Bit Server VM (build 25.65-b01, mixed mode) Thank you very much for your help! — C > On

[GitHub] drill pull request #1216: DRILL-6173: Support transitive closure during filt...

GitHub user vdiravka opened a pull request: https://github.com/apache/drill/pull/1216 DRILL-6173: Support transitive closure during filter push down and pa… …rtition pruning You can merge this pull request into a Git repository by running: $ git pull

Re: Drill Tests Fail on Local Machine

Hi Charles, According to this thread https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo/issues/167 there are a couple possibilities. Are you running 32-bit java or are you developing on Windows? Thanks, Tim From: Charles Givre

[GitHub] drill issue #1196: DRILL-6286: Fixed incorrect reference to shutdown in dril...

Github user dvjyothsna commented on the issue: https://github.com/apache/drill/pull/1196 @vrozov please review ---

Re: gitbox?

Hi Drill devs If no one has any objections I will open the Apache infra request to move to gitbox. Once this is setup, committers will be able to merge/commit without ever leaving github. Thanks Parth On Sun, Nov 12, 2017 at 8:00 AM, Kunal Khatua wrote: > My bad... I was

Re: Drill Tests Fail on Local Machine

HI Tim, No joy :-( --- Test set: org.apache.drill.exec.store.mongo.MongoTestSuit --- Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time

Re: Drill Tests Fail on Local Machine

Hi Charles, Can you try running the mongodb tests using this branch https://github.com/ilooner/drill/tree/mongodb-test-fix ? I can't reproduce the issue on my machine, but others reported setting the LC_ALL environment variable and upgrading the version of the test library resolved the issue

[GitHub] drill pull request #1218: DRILL-6335: Refactor row set abstractions to prepa...

GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/1218 DRILL-6335: Refactor row set abstractions to prepare for unions Refactors the column accessors to prepare for adding unions, lists and repeated lists. This is a subset of a PR done a

[GitHub] drill issue #1206: DRILL_6314: Add complex types to result set loader

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1206 Replacing this PR with a set of smaller ones. ---

[GitHub] drill issue #1218: DRILL-6335: Refactor row set abstractions to prepare for ...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1218 @ppadma , this PR contains a subset of the changes from the previous big PR. Mostly refactoring. Can you take a look? Thanks. ---

[GitHub] drill pull request #1219: DRILL-6339: Add a new option to disable TopN (for ...

GitHub user Ben-Zvi opened a pull request: https://github.com/apache/drill/pull/1219 DRILL-6339: Add a new option to disable TopN (for testing) To allow simple testing of the External Sort operator (e.g., test spilling), we would like to use a query of the form: " ORDER BY ...

[GitHub] drill pull request #1220: DRILL-6328: Consolidate developer docs in docs fol...

GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1220 DRILL-6328: Consolidate developer docs in docs folder. Consolidating the existing developer docs in the docs folder. This is just a copy paste from Paul's wiki

[GitHub] drill issue #1208: DRILL-6295: PartitionerDecorator may close partitioners w...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1208 +1 ---

[GitHub] drill pull request #1212: DRILL-6323: Lateral Join - Initial implementation

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1212#discussion_r182283067 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/LateralJoinBatch.java --- @@ -0,0 +1,861 @@ +/* + * Licensed

[GitHub] drill pull request #1206: DRILL_6314: Add complex types to result set loader

Github user paul-rogers closed the pull request at: https://github.com/apache/drill/pull/1206 ---

[GitHub] drill issue #1220: DRILL-6328: Consolidate developer docs in docs folder.

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1220 @paul-rogers @arina-ielchiieva Please review. After this goes in I will add the additional testing docs I wrote to Paul's existing documentation. ---

[GitHub] drill issue #1060: DRILL-5846: Improve parquet performance for Flat Data Typ...

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1060 @parthchandra , @vrozov I have done the following modifications: - Renamed newly added files with the prefix "VL" with "VarLen" as suggested by @parthchandra - After talking

[GitHub] drill pull request #1217: DRILL-6302: Fixed NPE in Drillbit close method

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1217#discussion_r182302719 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -225,14 +225,18 @@ public synchronized void close() { }