[jira] [Created] (DRILL-6846) Store test results

2018-11-12 Thread Vitalii Diravka (JIRA)
Vitalii Diravka created DRILL-6846: -- Summary: Store test results Key: DRILL-6846 URL: https://issues.apache.org/jira/browse/DRILL-6846 Project: Apache Drill Issue Type: Sub-task

[GitHub] Ben-Zvi commented on issue #1522: Drill 6735: Implement Semi-Join for the Hash-Join operator

2018-11-12 Thread GitBox
Ben-Zvi commented on issue #1522: Drill 6735: Implement Semi-Join for the Hash-Join operator URL: https://github.com/apache/drill/pull/1522#issuecomment-438119015 Good suggestions. The PR was changed - removed the 2nd and 3rd commits, and added a new commit with the Unused Hash Join

[GitHub] Ben-Zvi edited a comment on issue #1522: Drill 6735: Implement Semi-Join for the Hash-Join operator

2018-11-12 Thread GitBox
Ben-Zvi edited a comment on issue #1522: Drill 6735: Implement Semi-Join for the Hash-Join operator URL: https://github.com/apache/drill/pull/1522#issuecomment-438119015 Good suggestions. The PR was changed - removed the 2nd and 3rd commits, and added a new commit with the Unused Hash

Re: Hangout Discussion Topics

2018-11-12 Thread Timothy Farkas
Works for me. Then let's skip the hangout tomorrow. If there are any objections please feel free to respond to this thread. Thanks, Tim On Mon, Nov 12, 2018 at 5:35 PM Aman Sinha wrote: > Since we are having the Drill Developer day on Wednesday, perhaps we can > skip the hangout tomorrow ? > >

[GitHub] sohami commented on a change in pull request #1504: DRILL-6792: Find the right probe side fragment wrapper & fix DrillBuf…

2018-11-12 Thread GitBox
sohami commented on a change in pull request #1504: DRILL-6792: Find the right probe side fragment wrapper & fix DrillBuf… URL: https://github.com/apache/drill/pull/1504#discussion_r232881982 ## File path:

Re: Hangout Discussion Topics

2018-11-12 Thread Aman Sinha
Since we are having the Drill Developer day on Wednesday, perhaps we can skip the hangout tomorrow ? Aman On Mon, Nov 12, 2018 at 10:13 AM Timothy Farkas wrote: > Hi All, > > Does anyone have any topics to discuss during the hangout tomorrow? > > Thanks, > Tim >

[GitHub] vdiravka commented on issue #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2018-11-12 Thread GitBox
vdiravka commented on issue #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#issuecomment-438072903 @cgivre Please squash commits into the one and rebase the branch onto the latest master branch. Please add some description in the Jira or

[jira] [Created] (DRILL-6845) Eliminate duplicates for Semi Hash Join

2018-11-12 Thread Boaz Ben-Zvi (JIRA)
Boaz Ben-Zvi created DRILL-6845: --- Summary: Eliminate duplicates for Semi Hash Join Key: DRILL-6845 URL: https://issues.apache.org/jira/browse/DRILL-6845 Project: Apache Drill Issue Type:

[GitHub] sohami commented on a change in pull request #1504: DRILL-6792: Find the right probe side fragment wrapper & fix DrillBuf…

2018-11-12 Thread GitBox
sohami commented on a change in pull request #1504: DRILL-6792: Find the right probe side fragment wrapper & fix DrillBuf… URL: https://github.com/apache/drill/pull/1504#discussion_r232866925 ## File path:

[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM

2018-11-12 Thread GitBox
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437823097 I finally managed to reproduce the error. The `winutils.exe` (Hadoop WinUtils)

[GitHub] oleg-zinovev commented on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM

2018-11-12 Thread GitBox
oleg-zinovev commented on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437823097 I finally managed to reproduce the error. The `winutils.exe` (Hadoop WinUtils) requires a

[GitHub] vvysotskyi commented on a change in pull request #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM

2018-11-12 Thread GitBox
vvysotskyi commented on a change in pull request #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#discussion_r232587070 ## File path: distribution/src/resources/sqlline.bat ## @@

[GitHub] ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax

2018-11-12 Thread GitBox
ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax URL: https://github.com/apache/drill/pull/1488#issuecomment-437823918 Hi @amansinha100 , thanks for approving the PR and sorry for confusing comment about rule ordering. I've added documentation note under jira issue.

[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM

2018-11-12 Thread GitBox
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437823097 I finally managed to reproduce the error. The `winutils.exe` (Hadoop WinUtils)

[GitHub] vvysotskyi commented on a change in pull request #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM

2018-11-12 Thread GitBox
vvysotskyi commented on a change in pull request #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#discussion_r232586065 ## File path: distribution/src/resources/sqlline.bat ## @@

[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM

2018-11-12 Thread GitBox
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437823097 @vvysotskyi I finally managed to reproduce the error. The `winutils.exe` (Hadoop

[GitHub] weijietong commented on a change in pull request #1504: DRILL-6792: Find the right probe side fragment wrapper & fix DrillBuf…

2018-11-12 Thread GitBox
weijietong commented on a change in pull request #1504: DRILL-6792: Find the right probe side fragment wrapper & fix DrillBuf… URL: https://github.com/apache/drill/pull/1504#discussion_r232918469 ## File path:

[GitHub] weijietong commented on a change in pull request #1504: DRILL-6792: Find the right probe side fragment wrapper & fix DrillBuf…

2018-11-12 Thread GitBox
weijietong commented on a change in pull request #1504: DRILL-6792: Find the right probe side fragment wrapper & fix DrillBuf… URL: https://github.com/apache/drill/pull/1504#discussion_r232918785 ## File path:

[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM

2018-11-12 Thread GitBox
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437848102 @vvysotskyi, `2.7.1` is the latest version of `hadoop-winutils`. > Also, could

[GitHub] oleg-zinovev commented on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM

2018-11-12 Thread GitBox
oleg-zinovev commented on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437862742 @vvysotskyi I was able to remove warning on startup by adding `--add-opens` for all

[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM

2018-11-12 Thread GitBox
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437862742 @vvysotskyi I was able to remove warning on startup by adding `--add-opens` for

[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM

2018-11-12 Thread GitBox
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437848102 @vvysotskyi, `2.7.1` is the latest version of `hadoop-winutils` (in

[GitHub] oleg-zinovev commented on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM

2018-11-12 Thread GitBox
oleg-zinovev commented on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437848102 @vvysotskyi, `2.7.1` is the latest version of `hadoop-winutils`

[GitHub] arina-ielchiieva commented on a change in pull request #1531: DRILL-5571: Cancel running query from its Web UI

2018-11-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1531: DRILL-5571: Cancel running query from its Web UI URL: https://github.com/apache/drill/pull/1531#discussion_r232642539 ## File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl ## @@ -171,7

[GitHub] arina-ielchiieva commented on a change in pull request #1531: DRILL-5571: Cancel running query from its Web UI

2018-11-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1531: DRILL-5571: Cancel running query from its Web UI URL: https://github.com/apache/drill/pull/1531#discussion_r232642178 ## File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl ## @@ -50,6 +50,22

[GitHub] kkhatua commented on issue #1531: DRILL-5571: Cancel running query from its Web UI

2018-11-12 Thread GitBox
kkhatua commented on issue #1531: DRILL-5571: Cancel running query from its Web UI URL: https://github.com/apache/drill/pull/1531#issuecomment-437937304 Running Query: ![image](https://user-images.githubusercontent.com/4335237/48359626-3377dc00-e652-11e8-894c-1709d88cb42b.png)

[GitHub] kkhatua commented on a change in pull request #1531: DRILL-5571: Cancel running query from its Web UI

2018-11-12 Thread GitBox
kkhatua commented on a change in pull request #1531: DRILL-5571: Cancel running query from its Web UI URL: https://github.com/apache/drill/pull/1531#discussion_r232718757 ## File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl ## @@ -171,7 +188,30 @@

[GitHub] vvysotskyi commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax

2018-11-12 Thread GitBox
vvysotskyi commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax URL: https://github.com/apache/drill/pull/1488#issuecomment-437826528 +1 for this PR and for the proposal to fix this issue in the scope of the separate Jira.

Re: Unit Test Question

2018-11-12 Thread Charles Givre
Hi Paul, I fixed the issue with the unit test, updated the PR but now Tavis is timing out when building Kudu or something not related to my PR. Is there anything I can do about that? The job exceeded the maximum time limit for jobs, and has been terminated. > On Nov 11, 2018, at 14:32, Paul

[GitHub] amansinha100 commented on a change in pull request #1532: DRILL-6833: Support for pushdown of rowkey based joins

2018-11-12 Thread GitBox
amansinha100 commented on a change in pull request #1532: DRILL-6833: Support for pushdown of rowkey based joins URL: https://github.com/apache/drill/pull/1532#discussion_r232773609 ## File path:

[GitHub] kkhatua opened a new pull request #1535: DRILL-2035: Add ability to cancel multiple queries

2018-11-12 Thread GitBox
kkhatua opened a new pull request #1535: DRILL-2035: Add ability to cancel multiple queries URL: https://github.com/apache/drill/pull/1535 Currently Drill UI allows canceling one query at a time. This commit (on lines of DRILL-5571 / PR #1531) allows for cancelling multiple `running`

[GitHub] kkhatua commented on issue #1531: DRILL-5571: Cancel running query from its Web UI

2018-11-12 Thread GitBox
kkhatua commented on issue #1531: DRILL-5571: Cancel running query from its Web UI URL: https://github.com/apache/drill/pull/1531#issuecomment-437973137 @arina-ielchiieva that is my Drillbit's hostname. This is an automated

Hangout Discussion Topics

2018-11-12 Thread Timothy Farkas
Hi All, Does anyone have any topics to discuss during the hangout tomorrow? Thanks, Tim

[GitHub] arina-ielchiieva commented on issue #1531: DRILL-5571: Cancel running query from its Web UI

2018-11-12 Thread GitBox
arina-ielchiieva commented on issue #1531: DRILL-5571: Cancel running query from its Web UI URL: https://github.com/apache/drill/pull/1531#issuecomment-437949964 @kkhatua what kk127 on the screenshot with modal window? This

[GitHub] arina-ielchiieva edited a comment on issue #1531: DRILL-5571: Cancel running query from its Web UI

2018-11-12 Thread GitBox
arina-ielchiieva edited a comment on issue #1531: DRILL-5571: Cancel running query from its Web UI URL: https://github.com/apache/drill/pull/1531#issuecomment-437949964 @kkhatua what kk127 means on the screenshot with modal window?

[GitHub] dvjyothsna opened a new pull request #1536: DRILL-6039: Fixed drillbit.sh script to do graceful shutdown

2018-11-12 Thread GitBox
dvjyothsna opened a new pull request #1536: DRILL-6039: Fixed drillbit.sh script to do graceful shutdown URL: https://github.com/apache/drill/pull/1536 @sohami please review This is an automated message from the Apache Git

Re: Unit Test Question

2018-11-12 Thread Charles Givre
Hi Vitalii, I did run all the tests on my machine and it completed without error after 42 min. Is the PR ok to proceed, or what do I need to do in order for the PR to be reviewed here and approved? —C > On Nov 12, 2018, at 15:18, Vitalii Diravka wrote: > > Hi Charles, > > Actually 45-50

[GitHub] bitblender commented on issue #1467: DRILL-5671: Set secure ACLs (Access Control List) for Drill ZK nodes in a secure cluster

2018-11-12 Thread GitBox
bitblender commented on issue #1467: DRILL-5671: Set secure ACLs (Access Control List) for Drill ZK nodes in a secure cluster URL: https://github.com/apache/drill/pull/1467#issuecomment-438017349 @arina-ielchiieva @sohami Thanks for the reviews. The commits are squashed now.

Re: Unit Test Question

2018-11-12 Thread Vitalii Diravka
Hi Charles, Actually 45-50 mins is the Travis time limit for the job, but anyway you can see the output and find the result of the run. Also you can try to enable CircleCI for your own Drill repo. It can run tests for you similar to Travis, but without time limits. But neither TravisCI nor

[GitHub] gparai commented on a change in pull request #1532: DRILL-6833: Support for pushdown of rowkey based joins

2018-11-12 Thread GitBox
gparai commented on a change in pull request #1532: DRILL-6833: Support for pushdown of rowkey based joins URL: https://github.com/apache/drill/pull/1532#discussion_r232836231 ## File path: