[GitHub] [drill] jnturton opened a new pull request, #2635: DRILL-8282: Update hadoop.dll and winutils.exe to 3.2.4.

jnturton opened a new pull request, #2635: URL: https://github.com/apache/drill/pull/2635 # [DRILL-8282](https://issues.apache.org/jira/browse/DRILL-8282): Update hadoop.dll and winutils.exe to 3.2.4. ## Description Completes #2630 by updating hadoop.dll and winutils.exe to

[GitHub] [drill] cgivre commented on a diff in pull request #2633: DRILL-8287: Add Support for Keyset Based Pagination

cgivre commented on code in PR #2633: URL: https://github.com/apache/drill/pull/2633#discussion_r957380889 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpPaginatorConfig.java: ## @@ -137,21 +162,28 @@ public String toString() {

[GitHub] [drill] cgivre commented on pull request #2633: DRILL-8287: Add Support for Keyset Based Pagination

cgivre commented on PR #2633: URL: https://github.com/apache/drill/pull/2633#issuecomment-1230366234 > I'm not sure that the concept of pagination from the HTTP plugin should spill into the JSON reader. Can you abstract it, e.g. by renaming paginationMap to, say, listenerColumnMap?

[GitHub] [drill] jnturton merged pull request #2630: DRILL-8282: Bump Hadoop-Common Version to 3.2.4 (CVE)

jnturton merged PR #2630: URL: https://github.com/apache/drill/pull/2630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton merged pull request #2635: DRILL-8282: Update hadoop.dll and winutils.exe to 3.2.4.

jnturton merged PR #2635: URL: https://github.com/apache/drill/pull/2635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on a diff in pull request #2633: DRILL-8287: Add Support for Keyset Based Pagination

jnturton commented on code in PR #2633: URL: https://github.com/apache/drill/pull/2633#discussion_r957433471 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/values/ScalarListener.java: ## @@ -76,4 +79,33 @@ protected void setArrayNull() { protected

[GitHub] [drill] cgivre commented on pull request #2633: DRILL-8287: Add Support for Keyset Based Pagination

cgivre commented on PR #2633: URL: https://github.com/apache/drill/pull/2633#issuecomment-1230390598 @jnturton Thanks for the quick review! I addressed your comments. I actually reinserted the commented out block as that was intended to make sure that the user properly populates the

[GitHub] [drill] jnturton commented on a diff in pull request #2633: DRILL-8287: Add Support for Keyset Based Pagination

jnturton commented on code in PR #2633: URL: https://github.com/apache/drill/pull/2633#discussion_r957255881 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpPaginatorConfig.java: ## @@ -137,21 +162,28 @@ public String toString() {

[GitHub] [drill] cgivre commented on a diff in pull request #2633: DRILL-8287: Add Support for Keyset Based Pagination

cgivre commented on code in PR #2633: URL: https://github.com/apache/drill/pull/2633#discussion_r957448436 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/values/ScalarListener.java: ## @@ -76,4 +79,33 @@ protected void setArrayNull() { protected

[GitHub] [drill] jnturton commented on pull request #2633: DRILL-8287: Add Support for Keyset Based Pagination

jnturton commented on PR #2633: URL: https://github.com/apache/drill/pull/2633#issuecomment-1230204078 I'm not sure that the concept of pagination from the HTTP plugin should spill into the JSON reader. Can you abstract it, e.g. by renaming paginationMap to, say, listenerColumnMap? --

[GitHub] [drill] jnturton commented on pull request #2630: DRILL-8282: Bump Hadoop-Common Version to 3.2.4 (CVE)

jnturton commented on PR #2630: URL: https://github.com/apache/drill/pull/2630#issuecomment-1229820379 We also need to update hadoop.dll and winutils.exe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [drill] pjfanning commented on a diff in pull request #2634: DRILL-8289: Add Threat Hunting Functions

pjfanning commented on code in PR #2634: URL: https://github.com/apache/drill/pull/2634#discussion_r957792365 ## contrib/udfs/src/main/java/org/apache/drill/exec/udfs/ThreatHuntingFunctions.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [drill] pjfanning commented on a diff in pull request #2634: DRILL-8289: Add Threat Hunting Functions

pjfanning commented on code in PR #2634: URL: https://github.com/apache/drill/pull/2634#discussion_r957792833 ## contrib/udfs/src/main/java/org/apache/drill/exec/udfs/ThreatHuntingFunctions.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [drill] cgivre merged pull request #2633: DRILL-8287: Add Support for Keyset Based Pagination

cgivre merged PR #2633: URL: https://github.com/apache/drill/pull/2633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] jnturton commented on a diff in pull request #2633: DRILL-8287: Add Support for Keyset Based Pagination

jnturton commented on code in PR #2633: URL: https://github.com/apache/drill/pull/2633#discussion_r957489232 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/SimpleMessageParser.java: ## @@ -129,6 +135,44 @@ private boolean

[GitHub] [drill] pjfanning commented on pull request #2631: [MINOR UPDATE]: Disable lgtm build

pjfanning commented on PR #2631: URL: https://github.com/apache/drill/pull/2631#issuecomment-1230765965 @cgivre thanks for sorting out the INFRA ticket. This PR is now really just for removing a file that is no longer needed. -- This is an automated message from the Apache Git Service.