[GitHub] drill pull request: DRILL-3778: Add missed part of DRILL-3160 (mak...

2015-09-23 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/158#discussion_r40260046 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/package-info.java --- @@ -19,7 +19,13 @@ /** * JDBC driver for Drill

[GitHub] drill pull request: DRILL-3778: Add missed part of DRILL-3160 (mak...

2015-09-23 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/158#issuecomment-142735217 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-3778: Add missed part of DRILL-3160 (mak...

2015-09-23 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/158#discussion_r40260917 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/package-info.java --- @@ -19,7 +19,13 @@ /** * JDBC driver for Drill

[GitHub] drill pull request: DRILL-3836: find free port automatically

2015-09-24 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/168#issuecomment-143068088 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: Fix for DRILL-3869

2015-09-30 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/178#issuecomment-144543634 This isn't a complete solution, you can put a semi-colon in a string literal (and maybe a column name in backticks?), so this might end up chopping queries in ha

[GitHub] drill pull request: Fix for DRILL-3869

2015-09-30 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/178#issuecomment-144550151 @adeneche agreed, this is a good solution for now. If someone submits multiple queries I think it would be fine if they get back a parsing error that mentions semi

[GitHub] drill pull request: Fix for DRILL-3869

2015-09-30 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/178#issuecomment-144550362 One small improvement, I would make sure we run a trim() on the string and then check the last character, just to cover the case of a semi-colon followed by

[GitHub] drill pull request: Fix for DRILL-3869

2015-10-01 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/178#issuecomment-144819302 The change looks good, but thinking about this a little more it might make sense to fix this a little higher up the chain. If we fix this where queries are actually

[GitHub] drill pull request: Fix for DRILL-3869

2015-10-01 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/178#issuecomment-144823271 I just saw that the conversation fragmented on JIRA, Jacques point makes sense to me +1 --- If your project is set up for it, you can reply to this email and have

[GitHub] drill pull request: DRILL-3874: flattening large JSON objects uses...

2015-10-01 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/181#discussion_r40963410 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java --- @@ -123,6 +123,15 @@ public int getBufferSize

[GitHub] drill pull request: DRILL-3874: flattening large JSON objects uses...

2015-10-01 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/181#issuecomment-144846430 Overall, the changes look solid. I am thinking it may be worth trying to remove the bodies of the existing getBufferSize() methods and replace them with calls

[GitHub] drill pull request: DRILL-3874: flattening large JSON objects uses...

2015-10-02 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/181#issuecomment-145117861 I'm okay with merging as is, I think it is worth keeping a JIRA open for this refactoring. The fact that these behave inconsistently pretty much guarantees tha

[GitHub] drill pull request: DRILL-3874: flattening large JSON objects uses...

2015-10-02 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/181#issuecomment-145158691 I'm running the unit tests on the changeset rebased on top of master, will be merging shortly if it passes. --- If your project is set up for it, you can rep

[GitHub] drill pull request: DRILL-3874: flattening large JSON objects uses...

2015-10-02 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/181#issuecomment-145160952 Go for it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request: DRILL-3876: Avoid an extra copy of the origina...

2015-10-06 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/187 DRILL-3876: Avoid an extra copy of the original list when flattening This only fixes a basic case, a more complete refactoring of the rewrite rule could avoid copies in cases with multiple

[GitHub] drill pull request: DRILL-3912: Common subexpression elimination

2015-10-07 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/189#issuecomment-146363523 Do you want to go ahead and add these comments as javadocs on the classes? This is the kind of information that would help a future dev understand and extend these

[GitHub] drill pull request: DRILL-3876: Avoid an extra copy of the origina...

2015-10-12 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/187#issuecomment-147593073 Your changes look good to me, I should have considered this case when I was trying to enhance the rule. My small change, with or without your fix isn't reall

[GitHub] drill pull request: DRILL-3943: In constant folding, when the the ...

2015-10-16 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/206#issuecomment-148780579 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: Add Sequence file support.

2015-10-21 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r42682341 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/beans/CoreOperatorType.java --- @@ -58,7 +58,8 @@ HBASE_SUB_SCAN(33

[GitHub] drill pull request: Add Sequence file support.

2015-10-21 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r42684543 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/beans/CoreOperatorType.java --- @@ -58,7 +58,8 @@ HBASE_SUB_SCAN(33

[GitHub] drill pull request: DRILL-3484: Error with no-argument functions w...

2015-10-21 Thread jaltekruse
Github user jaltekruse closed the pull request at: https://github.com/apache/drill/pull/85 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: DRILL-3983: Small test improvements

2015-10-27 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/221#issuecomment-151673795 +1 to the change. I agree that we should be working to get this cleaned up sooner rather than later and this helps in the meantime with debugging. --- If your

[GitHub] drill pull request: DRILL-3871: Off by one error while reading bin...

2015-10-30 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/219#issuecomment-152588218 +1, thanks for cleaning this up Parth! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] drill pull request: DRILL-4028: Get off parquet fork

2015-11-03 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/236 DRILL-4028: Get off parquet fork You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaltekruse/incubator-drill parquet-update-squash

[GitHub] drill pull request: DRILL-4028: Get off parquet fork

2015-11-03 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/236#issuecomment-153550233 I need to update the POM version number once the parquet changes are actually merged and we can publish a new version of the "fork" (which will just be us h

[GitHub] drill pull request: DRILL-4048: Fix reading required dictionary en...

2015-11-06 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/247 DRILL-4048: Fix reading required dictionary encoded varbinary data in… … parquet files after recent update Fix was small, this update is a little larger than necessary because I was

[GitHub] drill pull request: DRILL-3791: MySQL tests for JDBC plugin

2015-11-12 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/251#issuecomment-156234958 Just reflecting a short offline conversation I had with Adrew here. It looks like we're missing a few MySQL types here (YEAR, ENUM) as well as a couple of derby

[GitHub] drill pull request: DRILL-4082: Better error message when multiple...

2015-11-12 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/252#discussion_r44725024 --- Diff: common/src/main/java/org/apache/drill/common/scanner/ClassPathScanner.java --- @@ -422,11 +423,16 @@ static ScanResult scan(Collection

[GitHub] drill pull request: DRILL-4082: Better error message when multiple...

2015-11-12 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/252#discussion_r44728766 --- Diff: common/src/main/java/org/apache/drill/common/scanner/ClassPathScanner.java --- @@ -422,11 +423,16 @@ static ScanResult scan(Collection

[GitHub] drill pull request: DRILL-4082: Better error message when multiple...

2015-11-12 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/252#issuecomment-156275194 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-3791: MySQL tests for JDBC plugin

2015-11-13 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/251#issuecomment-156557868 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4103: add drill.version to parquet metad...

2015-11-17 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/264#issuecomment-157576301 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4056: Avro corruption bug with UTF-8 str...

2015-11-17 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/266 DRILL-4056: Avro corruption bug with UTF-8 strings You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaltekruse/incubator-drill 4056-avro

[GitHub] drill pull request: DRILL-2915: After cartesian join is selected, ...

2015-11-20 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/271#discussion_r45524312 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java --- @@ -33,6 +33,30 @@ public class TestExampleQueries extends

[GitHub] drill pull request: DRILL-4070: Add note about parquet file migrat...

2015-11-22 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/278 DRILL-4070: Add note about parquet file migration in 1.3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaltekruse/incubator-drill gh-pages

[GitHub] drill pull request: DRILL-4056: Avro corruption bug with UTF-8 str...

2015-11-23 Thread jaltekruse
Github user jaltekruse closed the pull request at: https://github.com/apache/drill/pull/266 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: DRILL-4056: Avro corruption bug with UTF-8 str...

2015-11-23 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/266#issuecomment-159106823 This was merged into the 1.3 release branch, but I just realized it was not merged into master. Will get it in shortly. --- If your project is set up for it, you can

[GitHub] drill pull request: DRILL-4056: Avro corruption bug with UTF-8 str...

2015-11-23 Thread jaltekruse
GitHub user jaltekruse reopened a pull request: https://github.com/apache/drill/pull/266 DRILL-4056: Avro corruption bug with UTF-8 strings You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaltekruse/incubator-drill 4056-avro

[GitHub] drill pull request: DRILL-4048: Fix reading required dictionary en...

2015-11-23 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/247#issuecomment-159107022 Fixed in a5a1aa6b487d0642641ce70f2c2500465956f9ec --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] drill pull request: DRILL-4048: Fix reading required dictionary en...

2015-11-23 Thread jaltekruse
Github user jaltekruse closed the pull request at: https://github.com/apache/drill/pull/247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...

2015-11-25 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/281#issuecomment-159748623 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...

2015-11-30 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/281#issuecomment-160799401 I put it on my merge branch but it actually caused two small compilation issues in other modules that were using the utility method you refactored. I forgot to update

[GitHub] drill pull request: DRILL-4159: Use test framework in TestCsvHeade...

2015-12-03 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/289#issuecomment-161813807 As long as you are changing it do you want to remove the two test classes still using this method and then just delete it? --- If your project is set up for it, you

[GitHub] drill pull request: DRILL-4159: Use test framework in TestCsvHeade...

2015-12-03 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/289#issuecomment-161818595 The one that is generating a string representation of the result set, which caused the bug. getResultString() --- If your project is set up for it, you can reply to

[GitHub] drill pull request: DRILL-4123: refer to fully qualified variable ...

2015-12-07 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/293#issuecomment-162680673 This should not be using the File.Separator, as it is working with Hadoop and will always get Unix paths, even when running on Windows. Please see the JIRA linked

[GitHub] drill pull request: DRILL-4123: refer to fully qualified variable ...

2015-12-07 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/293#issuecomment-162696095 One other point here, the issue with fully qualified names actually shouldn't be a problem in the usual usage of this function. The function was only designed

[GitHub] drill pull request: DRILL-4123: refer to fully qualified variable ...

2015-12-07 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/293#issuecomment-162704924 Apologies, didn't think about the order in which compilation and resolving the injectables would be executed. I thought I had verified that this error would ma

[GitHub] drill pull request: DRILL-4241: Add Kudu reader

2016-01-04 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/314#issuecomment-168730376 I agree with Steven, at the hackathon we already did some basic performance and correctness verification at reasonable scale. +1 --- If your project is set up for it

[GitHub] drill pull request: DRILL-4277: Fix issue with JdbcPrel serializat...

2016-01-15 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/326#issuecomment-172110734 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4278: Fix issue where WorkspaceConfig wa...

2016-01-19 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/331#issuecomment-173078753 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: Drill 4261: add support for RANGE BETWEEN UNBO...

2016-01-21 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/334#discussion_r50482911 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java --- @@ -106,6 +106,16 @@ public void

[GitHub] drill pull request: DRILL-4291: Fix Missing classes when trying to...

2016-01-25 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/336#discussion_r50741405 --- Diff: exec/vector/src/main/java/org/apache/drill/exec/util/Text.java --- @@ -0,0 +1,612 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] drill pull request: DRILL-4291: Fix Missing classes when trying to...

2016-01-25 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/336#issuecomment-174627297 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4203: fix dates written into parquet fil...

2016-01-27 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/341#issuecomment-175793221 @adeneche @parthchandra @StevenMPhillips Can one of you please review this change? --- If your project is set up for it, you can reply to this email and have your

[GitHub] drill pull request: DRILL-4203: fix dates written into parquet fil...

2016-01-27 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/341 DRILL-4203: fix dates written into parquet files to conform to parquet format spec This branch includes an update of the version number to 1.5.0, this is required because we need a hard release

[GitHub] drill pull request: DRILL-4314: Unit Test Framework can support sc...

2016-01-27 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/339#issuecomment-175874266 Can do --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request: DRILL-4203: fix dates written into parquet fil...

2016-01-27 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/341#issuecomment-175920847 Did you see my comment above? I am using the version number to signal that the dates are fixed now and in all future versions. All other commits with a version of

[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...

2016-01-28 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/343#issuecomment-176312248 @sudheeshkatkam @jacques-n Can you please review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...

2016-01-28 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/343#issuecomment-176314047 @sudheeshkatkam Just saw that you actually had a patch for this, I was looking at DRILL-2663 originally, and found the duplicate DRILL-2653 when I went to write the

[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...

2016-01-28 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/343 DRILL-2653: Improve web UI experience when there is an error in a sto… …rage plugin configuration You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] drill pull request: DRILL-4322: Add underlying exception message w...

2016-01-28 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/344 DRILL-4322: Add underlying exception message when IOException causes … …DROP TABLE failure You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...

2016-01-28 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/343#discussion_r51185648 --- Diff: exec/java-exec/src/main/resources/rest/storage/update.ftl --- @@ -53,8 +53,17 @@ }); function doUpdate

[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...

2016-01-28 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/343#issuecomment-176434681 @sudheeshkatkam Message fixed, also added more colors :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] drill pull request: DRILL-4328: Fix backward compatibility regress...

2016-01-29 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/348#issuecomment-177013054 +1 tested the change by swapping the 1.5 mongo storage plugin jar with the 1.4 one and it worked. --- If your project is set up for it, you can reply to this email

[GitHub] drill pull request: DRILL-4128: Fix NPE when calling getString on ...

2016-02-01 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/353 DRILL-4128: Fix NPE when calling getString on a JDBC ResultSet when t… …he type is not varchar You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] drill pull request: DRILL-4314: Unit Test Framework can support sc...

2016-02-04 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/339#discussion_r51908667 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java --- @@ -235,6 +240,20 @@ public CSVTestBuilder csvBaselineFile(String filePath

[GitHub] drill pull request: DRILL-4314: Unit Test Framework can support sc...

2016-02-04 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/339#issuecomment-179963620 @hsuanyi Other than the small comment this looks good to me +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] drill pull request: DRILL-4353: Add HttpSessionListener to release...

2016-02-04 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/359#issuecomment-180079688 Currently running tests on the patch rebased onto the 1.5 release branch. Do you want to go mention on the vote thread that you would like this to be included

[GitHub] drill pull request: DRILL-4327: Fix rawtypes warnings emitted by c...

2016-02-05 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/347#discussion_r52048231 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java --- @@ -84,6 +64,26 @@ import

[GitHub] drill pull request: DRILL-4327: Fix rawtypes warnings emitted by c...

2016-02-05 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/347#discussion_r52048800 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java --- @@ -26,13 +26,13 @@ import

[GitHub] drill pull request: DRILL-4327: Fix rawtypes warnings emitted by c...

2016-02-05 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/347#issuecomment-180471371 Other than the two small comments this looks good to me +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] drill pull request: DRILL-4331: Fix TestFlattenPlanning.testFlatte...

2016-02-05 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/351#issuecomment-180472482 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...

2016-02-05 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/333#issuecomment-180477807 +1 on the clean change and removal of unnecessary files. If we want to try to clean up the build process to not check in the generated files, I assume that

[GitHub] drill pull request: DRILL-4225: TestDateFunctions#testToChar fails...

2016-02-05 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/311#issuecomment-180479132 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4358: Fix NPE in UserServer.close()

2016-02-05 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/362#issuecomment-180506885 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4353: Add HttpSessionListener to release...

2016-02-05 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/359#issuecomment-180514935 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4359: Adds equals/hashCode methods to En...

2016-02-05 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/363#discussion_r52080108 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/EndpointAffinity.java --- @@ -96,6 +96,42 @@ public boolean isAssignmentRequired

[GitHub] drill pull request: DRILL-4359: Adds equals/hashCode methods to En...

2016-02-05 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/363#discussion_r52084085 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/EndpointAffinity.java --- @@ -96,6 +96,42 @@ public boolean isAssignmentRequired

[GitHub] drill pull request: DRILL-4359: Adds equals/hashCode methods to En...

2016-02-08 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/363#issuecomment-181638228 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4361: Let FileSystemPlugin FormatCreator...

2016-02-08 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/365#issuecomment-181638322 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4383: Allow custom configurations to be ...

2016-02-11 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/375 DRILL-4383: Allow custom configurations to be specified for a FileSys… …tem plugin You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] drill pull request: DRILL-4410: ListVector should initialize bits ...

2016-02-17 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/380#issuecomment-185568844 Can you generate these files in the tests rather than check them in? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] drill pull request: DRILL-4410: ListVector should initialize bits ...

2016-02-18 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/380#issuecomment-185825063 Could you also add result verification? While there are some older tests that just run queries to verify that errors that previously occurred are gone, we have been

[GitHub] drill pull request: DRILL-4410: ListVector should initialize bits ...

2016-02-23 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/380#issuecomment-187942345 +1 @hsuanyi Does this second test look good to you? I will test this on windows before merging, but I think it should be fine. Will do a small refactoring to use the

[GitHub] drill pull request: DRILL-4411: hash join should limit batch based...

2016-02-24 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/381#discussion_r54017219 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java --- @@ -47,7 +47,11 @@ private

[GitHub] drill pull request: DRILL-4411: hash join should limit batch based...

2016-02-24 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/381#discussion_r54017535 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java --- @@ -47,7 +47,11 @@ private

[GitHub] drill pull request: DRILL-4411: hash join should limit batch based...

2016-02-24 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/381#discussion_r54018324 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java --- @@ -98,7 +102,9 @@ public void

[GitHub] drill pull request: DRILL-4441: Fix varchar data read out of Avro ...

2016-02-26 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/393 DRILL-4441: Fix varchar data read out of Avro filtering incorrectly d… …ue to metadata bug The precision of the Varchar datatype was not being set causing inconsistent truncation

[GitHub] drill pull request: DRILL-4437: Operator unit tests

2016-02-26 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/394 DRILL-4437: Operator unit tests Introduces a framework for testing physical operators without the need to start a complete Drill server. Several small interface changes were made to

[GitHub] drill pull request: DRILL-4437: Operator unit tests

2016-02-29 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/394#issuecomment-190353355 @sudheeshkatkam @parthchandra @adeneche @StevenMPhillips Would any of you be able to do a review? --- If your project is set up for it, you can reply to this email

[GitHub] drill pull request: DRILL-4375: Fix the maven release profile

2016-03-02 Thread jaltekruse
GitHub user jaltekruse opened a pull request: https://github.com/apache/drill/pull/402 DRILL-4375: Fix the maven release profile This generated pom file was being discovered and maven was trying to run the target directory in jdbc-all as a submodule. This change reverts

[GitHub] drill pull request: DRILL-4184: support variable length decimal fi...

2016-03-05 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/372#discussion_r55125265 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLengthValuesColumn.java --- @@ -81,6 +112,14 @@ public boolean

[GitHub] drill pull request: DRILL-4184: support variable length decimal fi...

2016-03-05 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/372#discussion_r55125267 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableVarLengthValuesColumn.java --- @@ -69,11 +73,16

[GitHub] drill pull request: DRILL-4184: support variable length decimal fi...

2016-03-05 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/372#issuecomment-192701211 @daveoshinsky I have a few questions about your design here, I have a proposed alternative but I might be wrong about what you are trying to accomplish. --- If your

[GitHub] drill pull request: DRILL-4457: Difference in results returned by ...

2016-03-07 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/410#issuecomment-193362442 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request: DRILL-4332: Makes vector comparison order stab...

2016-03-07 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/389#issuecomment-193372672 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4452: Uses Apache Calcite Avatica driver...

2016-03-07 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/395#issuecomment-193418830 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4486: Fix expression serialization escap...

2016-03-07 Thread jaltekruse
Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/412#discussion_r55304775 --- Diff: logical/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java --- @@ -119,14 +126,14 @@ public Void visitSchemaPath

[GitHub] drill pull request: DRILL-4486: Fix expression serialization escap...

2016-03-07 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/412#issuecomment-193558494 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request: DRILL-4474: Use varchar for default column whe...

2016-03-08 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/415#issuecomment-193884035 Could you also close this PR and open a new one? the JIRA number was wrong in your commit so this is posting to the JIRA about incorrect creation if direct scans. The

  1   2   >