Github user laurentgo commented on the issue:
https://github.com/apache/drill/pull/602
Branch updated with only commits associated with a JIRA (everything else
has been merged into commit for DRILL-4420)
---
If your project is set up for it, you can reply to this email and have your
Github user laurentgo commented on the issue:
https://github.com/apache/drill/pull/602
yes, let me clean my branch one last time by squashing the small commits
with no JIRA. For the windows build, I already added instructions regarding the
need for PowerShell on the system, and on
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/602
+1. Everything looks good. I'm assuming that you will squash the commits
which don't have an associated Jira.
Also, if you can add any notes needed to the Windows build instructions,
that
Github user laurentgo commented on the issue:
https://github.com/apache/drill/pull/602
sounds good, I think all of the comments I received have been addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/602
No need for many PRs. Let's just squash this branch into commits for the
individual JIRA's I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user laurentgo commented on the issue:
https://github.com/apache/drill/pull/602
@parthchandra do you want individual pull requests for each issue, or are
you okay having this branch squashed and merged?
---
If your project is set up for it, you can reply to this email and
Github user laurentgo commented on the issue:
https://github.com/apache/drill/pull/602
New version of the branch with a fix for the version detection (also added
the option to provide the version from the commandline if needed) + disable
secure iterator check which causes all these
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/602
@laurentgo What version of zookeeper libs are you using on Windows?
FindZookeeper is failing for me because my version (3.4.6), has a
zookeeper.lib file, not zookeeper_d.lib.
Also, I
Github user laurentgo commented on the issue:
https://github.com/apache/drill/pull/602
Just uploaded a new version of the branch
@parthchandra: on windows, I'm using PowerShell to extract the project
information from the pom.xml instead of a call to maven (which I assume is
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/602
I just put the FindCppUnit hack in my branch here:
https://github.com/parthchandra/drill/tree/DRILL-4420
I hit another issue (bit of a show stopper) with windows. In order to get
on with the
Github user laurentgo commented on the issue:
https://github.com/apache/drill/pull/602
Thanks @parthchandra for the feedback
1) I'm still struggling having a working Windows dev environment. Regarding
CppUnit, it seems the LibreOffice folks are using the version hosted on FDo
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/602
@laurentgo These changes are looking good. I just have the following
observations -
1) The build on Windows was a problem for me. I found CppUnit here
Github user superbstreak commented on the issue:
https://github.com/apache/drill/pull/602
**Mac Environment:**
OS: OSX 10.8.5
COMPILER=xcode5_1
**Libraries:**
Zookeeper: 3.4.6 (patched)
boost: 1.57.0
protobuf: 2.5.0rc1
**For libc++:**
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/602
OK. The Mac issue I see is caused by MacOS -
https://issues.apache.org/jira/browse/ZOOKEEPER-2049
Just to confirm, what version of MacOS and Zookeeper did you build with?
Should we
Github user laurentgo commented on the issue:
https://github.com/apache/drill/pull/602
My build environment on Mac is OS X 10.11.6 (El Capitan) and Zookeeper
3.4.8 (brew package).
I don't think the client needs to be updated if people are using an older
version of OS X
---
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/602
Let's discuss this offline. My goal would be to review (most changes look
OK to me; but I want to take a more detailed look at c10e652 and a931903),
build on Mac, Linux and Windows. I was
Github user laurentgo commented on the issue:
https://github.com/apache/drill/pull/602
I have built it successfully on Mac and Linux (centos 5). On Mac, I used
homebrew to install cppunit locally on Mac, but I didn't try to build it from
source. You can send me your output, and I
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/602
@laurentgo I have been trying, unsuccessfully, to build on Windows and Mac.
Is there a cppunit build available for Windows? I am unable to get past that
and my effort to build cppunit from
18 matches
Mail list logo
