[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1203 ---

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182553045 --- Diff: common/src/main/java/org/apache/drill/exec/metrics/DrillMetrics.java --- @@ -18,6 +18,7 @@ package org.apache.drill.exec.metrics;

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182552999 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -180,20 +180,22 @@ public void run() throws Exception { if

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182553108 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -79,11 +94,15 @@

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182507182 --- Diff: protocol/src/main/protobuf/Coordination.proto --- @@ -18,6 +18,7 @@ message DrillbitEndpoint{ OFFLINE = 3; } optional State

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182510967 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -79,11 +94,15 @@

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182496734 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -180,20 +180,22 @@ public void run() throws Exception { if

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182495572 --- Diff: common/src/main/java/org/apache/drill/exec/metrics/DrillMetrics.java --- @@ -18,6 +18,7 @@ package org.apache.drill.exec.metrics;

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182502500 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -283,20 +308,114 @@ alert(errorThrown);

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182502418 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -79,9 +91,14 @@

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182501277 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -189,11 +189,16 @@ public void run() throws Exception {

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182501230 --- Diff: common/src/main/java/org/apache/drill/exec/metrics/DrillMetrics.java --- @@ -60,6 +61,7 @@ private static void registerSystemMetrics() {

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182500652 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -67,9 +73,15 @@ ${i} ${drillbit.getAddress()}<#if

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182499705 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java --- @@ -158,7 +158,13 @@ public void start() throws Exception {

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182499262 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -260,7 +285,7 @@ function fillQueryCount(row_id) { var

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-18 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r182499088 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -180,7 +180,7 @@ public void run() throws Exception { if

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-16 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181834064 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -283,20 +308,114 @@ alert(errorThrown);

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-16 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181830465 --- Diff: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-13 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181510944 --- Diff: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181254054 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -67,9 +73,15 @@ ${i} ${drillbit.getAddress()}<#if

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181252867 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java --- @@ -158,7 +158,13 @@ public void start() throws Exception {

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181251700 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -79,9 +91,14 @@

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181161322 --- Diff: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181161557 --- Diff: common/src/main/java/org/apache/drill/exec/metrics/DrillMetrics.java --- @@ -60,6 +61,7 @@ private static void registerSystemMetrics() {

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181252317 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -260,7 +285,7 @@ function fillQueryCount(row_id) { var requestPath

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181258290 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -283,20 +308,114 @@ alert(errorThrown);

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181179746 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -189,11 +189,16 @@ public void run() throws Exception {

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181253785 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -283,20 +308,114 @@ alert(errorThrown);

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181165145 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -180,7 +180,7 @@ public void run() throws Exception { if

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181161567 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -52,12 +52,18 @@ # -

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181157818 --- Diff: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181156759 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -79,9 +91,14 @@

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181156606 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -52,12 +52,18 @@ # -

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181155880 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java --- @@ -296,12 +302,19 @@ private ConstraintSecurityHandler

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181155596 --- Diff: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181154984 --- Diff: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java --- @@ -0,0 +1,62 @@ +/** --- End diff -- Never noticed that

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181033697 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -79,9 +91,14 @@

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181033526 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -52,12 +52,18 @@ # -

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181032357 --- Diff: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java --- @@ -0,0 +1,62 @@ +/** --- End diff -- Javadoc

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181033047 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java --- @@ -296,12 +302,19 @@ private

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181032458 --- Diff: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r181032603 --- Diff: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-10 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r180553686 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java --- @@ -102,6 +105,7 @@ public DrillbitEndpoint start() throws

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-09 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r180296333 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java --- @@ -102,6 +105,7 @@ public DrillbitEndpoint start() throws

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-09 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r180268114 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java --- @@ -102,6 +105,7 @@ public DrillbitEndpoint start() throws

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-09 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r180248133 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -289,14 +314,94 @@ }); } } -

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-09 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r180238126 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -289,14 +314,94 @@ }); } }

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-09 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r180226226 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -289,14 +314,94 @@ }); } } -

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-09 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r180196490 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -289,14 +314,94 @@ }); } }

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-06 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/1203 DRILL-6289: Cluster view should show more relevant information The commits make use of AJAX calls by the browser to all the Drillbits for status metrics, which are then displayed here. This works