[GitHub] RestfulBlue commented on issue #5990: fromIndex(0) to toIndex(-1) exception in kafka indexing task

2018-07-10 Thread GitBox
RestfulBlue commented on issue #5990: fromIndex(0) to toIndex(-1) exception in kafka indexing task URL: https://github.com/apache/incubator-druid/issues/5990#issuecomment-403806812 okay, found this pr: https://github.com/apache/incubator-druid/pull/5374

[GitHub] RestfulBlue closed issue #5990: fromIndex(0) to toIndex(-1) exception in kafka indexing task

2018-07-10 Thread GitBox
RestfulBlue closed issue #5990: fromIndex(0) to toIndex(-1) exception in kafka indexing task URL: https://github.com/apache/incubator-druid/issues/5990 This is an automated message from the Apache Git Service. To respond to

Question about sketches aggregation in druid

2018-07-10 Thread Eshcar Hillel
Hi All, My name is Eshcar Hillel from Oath research. I'm currently working with Lee Rhodes on committing a new concurrent implementation of the theta sketch to the sketches-core library.I was wondering whether this implementation can help boost the union operation that is applied to multiple

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

2018-07-10 Thread GitBox
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r201366966 ## File path: common/src/main/java/io/druid/math/expr/Expr.java ## @@ -365,15

[GitHub] nishantmonu51 opened a new issue #5991: Evaluate changing evalLong() or evalDouble to return a nullable Long or Double

2018-07-10 Thread GitBox
nishantmonu51 opened a new issue #5991: Evaluate changing evalLong() or evalDouble to return a nullable Long or Double URL: https://github.com/apache/incubator-druid/issues/5991 changing evalLong() or evalDouble to return a nullable Long or Double, respectively. Needs performance

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

2018-07-10 Thread GitBox
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r201364128 ## File path: common/src/main/java/io/druid/math/expr/Expr.java ## @@ -365,15

TeamCity Inspections CI broke

2018-07-10 Thread Roman Leventov
Since the repo was moved to apache org, the integration failed, the error message is: Commit Status Publisher error. GitHub status: 'Success'. Publisher: githubStatusPublisher(https://api.github.com). Failed to complete request to GitHub. Please check if the error is not returned by a proxy or

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

2018-07-10 Thread GitBox
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r201367313 ## File path: common/src/main/java/io/druid/math/expr/ExprEval.java ## @@ -245,36

[GitHub] leventov commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
leventov commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201370593 ## File path: services/src/main/java/io/druid/cli/CliPeon.java ## @@ -243,7 +242,7 @@ public

[GitHub] leventov commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
leventov commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201365909 ## File path:

[GitHub] leventov commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
leventov commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201367693 ## File path: server/src/test/java/io/druid/initialization/InitializationTest.java ## @@ -454,8

[GitHub] leventov commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
leventov commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201368627 ## File path: services/src/main/java/io/druid/cli/CliCoordinator.java ## @@ -255,6 +255,6 @@

[GitHub] leventov commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
leventov commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201368904 ## File path: services/src/main/java/io/druid/cli/CliInternalHadoopIndexer.java ## @@ -150,7

[GitHub] leventov commented on issue #5957: Various changes

2018-07-10 Thread GitBox
leventov commented on issue #5957: Various changes URL: https://github.com/apache/incubator-druid/pull/5957#issuecomment-403848811 @nishantmonu51 we can (however it will take several more weeks), but you could review this PR in parallel?

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

2018-07-10 Thread GitBox
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r201371259 ## File path:

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

2018-07-10 Thread GitBox
nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r201373058 ## File path:

[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
asdf2014 commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201389385 ## File path:

[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
asdf2014 commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201389804 ## File path: server/src/test/java/io/druid/initialization/InitializationTest.java ## @@ -454,8

This week's dev sync

2018-07-10 Thread Charles Allen
https://meet.google.com/ozi-rtfg-ags

Re: Druid 0.12.2-rc1 vote

2018-07-10 Thread Charles Allen
Brought this up in the dev sync: I saw a lot of PRs and fixes for Coordinator segment balancing related to some regressions that happened in 0.12.x . Is anyone able to give a rundown of the state of coordinator segment management for the 0.12.2 RC? On Tue, Jul 10, 2018 at 10:26 AM Nishant

Druid August 2018 Bay Area meetup

2018-07-10 Thread Gian Merlino
Please join us for our next Druid meetup at Lyft, which you can RSVP to here: https://www.meetup.com/druidio/events/252515792/ Speakers will be sharing real-world experience with Druid and discussing the upcoming Druid roadmap. Hope to see everyone there!

[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
asdf2014 commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201398587 ## File path: services/src/main/java/io/druid/cli/CliCoordinator.java ## @@ -255,6 +255,6 @@

Re: Question about sketches aggregation in druid

2018-07-10 Thread Gian Merlino
Hi Eshcar, To my knowledge, in the Druid Aggregator and BufferAggregator interfaces, the main place where concurrency happens is that "aggregate" and "get" may be called simultaneously during realtime ingestion. So if there would be a benefit from improving concurrency it would probably end up in

Re: TeamCity Inspections CI broke

2018-07-10 Thread Gian Merlino
Any idea what has to be done to fix it? I am not too familiar with how the TeamCity integration works. Is it something we can fix ourselves or something Infra has to do? On Tue, Jul 10, 2018 at 7:29 AM Roman Leventov wrote: > Since the repo was moved to apache org, the integration failed, the

Re: Druid 0.12.2-rc1 vote

2018-07-10 Thread Nishant Bangarwa
+1 -- Nishant Bangarwa Hortonworks On 7/10/18, 3:57 AM, "Jihoon Son" wrote: Related thread: https://lists.apache.org/thread.html/76755aecfddb1210fcc3f08b1d4631784a8a5eede64d22718c271841@%3Cdev.druid.apache.org%3E . Jihoon On Mon, Jul 9, 2018 at 3:25 PM Jihoon

[GitHub] erankor closed issue #5979: Kafka Indexing Service lagging every hour

2018-07-10 Thread GitBox
erankor closed issue #5979: Kafka Indexing Service lagging every hour URL: https://github.com/apache/incubator-druid/issues/5979 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] jihoonson commented on issue #5979: Kafka Indexing Service lagging every hour

2018-07-10 Thread GitBox
jihoonson commented on issue #5979: Kafka Indexing Service lagging every hour URL: https://github.com/apache/incubator-druid/issues/5979#issuecomment-403947611 @erankor good to hear that you've solved! FYI, a new feature for automatic pendingSegments cleanup

[GitHub] jihoonson commented on issue #5979: Kafka Indexing Service lagging every hour

2018-07-10 Thread GitBox
jihoonson commented on issue #5979: Kafka Indexing Service lagging every hour URL: https://github.com/apache/incubator-druid/issues/5979#issuecomment-403952075 > I won't have any job in queue for that long, my main concern is whether it's ok to update this table directly while the

[GitHub] erankor commented on issue #5979: Kafka Indexing Service lagging every hour

2018-07-10 Thread GitBox
erankor commented on issue #5979: Kafka Indexing Service lagging every hour URL: https://github.com/apache/incubator-druid/issues/5979#issuecomment-403952469 Great! thanks @jihoonson! This is an automated message from the

[GitHub] himanshug commented on issue #5988: Coordinator fix exception caused by additional logging

2018-07-10 Thread GitBox
himanshug commented on issue #5988: Coordinator fix exception caused by additional logging URL: https://github.com/apache/incubator-druid/pull/5988#issuecomment-404000855 :+1: This is an automated message from the Apache Git

write access to https://github.com/apache/incubator-druid

2018-07-10 Thread Himanshu
It appears I don't have the write access on new repository. Can anyone tell how to enable that? I think I had submitted my ICLA before. Thanks, Himanshu

[GitHub] erankor commented on issue #5979: Kafka Indexing Service lagging every hour

2018-07-10 Thread GitBox
erankor commented on issue #5979: Kafka Indexing Service lagging every hour URL: https://github.com/apache/incubator-druid/issues/5979#issuecomment-403948881 Thanks @jihoonson, I bumped into this pull after I figured out the problem, that's good news :) Another small question on this -

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

2018-07-10 Thread GitBox
drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201513918 ## File path: indexing-service/src/main/java/io/druid/indexing/common/IndexTaskClient.java

[GitHub] himanshug commented on issue #5957: Various changes

2018-07-10 Thread GitBox
himanshug commented on issue #5957: Various changes URL: https://github.com/apache/incubator-druid/pull/5957#issuecomment-404003366 > Renamed `GenericColumnSerializer` to just `ColumnSerializer` and changed the signature of it's serialize() method. This class was annotated

[GitHub] himanshug commented on issue #5938: URL encode datasources, task ids, authenticator names.

2018-07-10 Thread GitBox
himanshug commented on issue #5938: URL encode datasources, task ids, authenticator names. URL: https://github.com/apache/incubator-druid/pull/5938#issuecomment-404004590 looks like most of the fixes are in the calls to makeWorkerUrl(..), is it possible to put the fix inside impl of that

[GitHub] himanshug commented on issue #5938: URL encode datasources, task ids, authenticator names.

2018-07-10 Thread GitBox
himanshug commented on issue #5938: URL encode datasources, task ids, authenticator names. URL: https://github.com/apache/incubator-druid/pull/5938#issuecomment-404004408 nasty bug! > I think this is a very common mistake, so we need another way to prevent such mistakes. I suggest

[GitHub] himanshug commented on issue #5976: Update license headers.

2018-07-10 Thread GitBox
himanshug commented on issue #5976: Update license headers. URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-404001468 :+1: ps: I don't see the merge button, need to get the permissions set up.

[GitHub] jihoonson closed pull request #5978: Extend various test timeouts.

2018-07-10 Thread GitBox
jihoonson closed pull request #5978: Extend various test timeouts. URL: https://github.com/apache/incubator-druid/pull/5978 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-druid] branch master updated: Extend various test timeouts. (#5978)

2018-07-10 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 948e73d Extend various test

[GitHub] asdf2014 edited a comment on issue #5993: SQL: Add server-wide default time zone config.

2018-07-10 Thread GitBox
asdf2014 edited a comment on issue #5993: SQL: Add server-wide default time zone config. URL: https://github.com/apache/incubator-druid/pull/5993#issuecomment-404024170 It seems to use the forbidden joda-time api. See:

[GitHub] asdf2014 commented on issue #5993: SQL: Add server-wide default time zone config.

2018-07-10 Thread GitBox
asdf2014 commented on issue #5993: SQL: Add server-wide default time zone config. URL: https://github.com/apache/incubator-druid/pull/5993#issuecomment-404024170 It seems to use the forbidden joda-time api. See:

[GitHub] hellobabygogo commented on issue #5871: fix push supervisor error

2018-07-10 Thread GitBox
hellobabygogo commented on issue #5871: fix push supervisor error URL: https://github.com/apache/incubator-druid/pull/5871#issuecomment-404040224 @jihoonson it can avoid task2 failed! This is an automated message from the

Re: Druid 0.12.2-rc1 vote

2018-07-10 Thread Clint Wylie
Heya, sorry for the delay (and missing the sync, i'll try to get better about showing up). I've fixed a handful of coordinator bugs post 0.12.0 (and not backported to 0.12.1), some of these issues go far back, some back to when segment assignment priority for different tiers of historicals was

[GitHub] asdf2014 commented on a change in pull request #5993: SQL: Add server-wide default time zone config.

2018-07-10 Thread GitBox
asdf2014 commented on a change in pull request #5993: SQL: Add server-wide default time zone config. URL: https://github.com/apache/incubator-druid/pull/5993#discussion_r201544930 ## File path: sql/src/test/java/io/druid/sql/calcite/CalciteQueryTest.java ## @@ -169,6

[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
asdf2014 commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201555314 ## File path: services/src/main/java/io/druid/cli/CliPeon.java ## @@ -243,7 +242,7 @@ public

[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
asdf2014 commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201555396 ## File path:

[GitHub] erankor edited a comment on issue #5979: Kafka Indexing Service lagging every hour

2018-07-10 Thread GitBox
erankor edited a comment on issue #5979: Kafka Indexing Service lagging every hour URL: https://github.com/apache/incubator-druid/issues/5979#issuecomment-404050959 @jihoonson, a couple of additional questions on the MySQL tables - 1. Following this issue, we started tracking slow

[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
asdf2014 commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201554378 ## File path: services/src/main/java/io/druid/cli/CliInternalHadoopIndexer.java ## @@ -150,7