Re: Fix issue 2425 and bring a new contributor

2018-12-06 Thread Huxing Zhang
Great work! On Mon, Nov 26, 2018 at 7:45 PM yuhang xiu wrote: > > Hi, > I am very willing to synchronize the latest progress. > I have already distributed two issues to newcomers. So far I have seen > their pull request[1][2] on github and left my review comment. I think we > still need more

Re: [DISCUSS] A robot for Dubbo to help the community collaboration

2018-12-06 Thread yuhang xiu
Great, this robot is very interesting. Netty also has a similar robot[1] that can control whether or not to perform unit tests (some pr can be judged that we won't accept them during the review phase), I think we can also try this. Another feature. It will leave a comment said: 'Can one of the

Re: [DISCUSS] A robot for Dubbo to help the community collaboration

2018-12-06 Thread YunKun Huang
I think if we can have a robot to help manage issue/pr, it will be great. On 2018/12/06 08:09:41, Huxing Zhang wrote: > Hi, > > Recently I‘ve chatted with the maintainer of the pouch[1] project, one > of the interesting thing I learned is that they are using a robot[2] > to help the

Re: [DISCUSS] A robot for Dubbo to help the community collaboration

2018-12-06 Thread Huxing Zhang
On Thu, Dec 6, 2018 at 4:23 PM yuhang xiu wrote: > > Great, this robot is very interesting. > > Netty also has a similar robot[1] that can control whether or not to > perform unit tests (some pr can be judged that we won't accept them during > the review phase), I think we can also try this. >

Re: About the comments coverage of the code

2018-12-06 Thread Ian Luo
That's correct. I think now it is a good chance to build another book 'source code guide' aside of 'user manual', 'dev guide', and 'admin book'. What do you think? Thanks, -Ian. On Thu, Dec 6, 2018 at 6:20 PM 田 小波 wrote: > Hi Ian: > > There is already an article[1] on the Dubbo architecture

Re: Dubbo Community page 404

2018-12-06 Thread Ian Luo
Would you mind to file an issue :) On Thu, Dec 6, 2018 at 5:36 PM 凝雨 wrote: > Hi community, > > > This page in the community[1] access returns 404, Please check. > > > > [1]. > http://dubbo.apache.org/zh-cn/blog/dubbo-meetup-beijing-may-12th-2018.html > > > Best regards, > ningyu

Re: About the comments coverage of the code

2018-12-06 Thread 田 小波
Hi Ian: There is already an article[1] on the Dubbo architecture in Dubbo's official documentation. Maybe I can write an article about "how to read Dubbo code" according to my own experience. Dubbo 官方文档中已经有一篇对 Dubbo 架构介绍的文章,或许我可以根据我自己的经历写一篇如何阅读 Dubbo 源码的文章。 [1]

Re: [DISCUSS] A robot for Dubbo to help the community collaboration

2018-12-06 Thread Huxing Zhang
On Thu, Dec 6, 2018 at 6:27 PM Mark Thomas wrote: > > On 06/12/2018 08:36, Huxing Zhang wrote: > > On Thu, Dec 6, 2018 at 4:23 PM yuhang xiu wrote: > >> > >> Great, this robot is very interesting. > >> > >> Netty also has a similar robot[1] that can control whether or not to > >> perform unit

Re: About the comments coverage of the code

2018-12-06 Thread Huxing Zhang
On Thu, Dec 6, 2018 at 7:25 PM Ian Luo wrote: > > That's correct. > > I think now it is a good chance to build another book 'source code guide' > aside of 'user manual', 'dev guide', and 'admin book'. What do you think? +1 maybe we can also organize some online webinar for Dubbo's source code

Re: Dubbo Community page 404

2018-12-06 Thread YunKun Huang
I believe the root cause is we don't have default route rule for website. If one article doesn't have Chinese version, it should show english version. Same for only Chinese version article. On 2018/12/07 02:35:18, Huxing Zhang wrote: > Hi, > > Thanks for reporting, it is appreciated if you

Re: Use longObjectMap to increase performance

2018-12-06 Thread Huxing Zhang
On Tue, Dec 4, 2018 at 9:43 PM Huxing Zhang wrote: > > Hi, > > On Tue, Dec 4, 2018 at 4:24 PM yuhang xiu wrote: > > > > Hi, community > > At present, there are many Map type maps in dubbo. When using > > this kind of map, jdk performs automatic package. > > > > We can use longObjectMap(or

Re: Dubbo Community page 404

2018-12-06 Thread 田 小波
We may have regular health checks for the official website through web crawlers, so that 404 pages can be processed in time. 我们或许可以通过网络爬虫定期对官网进行健康检测,这样可以及时处理404页面。 Regards, Xiaobo 在 2018年12月7日,上午11:17,Huxing Zhang mailto:hux...@apache.org>> 写道: On Fri, Dec 7, 2018 at 11:14 AM YunKun Huang

Re: help wanted: issue 2899

2018-12-06 Thread Ian Luo
Looks like I cannot assign it to you if you are not a committer but I left a comment to indicate you will be on this issue, pls. simply submit your pull request when you finish the fix. Thanks, -Ian. On Thu, Dec 6, 2018 at 8:07 PM Yuhao Bi wrote: > Hi there, > > I'm willing to give it a try,

Re: Dubbo Community page 404

2018-12-06 Thread Huxing Zhang
Hi, Thanks for reporting, it is appreciated if you can help to fix it :) On Thu, Dec 6, 2018 at 5:36 PM 凝雨 wrote: > > Hi community, > > > This page in the community[1] access returns 404, Please check. > > > > [1].http://dubbo.apache.org/zh-cn/blog/dubbo-meetup-beijing-may-12th-2018.html > > >

Re: help wanted: issue 2899

2018-12-06 Thread Huxing Zhang
On Thu, Dec 6, 2018 at 8:07 PM Yuhao Bi wrote: > > Hi there, > > I'm willing to give it a try, but I cannot change the Assignees in issue > page. Maybe I don't have the authority. > My github id is *biyuhao *,could you please assign it to me? Due to the limitation of Github, we can't assign an

Re: Dubbo Community page 404

2018-12-06 Thread Huxing Zhang
On Fri, Dec 7, 2018 at 11:14 AM YunKun Huang wrote: > > I believe the root cause is we don't have default route rule for website. > > If one article doesn't have Chinese version, it should show english version. > Same for only Chinese version article. If that is the case, this is a known issue.

Re: help wanted: issue 2899

2018-12-06 Thread Yuhao Bi
Hi there, I'm willing to give it a try, but I cannot change the Assignees in issue page. Maybe I don't have the authority. My github id is *biyuhao *,could you please assign it to me? Thanks, Yuhao Ian Luo 于2018年12月6日周四 下午7:39写道: > Hi folks, > > Today I noticed that Travis job started to

Re: Dubbo Community page 404

2018-12-06 Thread Huxing Zhang
Hi, On Fri, Dec 7, 2018 at 11:34 AM 田 小波 wrote: > > We may have regular health checks for the official website through web > crawlers, so that 404 pages can be processed in time. Sounds like a good idea. Would you like to contribute to it? > > 我们或许可以通过网络爬虫定期对官网进行健康检测,这样可以及时处理404页面。 > >