Re: Wanted to assist dubbo community on issue #2884

2018-12-10 Thread Imteyaz Khan
Created an documentation an #2935 issue (Creating dubbo dubbo-rpc-api java documentation) and will be on it, could someone tag or assigned it to me. Regards Imteyaz On Sat, Dec 8, 2018 at 7:19 PM Huxing Zhang wrote: > Hi Imteyaz, > > On

Re: Wanted to assist dubbo community on issue #2884

2018-12-10 Thread Huxing Zhang
Hi, On Tue, Dec 11, 2018 at 3:04 AM Imteyaz Khan wrote: > > Created an documentation an #2935 > issue (Creating > dubbo dubbo-rpc-api java documentation) and will be on it, could someone > tag or assigned it to me. I've assigned it to you

Re: [PR-2803]: Fix telnet can not find method with enum type

2018-12-10 Thread Ian Luo
Sure. I will move your change in. It is not a big deal. We can revisit it later if performance is a concern. -Ian. On Mon, Dec 10, 2018 at 8:30 PM 李振 wrote: > @Ian Luo > > 我感觉你建议的改法可能有些问题,我的方案只是性能不好,但是我认为telnet 用途主要是debug ,可以不太关注性能。 > > I feel that your proposed modification may have some

Re: 回复:[DISCUSS] Next Dubbo meetup

2018-12-10 Thread Mercy
I vote twice, one is Nanjing, another is Guangzhou :D Kind regards, Mercy Ma 在 2018/12/11 下午1:47, 王蓉(涂南) 写道: Folks, so far we have received 40 votes. Looks like Guangzhou is where we're gonna meet on Jan 19th. 广州 12 南京 10 北京 4 深圳 4

Re: [PR2738]: epoll support

2018-12-10 Thread Zonghai Shang
I will modify it again as suggested by the code review. -yiji Ian Luo 于2018年12月11日周二 上午10:43写道: > Hi Zonghai, > > Is there any update on pull request 2738 [1]? It starts to conflict with > the base. > > Thanks, > -Ian. > > 1. https://github.com/apache/incubator-dubbo/pull/2738 >

Re: issue#2850, the original pull request closed

2018-12-10 Thread jun liu
All questions cleared up about this PR. After reproduced and debugged it locally, I understand why stub cannot work in a multi registries circumstance now: the Invoker instance used for creating a proxy in ReferenceConfig is already a wrapped cluster invoker, this wrapped invoker derives a

Re: About the comments coverage of the code

2018-12-10 Thread yuhang xiu
Ok, huxing I'd like take some time to do this. Huxing Zhang 于2018年12月10日周一 下午11:43写道: > On Mon, Dec 10, 2018 at 7:14 PM yuhang xiu wrote: > > > > Hi, > > @zhuzi @shunyumaple > > You are welcome to claim a new job. > > > > We currently have a project, but I have not yet divided it. I think we

Re: Wanted to assist dubbo community on issue #2884

2018-12-10 Thread Imteyaz Khan
Thanks a lot, appreciate it. On Tue, Dec 11, 2018 at 7:03 AM Huxing Zhang wrote: > Hi, > > On Tue, Dec 11, 2018 at 3:04 AM Imteyaz Khan > wrote: > > > > Created an documentation an #2935 > > issue (Creating > > dubbo dubbo-rpc-api java

Re: A proposal for transfer dubbo-samples to github.com/apache

2018-12-10 Thread Huxing Zhang
Hi All, dubbo-samples has been moved to https://github.com/apache/incubator-dubbo-samples and configured as a gibox repo. It may take up to an hour for gitbox to associate the dubbo team with the repo. Please take some look, for now all look good to me. On Thu, Dec 6, 2018 at 10:23 AM Huxing

[PR2738]: epoll support

2018-12-10 Thread Ian Luo
Hi Zonghai, Is there any update on pull request 2738 [1]? It starts to conflict with the base. Thanks, -Ian. 1. https://github.com/apache/incubator-dubbo/pull/2738

[incubator-dubbo-samples] branch master updated: Update README.md

2018-12-10 Thread wangxin
This is an automated email from the ASF dual-hosted git repository. wangxin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new d4e1a15 Update README.md

Re: [PR2738]: epoll support

2018-12-10 Thread Ian Luo
look forward to it. Let me know when it's ready. On Tue, Dec 11, 2018 at 10:45 AM Zonghai Shang wrote: > I will modify it again as suggested by the code review. > > -yiji > > Ian Luo 于2018年12月11日周二 上午10:43写道: > > > Hi Zonghai, > > > > Is there any update on pull request 2738 [1]? It starts to

回复:[DISCUSS] Next Dubbo meetup

2018-12-10 Thread 王蓉(涂南)
Folks, so far we have received 40 votes. Looks like Guangzhou is where we're gonna meet on Jan 19th. 广州 12 南京 10 北京 4 深圳 4 上海 4 厦门 2 武汉 1 西安 1 重庆 1 大连 1

Re: [incubator-dubbo-samples] branch master updated: Update README.md

2018-12-10 Thread Xin Wang
I modify the dubbo-samples/README.md because the travis ci info changed I think this mail should be sent to notifacati...@dubbo.apache.org automatically, but why sent to dev@dubbo.apache.org Huxing Zhang 于2018年12月11日周二 下午3:32写道: > Sorry, I mean to say let's wait a few more times. > > On

Re: [incubator-dubbo-samples] branch master updated: Update README.md

2018-12-10 Thread Huxing Zhang
Hi, I think this notification should be sent to comm...@dubbo.apache.org. As Infra said, It may take some time to set up them, let's wait a few more time.On Tue, Dec 11, 2018 at 12:58 PM wrote: > > This is an automated email from the ASF dual-hosted git repository. > > wangxin pushed a commit to

Re: [incubator-dubbo-samples] branch master updated: Update README.md

2018-12-10 Thread Huxing Zhang
Sorry, I mean to say let's wait a few more times. On Tue, Dec 11, 2018 at 3:18 PM Huxing Zhang wrote: > > Hi, > > I think this notification should be sent to comm...@dubbo.apache.org. > As Infra said, It may take some time to set up them, let's wait a few > more time.On Tue, Dec 11, 2018 at

Re: help wanted: issue 2899

2018-12-10 Thread Ian Luo
https://github.com/apache/incubator-dubbo/pull/2917 is merged. On Fri, Dec 7, 2018 at 4:56 PM Ian Luo wrote: > Thank you. This problem is quite weird. It cannot reproduce on my laptop. > > -Ian. > > On Fri, Dec 7, 2018 at 4:44 PM Yuhao Bi wrote: > >> Sure! I'm working on it~ >> >> Ian Luo

Re: Source code guide

2018-12-10 Thread Ian Luo
will take a look soon :) On Mon, Dec 10, 2018 at 2:21 PM 田 小波 wrote: > Hi community, > > I just submitted my source analysis article to dubbo-website, the PR > number is #197 [1], please help check. > > [1] https://github.com/apache/incubator-dubbo-website/pull/197 > > Thanks! > Xiaobo > > 在

[PR-2803]: Fix telnet can not find method with enum type

2018-12-10 Thread Ian Luo
@LiZhenNet, I left my review comments on PR2803 [1], pls. take a look when you notice this email. Thanks, -Ian. 1. https://github.com/apache/incubator-dubbo/pull/2803

Re: help wanted: issue 2899

2018-12-10 Thread Ian Luo
also merged the corresponding change from PR2913 [1] contributed from @biyuhao. -Ian. 1. https://github.com/apache/incubator-dubbo/pull/2913 On Mon, Dec 10, 2018 at 4:21 PM Ian Luo wrote: > https://github.com/apache/incubator-dubbo/pull/2917 is merged. > > On Fri, Dec 7, 2018 at 4:56 PM Ian

Re: About the comments coverage of the code

2018-12-10 Thread yuhang xiu
Hi, @zhuzi @shunyumaple You are welcome to claim a new job. We currently have a project, but I have not yet divided it. I think we need a discussion about how to divide tasks. @huxing @beiwei Can you give some advice? I personally think that you can divide by module, but the work of a module can

Re: Repeated content in dubbo 2.6.4's internal content

2018-12-10 Thread yuhang xiu
Hi, @jerrick zhu @beiwei I am very sorry that I did not spend a lot of time on this issue last week. I will take the time to verify this issue this week. This issue is still being tracked. Ian Luo 于2018年11月29日周四 上午10:08写道: > Great. In this week I didn't have much time on dubbo project. I

Re: [PR-2803]: Fix telnet can not find method with enum type

2018-12-10 Thread 李振
@Ian Luo 我感觉你建议的改法可能有些问题,我的方案只是性能不好,但是我认为telnet 用途主要是debug ,可以不太关注性能。 I feel that your proposed modification may have some problems. My solution is just poor performance, but I think telnet is mainly used for debugging, and can pay less attention to performance. Ian Luo 于2018年12月10日周一

Re: About the comments coverage of the code

2018-12-10 Thread Huxing Zhang
On Mon, Dec 10, 2018 at 7:14 PM yuhang xiu wrote: > > Hi, > @zhuzi @shunyumaple > You are welcome to claim a new job. > > We currently have a project, but I have not yet divided it. I think we need > a discussion about how to divide tasks. > @huxing @beiwei Can you give some advice? I personally