Supportted java version

2018-03-27 Thread htynkn
hey team, What's the supportted java version for dubbo now? In travis file, I can see it's using java7 and java8. do we have offical support java9 or even java10? Regards, Yunkun

Re:Re: Supportted java version

2018-03-27 Thread htynkn
arty >libraries, checking third party support for Java 9 is still something >we need to work on. > >Java 10 support is underway. > > > >On Wed, Mar 28, 2018 at 9:34 AM, htynkn wrote: >> hey team, >> >> >> What's the supportted java version for du

Re:Re: Re: Supportted java version

2018-03-28 Thread htynkn
just did a try. we are using cobertura as coverage plugin. cobertura doesn't support java9 and latest version is released at 2015. we need consider to switch to jacoco or other tool. At 2018-03-28 14:44:31, "Huxing Zhang" wrote: >On Wed, Mar 28, 2018 at 1:39 PM, htynkn

[Suggestion] PR failing if test coverage went down

2018-04-09 Thread htynkn
hey team, In pull request template(https://github.com/apache/incubator-dubbo/blob/master/PULL_REQUEST_TEMPLATE.md), this is one item to ask all pr to "Write necessary unit-test to verify your logic correction" Codecov has feature to fail PR if test coverage went down. Which means for an

Unstable test for HessianProtocolTest

2018-04-13 Thread htynkn
hey team, I notice two fail for HessianProtocolTest in travis CI. but it will pass next time if you trigger CI again. The fail test file is com.alibaba.dubbo.rpc.protocol.hessian.HessianProtocolTest and console logs: Tests run: 5, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 2.609 sec <<<

Re: [Suggestion] PR failing if test coverage went down

2018-04-13 Thread htynkn
po[1], which makes confused. > > Unless we can figure it out, or I think it will be better if we can > set a threshold. > > For example, if the code coverage drops >=0.1%, prevent the PR to be merged. > > [1] https://github.com/apache/incubator-dubbo/pull/1562 > > On T

Re: [Suggestion] PR failing if test coverage went down

2018-04-15 Thread htynkn
t; >> > >> Unless we can figure it out, or I think it will be better if we can > >> set a threshold. > >> > >> For example, if the code coverage drops >=0.1%, prevent the PR to be > >> merged. > >> > >> [1] https://github.com/apach

Re: [Suggestion] PR failing if test coverage went down

2018-04-19 Thread htynkn
Cool. I'm busy recently and may not have time to make this change. So I'm going to raise a issue in github repo and put everything together, if anyone interested in this, he/she can help with this. On 2018/04/16 04:04:39, shang zonghai wrote: > +1 for considering small changes. > > We need r

Plan to improve unit test and test coverage

2018-04-24 Thread htynkn
hey team, There is one issue opening (https://github.com/apache/incubator-dubbo/issues/1487) related to code coverage. But this is no further discuss about this issue. So I send this email to mail list. Current code coverage is 35%, and refer to https://codecov.io/gh/apache/incubator-dubbo. T

[Suggestion] Add maven wrapper

2018-06-01 Thread htynkn
hey team, I suggest adding maven wrapper to Dubbo project. (https://github.com/takari/maven-wrapper) maven wrapper can help us to use same maven version to avoid some unexpected issue. maven wrapper also helps the user who doesn't install maven in their own machine to easily use maven. I thi

Re: Refactor Dubbo metrics

2018-06-12 Thread htynkn
easy integration to existing popular monitoring systems +1 I think this is very important since many companies already have their own monitor system, it's better to provide an easy way to integrate with them On 2018/06/08 03:44:31, Huxing Zhang wrote: > Hi All, > > I have took some time to lo

Re: Supportted java version

2018-06-12 Thread htynkn
ld keep Java 7 support on branch 2.6.x, but > we should definitely switch the development activities on master branch and > fix severe bug only on branch 2.6.x. > > What do you think? > > Thanks, > -Ian. > > 1. https://www.infoq.com/news/2015/05/Oracle-Ends-Java-7Public