[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays
[ https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644792#comment-15644792 ] ASF GitHub Bot commented on FINERACT-37: Github user jroweboy closed the pull request at: https://github.com/apache/incubator-fineract/pull/110 > Support rescheduling repayments on holidays > --- > > Key: FINERACT-37 > URL: https://issues.apache.org/jira/browse/FINERACT-37 > Project: Apache Fineract > Issue Type: Improvement > Components: System >Reporter: James Rowe >Assignee: Markus Geiss > > Our client is currently trying to migrate from their current financial > software, but one of the configuration options is not present in Fineract. > The option changes the way Fineract schedules loan repayments. Instead of > rescheduling a repayment to a different day in the week, holidays would > reschedule the repayment to the next due date and extend the schedule. For > example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that > has a repayment fall in the holiday will be rescheduled to the next week and > the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png > With this the loan term is extended and the repayment that landed on a > holiday is repaid on the next due date. > I already have a proof of concept patch for this, but I think there are some > issues with it. As such, I would like to work with a developer to discuss the > best way to implement this, or if you would like, we can just figure out why > my patch occasionally enters an infinite loop... > As a related request, the client is looking to have the interest due at this > repayment to be redistributed across the full loan schedule. I wasn't sure if > I should include this in this issue report or to make a new one that is > related to this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays
[ https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584692#comment-15584692 ] ASF GitHub Bot commented on FINERACT-37: Github user asfgit closed the pull request at: https://github.com/apache/incubator-fineract/pull/219 > Support rescheduling repayments on holidays > --- > > Key: FINERACT-37 > URL: https://issues.apache.org/jira/browse/FINERACT-37 > Project: Apache Fineract > Issue Type: Improvement > Components: System >Reporter: James Rowe >Assignee: Markus Geiss > > Our client is currently trying to migrate from their current financial > software, but one of the configuration options is not present in Fineract. > The option changes the way Fineract schedules loan repayments. Instead of > rescheduling a repayment to a different day in the week, holidays would > reschedule the repayment to the next due date and extend the schedule. For > example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that > has a repayment fall in the holiday will be rescheduled to the next week and > the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png > With this the loan term is extended and the repayment that landed on a > holiday is repaid on the next due date. > I already have a proof of concept patch for this, but I think there are some > issues with it. As such, I would like to work with a developer to discuss the > best way to implement this, or if you would like, we can just figure out why > my patch occasionally enters an infinite loop... > As a related request, the client is looking to have the interest due at this > repayment to be redistributed across the full loan schedule. I wasn't sure if > I should include this in this issue report or to make a new one that is > related to this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays
[ https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584537#comment-15584537 ] ASF GitHub Bot commented on FINERACT-37: Github user nazeer1100126 commented on the issue: https://github.com/apache/incubator-fineract/pull/219 I agree to your point :-) > Support rescheduling repayments on holidays > --- > > Key: FINERACT-37 > URL: https://issues.apache.org/jira/browse/FINERACT-37 > Project: Apache Fineract > Issue Type: Improvement > Components: System >Reporter: James Rowe >Assignee: Markus Geiss > > Our client is currently trying to migrate from their current financial > software, but one of the configuration options is not present in Fineract. > The option changes the way Fineract schedules loan repayments. Instead of > rescheduling a repayment to a different day in the week, holidays would > reschedule the repayment to the next due date and extend the schedule. For > example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that > has a repayment fall in the holiday will be rescheduled to the next week and > the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png > With this the loan term is extended and the repayment that landed on a > holiday is repaid on the next due date. > I already have a proof of concept patch for this, but I think there are some > issues with it. As such, I would like to work with a developer to discuss the > best way to implement this, or if you would like, we can just figure out why > my patch occasionally enters an infinite loop... > As a related request, the client is looking to have the interest due at this > repayment to be redistributed across the full loan schedule. I wasn't sure if > I should include this in this issue report or to make a new one that is > related to this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays
[ https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568368#comment-15568368 ] ASF GitHub Bot commented on FINERACT-37: Github user terencemo commented on the issue: https://github.com/apache/incubator-fineract/pull/219 extendTermForDailyRepayments flag is for a different purpose than extendTermForRepaymentsOnHolidays. There should be a way to specify which of the 2 is required and hence 2 bools. If a single bool is used, what is the behaviour if its set? Does it extend the term for both loans with daily repayment schedule and for holidays? What if the API user needs one of these 2 functionalities? > Support rescheduling repayments on holidays > --- > > Key: FINERACT-37 > URL: https://issues.apache.org/jira/browse/FINERACT-37 > Project: Apache Fineract > Issue Type: Improvement > Components: System >Reporter: James Rowe >Assignee: Markus Geiss > > Our client is currently trying to migrate from their current financial > software, but one of the configuration options is not present in Fineract. > The option changes the way Fineract schedules loan repayments. Instead of > rescheduling a repayment to a different day in the week, holidays would > reschedule the repayment to the next due date and extend the schedule. For > example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that > has a repayment fall in the holiday will be rescheduled to the next week and > the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png > With this the loan term is extended and the repayment that landed on a > holiday is repaid on the next due date. > I already have a proof of concept patch for this, but I think there are some > issues with it. As such, I would like to work with a developer to discuss the > best way to implement this, or if you would like, we can just figure out why > my patch occasionally enters an infinite loop... > As a related request, the client is looking to have the interest due at this > repayment to be redistributed across the full loan schedule. I wasn't sure if > I should include this in this issue report or to make a new one that is > related to this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays
[
https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568359#comment-15568359
]
ASF GitHub Bot commented on FINERACT-37:
Github user terencemo commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/219#discussion_r82979521
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java
---
@@ -96,10 +96,33 @@ public LocalDate generateNextRepaymentDate(final
LocalDate lastRepaymentDate, fi
loanApplicationTerms.getNumberOfdays());
}
}
-
+if (currentCalendar == null &&
holidayDetailDTO.getWorkingDays().getExtendTermForRepaymentsOnHolidays()) {
--- End diff --
Tried calling adjustRepaymentDate. It doesn't reschedule for holidays other
than weekend. Went through the code of adjustRepaymentDate and found nothing
that handles holidays. The code block after the if does something which I
couldn't find in any existing function in the codebase.
> Support rescheduling repayments on holidays
> ---
>
> Key: FINERACT-37
> URL: https://issues.apache.org/jira/browse/FINERACT-37
> Project: Apache Fineract
> Issue Type: Improvement
> Components: System
>Reporter: James Rowe
>Assignee: Markus Geiss
>
> Our client is currently trying to migrate from their current financial
> software, but one of the configuration options is not present in Fineract.
> The option changes the way Fineract schedules loan repayments. Instead of
> rescheduling a repayment to a different day in the week, holidays would
> reschedule the repayment to the next due date and extend the schedule. For
> example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that
> has a repayment fall in the holiday will be rescheduled to the next week and
> the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png
> With this the loan term is extended and the repayment that landed on a
> holiday is repaid on the next due date.
> I already have a proof of concept patch for this, but I think there are some
> issues with it. As such, I would like to work with a developer to discuss the
> best way to implement this, or if you would like, we can just figure out why
> my patch occasionally enters an infinite loop...
> As a related request, the client is looking to have the interest due at this
> repayment to be redistributed across the full loan schedule. I wasn't sure if
> I should include this in this issue report or to make a new one that is
> related to this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays
[ https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467030#comment-15467030 ] ASF GitHub Bot commented on FINERACT-37: Github user nazeer1100126 commented on the issue: https://github.com/apache/incubator-fineract/pull/219 I believe we no need to have two boolean variables to extend the term. 1) extendTermForDailyRepayments 2) extendTermForRepaymentsOnHolidays We can have a single config extendTerm. If this config is enabled, generateNextRepaymentDate method should return adjusted date > Support rescheduling repayments on holidays > --- > > Key: FINERACT-37 > URL: https://issues.apache.org/jira/browse/FINERACT-37 > Project: Apache Fineract > Issue Type: Improvement > Components: System >Reporter: James Rowe >Assignee: Markus Geiss > > Our client is currently trying to migrate from their current financial > software, but one of the configuration options is not present in Fineract. > The option changes the way Fineract schedules loan repayments. Instead of > rescheduling a repayment to a different day in the week, holidays would > reschedule the repayment to the next due date and extend the schedule. For > example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that > has a repayment fall in the holiday will be rescheduled to the next week and > the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png > With this the loan term is extended and the repayment that landed on a > holiday is repaid on the next due date. > I already have a proof of concept patch for this, but I think there are some > issues with it. As such, I would like to work with a developer to discuss the > best way to implement this, or if you would like, we can just figure out why > my patch occasionally enters an infinite loop... > As a related request, the client is looking to have the interest due at this > repayment to be redistributed across the full loan schedule. I wasn't sure if > I should include this in this issue report or to make a new one that is > related to this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays
[
https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467008#comment-15467008
]
ASF GitHub Bot commented on FINERACT-37:
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/219#discussion_r77605384
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java
---
@@ -96,10 +96,33 @@ public LocalDate generateNextRepaymentDate(final
LocalDate lastRepaymentDate, fi
loanApplicationTerms.getNumberOfdays());
}
}
-
+if (currentCalendar == null &&
holidayDetailDTO.getWorkingDays().getExtendTermForRepaymentsOnHolidays()) {
--- End diff --
if extendTermForRepaymentsOnHolidays is true, why can't we call
adjustRepaymentDate method and return that date?
> Support rescheduling repayments on holidays
> ---
>
> Key: FINERACT-37
> URL: https://issues.apache.org/jira/browse/FINERACT-37
> Project: Apache Fineract
> Issue Type: Improvement
> Components: System
>Reporter: James Rowe
>Assignee: Markus Geiss
>
> Our client is currently trying to migrate from their current financial
> software, but one of the configuration options is not present in Fineract.
> The option changes the way Fineract schedules loan repayments. Instead of
> rescheduling a repayment to a different day in the week, holidays would
> reschedule the repayment to the next due date and extend the schedule. For
> example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that
> has a repayment fall in the holiday will be rescheduled to the next week and
> the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png
> With this the loan term is extended and the repayment that landed on a
> holiday is repaid on the next due date.
> I already have a proof of concept patch for this, but I think there are some
> issues with it. As such, I would like to work with a developer to discuss the
> best way to implement this, or if you would like, we can just figure out why
> my patch occasionally enters an infinite loop...
> As a related request, the client is looking to have the interest due at this
> repayment to be redistributed across the full loan schedule. I wasn't sure if
> I should include this in this issue report or to make a new one that is
> related to this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays
[
https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466765#comment-15466765
]
ASF GitHub Bot commented on FINERACT-37:
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/219#discussion_r77589232
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java
---
@@ -57,10 +57,10 @@ public LocalDate generateNextRepaymentDate(final
LocalDate lastRepaymentDate, fi
boolean isFirstRepayment, final HolidayDetailDTO
holidayDetailDTO) {
final LocalDate firstRepaymentPeriodDate =
loanApplicationTerms.getCalculatedRepaymentsStartingFromLocalDate();
LocalDate dueRepaymentPeriodDate = null;
+Calendar currentCalendar = loanApplicationTerms.getLoanCalendar();
if (isFirstRepayment && firstRepaymentPeriodDate != null) {
dueRepaymentPeriodDate = firstRepaymentPeriodDate;
} else {
-Calendar currentCalendar =
loanApplicationTerms.getLoanCalendar();
dueRepaymentPeriodDate =
getRepaymentPeriodDate(loanApplicationTerms.getRepaymentPeriodFrequencyType(),
--- End diff --
You have removed Calendar currentCalendar =
loanApplicationTerms.getLoanCalendar();
It is going to affect existing functionality
> Support rescheduling repayments on holidays
> ---
>
> Key: FINERACT-37
> URL: https://issues.apache.org/jira/browse/FINERACT-37
> Project: Apache Fineract
> Issue Type: Improvement
> Components: System
>Reporter: James Rowe
>Assignee: Markus Geiss
>
> Our client is currently trying to migrate from their current financial
> software, but one of the configuration options is not present in Fineract.
> The option changes the way Fineract schedules loan repayments. Instead of
> rescheduling a repayment to a different day in the week, holidays would
> reschedule the repayment to the next due date and extend the schedule. For
> example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that
> has a repayment fall in the holiday will be rescheduled to the next week and
> the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png
> With this the loan term is extended and the repayment that landed on a
> holiday is repaid on the next due date.
> I already have a proof of concept patch for this, but I think there are some
> issues with it. As such, I would like to work with a developer to discuss the
> best way to implement this, or if you would like, we can just figure out why
> my patch occasionally enters an infinite loop...
> As a related request, the client is looking to have the interest due at this
> repayment to be redistributed across the full loan schedule. I wasn't sure if
> I should include this in this issue report or to make a new one that is
> related to this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays
[ https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436741#comment-15436741 ] ASF GitHub Bot commented on FINERACT-37: GitHub user terencemo opened a pull request: https://github.com/apache/incubator-fineract/pull/219 FINERACT-37 Reschedule repayment on holidays+extend term Based on PR #110. Adds a WorkingDays flag extendTermForRepaymentOnHoliday when this is set If a repayment occurs on a holiday, shift it to the next repayment date and extend the loan term by the repayment interval, e.g if repayment is weekly and one repayment occurs on holiday, move that to the next original schedule repayment date and extend loan term by 1 week You can merge this pull request into a Git repository by running: $ git pull https://github.com/terencemo/incubator-fineract i37-holidays-repayment Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-fineract/pull/219.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #219 commit b478064ac0fe74a7130b9a0c2f07a5ccd30631a5 Author: Terence Denzil Monteiro Date: 2016-08-25T12:15:14Z Reschedule repayment on holidays+extend term > Support rescheduling repayments on holidays > --- > > Key: FINERACT-37 > URL: https://issues.apache.org/jira/browse/FINERACT-37 > Project: Apache Fineract > Issue Type: Improvement > Components: System >Reporter: James Rowe >Assignee: Markus Geiss > > Our client is currently trying to migrate from their current financial > software, but one of the configuration options is not present in Fineract. > The option changes the way Fineract schedules loan repayments. Instead of > rescheduling a repayment to a different day in the week, holidays would > reschedule the repayment to the next due date and extend the schedule. For > example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that > has a repayment fall in the holiday will be rescheduled to the next week and > the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png > With this the loan term is extended and the repayment that landed on a > holiday is repaid on the next due date. > I already have a proof of concept patch for this, but I think there are some > issues with it. As such, I would like to work with a developer to discuss the > best way to implement this, or if you would like, we can just figure out why > my patch occasionally enters an infinite loop... > As a related request, the client is looking to have the interest due at this > repayment to be redistributed across the full loan schedule. I wasn't sure if > I should include this in this issue report or to make a new one that is > related to this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays
[ https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279113#comment-15279113 ] ASF GitHub Bot commented on FINERACT-37: GitHub user jroweboy opened a pull request: https://github.com/apache/incubator-fineract/pull/110 FINERACT-37 Reschedule payments to the next payment date on holidays A simple patch that adds a field to the database to enable rescheduling repayments that land on holidays to the next repayment date instead of a set date. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jroweboy/incubator-fineract holiday_reschedule Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-fineract/pull/110.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #110 > Support rescheduling repayments on holidays > --- > > Key: FINERACT-37 > URL: https://issues.apache.org/jira/browse/FINERACT-37 > Project: Apache Fineract > Issue Type: Improvement > Components: System >Reporter: James Rowe >Assignee: Markus Geiss > > Our client is currently trying to migrate from their current financial > software, but one of the configuration options is not present in Fineract. > The option changes the way Fineract schedules loan repayments. Instead of > rescheduling a repayment to a different day in the week, holidays would > reschedule the repayment to the next due date and extend the schedule. For > example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that > has a repayment fall in the holiday will be rescheduled to the next week and > the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png > With this the loan term is extended and the repayment that landed on a > holiday is repaid on the next due date. > I already have a proof of concept patch for this, but I think there are some > issues with it. As such, I would like to work with a developer to discuss the > best way to implement this, or if you would like, we can just figure out why > my patch occasionally enters an infinite loop... > As a related request, the client is looking to have the interest due at this > repayment to be redistributed across the full loan schedule. I wasn't sure if > I should include this in this issue report or to make a new one that is > related to this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
