Re: [DISCUSS] FLIP-10: Unify Savepoints and Checkpoints

[Till Rohrmann]

+1 for the FLIP.

I like the described changes and new functionality.

When looking at the public interface, I was wondering whether we should not
allow the user to specify a TimeUnit for the periodic interval. I think
it's nicer to be able to specify the time unit instead of converting
everything to milli seconds.

Cheers,
Till

On Fri, Aug 19, 2016 at 6:21 PM, Aljoscha Krettek 
wrote:

> +1 A great proposal.
>
> I'd like to suggest one change. In one paragraph you say "If no savepoint
> path is configured, fail the savepoint.". I think this is
> problematic because it means that users who forgot to add the setting to
> the config will be at a dead if they want to update. Can we make it work by
> specifying a file path with the command? A bit further below you mention
> adding an explicit file path to the savepoint command but it seems that one
> would only work if you also specified the config setting?
>
> Cheers,
> Aljoscha
>
> On Fri, 19 Aug 2016 at 18:07 Gyula Fóra  wrote:
>
> > Hi Ufuk,
> >
> > Great initiative in general I agree with pretty much everything in the
> > proposal.
> >
> > Some minor comments:
> > With these changes savepoints and checkpoints become pretty much the same
> > thing so we might as well drop one of the concepts and just refer to
> > checkpoints as savepoints that are discarded by the system.
> >
> > How do you plan to keep track of the available savepoints? It would be
> > great to provide a rest api or something to query it. Otherwise devs need
> > to have a lot of custom bookkeeping outside of the system. This might be
> > inevitable though...
> >
> > Cheers,
> > Gyula
> >
> > On Fri, Aug 19, 2016, 17:59 Ufuk Celebi  wrote:
> >
> > > Hey devs! I've created a FLIP to unify savepoints and checkpoints:
> > >
> > >
> > >
> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-
> 10%3A+Unify+Checkpoints+and+Savepoints#
> > >
> > > Looking forward to your feedback.
> > >
> > > – Ufuk
> > >
> >
>

Re: [DISCUSS] FLIP-10: Unify Savepoints and Checkpoints

[Aljoscha Krettek]

+1 A great proposal.

I'd like to suggest one change. In one paragraph you say "If no savepoint
path is configured, fail the savepoint.". I think this is
problematic because it means that users who forgot to add the setting to
the config will be at a dead if they want to update. Can we make it work by
specifying a file path with the command? A bit further below you mention
adding an explicit file path to the savepoint command but it seems that one
would only work if you also specified the config setting?

Cheers,
Aljoscha

On Fri, 19 Aug 2016 at 18:07 Gyula Fóra  wrote:

> Hi Ufuk,
>
> Great initiative in general I agree with pretty much everything in the
> proposal.
>
> Some minor comments:
> With these changes savepoints and checkpoints become pretty much the same
> thing so we might as well drop one of the concepts and just refer to
> checkpoints as savepoints that are discarded by the system.
>
> How do you plan to keep track of the available savepoints? It would be
> great to provide a rest api or something to query it. Otherwise devs need
> to have a lot of custom bookkeeping outside of the system. This might be
> inevitable though...
>
> Cheers,
> Gyula
>
> On Fri, Aug 19, 2016, 17:59 Ufuk Celebi  wrote:
>
> > Hey devs! I've created a FLIP to unify savepoints and checkpoints:
> >
> >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-10%3A+Unify+Checkpoints+and+Savepoints#
> >
> > Looking forward to your feedback.
> >
> > – Ufuk
> >
>

Re: [DISCUSS] FLIP-10: Unify Savepoints and Checkpoints

[Gyula Fóra]

Hi Ufuk,

Great initiative in general I agree with pretty much everything in the
proposal.

Some minor comments:
With these changes savepoints and checkpoints become pretty much the same
thing so we might as well drop one of the concepts and just refer to
checkpoints as savepoints that are discarded by the system.

How do you plan to keep track of the available savepoints? It would be
great to provide a rest api or something to query it. Otherwise devs need
to have a lot of custom bookkeeping outside of the system. This might be
inevitable though...

Cheers,
Gyula

On Fri, Aug 19, 2016, 17:59 Ufuk Celebi  wrote:

> Hey devs! I've created a FLIP to unify savepoints and checkpoints:
>
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-10%3A+Unify+Checkpoints+and+Savepoints#
>
> Looking forward to your feedback.
>
> – Ufuk
>