Re: Review Request 54003: GEODE-2137 client membership IDs contain 17 bytes of useless information that should be removed

2016-11-29 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54003/ --- (Updated Nov. 29, 2016, 9:12 p.m.) Review request for geode, Galen O'Sullivan,

[GitHub] incubator-geode issue #300: [GEODE-224] Geode Spark connector parser is not ...

2016-11-29 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/incubator-geode/pull/300 @jhuynh1 @markito Thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...

2016-11-29 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/283 closing the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-geode pull request #300: [GEODE-224] Geode Spark connector parser ...

2016-11-29 Thread vectorijk
GitHub user vectorijk opened a pull request: https://github.com/apache/incubator-geode/pull/300 [GEODE-224] Geode Spark connector parser is not processing type casting properly This issue is related to wrong regex of query string. You can merge this pull request into a Git

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

2016-11-29 Thread gesterzhou
Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90173264 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java --- @@ -0,0 +1,164 @@ +/*

[GitHub] incubator-geode pull request #299: [ GEODE-2141 ] #comment Fix Issue #2141

2016-11-29 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/299#discussion_r90025760 --- Diff: geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java --- @@ -110,7 +100,7 @@ public void sampled(long

[GitHub] incubator-geode pull request #299: [ GEODE-2141 ] #comment Fix Issue #2141

2016-11-29 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/299#discussion_r90025277 --- Diff: geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java --- @@ -38,7 +37,8 @@ private final boolean

[GitHub] incubator-geode pull request #299: [ GEODE-2141 ] #comment Fix Issue #2141

2016-11-29 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/299#discussion_r90025623 --- Diff: geode-core/src/main/java/org/apache/geode/internal/statistics/StatisticsMonitor.java --- @@ -114,14 +100,14 @@ protected void

[GitHub] incubator-geode pull request #292: [GEODE-1509] Fixed : Reduce the memory us...

2016-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #290: GEODE-2092: Security examples should not ...

2016-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

2016-11-29 Thread upthewaterspout
Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90073132 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java --- @@ -0,0 +1,164 @@

[GitHub] incubator-geode pull request #299: [ GEODE-2141 ] #comment Fix Issue #2141

2016-11-29 Thread upthewaterspout
Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/299#discussion_r90077733 --- Diff: geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java --- @@ -50,36 +50,26 @@ public