Re: [DISCUSS] add GEODE-7079 to release/1.9.2

2019-10-04 Thread Jens Deppe
Thank you for your votes. GEODE-7079 will now be added to the 1.9.2 release. --Jens On Fri, Oct 4, 2019 at 12:51 PM Eric Shu wrote: > +1 > > > On Fri, Oct 4, 2019 at 11:38 AM Anilkumar Gingade > wrote: > > > +1 > > > > On Fri, Oct 4, 2019 at 11:15 AM Juan José Ramos > wrote: > > > > > +1 > >

Re: [Announce] Release branch 1.9.2 created

2019-10-04 Thread Juan José Ramos
Hello Jens, Can we add *GEODE-7079 [1]* to this release branch as well?. The fix basically prevents a NPE during restart of members that have configured asynchronous event distribution (either WAN replication of async event listener) & conflation. Best regards. [1]:

[Announce] Release branch 1.9.2 created

2019-10-04 Thread Jens Deppe
Hello Geode Dev Community, We have created a new release branch for Apache Geode 1.9.2 - "release/1.9.2" This branch currently includes the following commits: GEODE-7124: Fixing tests for older version GEODE-7204: Add changes to AEQ documentation for 'pause-event-processing' functionality

Re: [Announce] Release branch 1.9.2 created

2019-10-04 Thread Robert Houghton
I'm about to merge the war pr into develop. On Fri, Oct 4, 2019, 06:47 Jens Deppe wrote: > Hello Geode Dev Community, > > We have created a new release branch for Apache Geode 1.9.2 - > "release/1.9.2" > > > This branch currently includes the following commits: > > > GEODE-7124: Fixing tests

Re: [Announce] Release branch 1.9.2 created

2019-10-04 Thread Jens Deppe
Hi Juan, The purpose of this release is to provide fixes that are required for the Spring Data Geode project. Since the current release of SDG (2.2.0.RELEASE) is based against Geode 1.9.1, it cannot be bumped to any newer (major or even minor) version that may contain fixes it requires. Thus, for

Re: [Announce] Release branch 1.9.2 created

2019-10-04 Thread Udo Kohlmeyer
+1 to adding GEODE-7079. I believe this will improve the overall stability of what is already being targeted for the 1.9.2 release. --Udo On 10/4/19 10:12 AM, Juan José Ramos wrote: Hello Jens, Thanks for your detailed email. That said, I'm aware of the fact that the main purpose of 1.9.2

[DISCUSS] add GEODE-7079 to release/1.9.2

2019-10-04 Thread Jens Deppe
On behalf of Juan I'm requesting approval to add GEODE-7079 to release/1.9.2 The original justification is: Long story short: GEODE-7079 can be hit by *spring-data-geode* users that restart a member configured with a persistent asynchronous event queue (with conflation enabled) without pausing

Re: [DISCUSS] Add GEODE-7261 and GEODE-7241 to release/1.9.2

2019-10-04 Thread Juan José Ramos
+1 On Fri, Oct 4, 2019 at 6:44 PM Jens Deppe wrote: > I'd like to propose adding these two fixes to release/1.9.2 > > GEODE-7261 ensures that the Admin REST service can start when Spring Boot > Data Geode is used to launch a server. > > GEODE-7241 publishes our various war artifacts to maven.

Re: [DISCUSS] add GEODE-7079 to release/1.9.2

2019-10-04 Thread Anilkumar Gingade
+1 On Fri, Oct 4, 2019 at 11:15 AM Juan José Ramos wrote: > +1 > > > > > On Fri, Oct 4, 2019 at 6:39 PM Jens Deppe wrote: > > > On behalf of Juan I'm requesting approval to add GEODE-7079 to > > release/1.9.2 > > > > The original justification is: > > > > Long story short: GEODE-7079 can be

Re: [Announce] Release branch 1.9.2 created

2019-10-04 Thread Juan José Ramos
Hello Jens, Thanks for your detailed email. That said, I'm aware of the fact that the main purpose of 1.9.2 release is to provide fixes that are required for the Spring Data Geode project, that's why I want to include GEODE-7079 :-). Long story short: GEODE-7079 can be hit by *spring-data-geode*

Re: [Announce] Release branch 1.9.2 created

2019-10-04 Thread Jens Deppe
I have issued a separate email thread for inclusion of GEODE-7241 and GEODE-7261 On Fri, Oct 4, 2019 at 10:32 AM Udo Kohlmeyer wrote: > Hi there Owen, > > Thank you for pointing out the missed process. > > @Jens, I think the majority of the GEODE tickets listed are related to > the AEQ pause

Re: Token based authentication support added in Geode Develop

2019-10-04 Thread Jinmei Liao
yes, correct, we are assuming the client will have the token available somehow and send in the token in the authentication header. We are not doing anything with actual token management. On Fri, Oct 4, 2019 at 11:34 AM Jens Deppe wrote: > So, to be clear, we're providing the ability to

Re: [DISCUSS] GEODE-7241 - make Jar not War?

2019-10-04 Thread Robert Houghton
This has been merged to develop. On Tue, Oct 1, 2019 at 8:15 AM Jens Deppe wrote: > Somewhat related to this - I've found that the V1 Admin Rest API > (geode-web) will not start when Spring 5 libs are on the classpath. I've > raised https://issues.apache.org/jira/browse/GEODE-7261. I'd like to

Re: [Announce] Release branch 1.9.2 created

2019-10-04 Thread Udo Kohlmeyer
Hi there Owen, Thank you for pointing out the missed process. @Jens, I think the majority of the GEODE tickets listed are related to the AEQ pause feature. If so, it might be best to group them, in order to best gauge which tickets need to be discussed to be included in the release. --Udo

[DISCUSS] Add GEODE-7261 and GEODE-7241 to release/1.9.2

2019-10-04 Thread Jens Deppe
I'd like to propose adding these two fixes to release/1.9.2 GEODE-7261 ensures that the Admin REST service can start when Spring Boot Data Geode is used to launch a server. GEODE-7241 publishes our various war artifacts to maven. This ensures that, in the context of starting a SBDG server, the

Re: [Announce] Release branch 1.9.2 created

2019-10-04 Thread Owen Nichols
I can see that the AEQ pause feature was previously discussed and approved: https://lists.apache.org/thread.html/9b5f5c58e1b298d9d0ca870a0deec06f7344a60809790c75a5f68bfa@%3Cdev.geode.apache.org%3E

Passed: apache/geode-native#2133 (moleske-patch-1 - 5545210)

2019-10-04 Thread Travis CI
Build Update for apache/geode-native - Build: #2133 Status: Passed Duration: 1 hr, 37 mins, and 37 secs Commit: 5545210 (moleske-patch-1) Author: M. Oleske Message: Update lgtm to point to current Geode (1.10.0) - 1.9.0 no longer exists so lgtm doesn't

Token based authentication support added in Geode Develop

2019-10-04 Thread Jinmei Liao
Hi, all JWT token based authentication support is added to Geode develop branch. Currently only management v2 rest api can use this (we can add dev rest there too if requested). In order to turn on token based auth for management rest api, you will need to do these two things: 1. start your

Re: [DISCUSS] add GEODE-7079 to release/1.9.2

2019-10-04 Thread Juan José Ramos
+1 On Fri, Oct 4, 2019 at 6:39 PM Jens Deppe wrote: > On behalf of Juan I'm requesting approval to add GEODE-7079 to > release/1.9.2 > > The original justification is: > > Long story short: GEODE-7079 can be hit by *spring-data-geode* users that > restart a member configured with a

Re: Token based authentication support added in Geode Develop

2019-10-04 Thread Jens Deppe
So, to be clear, we're providing the ability to recognize a HTTP authentication header containing 'Bearer ' and then handing that to the Security Manager to do with as it pleases? We're not doing anything with actual token management? (i.e. generating, revoking, etc.). --Jens On Fri, Oct 4,

Re: [DISCUSS] add GEODE-7079 to release/1.9.2

2019-10-04 Thread Eric Shu
+1 On Fri, Oct 4, 2019 at 11:38 AM Anilkumar Gingade wrote: > +1 > > On Fri, Oct 4, 2019 at 11:15 AM Juan José Ramos wrote: > > > +1 > > > > > > > > > > On Fri, Oct 4, 2019 at 6:39 PM Jens Deppe wrote: > > > > > On behalf of Juan I'm requesting approval to add GEODE-7079 to > > >

Re: Token based authentication support added in Geode Develop

2019-10-04 Thread John Blum
So application developer's will need to know to code their application client's to lookup the JWT token (from some store) and set HTTP request headers to send the token, or will this be handled automatically by a geode client? On Fri, Oct 4, 2019 at 11:37 AM Jinmei Liao wrote: > yes, correct,