Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

+1 On Wed, Feb 5, 2020 at 9:29 AM Udo Kohlmeyer wrote: > +1 - for inclusion > > On 2/5/20 4:22 AM, Ju@N wrote: > > Hello devs, > > > > I'd like to include the fix for GEODE-7728 [1] in release 1.12.0. > > The change is basically to avoid throwing an exception and return the > > correct result

Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

+1 On Wed, Feb 5, 2020 at 10:16 AM Nabarun Nag wrote: > ++ > > On Wed, Feb 5, 2020 at 9:54 AM Alexander Murmann > wrote: > > > +1 > > > > On Wed, Feb 5, 2020 at 9:29 AM Udo Kohlmeyer wrote: > > > > > +1 - for inclusion > > > > > > On 2/5/20 4:22 AM, Ju@N wrote: > > > > Hello devs, > > > > > >

Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

++ On Wed, Feb 5, 2020 at 9:54 AM Alexander Murmann wrote: > +1 > > On Wed, Feb 5, 2020 at 9:29 AM Udo Kohlmeyer wrote: > > > +1 - for inclusion > > > > On 2/5/20 4:22 AM, Ju@N wrote: > > > Hello devs, > > > > > > I'd like to include the fix for GEODE-7728 [1] in release 1.12.0. > > > The

Re: [Vote] Include GEODE-7752 into 1.12

+1 On 2/5/20, 1:53 PM, "Udo Kohlmeyer" wrote: Hi there Geode dev, I would like to request that GEODE-7752 (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12. This piece of code is a refactor of work done in GEODE-7715. This refactor specializes

[Vote] Include GEODE-7752 into 1.12

Hi there Geode dev, I would like to request that GEODE-7752 (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12. This piece of code is a refactor of work done in GEODE-7715. This refactor specializes Builders and simplifies Builder behavior for better user experience. --Udo

Re: [Vote] Include GEODE-7752 into 1.12

My apologies.. I had paid further attention to this, after I made changes to the assembly-context.txt file. I will revert now and then come back when it passes all test requirements. --Udo On 2/5/20 4:14 PM, Ernest Burghardt wrote: Udo, the PR has some failing tests that are in the

Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

+1 I'll plan to cherry-pick in the morning if there are no objections... On Wed, Feb 5, 2020 at 11:20 AM Ivan Godwin wrote: > +1 > > On Wed, Feb 5, 2020 at 10:16 AM Nabarun Nag wrote: > > > ++ > > > > On Wed, Feb 5, 2020 at 9:54 AM Alexander Murmann > > wrote: > > > > > +1 > > > > > > On

Re: [Vote] Include GEODE-7752 into 1.12

+1 On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson wrote: > +1 > > On 2/5/20, 1:53 PM, "Udo Kohlmeyer" wrote: > > Hi there Geode dev, > > I would like to request that GEODE-7752 > (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12. > > This piece of code is a

Re: [Vote] Include GEODE-7752 into 1.12

Udo, the PR has some failing tests that are in the "non-mandatory" category for merge, TBH I'd prefer to have solid green changes being added at this point forward... Thanks, EB On Wed, Feb 5, 2020 at 3:01 PM Alexander Murmann wrote: > Udo, you say "refactor", but this sounds more like a

Re: [Vote] Include GEODE-7752 into 1.12

Hi Ernie, Thanks for the heads up. This is breaking DistributedTestOpenJDK and Udo confirmed the are of concern and is going to revert this. Thanks, Mark > On Feb 5, 2020, at 4:14 PM, Ernest Burghardt wrote: > > Udo, > the PR has some failing tests that are in the "non-mandatory" category

Re: [Vote] Include GEODE-7752 into 1.12

Thanks for the additional context, Udo! That makes a lot of sense. I want to make sure we are very deliberate about including anything but a critical fix in a release branch after it has been cut. +1 to including Udo's change once we feel confident about the tests On Wed, Feb 5, 2020 at 4:27 PM

Re: [Vote] Include GEODE-7752 into 1.12

+1 On Wed, Feb 5, 2020 at 2:36 PM John Blum wrote: > +1 > > On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson > > wrote: > > > +1 > > > > On 2/5/20, 1:53 PM, "Udo Kohlmeyer" wrote: > > > > Hi there Geode dev, > > > > I would like to request that GEODE-7752 > >

Re: [Vote] Include GEODE-7752 into 1.12

@Alexander, I can most certainly elaborate more. In short, this refactor does not have to be in 1.12, but it does alter public Builders and classes. Which means, that if we don't release it with 1.12, we would have to go through the cycle of deprecation,etc. to get this change in. Given that

Re: [Vote] Include GEODE-7752 into 1.12

Udo, you say "refactor", but this sounds more like a feature or user facing improvement. Do you mind elaborating a little more why this should be in this release? On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson wrote: > +1 > > On 2/5/20, 1:53 PM, "Udo Kohlmeyer" wrote: > > Hi there Geode

Re: [Vote] Include GEODE-7752 into 1.12

Fair enough Udo, just let us know when you have it ready. Thanks, EB On Wed, Feb 5, 2020 at 4:31 PM Udo Kohlmeyer wrote: > My apologies.. I had paid further attention to this, after I made > changes to the assembly-context.txt file. > > I will revert now and then come back when it passes all

Re: [Vote] Include GEODE-7752 into 1.12

Even though the management service is still marketed as "experimental" and we don't need to go through deprecations, I would still very much prefer this gets pulled into 1.12 so that users don't have to deal with experimental public API changes. On Wed, Feb 5, 2020 at 4:23 PM Udo Kohlmeyer

Re: [Vote] Include GEODE-7752 into 1.12

+1 Getting it right the first time will definitely save us pains down the road. > On Feb 5, 2020, at 4:23 PM, Udo Kohlmeyer wrote: > > @Alexander, I can most certainly elaborate more. > > In short, this refactor does not have to be in 1.12, but it does alter public > Builders and classes.

Odg: StressNewTest timeout exceeded

Thanks Owen Nichols! Šalje: Robert Houghton Poslano: 5. veljače 2020. 16:30 Prima: dev@geode.apache.org Predmet: Re: StressNewTest timeout exceeded How did you change its timeout? On Wed, Feb 5, 2020, 07:27 Owen Nichols wrote: > Hi

Re: [Vote] Include GEODE-7752 into 1.12

Hi there EB, fix has been merged to develop. (Everything is green now) 9c102e4f8836ca32ad51a05bbd4d0107e8fc0343 Thanks --Udo 0On 2/5/20 4:34 PM, Ernest Burghardt wrote: Fair enough Udo, just let us know when you have it ready. Thanks, EB On Wed, Feb 5, 2020 at 4:31 PM Udo Kohlmeyer

Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

+1 - for inclusion On 2/5/20 4:22 AM, Ju@N wrote: Hello devs, I'd like to include the fix for GEODE-7728 [1] in release 1.12.0. The change is basically to avoid throwing an exception and return the correct result whenever a query has more than one condition and one of them compares two indexed

[PROPOSAL]: Include GEODE-7728 in Release 1.12.0

Hello devs, I'd like to include the fix for GEODE-7728 [1] in release 1.12.0. The change is basically to avoid throwing an exception and return the correct result whenever a query has more than one condition and one of them compares two indexed fields. This is not a new issue but it can be hit by

StressNewTest timeout exceeded

Hi all, I'm working on https://issues.apache.org/jira/browse/GEODE-7309 PR: https://github.com/apache/geode/pull/4395 All tests passed except stressNewTest which failed with timeout exceeded. Can we somehow override it to pass this tests? BR, Mario

Re: StressNewTest timeout exceeded

How did you change its timeout? On Wed, Feb 5, 2020, 07:27 Owen Nichols wrote: > Hi Mario, I’ve re-triggered your PR check with a longer timeout, since I > think you are only about an hour over the current timeout of 6 hours for > StressNewTest. > > > On Feb 5, 2020, at 5:10 AM, Mario Kevo

Re: StressNewTest timeout exceeded

Hi Mario, I’ve re-triggered your PR check with a longer timeout, since I think you are only about an hour over the current timeout of 6 hours for StressNewTest. > On Feb 5, 2020, at 5:10 AM, Mario Kevo wrote: > > Hi all, > > I'm working on https://issues.apache.org/jira/browse/GEODE-7309 >