Re: Review Request 61676: Release the lock held when beforeCompletion failed with CommitConflictException

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61676/#review183009 --- Ship it! Ship It! - Nick Reich On Aug. 15, 2017, 10:47 p.m

Re: [DISCUSS] Improvements to backups

t; not already happening that definitely should change! > > -Dan > > On Thu, Aug 10, 2017 at 10:31 AM, Nick Reich <nre...@pivotal.io> wrote: > > > There is a desire to improve backup creation and restore. The suggested > > improvements are listed below and I am seeking feedback

Re: ParallelSnapshotFileMapper broke AnalyzeSerializablesJUnitTest

I have created GEODE-3435 to fix the issue. On Fri, Aug 11, 2017 at 3:41 PM, Kirk Lund <kl...@pivotal.io> wrote: > Looks like it was this commit... > > commit 7072f8ef7b764d1507e26cca8ed0c4d184ccc81a > Author: Nick Reich <nre...@pivotal.io> > Date: Fri Jul 28 16:47:

Re: Review Request 61676: Release the lock held when beforeCompletion failed with CommitConflictException

ply, visit: > https://reviews.apache.org/r/61676/ > --- > > (Updated Aug. 15, 2017, 10:47 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, > and Nick Reich. > > > Bugs: GEODE-3444 > https://issues.apache.org/jira

[DISCUSS] Improvements to backups

There is a desire to improve backup creation and restore. The suggested improvements are listed below and I am seeking feedback from the community: 1) Allow saving of backups to different locations/systems: currently, backups are saved to a directory on each member. Users can manually or through

Re: Review Request 60935: GEODE-3115 Added changes to check for persistent region during pdx type registry.

in 4, so the try catch idiom was the only option back in JUnit 3): http://junit.org/junit4/javadoc/4.12/org/junit/rules/ExpectedException.html - Nick Reich On July 18, 2017, 1:20 a.m., anilkumar gingade wrote: > > --- > This is a

Re: Review Request 60935: GEODE-3115 Added changes to check for persistent region during pdx type registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60935/#review181270 --- Ship it! Ship It! - Nick Reich On July 21, 2017, 7:18 p.m

Re: Review Request 61143: GEODE-3310 Set target node in TXStateProxy during TXFailover if necessary

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61143/#review181588 --- Ship it! Ship It! - Nick Reich On July 27, 2017, 5:32 p.m

Re: Review Request 61143: GEODE-3310 Set target node in TXStateProxy during TXFailover if necessary

ot my ability to string together the right mock call and response sequences, though if it is the only way to get it done, it is still better than nothing. - Nick Reich On July 26, 2017, 5:37 p.m., Eric Shu wrote: > > --

Re: Review Request 61143: GEODE-3310 Set target node in TXStateProxy during TXFailover if necessary

> On July 26, 2017, 8:11 p.m., Nick Reich wrote: > > All my comments are nits and only suggestions / thoughts and not barriers to accepting this review and shipping it. - Nick --- This is an automatically generated e-mail.

Re: Adding parallel import/export of snapshots to gfsh

the .gfd extension. > > No need for a new option (--parallel). > No need for a new option (--path). > > In fact, no need for a change to gfsh command at all. > > > -- > Mike Stolz > Principal Engineer, GemFire Product Manager > Mobile: +1-631-835-4771 > > On Tu

Adding parallel import/export of snapshots to gfsh

Team, I am working on exposing the parallel export/import of snapshots through gfsh and would appreciate input on the best approach to adding to / updating the existing interface. Currently, ExportDataCommand and ImportDataCommand take a region name, a member to run the command on, and a file

Re: Adding parallel import/export of snapshots to gfsh

options (but I agree: less options is generally better). On Tue, Aug 22, 2017 at 1:59 PM, Jacob Barrett <jbarr...@pivotal.io> wrote: > On Tue, Aug 22, 2017 at 1:49 PM Nick Reich <nre...@pivotal.io> wrote: > > > The idea of deprecating —file in favor of path is interesting. I

Re: Adding parallel import/export of snapshots to gfsh

and ‘—dir’? > > > > If you go for implementing the new functionality as a separate command, > I would suggest calling the gfsh commands: “export data-parallel” and > “import data-parallel" > > > >> On Aug 22, 2017, at 11:32 AM, Nick Reich <nre...@pivotal.io> wr

Re: Review Request 61722: GEODE-3047 Atomic creation flag is not set if the region is recoverd from the disk.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61722/#review183187 --- Ship it! Ship It! - Nick Reich On Aug. 17, 2017, 11:20 p.m

Requesting assignment permissions for Geode tickets

Hi, Could I get permissions to assign Geode tickets (especially to myself)? User name is nreich. Thanks, Nick

Re: Review Request 62506: GEODE-3679: Original client member Id in the transaction should be set in the PartitionMessage

> Do not need to hold onto the set: for (Object key : region.keySet()) - Nick Reich On Sept. 22, 2017, 5:01 p.m., Eric Shu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Rebase and squash before merging PRs

Here are the docs from github: https://help.github.com/articles/about-pull-request-merges/ Based on those and using squash and commit for some of my merges, it looks like it does what we want: just one commit for the merge of the feature branch. Note that "rebase and merge" in github does not

Re: Review Request 62164: GEODE-3566 Moving a bucket during rebalancing does not update overflow stats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62164/#review184982 --- Ship it! Ship It! - Nick Reich On Sept. 8, 2017, 4:10 p.m

Re: Review Request 62164: GEODE-3566 Moving a bucket during rebalancing does not update overflow stats

> On Sept. 7, 2017, 8:08 p.m., Nick Reich wrote: > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java > > Lines 17 (patched) > > <https://reviews.apache.org/r/62164/diff/1/?file=1817801#file1817801lin

Re: Review Request 62164: GEODE-3566 Moving a bucket during rebalancing does not update overflow stats

/62164/#comment261070> Normalize variable names to camel case? geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java Lines 249 (patched) <https://reviews.apache.org/r/62164/#comment261067> use TEST_REGION constant - Nick Reich On

Re: Review Request 62164: GEODE-3566 Moving a bucket during rebalancing does not update overflow stats

atched) <https://reviews.apache.org/r/62164/#comment261064> It does not look like the second part of this method uses the shortcut or overflow parameters, so it could be a seperate method. Since this method does two different things, that would probably be optimal. - Nick Reich On Sept. 7, 2

Re: Review Request 61895: GEDOE-3516: TXManagerImpl.tryResume call may add itself again into the waiting thread queue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61895/#review184710 --- Ship it! Ship It! - Nick Reich On Sept. 6, 2017, 6:42 p.m

Re: Review Request 61895: GEDOE-3516: TXManagerImpl.tryResume call may add itself again into the waiting thread queue

<https://reviews.apache.org/r/61895/#comment259995> Is spyMgr.suspend() here being attempted to occur between when the two threads start and before they complete? If so, is that guaranteed to occur? - Nick Reich On Aug. 25, 2017, 4:53 p.m., Er

Re: [Discuss] CliStrings

+1 for moving those messages out of CliStrings if at all possible and placing them where they are used. In my experiences with those strings, I have rarely if ever seen them reused across classes, so they really should belong in the class they are used by. On Thu, Oct 19, 2017 at 3:05 PM, Jared

Re: [DISCUSS] Benchmarks module package structure

> > > > The package might be always a problem. Even you put the cq benchmark > code > > > under geode-cq to near its source code, it might still have to access > > code > > > under other package, such as geode-core. > > > > > > So I think put be

[DISCUSS] Benchmarks module package structure

Team, I am in the progress of adding new benchmarks to the (currently sparse) geode-benchmarks module. The lack of current examples in the module leads me to wonder what the correct organization of benchmarks in the module is (and if this is the right location). The existing benchmarks are all

Re: [PROPOSAL]: Adding declarable support in Gfsh command

This would solve the problem of specifying the parameters for a Declarable, but if you provided support for any valid json, you could cover other situations as well, including those with more complicated and possibly nested configuration. If we would ever support such scenarios in the future, I

Re: [PROPOSAL]: deprecating create region using --template-region option

+1 for deprecating --template-region. It feels like a convenience method that by it very nature has an unobvious result and would require more effort to understand so it could be used correctly by a user than the value that it presents. On Wed, Feb 7, 2018 at 10:26 AM, Anilkumar Gingade

[PROPOSAL]: concurrent bucket moves during rebalance

Team, The time required to undertake a rebalance of a geode cluster has often been an area for improvement noted by users. Currently, buckets are moved one at a time and we propose that creating a system that moved buckets in parallel could greatly improve performance for this feature.

Re: [PROPOSAL]: concurrent bucket moves during rebalance

. > > I do think we need to improve our rebalancing such that it iterates until > it achieves balance, but not in a way that will consume all available > resources. > > -- > Mike Stolz > > > On Thu, Mar 8, 2018 at 2:25 PM, Nick Reich <nre...@pivotal.io> wrote: >

Re: [PROPOSAL]: concurrent bucket moves during rebalance

dvance > > without knowing what the actual load looks like when rebalance is in > > progress and hence could be difficult to get right. It would be ideal if > we > > can handle this using back pressure. > > > >> On Thu, Mar 8, 2018 at 12:05 PM Nick Reich <

Re: [DISCUSS]: Tests requiring external services

; wrote: > > > I'm in favor of using docker for test isolation. We already have an > > 'AcceptanceTest' category which you might consider using instead of > > creating yet another category. > > > > --Jens > > > > On Tue, Apr 3, 2018 at 2:02 PM, Nick R

[DISCUSS]: Tests requiring external services

Team, As part of validating the new JDBC connector for Geode, we have a need for tests that involving connecting to specific databases (like MySQL and Postgres) to validate proper function with those databases. Since these tests require connecting to outside services, unlike existing Geode tests,

Re: [DISCUSS] New List for Commit and CI Emails

+1 I use an email filter (from:apachegeod...@gmail.com) to move all the automated CI messages to a different section of my inbox, but having a fully distinct email list, if possible, would be even nicer. On Tue, Mar 20, 2018 at 2:27 PM, Galen O'Sullivan wrote: > Hi all, >