Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/683
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r132864196
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockService.java
---
@@ -74,17 +73,6 @@
public static final long
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131974883
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockService.java
---
@@ -74,17 +73,6 @@
public static final l
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131977004
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockService.java
---
@@ -1433,29 +1412,7 @@ public boolean lockInter
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131290606
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java
---
@@ -302,14 +302,14 @@ boolean checkForExpiration() {
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131290383
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java
---
@@ -302,14 +302,14 @@ boolean checkForExpiration() {
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131290142
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRequestProcessor.java
---
@@ -196,6 +196,13 @@ long getLeaseExpireT
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131290034
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java
---
@@ -87,7 +87,8 @@
private Thread thread;
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131287954
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java
---
@@ -302,14 +302,14 @@ boolean checkForExpiration() {
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131287871
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java
---
@@ -87,7 +87,8 @@
private Thread thread;
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131287366
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRequestProcessor.java
---
@@ -196,6 +196,13 @@ long getLeaseExpireTime(
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/683
GEODE-3314 - additional refactoring for developer QoL.
* Write characterization tests for DLockService.
* Remove debugging code.
* Remove dead code.
* Remove comments.
* Extract
12 matches
Mail list logo
