Re: New build warnings

2019-08-15 Thread Jacob Barrett
s... > > We are adding new build warnings which makes me sad. This one was added > recently: > > /Users/klund/dev/geode3/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java:1075: > warning: unreachable catch clause >} catch (

New build warnings

2019-08-15 Thread Kirk Lund
Just a reminder, that our many sun.misc.* warnings are drowning out real warnings... We are adding new build warnings which makes me sad. This one was added recently: /Users/klund/dev/geode3/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java:1075: warning

Re: Preventing new build warnings

2019-01-16 Thread Robert Houghton
would be nice to reduce or eliminate > our > >> existing build warnings as well. > >> > >> Thanks, > >> Galen > >> > >> > >> On Tue, Jan 15, 2019 at 12:33 PM Peter Tran wrote: > >> > >>> Hello! > >>&

Re: Preventing new build warnings

2019-01-15 Thread Udo Kohlmeyer
uce or eliminate our existing build warnings as well. Thanks, Galen On Tue, Jan 15, 2019 at 12:33 PM Peter Tran wrote: Hello! I've noticed that there is no mechanism in which we prevent new PRs from introduce new build warnings. In our PR template we ask people to self report that they

Re: Preventing new build warnings

2019-01-15 Thread Dan Smith
> > On Tue, Jan 15, 2019 at 12:33 PM Peter Tran wrote: > > > Hello! > > > > I've noticed that there is no mechanism in which we prevent new PRs from > > introduce new build warnings. In our PR template we ask people to self > > report that they ha

Re: Preventing new build warnings

2019-01-15 Thread Galen O'Sullivan
I'm for failing CI on warnings. It would be nice to reduce or eliminate our existing build warnings as well. Thanks, Galen On Tue, Jan 15, 2019 at 12:33 PM Peter Tran wrote: > Hello! > > I've noticed that there is no mechanism in which we prevent new PRs from > introd

Preventing new build warnings

2019-01-15 Thread Peter Tran
Hello! I've noticed that there is no mechanism in which we prevent new PRs from introduce new build warnings. In our PR template we ask people to self report that they have a "clean build" but nothing more to ensure we're not adding new warnings. Has there been an initiativ