Regarding -add-opens for reflection - I misunderstood. I thought you were
saying we need --add-opens for *all* reflection. But it sounds like we are
doing reflection on the JDK classes themselves. If that is the case I agree
we need --add-opens until we fix that.
-Dan
On Mon, Nov 5, 2018 at 8:41
Dan, are you saying we do or do not need --add-opens for reflection? The
opens directive is for open up classes in its own modules for reflection. I
don't think we can use that to open up jdk's packages, can we?
On Fri, Nov 2, 2018 at 3:52 PM Dan Smith wrote:
> I guess I'm ok with documenting
I guess I'm ok with documenting the --add-opens workaround in the short
term, so that users can start playing with Geode on JDK 11. Maybe we should
indicate the JDK 11 support is experimental. I guess in addition to that,
we are going to document that users should put Geode on the classpath and
Galen, you are right, --add-opens is necessary for accessing the private
fields and methods when doing deep reflection which is used a lot in our
serialization code.
Let me step back and explain the scope of what we are trying to do here.
We all know to be fully java11 compliant, we need to:
1.
I did a little more reading, and it sounds like we should create an
module-info.java to reserve the proper name for those customers who are
using Java 9+. See this article[1] for a description of what can go wrong
if people start using the automatic package without us having declared a
name. I
And one disclaimer I have to add is that these "--add-opens" are the ones
uncovered by our current set of tests, there might be more needed in areas
that are not covered by our tests. So to say the most, our current jdk11
support is still in beta mode.
On Thu, Nov 1, 2018 at 10:33 AM Jinmei Liao
1) yes, gfsh script will need to be updated to add these configurations.
2) yes, these ad-opens are required to run geode clients as well. We will
need to document them.
On Thu, Nov 1, 2018 at 10:31 AM Dan Smith wrote:
> A couple of questions:
>
> 1) Are you proposing changing gfsh start server
A couple of questions:
1) Are you proposing changing gfsh start server to automatically add these
add-opens, or are you suggesting users will have to do that?
2) Are these add-opens required for running a geode client?
-Dan
On Thu, Nov 1, 2018 at 9:48 AM Patrick Rhomberg
wrote:
> In case
In case anyone else's email broke the thread, below is a link to the
previous thread in the mail archive for context.
https://markmail.org/thread/xt224pvavxu3d54p
On Thu, Nov 1, 2018 at 9:35 AM, Jinmei Liao wrote:
> We will need to wrap up this discussion with a decision. Looks like we are
>
