Re: A small proposal: Not Sorting in AnalyzeSerializablesJUnitTest

2018-11-13 Thread Patrick Rhomberg
I categorically like style improvement and enforcement. +1 to this specific style improvement and enforcement. It's pretty straight-forward to write a regex into our spotless.gradle. Let me know if you need a hand on that front, since I know I shouldn't use "straightforward" to refer to either

Re: A small proposal: Not Sorting in AnalyzeSerializablesJUnitTest

2018-11-13 Thread Anilkumar Gingade
If it makes easy to find/address failure with AnalyzeSerializablesTest, +1 -Anil. On Tue, Nov 13, 2018 at 9:34 AM Kirk Lund wrote: > +1 I've had to reorder the list a few times myself to correct the ordering > > On Mon, Nov 12, 2018 at 5:28 PM, Galen O'Sullivan > wrote: > > > Hi all, > > > >

Re: A small proposal: Not Sorting in AnalyzeSerializablesJUnitTest

2018-11-13 Thread Kirk Lund
+1 I've had to reorder the list a few times myself to correct the ordering On Mon, Nov 12, 2018 at 5:28 PM, Galen O'Sullivan wrote: > Hi all, > > I wrote a PR (GEODE-5800) recently to remove redundant cases from > DataSerializer.readObject etc. calls. This changed the bytecode size (but > not